On Thu, Jun 29, 2017 at 6:16 PM, Greg Sheremeta wrote:
> Do we have or follow a standard on patch granularity?
>
As a matter of fact, we have.
According to
https://www.ovirt.org/develop/dev-process/devprocess/#sending-a-patch-for-work-in-progress
1. Each commits contain a single logical chan
Hi,
I think I have found a rule which applies to lot of CRs. If you submit set
of small patches, you will be asked to squash them, and if you submit 'big
bang' patch, you will be asked to split it. Sometimes, and that's the
hardest situation, you are asked to do both :D
I think you should lead wi
On Thu, Jun 29, 2017 at 6:16 PM, Greg Sheremeta wrote:
> Do we have or follow a standard on patch granularity?
>
I don't think we have or should have any strict standard about this. Every
reviewer is different and prefers different kind of patch granularity.
For example I really dislike if some
Do we have or follow a standard on patch granularity? When I started, I
picked up on the culture that we do small, logical commits -- as much as
possible, each commit should be focused on a specific purpose. I've
perceived some reviewers prefer to have all orthogonal changes (fix a
random spelling
