Re: [riot-devel] Progress of port to SODAQ Autonomo

2016-07-04 Thread Thomas Eichinger
All, I am a little concerned the coding conventions getting too pedantic lately. While I agree magic numbers should be avoided, I disagree to introduce #defines for every single one of them as I do with introducing a static check for it. (Using a #define for a number only used once in HW

Re: [riot-devel] Progress of port to SODAQ Autonomo

2016-07-04 Thread Ludwig Knüpfer
On Mon, Jul 04, 2016 at 07:44:21AM +0200, Ludwig Knüpfer wrote: > Am 2. Juli 2016 13:21:19 MESZ, schrieb Kees Bakker : > >While going through the code I notice that there are too many "magic" > >constants. Hard coded numbers that are obvious for some, but not > >obvious > >for

[riot-devel] Progress of port to SODAQ Autonomo

2016-07-02 Thread Kees Bakker
Despite the ongoing discussion of how cpu/sam* should be configured I am continuing with my effort to port RIOT to SODAQ Autonomo. The changes are available in my add-sodaq-autonomo branch at g...@github.com:keestux/RIOT.git UART and I2C are working now, and so is xtimer. Next on my list is