Re: [PATCH 2/2] bsp/xilinx-zynq: Add device configuration driver

2017-04-19 Thread Chris Johns
Thanks for submitting this driver. My comments are below. Chris On 20/04/2017 13:08, Patrick Gauvin wrote: --- c/src/lib/libbsp/arm/xilinx-zynq/Makefile.am | 5 + .../libbsp/arm/xilinx-zynq/devcfg/zynq-devcfg.c| 770 + .../arm/xilinx-zynq/include/zynq-devcfg-reg

Re: [PATCH 1/2] bsp/xilinx-zynq: Add SLCR driver

2017-04-19 Thread Chris Johns
Thanks for submitting this driver. My comments are below. Chris On 20/04/2017 13:06, Patrick Gauvin wrote: --- c/src/lib/libbsp/arm/xilinx-zynq/Makefile.am | 5 ++ .../arm/xilinx-zynq/include/zynq-slcr-regs.h | 84 .../lib/libbsp/arm/xilinx-zynq/include/zynq-s

Re: GSOC 2017 RTEMS-libbsd issue

2017-04-19 Thread Christian Mauderer
Am 20.04.2017 um 04:02 schrieb Sichen Zhao: > Hi Christian Mauderer, > > Ok, i got your idea,I will try it. > > Thank you for your patient for my problem. > > > Best regards > > Sichen Zhao > Hello Sichen Zhao, no problem. Don't hesitate to ask if there are any further questions or problems

[PATCH 2/2] bsp/xilinx-zynq: Add device configuration driver

2017-04-19 Thread Patrick Gauvin
--- c/src/lib/libbsp/arm/xilinx-zynq/Makefile.am | 5 + .../libbsp/arm/xilinx-zynq/devcfg/zynq-devcfg.c| 770 + .../arm/xilinx-zynq/include/zynq-devcfg-regs.h | 194 ++ .../libbsp/arm/xilinx-zynq/include/zynq-devcfg.h | 160 + c/src/lib/libbsp/arm/xili

[PATCH 1/2] bsp/xilinx-zynq: Add SLCR driver

2017-04-19 Thread Patrick Gauvin
--- c/src/lib/libbsp/arm/xilinx-zynq/Makefile.am | 5 ++ .../arm/xilinx-zynq/include/zynq-slcr-regs.h | 84 .../lib/libbsp/arm/xilinx-zynq/include/zynq-slcr.h | 70 + c/src/lib/libbsp/arm/xilinx-zynq/preinstall.am | 8 ++ c/src/lib/libbsp/arm/

[PATCH 1/2] bsp/xilinx-zynq: Add SLCR driver

2017-04-19 Thread Patrick Gauvin
--- c/src/lib/libbsp/arm/xilinx-zynq/Makefile.am | 5 ++ .../arm/xilinx-zynq/include/zynq-slcr-regs.h | 84 .../lib/libbsp/arm/xilinx-zynq/include/zynq-slcr.h | 70 + c/src/lib/libbsp/arm/xilinx-zynq/preinstall.am | 8 ++ c/src/lib/libbsp/arm/

[PATCH 0/2] Zynq7000 series device configuration driver

2017-04-19 Thread Patrick Gauvin
Hello, I'm submitting this device configuration driver to be reviewed and hopefully to be accepted into the RTEMS source tree. In its current state, it is able to send PCAP command sequences, successfully program the FPGA, and also use the PCAP to read internal registers. The SLCR patch is only f

Re: GSOC 2017 RTEMS-libbsd issue

2017-04-19 Thread Sichen Zhao
Hi Christian Mauderer, Ok, i got your idea,I will try it. Thank you for your patient for my problem. Best regards Sichen Zhao From: Christian Mauderer Sent: Wednesday, April 19, 2017 11:05 PM To: 赵 思晨 Cc: RTEMS Subject: Re: GSOC 2017 RTEMS-libbsd issue --

Re: [PATCH] Added declaration of method pthread_getname_np

2017-04-19 Thread Joel Sherrill
On Wed, Apr 19, 2017 at 2:02 PM, Gedare Bloom wrote: > Hi Tanu, > > This comes into RTEMS through newlib. You have to clone newlib and > search in newlib.git/newlib. > It is installed as part of your tools by the RSB. You can #define _GNU_SOURCE before you include any .h files or add it to the

Re: [PATCH] Added declaration of method pthread_getname_np

2017-04-19 Thread Gedare Bloom
Hi Tanu, This comes into RTEMS through newlib. You have to clone newlib and search in newlib.git/newlib. Side-note: Please ensure to use a properly configured git user.name and user.email so that git-send-email and git-format-patch will preserve the correct authorship information. Gedare On Wed

Re: [PATCH] Added declaration of method pthread_getname_np

2017-04-19 Thread Tanu Hari Dixit
Hello Joel, I git grepped for the above lines in src/rtems but couldn't find it. I couldn't find it in /src/rtems/cpukit/posix/include/rtems/posix/pthread.h. I don't know how to define _GNU_SOURCE. Can you please help me with this? Thank you, Tanu Hari Dixit. On Wed, Apr 19, 2017 at 9:38 PM, Joe

Re: [PATCH] Added declaration of method pthread_getname_np

2017-04-19 Thread Joel Sherrill
Hi, This is prototyped in pthread.h in the current tools: #if __GNU_VISIBLE int pthread_getname_np(pthread_t, char *, size_t) __nonnull(2); int pthread_setname_np(pthread_t, const char *) __nonnull(2); #endif Do you have current tools? Did you define _GNU_SOURCE so this prototype is vi

Re: GSOC 2017 RTEMS-libbsd issue

2017-04-19 Thread Christian Mauderer
- Ursprüngliche Mail - > Von: "赵 思晨" > An: "Christian Mauderer" , "RTEMS" > > Gesendet: Mittwoch, 19. April 2017 16:41:20 > Betreff: Re: GSOC 2017 RTEMS-libbsd issue > Hi Christian Mauderer, > > 1. I haven't put these change in my git repo yet. > > 2.Yes, i verified that by the cons

Re: [PATCH] Added declaration of method pthread_getname_np

2017-04-19 Thread Tanu Hari Dixit
Hello all, Please let me know if this is okay. Thanks, Tanu Hari Dixit. On Wed, Apr 19, 2017 at 8:30 PM, tokencolour wrote: > Gets rid of 1 warning --> > warning: no previous prototype for 'pthread_getname_np' [-Wmissing-prototypes] > --- > cpukit/posix/include/rtems/posix/pthreadimpl.h | 5 ++

[PATCH] Added declaration of method pthread_getname_np

2017-04-19 Thread tokencolour
Gets rid of 1 warning --> warning: no previous prototype for 'pthread_getname_np' [-Wmissing-prototypes] --- cpukit/posix/include/rtems/posix/pthreadimpl.h | 5 + cpukit/posix/src/pthreadgetnamenp.c| 1 + 2 files changed, 6 insertions(+) diff --git a/cpukit/posix/include/rtems/pos

Re: GSOC 2017 RTEMS-libbsd issue

2017-04-19 Thread Sichen Zhao
Hi Christian Mauderer, 1. I haven't put these change in my git repo yet. 2.Yes, i verified that by the console output , the below snapshot : including some debug info. just forget it. [cid:4fb54908-2ff4-4098-9f94-6f2aa529babf] 3.The application i use is testsuite/usb01, i debug it, and it l

RE: GSOC 2017 RTEMS-libbsd issue

2017-04-19 Thread Kirspel, Kevin
My USB mass storage works without UGEN. Kevin Kirspel Electrical Engineer - Sr. Staff Idexx Roswell 235 Hembree Park Drive Roswell GA 30076 Tel: (770)-510- ext. 81642 Direct: (770)-688-1642 Fax: (770)-510-4445 -Original Message- From: devel [mailto:devel-boun...@rtems.org] On Behalf O

Re: GSOC 2017 RTEMS-libbsd issue

2017-04-19 Thread Christian Mauderer
Hello Sichen Zhao, Sorry for the delayed response. Somehow the mail must have been lost. I only received it through the answer from Kevin Kirspel. I slightly changed my mailing list settings so the next time it will (hopefully) work. > > Hi Christian Mauderer, Hi all, > > > > I understand wh

Re: Issue with 'rtems_shell_wait_for_input' function

2017-04-19 Thread vivek kukreja
Hello Chris, Inside rtems_shell_wait_for_input we call the change_serial_settings function which is returning RTEMS_UNSUCCESSFUL so the test doesn't start on qemu. I tried the tests on gdb for other bsps and they work. I'm still looking into this issue so I can start working on transports. If you

RE: GSOC 2017 RTEMS-libbsd issue

2017-04-19 Thread Kirspel, Kevin
I have recently posted patches for TTY and USB serial support for FREEBSD. I was going to take a stab at supporting UGEN as well. The USB mouse and keyboard drivers need it as well. The TTY patches contain some support needed for UGEN but there is more required. Let me take a look at it toda

Re: GSOC 2017 RTEMS-libbsd issue

2017-04-19 Thread Sichen Zhao
Hi Christian Mauderer, Hi all, I understand what you mean, i will update my RTEMS-libbsd to the newest branch. I already pull over the host controller driver files(am335x_musb.c am335x_usbss.c umass.c)from freebsd and make them compilable in rtems-libbsd. The umass.c is driver for storage devic