Re: Best Home for uncrustify configuration file

On 05/12/2018 05:18, Chris Johns wrote: On 05/12/2018 14:59, Joel Sherrill wrote: Current location: https://devel.rtems.org/attachment/wiki/Developer/Coding/Conventions/rtems.uncrustify Any thoughts on a better location? The page is being converted to Rest for the SW Eng Handbook. How good

Re: Best Home for uncrustify configuration file

On 05/12/2018 14:59, Joel Sherrill wrote: > Current location: > https://devel.rtems.org/attachment/wiki/Developer/Coding/Conventions/rtems.uncrustify > > Any thoughts on a better location? The page is being converted to Rest for the > SW Eng Handbook. > How good is it? The page says the

Best Home for uncrustify configuration file

Hi Current location: https://devel.rtems.org/attachment/wiki/Developer/Coding/Conventions/rtems.uncrustify Any thoughts on a better location? The page is being converted to Rest for the SW Eng Handbook. --joel ___ devel mailing list devel@rtems.org

Re: [PATCH] Capitalize Rtems to RTEMS

Thanks! Pushed. --joel On Tue, Dec 4, 2018 at 4:13 PM Marçal Comajoan Cara wrote: > --- > bsps/powerpc/beatnik/irq/irq_init.c | 2 +- > bsps/powerpc/mvme5500/irq/irq_init.c | 2 +- > bsps/powerpc/psim/irq/irq_init.c | 2 +- > bsps/powerpc/ss555/start/irq_init.c | 2

[PATCH] Capitalize Rtems to RTEMS

--- bsps/powerpc/beatnik/irq/irq_init.c | 2 +- bsps/powerpc/mvme5500/irq/irq_init.c | 2 +- bsps/powerpc/psim/irq/irq_init.c | 2 +- bsps/powerpc/ss555/start/irq_init.c | 2 +- testsuites/sptests/spfatal_support/init.c | 2 +- 5 files changed, 5 insertions(+), 5

Re: [PATCH] eng/coding-doxygen: Convert wiki page to Rest

Sure! On Tue, Dec 4, 2018 at 10:18 PM Joel Sherrill wrote: > How about a new task to fix them and submit a patch? :) > > https://codein.withgoogle.com/dashboard/tasks/6126294447161344/ > > --joel > > On Tue, Dec 4, 2018 at 2:01 PM Marçal wrote: > >> Hi, it's weird because the task to do the

Re: [PATCH] eng/coding-doxygen: Convert wiki page to Rest

How about a new task to fix them and submit a patch? :) https://codein.withgoogle.com/dashboard/tasks/6126294447161344/ --joel On Tue, Dec 4, 2018 at 2:01 PM Marçal wrote: > Hi, it's weird because the task to do the eng/coding-doxygen was claimed > but me but apparently another student did

Re: [PATCH] Spelling and grammar fixes in source code comments

Good eye! Thanks. Pushed. On Tue, Dec 4, 2018 at 2:10 PM Marçal Comajoan Cara wrote: > This work was part of GCI 2018. > --- > bsps/i386/pc386/start/README-SMP | 2 +- > bsps/powerpc/shared/exceptions/ppc_exc_address.c | 2 +- > bsps/sparc/leon3/start/bspclean.c

[PATCH] Spelling and grammar fixes in source code comments

This work was part of GCI 2018. --- bsps/i386/pc386/start/README-SMP | 2 +- bsps/powerpc/shared/exceptions/ppc_exc_address.c | 2 +- bsps/sparc/leon3/start/bspclean.c | 2 +- cpukit/include/rtems/confdefs.h | 4 ++--

Re: [PATCH] eng/coding-doxygen: Convert wiki page to Rest

Hi, it's weird because the task to do the eng/coding-doxygen was claimed but me but apparently another student did the conversion before. However, I see some things wrong that I think were correct in my conversion, for example, the TBDs are not turned into comments, the links on Header File

Re: [PATCH] eng/coding-doxygen: Convert wiki page to Rest

Part of this is pushed. I made a sweep at coding-doxygen.rst before this arrived. Please see if I missed anything. If so, send a new patch. THanks. On Tue, Dec 4, 2018 at 11:30 AM Marçal Comajoan Cara < mcomajoanc...@gmail.com> wrote: > Converted

[PATCH] eng/coding-doxygen: Convert wiki page to Rest

Converted https://devel.rtems.org/wiki/Developer/Coding/Doxygen to Rest, and TBDs and wiki TODOs into comments. Also added formattings, updated links to Header File Examples and updated the Script Example to include https://devel.rtems.org/newticket instead of http://www.rtems.org/bugzilla, which

Re: POSIX Header File Signature Test for fenv.h (GCI 2018) (PATCH)

Same comment about claiming the task as the other patch. Submit as part of the GCI task so you get credit. I will merge from there On this one, I am going to add that the code should build without warnings. Just visually reviewing, I see some variables which look to be uninitialized. Please

Re: POSIX Signature Test for Header File glob.h (GCI2018)

This looks good. Did you claim this GCI task? If yes and someone approved it, please reply with the URL. Once you claim the GCI task, I will push this patch and approve the GCI task. Thanks. --joel On Tue, Dec 4, 2018 at 3:26 AM Abhimanyu Raghuvanshi < abhimanyuraghuvansh...@gmail.com> wrote:

POSIX Signature Test for Header File glob.h (GCI2018)

>From 3e8f31fdcdcd8b186891f4511584dbcec667950c Mon Sep 17 00:00:00 2001 From: ABR290B Date: Tue, 4 Dec 2018 14:54:02 +0530 Subject: [PATCH] POSIX Signature Test for glob.h (GCI2018) --- testsuites/psxtests/Makefile.am | 4 ++- testsuites/psxtests/psxhdrs/glob/glob.c | 40