Re: [PATCH] libdebugger: Fix ARMv7-M with -O0

2020-04-01 Thread Chris Johns
On 2020-04-02 16:53, Sebastian Huber wrote: Hallo Chris, On 21/03/2020 07:45, Sebastian Huber wrote: On 20/03/2020 22:23, Chris Johns wrote: On 20 Mar 2020, at 4:49 pm, Sebastian Huber wrote: On 20/03/2020 05:15, Chris Johns wrote: On 19/3/20 7:52 pm, Sebastian Huber wrote: The ARMv7-M ar

[PATCH] bsps/arm: Add support for MPU region alignment

2020-04-01 Thread Sebastian Huber
--- bsps/arm/shared/start/linkcmds.base | 21 + 1 file changed, 21 insertions(+) diff --git a/bsps/arm/shared/start/linkcmds.base b/bsps/arm/shared/start/linkcmds.base index 1f5f1ef959..d0663cf97e 100644 --- a/bsps/arm/shared/start/linkcmds.base +++ b/bsps/arm/shared/start/li

[PATCH] arm: ARMv7-M statically initialized vector table

2020-04-01 Thread Sebastian Huber
Statically initialize the ARMv7-M vector table to allow a placement in ROM with read-only MPU settings. Change licence to BSD-2-Clause in some files. --- bsps/arm/shared/clock/clock-armv7m.c | 39 -- bsps/arm/shared/irq/irq-armv7m.c | 50 +

Re: [PATCH] libdebugger: Fix ARMv7-M with -O0

2020-04-01 Thread Sebastian Huber
Hallo Chris, On 21/03/2020 07:45, Sebastian Huber wrote: On 20/03/2020 22:23, Chris Johns wrote: On 20 Mar 2020, at 4:49 pm, Sebastian Huber wrote: On 20/03/2020 05:15, Chris Johns wrote: On 19/3/20 7:52 pm, Sebastian Huber wrote: The ARMv7-M architecture has no CP-15. The inline ass

Re: [PATCH] sb/setbuilder: do not include remotes in mailed reports

2020-04-01 Thread Chris Johns
Hi Gedare, Thanks for taking a look at this ticket. Comments below.. On 2020-04-02 15:33, Gedare Bloom wrote: Closes #3887. --- source-builder/sb/reports.py| 47 - source-builder/sb/setbuilder.py | 2 +- 2 files changed, 29 insertions(+), 20 deletions(-)

Re: [PATCH] sb/setbuilder: do not include remotes in mailed reports

2020-04-01 Thread Gedare Bloom
I couldn't test this patch successfully, the "Mailing report" step hung for me without a good SMTP server to test it with. On Wed, Apr 1, 2020 at 10:33 PM Gedare Bloom wrote: > > Closes #3887. > --- > source-builder/sb/reports.py| 47 - > source-builder/sb/set

[PATCH] sb/setbuilder: do not include remotes in mailed reports

2020-04-01 Thread Gedare Bloom
Closes #3887. --- source-builder/sb/reports.py| 47 - source-builder/sb/setbuilder.py | 2 +- 2 files changed, 29 insertions(+), 20 deletions(-) diff --git a/source-builder/sb/reports.py b/source-builder/sb/reports.py index ab20671..2f72088 100644 --- a/source

[PATCH] sb/reports.py: Remove spurious error check

2020-04-01 Thread Gedare Bloom
The error path is taken when list-bsets or list-cfgs returns true (meaning it listed them). So the error is invalid. --- source-builder/sb/reports.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/source-builder/sb/reports.py b/source-builder/sb/reports.py index 86a4c3a..ab20671 100644 --- a

[PATCH] start/user: describe version numbers and releases

2020-04-01 Thread Gedare Bloom
Closes #2562. --- user/start/preparation.rst | 49 ++ 1 file changed, 49 insertions(+) diff --git a/user/start/preparation.rst b/user/start/preparation.rst index 546a03d..eb0d56b 100644 --- a/user/start/preparation.rst +++ b/user/start/preparation.rst @@ -1,8 +

RTEMS 5 release status

2020-04-01 Thread Chris Johns
Hello, Please read if you have commit access. I am cleaning up a few issues like the release README.txt to match moving all the released source in to `sources`, then updating the documentation to reference this and then I will create a 5.0.0-m2004 snapshot. After this I will be looking to m

[PATCH v4] doc: Moving M68K BSP Content to User Manual (#3905)

2020-04-01 Thread Mritunjay
--- user/bsps/bsps-m68k.rst | 190 +++- 1 file changed, 188 insertions(+), 2 deletions(-) diff --git a/user/bsps/bsps-m68k.rst b/user/bsps/bsps-m68k.rst index 60882fb..1e41f72 100644 --- a/user/bsps/bsps-m68k.rst +++ b/user/bsps/bsps-m68k.rst @@ -53,7 +53,19 @@

Re: [PATCH v2] doc: Moving BSP Content to User Manual (#3905)

2020-04-01 Thread Gedare Bloom
On Wed, Apr 1, 2020 at 4:32 PM Mritunjay Sharma wrote: > > > > Sent from my iPhone > > > On 02-Apr-2020, at 3:51 AM, Gedare Bloom wrote: > > > > On Wed, Apr 1, 2020 at 4:19 PM Gedare Bloom wrote: > >> > >>> On Wed, Apr 1, 2020 at 3:56 PM Mritunjay > >>> wrote: > >>> > >>> --- > >>> user/bsps/

Re: [PATCH v3] doc: Moving BSP Content to User Manual (#3905)

2020-04-01 Thread Mritunjay Sharma
> On 02-Apr-2020, at 3:48 AM, Chris Johns wrote: > > Hi, > > The content is good however git noticed trailing whitespace and the > documentation standard says no trailing whitespace... I'll fix them and will send you the updated patch once the discussion related to Copyright is resolved. T

Re: [PATCH v2] doc: Moving BSP Content to User Manual (#3905)

2020-04-01 Thread Mritunjay Sharma
Sent from my iPhone > On 02-Apr-2020, at 3:51 AM, Gedare Bloom wrote: > > On Wed, Apr 1, 2020 at 4:19 PM Gedare Bloom wrote: >> >>> On Wed, Apr 1, 2020 at 3:56 PM Mritunjay >>> wrote: >>> >>> --- >>> user/bsps/bsps-m68k.rst | 196 +++- >>> 1 file change

Re: [PATCH v2] doc: Moving BSP Content to User Manual (#3905)

2020-04-01 Thread Gedare Bloom
On Wed, Apr 1, 2020 at 4:19 PM Gedare Bloom wrote: > > On Wed, Apr 1, 2020 at 3:56 PM Mritunjay wrote: > > > > --- > > user/bsps/bsps-m68k.rst | 196 +++- > > 1 file changed, 194 insertions(+), 2 deletions(-) > > > > diff --git a/user/bsps/bsps-m68k.rst b/user

Re: [PATCH v2] doc: Moving BSP Content to User Manual (#3905)

2020-04-01 Thread Gedare Bloom
On Wed, Apr 1, 2020 at 3:56 PM Mritunjay wrote: > > --- > user/bsps/bsps-m68k.rst | 196 +++- > 1 file changed, 194 insertions(+), 2 deletions(-) > > diff --git a/user/bsps/bsps-m68k.rst b/user/bsps/bsps-m68k.rst > index 60882fb..84f5f9d 100644 > --- a/user/bsp

Re: [PATCH v3] doc: Moving BSP Content to User Manual (#3905)

2020-04-01 Thread Chris Johns
Hi, The content is good however git noticed trailing whitespace and the documentation standard says no trailing whitespace... Applying: doc: Moving BSP Content to User Manual (#3905) .git/rebase-apply/patch:31: trailing whitespace. This BSP is heavily based on the MCF5235 BSP. The MCF5329EV

[PATCH v3] doc: Moving BSP Content to User Manual (#3905)

2020-04-01 Thread Mritunjay
--- user/bsps/bsps-m68k.rst | 197 +++- 1 file changed, 195 insertions(+), 2 deletions(-) diff --git a/user/bsps/bsps-m68k.rst b/user/bsps/bsps-m68k.rst index 60882fb..b829f5b 100644 --- a/user/bsps/bsps-m68k.rst +++ b/user/bsps/bsps-m68k.rst @@ -1,6 +1,13 @@

Re: [PATCH v2] doc: Moving BSP Content to User Manual (#3905)

2020-04-01 Thread Chris Johns
Thanks and looking good. There is a long line with a length of 96 at the end ... On 2020-04-02 08:54, Mritunjay wrote: --- user/bsps/bsps-m68k.rst | 196 +++- 1 file changed, 194 insertions(+), 2 deletions(-) diff --git a/user/bsps/bsps-m68k.rst b/user/bs

[PATCH v2] doc: Moving BSP Content to User Manual (#3905)

2020-04-01 Thread Mritunjay
--- user/bsps/bsps-m68k.rst | 196 +++- 1 file changed, 194 insertions(+), 2 deletions(-) diff --git a/user/bsps/bsps-m68k.rst b/user/bsps/bsps-m68k.rst index 60882fb..84f5f9d 100644 --- a/user/bsps/bsps-m68k.rst +++ b/user/bsps/bsps-m68k.rst @@ -1,6 +1,13 @@

Re: [PATCH 2/3] testsuite: User input define added

2020-04-01 Thread Chris Johns
On 2020-04-01 16:40, Sebastian Huber wrote: On 01/04/2020 00:06, Chris Johns wrote: On 2020-03-31 21:02, Sebastian Huber wrote: On 31/03/2020 11:56, Chris Johns wrote: On 2020-03-31 19:57, Moyano, Gabriel wrote: diff --git a/testsuite/arphole/test_main.c b/testsuite/arphole/test_main.c ind

Re: [PATCH libbsd v2] mmcsd: Don't handle multiple hardware partitions.

2020-04-01 Thread Christian Mauderer
On 01/04/2020 14:10, Sebastian Huber wrote: > On 01/04/2020 14:09, Christian Mauderer wrote: > >> On 01/04/2020 11:55, Sebastian Huber wrote: >>> On 01/04/2020 11:45, Christian Mauderer wrote: The rtems_bsd_mmcsd_attach_worker acquired the bus without releasing it. If a MMC device has mu

Re: [PATCH libbsd v2] mmcsd: Don't handle multiple hardware partitions.

2020-04-01 Thread Sebastian Huber
On 01/04/2020 14:09, Christian Mauderer wrote: On 01/04/2020 11:55, Sebastian Huber wrote: On 01/04/2020 11:45, Christian Mauderer wrote: The rtems_bsd_mmcsd_attach_worker acquired the bus without releasing it. If a MMC device has multiple hardware partitions (like eMMC which typically has at

Re: [PATCH libbsd v2] mmcsd: Don't handle multiple hardware partitions.

2020-04-01 Thread Christian Mauderer
On 01/04/2020 11:55, Sebastian Huber wrote: > On 01/04/2020 11:45, Christian Mauderer wrote: >> The rtems_bsd_mmcsd_attach_worker acquired the bus without releasing it. >> If a MMC device has multiple hardware partitions (like eMMC which >> typically has at least one boot partition) the >> rtems_bs

Re: [PATCH libbsd v2] mmcsd: Don't handle multiple hardware partitions.

2020-04-01 Thread Sebastian Huber
On 01/04/2020 11:45, Christian Mauderer wrote: The rtems_bsd_mmcsd_attach_worker acquired the bus without releasing it. If a MMC device has multiple hardware partitions (like eMMC which typically has at least one boot partition) the rtems_bsd_mmcsd_attach_worker would try to acquire the bus multi

[PATCH libbsd v2] mmcsd: Don't handle multiple hardware partitions.

2020-04-01 Thread Christian Mauderer
The rtems_bsd_mmcsd_attach_worker acquired the bus without releasing it. If a MMC device has multiple hardware partitions (like eMMC which typically has at least one boot partition) the rtems_bsd_mmcsd_attach_worker would try to acquire the bus multiple times. This doesn't work. Doing it right wou

Re: [PATCH libbsd] mmcsd: Fix missing MMCBUS_RELEASE_BUS.

2020-04-01 Thread Christian Mauderer
Hello Sebastian, thanks for the review. On 01/04/2020 10:41, Sebastian Huber wrote: > On 01/04/2020 10:03, Christian Mauderer wrote: > >> The rtems_bsd_mmcsd_attach_worker acquired the bus without releasing it. >> Fix that by only acquire the bus if necessary (during initialization and >> during

Re: [PATCH libbsd] mmcsd: Fix missing MMCBUS_RELEASE_BUS.

2020-04-01 Thread Sebastian Huber
On 01/04/2020 10:41, Sebastian Huber wrote:     for (i = 0; i < buffer_count; ++i) { @@ -394,6 +399,7 @@ rtems_bsd_mmcsd_disk_read_write(struct mmcsd_part *part, rtems_blkdev_request *b   error:     MMCSD_DISK_UNLOCK(part); +    MMCBUS_RELEASE_BUS(device_get_parent(dev), dev);    

Re: [PATCH libbsd] mmcsd: Fix missing MMCBUS_RELEASE_BUS.

2020-04-01 Thread Sebastian Huber
On 01/04/2020 10:03, Christian Mauderer wrote: The rtems_bsd_mmcsd_attach_worker acquired the bus without releasing it. Fix that by only acquire the bus if necessary (during initialization and during read / writes). --- freebsd/sys/dev/mmc/mmcsd.c | 8 ++-- 1 file changed, 6 insertions(+)

[PATCH libbsd] mmcsd: Fix missing MMCBUS_RELEASE_BUS.

2020-04-01 Thread Christian Mauderer
The rtems_bsd_mmcsd_attach_worker acquired the bus without releasing it. Fix that by only acquire the bus if necessary (during initialization and during read / writes). --- freebsd/sys/dev/mmc/mmcsd.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/freebsd/sys/dev/mmc/m

[PATCH] libio: Remove RTEMS_FILESYSTEM_TYPE_MINIIMFS

2020-04-01 Thread Sebastian Huber
This type is unused. Do not mention non-existing CONFIGURE_FILESYSTEM_MINIIMFS. --- cpukit/include/rtems/libio.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/cpukit/include/rtems/libio.h b/cpukit/include/rtems/libio.h index 6e0bf8ede5..b3c0e975cd 100644 --- a/cpukit/include/rtems/libio.h

[PATCH 1/2] c-user: Clarify config options use

2020-04-01 Thread Sebastian Huber
--- c-user/config/general.rst | 5 - c-user/config/mpci.rst | 24 c-user/config/posix-api.rst | 10 ++ 3 files changed, 34 insertions(+), 5 deletions(-) diff --git a/c-user/config/general.rst b/c-user/config/general.rst index 388a8bf..c366be3 100644 --

[PATCH 2/2] c-user: Move CONFIGURE_MAXIMUM_PRIORITY

2020-04-01 Thread Sebastian Huber
Move this option to the scheduler configuration options. --- c-user/config/general.rst | 58 - c-user/config/scheduler-general.rst | 58 + 2 files changed, 58 insertions(+), 58 deletions(-) diff --git a/c-user/confi