Re: [PATCH] bsps/shared/ofw: Added and Documented RTEMS OFW interface

2020-08-12 Thread Christian Mauderer
Hello Niteesh, On 13/08/2020 07:05, Niteesh G. S. wrote: > On Thu, Aug 13, 2020 at 12:36 AM Gedare Bloom > wrote: > > I make a few comments below for you to consider. At a high level, I > think the interface looks reasonable, although plainly mimics the > fre

Re: [PATCH 1/2] Confstr Port for RTEMS

2020-08-12 Thread Sebastian Huber
On 12/08/2020 21:07, Gedare Bloom wrote: Chris, Christian, Sebastian: I think it would be best if one of you may have insight on this touching libbsd. Is libbsd really the right place for this function? Do we need the ability to synchronize it with FreeBSD? Are FreeBSD and RTEMS similar enoug

Re: RSB BSP Build Sets.

2020-08-12 Thread Sebastian Huber
On 13/08/2020 01:33, Chris Johns wrote: I am in the process of moving some build sets from 5 to 6. I am considering moving the `rtems/config/5/bsps` directory to `rtems/config/bsps`. This will make moving to a new release a simple change of editing the files with the version number. It will mean

Re: [PATCH] bsps/shared/ofw: Added and Documented RTEMS OFW interface

2020-08-12 Thread Niteesh G. S.
On Thu, Aug 13, 2020 at 12:36 AM Gedare Bloom wrote: > I make a few comments below for you to consider. At a high level, I > think the interface looks reasonable, although plainly mimics the > freebsd naming conventions. I wonder if we should prefer our naming > conventions, which is to aim to us

Re: crypt and POSIX

2020-08-12 Thread Sebastian Huber
On 13/08/2020 00:41, Joel Sherrill wrote: Hi I was poking at updating the Compliance Spreadsheet to track what Eshan has been doing this summer. POSIX requires crypt with crypt_r being a GNU extension. https://pubs.opengroup.org/onlinepubs/009695399/functions/crypt.html I don't see the bas

Re: [PATCH] Move 5 build sets to 6

2020-08-12 Thread Chris Johns
On 13/8/20 11:53 am, chr...@rtems.org wrote: > From: Chris Johns > > - Move 5/bsps/* to bsps/* > > - Update package build references from 5 to 6 > > - Remove 5 build sets. > Oops, forgot to `rm config/5`. I will send v2. Chris ___ devel mailing lis

[PATCH v2] Move 5 build sets to 6

2020-08-12 Thread chrisj
From: Chris Johns - Move 5/bsps/* to bsps/* - Update package build references from 5 to 6 - Remove 5 build sets. Update #4048 --- rtems/config/5/bsps/atsamv.bset | 10 - rtems/config/5/bsps/imx7.bset | 10 - rtems/config/5/bsps/qoriq_e500.bset |

[PATCH] Move 5 build sets to 6

2020-08-12 Thread chrisj
From: Chris Johns - Move 5/bsps/* to bsps/* - Update package build references from 5 to 6 - Remove 5 build sets. Update #4048 --- rtems/config/5/bsps/atsamv.bset | 10 -- rtems/config/5/bsps/imx7.bset| 10 -- rtems/config/5/bsps/qor

Re: Context switching through an ISR in RTEMS

2020-08-12 Thread Utkarsh Rai
Thanks, I'll check them out. On Thu, Aug 13, 2020 at 12:56 AM Gedare Bloom wrote: > On Wed, Aug 12, 2020 at 11:33 AM Utkarsh Rai > wrote: > > > > Hello, > > I have been testing my code for thread stack isolation against various > tests( Some written by me, and remaining already present). One of

Re: [PATCH v2] Test for clock_nanosleep with CLOCK_MONOTONIC option.

2020-08-12 Thread Utkarsh Rai
Hello Joel, I had sent a v3 patch https://lists.rtems.org/pipermail/devel/2020-April/059603.html, but it somehow went unnoticed. This may need a bit of fine-tuning, and I plan to pursue it after my GSoC ends (I have too many things on my plate right now :)) On Thu, Aug 13, 2020 at 3:46 AM Joel She

RSB BSP Build Sets.

2020-08-12 Thread Chris Johns
Hi, I am in the process of moving some build sets from 5 to 6. I am considering moving the `rtems/config/5/bsps` directory to `rtems/config/bsps`. This will make moving to a new release a simple change of editing the files with the version number. It will mean a few documentation changes. Comment

crypt and POSIX

2020-08-12 Thread Joel Sherrill
Hi I was poking at updating the Compliance Spreadsheet to track what Eshan has been doing this summer. POSIX requires crypt with crypt_r being a GNU extension. https://pubs.opengroup.org/onlinepubs/009695399/functions/crypt.html I don't see the basic POSIX method in our libcrypt. Did I miss som

Re: [PATCH v2] Test for clock_nanosleep with CLOCK_MONOTONIC option.

2020-08-12 Thread Joel Sherrill
What's the status of this test? The last email seems to indicate it needed further work before being merged. On Wed, Apr 15, 2020 at 9:16 AM Joel Sherrill wrote: > > > On Wed, Apr 15, 2020 at 9:11 AM Gedare Bloom wrote: > >> On Tue, Apr 14, 2020 at 10:56 PM Sebastian Huber >> wrote: >> > >> >

Re: Need help finding the cause of an ARM4 Exception

2020-08-12 Thread Gedare Bloom
On Wed, Aug 12, 2020 at 2:28 PM Richi Dubey wrote: > > Hi, > > Can someone please help me figure out why I am getting the > _ARMV4_Exception_data_abort_default? > > I have attached the gdb script (Provided by Mr. Huber) that I used with this > email. I have also printed the commands I have used

Need help finding the cause of an ARM4 Exception

2020-08-12 Thread Richi Dubey
Hi, Can someone please help me figure out why I am getting the _ARMV4_Exception_data_abort_default? I have attached the gdb script (Provided by Mr. Huber) that I used with this email. I have also printed the commands I have used to run gdb and qemu. I have provided my view on this exception and

Re: [PATCH 1/2] Confstr Port for RTEMS

2020-08-12 Thread Joel Sherrill
+1 >From a POSIX perspective, I think Eshan's modifications make it more correct for RTEMS but his patch and test are out of sync with master so there needs to be resolution to move this forward. On Wed, Aug 12, 2020 at 2:07 PM Gedare Bloom wrote: > Chris, Christian, Sebastian: > > I think it w

Re: Context switching through an ISR in RTEMS

2020-08-12 Thread Gedare Bloom
On Wed, Aug 12, 2020 at 11:33 AM Utkarsh Rai wrote: > > Hello, > I have been testing my code for thread stack isolation against various tests( > Some written by me, and remaining already present). One of the limitations > that I have found is that I encounter fatal errors whenever a context swit

Re: [PATCH 1/2] Confstr Port for RTEMS

2020-08-12 Thread Gedare Bloom
Chris, Christian, Sebastian: I think it would be best if one of you may have insight on this touching libbsd. On Wed, Aug 12, 2020 at 11:13 AM Joel Sherrill wrote: > > > It appears that confstr is already added (with no ifdefs on RTEMS) to libbsd. > We discussed that some of these cases make no

Re: [PATCH] bsps/shared/ofw: Added and Documented RTEMS OFW interface

2020-08-12 Thread Gedare Bloom
I make a few comments below for you to consider. At a high level, I think the interface looks reasonable, although plainly mimics the freebsd naming conventions. I wonder if we should prefer our naming conventions, which is to aim to use _ to separate different words, and to limit use of abbreviati

Context switching through an ISR in RTEMS

2020-08-12 Thread Utkarsh Rai
Hello, I have been testing my code for thread stack isolation against various tests( Some written by me, and remaining already present). One of the limitations that I have found is that I encounter fatal errors whenever a context switch takes place through an ISR. Can you please explain how the con

Re: [PATCH 1/2] Confstr Port for RTEMS

2020-08-12 Thread Joel Sherrill
It appears that confstr is already added (with no ifdefs on RTEMS) to libbsd. We discussed that some of these cases make no sense for RTEMS and should just return the UPE (unsupported programming environment" string. We also do not have a "standard path" so shouldn't return one. But the second pat

Re: [PATCH] bsps/shared/ofw: Added and Documented RTEMS OFW interface

2020-08-12 Thread Niteesh G. S.
Hello, I have resent the patches onto the mailing list as per Gedare's suggestion in the IRC. The current implementation is not 100% OF compliant. I have avoided a few functions like OF_call, OF_write etc since these don't have a valid implementation in the FDT implementation of OF interface. Onc

[PATCH] bsps/shared/ofw: Added and Documented RTEMS OFW interface

2020-08-12 Thread G S Niteesh Babu
--- bsps/shared/dev/ofw/ofw.c | 0 bsps/shared/dev/ofw/ofw.h | 437 ++ 2 files changed, 437 insertions(+) create mode 100644 bsps/shared/dev/ofw/ofw.c create mode 100644 bsps/shared/dev/ofw/ofw.h diff --git a/bsps/shared/dev/ofw/ofw.c b/bsps/shared/dev/ofw/

Re: [GSoC 2020] : BSP Buildset for EPICS (next steps)

2020-08-12 Thread Gedare Bloom
On Wed, Aug 12, 2020 at 9:20 AM Mritunjay Sharma wrote: > > Thank you so much Heinz and Gedare for the suggestion of using sed instead of > patches. > > The good news is that I worked with them and EPICS 7 was built successfully > for "xilinx_zynq_a9_qemu" using RSB recipe. > > The changes I made

Re: [PATCH] Psxtest : Fix String Turncation warning

2020-08-12 Thread Joel Sherrill
On Wed, Aug 12, 2020 at 9:43 AM Aschref Ben-Thabet < aschref.ben-tha...@embedded-brains.de> wrote: > Hello joel, Gedare, > > i think in this way , we may use Strdup/ Strrndup instead of memcpy to > guarantee the copy of null terminated String. > in this case we don't need to allocate memory, sin

Re: [GSoC 2020] : BSP Buildset for EPICS (next steps)

2020-08-12 Thread Mritunjay Sharma
Thank you so much Heinz and Gedare for the suggestion of using sed instead of patches. The good news is that I worked with them and EPICS 7 was built successfully for "xilinx_zynq_a9_qemu" using RSB recipe. The changes I made were as follows: ```diff --git a/source-builder/config/epics-7-1.cfg

Re: [PATCH 2/2] Psxtest : Fix String Turncation warning

2020-08-12 Thread Sebastian Huber
Please use git format-patch -v2 to generate a second version of the patch. This [PATCH 2/2] is confusing, for example where is [PATCH 1/2]? On 12/08/2020 17:10, Aschref Ben-Thabet wrote: From: Aschref Ben Thabet replace strncpy with strdup to silence this warning since it tries to allocate

Re: Need help in debugging a testsuite over qemu and gdb

2020-08-12 Thread Richi Dubey
Great advice. I'll keep these points in my mind. Thanks. On Tue, Aug 11, 2020 at 10:27 PM Gedare Bloom wrote: > On Tue, Aug 11, 2020 at 9:07 AM Richi Dubey wrote: > >> > >> If you hit this break point, try to use > >> bt > >> and then set a conditional break point to the offending function, res

[PATCH 2/2] Psxtest : Fix String Turncation warning

2020-08-12 Thread Aschref Ben-Thabet
From: Aschref Ben Thabet replace strncpy with strdup to silence this warning since it tries to allocate enough memory to hold the old string (plus a '\0' character to mark the end of the string). --- testsuites/psxtests/psxndbm01/init.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-

Re: [PATCH] Psxtest : Fix String Turncation warning

2020-08-12 Thread Sebastian Huber
Hello Aschref, On 12/08/2020 14:06, Aschref Ben-Thabet wrote: From: Aschref Ben Thabet replace strncpy with memcpy to silence this warning and free the allocated memory block. --- testsuites/psxtests/psxndbm01/init.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test

Re: [PATCH] Psxtest : Fix String Turncation warning

2020-08-12 Thread Aschref Ben-Thabet
Hello joel, Gedare, i think in this way , we may use Strdup/ Strrndup instead of memcpy to guarantee the copy of null terminated String. in this case we don't need to allocate memory, since Strdup do this one. i m unconscious with the line #224 key.dsize = sizeof( test_strings ) then i have

Re: [PATCH v2] rtems/printer.h Fix build warnings -Wclass-memaccess

2020-08-12 Thread Sebastian Huber
On 11/08/2020 14:30, Joel Sherrill wrote: On Tue, Aug 11, 2020 at 3:41 AM Aschref Ben-Thabet > wrote: From: Aschref Ben Thabet mailto:aschref.ben-tha...@embedded-brains.de>> ---  cpukit/include/rtems/printer.h | 6 +-  1 file

Re: [PATCH] Psxtest : Fix String Turncation warning

2020-08-12 Thread Joel Sherrill
On Wed, Aug 12, 2020 at 8:41 AM Gedare Bloom wrote: > On Wed, Aug 12, 2020 at 7:03 AM Joel Sherrill wrote: > > > > > > > > On Wed, Aug 12, 2020 at 7:07 AM Aschref Ben-Thabet < > aschref.ben-tha...@embedded-brains.de> wrote: > >> > >> From: Aschref Ben Thabet > >> > >> replace strncpy with memcp

Re: [PATCH] Psxtest : Fix String Turncation warning

2020-08-12 Thread Gedare Bloom
On Wed, Aug 12, 2020 at 7:03 AM Joel Sherrill wrote: > > > > On Wed, Aug 12, 2020 at 7:07 AM Aschref Ben-Thabet > wrote: >> >> From: Aschref Ben Thabet >> >> replace strncpy with memcpy to silence this warning and free the >> allocated memory block. > > > I don't see a call to strncpy being rep

Re: [GSoC 2020] : BSP Buildset for EPICS (next steps)

2020-08-12 Thread Gedare Bloom
On Wed, Aug 12, 2020 at 1:58 AM Heinz Junkes wrote: > > I think you should not make a patch for these two changes but a > simple replacement with e.g. sed. > > like > > sed -i ’s/^RTEMS_BASE/RTEMS_BASE = > \/home\/mritunjay\/development\/rtems/\$\(RTEMS_VERSION\)-arm\/g’ > configure/os/CONFIG_SI

Re: [PATCH] Psxtest : Fix String Turncation warning

2020-08-12 Thread Joel Sherrill
On Wed, Aug 12, 2020 at 7:07 AM Aschref Ben-Thabet < aschref.ben-tha...@embedded-brains.de> wrote: > From: Aschref Ben Thabet > > replace strncpy with memcpy to silence this warning and free the > allocated memory block. > I don't see a call to strncpy being replaced. Maybe I need coffee. I see

[PATCH] Psxtest : Fix String Turncation warning

2020-08-12 Thread Aschref Ben-Thabet
From: Aschref Ben Thabet replace strncpy with memcpy to silence this warning and free the allocated memory block. --- testsuites/psxtests/psxndbm01/init.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/testsuites/psxtests/psxndbm01/init.c b/testsuites/psxtests/psxndbm01/i

Re: [GSoC 2020] : BSP Buildset for EPICS (next steps)

2020-08-12 Thread Heinz Junkes
I think you should not make a patch for these two changes but a simple replacement with e.g. sed. like sed -i ’s/^RTEMS_BASE/RTEMS_BASE = \/home\/mritunjay\/development\/rtems/\$\(RTEMS_VERSION\)-arm\/g’ configure/os/CONFIG_SITE.Common.RTEMS oder so ;-) Viele Grüße Heinz Junkes -- Experienc

Re: [PATCH 0/1] arm/atsam/SC16IS752: Make interrupt server configurable

2020-08-12 Thread Chris Johns
On 4/8/20 2:08 am, Gedare Bloom wrote: > Up to Chris if this gets put in 5.1 release. As a bsp-specific patch, > I'm fine with it going in. Sorry I missed this. Please push to the 5 branch and it will make rc2. Thanks Chris ___ devel mailing list devel@