[PATCH v2] libcsupport: Add sbrk greedy support to consume all sbrk memory

2021-02-08 Thread chrisj
From: Chris Johns - Move the heap sbrk code into a separate routnine. - Update heap and workspace greedy allocators to use the common sbrk greedy support. Closes #3982 --- cpukit/Makefile.am| 1 + cpukit/include/rtems/malloc.h | 13 cpukit/li

Re: [PATCH] libcsupport: Add sbrk greedy support to consume all sbrk memory

2021-02-08 Thread Chris Johns
On 9/2/21 3:58 pm, Sebastian Huber wrote: > On 09/02/2021 03:31, chr...@rtems.org wrote: > >> +++ b/cpukit/libcsupport/src/rtems_heap_sbrk_greedy.c >> @@ -0,0 +1,37 @@ >> +/** >> + *  @file >> + * >> + *  @brief Greedy Allocate that Empties the sbrk system call >> + *  @ingroup MallocSupport >> +

Re: [PATCH 2/4] bsp/riscv: Add NOEL-V BSP

2021-02-08 Thread Sebastian Huber
On 08/02/2021 20:44, Daniel Hellstrom wrote: +/* + * Copyright (c) 2021 Cobham Gaisler AB. + * + * Copyright (c) 2018 embedded brains GmbH. All rights reserved. + * + * embedded brains GmbH + * Dornierstr. 4 + * 82178 Puchheim + * Germany + * + * + * The license and distribution terms for t

Re: [PATCH 4/4] bsp/riscv: Add NOEL-V BSP build specification

2021-02-08 Thread Sebastian Huber
On 08/02/2021 20:44, Daniel Hellstrom wrote: spec/build/bsps/riscv/noel/abi.yml | 48 ++ spec/build/bsps/riscv/noel/bspnoel32im.yml | 19 + spec/build/bsps/riscv/noel/bspnoel32imafd.yml | 19 + spec/build/bsps/riscv/noel/bspnoel64imac.yml

Re: [PATCH 3/4] bsp/riscv: work area size based on stack pointer

2021-02-08 Thread Sebastian Huber
On 08/02/2021 20:44, Daniel Hellstrom wrote: + + .section.data, "aw" + .align 3 + + .globl bsp_sp_at_entry + .type bsp_sp_at_entry, @object + .size bsp_sp_at_entry, 8 +bsp_sp_at_entry: + .dword 0 The size of this object should match uintptr_t.

Re: [PATCH] libcsupport: Add sbrk greedy support to consume all sbrk memory

2021-02-08 Thread Sebastian Huber
On 09/02/2021 03:31, chr...@rtems.org wrote: +++ b/cpukit/libcsupport/src/rtems_heap_sbrk_greedy.c @@ -0,0 +1,37 @@ +/** + * @file + * + * @brief Greedy Allocate that Empties the sbrk system call + * @ingroup MallocSupport + */ + +/* + * Copyright (c) 2021 Chris Johns. All rights reserved. +

[PATCH] libcsupport: Add sbrk greedy support to consume all sbrk memory

2021-02-08 Thread chrisj
From: Chris Johns - Move the heap sbrk code into a separate routnine. - Update heap and workspace greedy allocators to use the common sbrk greedy support. Closes #3982 --- cpukit/Makefile.am| 1 + cpukit/include/rtems/malloc.h | 13 +++ cpukit

Re: test for rtems_workspace_greedy_allocate

2021-02-08 Thread Chris Johns
On 8/2/21 4:50 pm, Chris Johns wrote: > On 8/2/21 4:31 pm, Sebastian Huber wrote: >> On 08/02/2021 06:14, Sebastian Huber wrote: >>> >>> We already have a ticket for this: >>> >>> >>> https://devel.rtems.org/ticket/3982 > > Thanks. I am working on a solution. It is working but there is a small pau

Re: [RTEMS 5 PATCH] bsp/motorola_powerp: Print RTEMS_VERSION from the bootloader

2021-02-08 Thread Gedare Bloom
On Mon, Feb 8, 2021 at 2:45 PM Gedare Bloom wrote: > > On Mon, Feb 8, 2021 at 2:04 PM Chris Johns wrote: > >> On 9/2/21 5:18 am, Gedare Bloom wrote: >> > If you put this on master/6, you can switch that align to use >> > RTEMS_ALIGN_UP(addr, PAGE_SIZE) -- not PAGE_MASK >> >> Sorry, I had already

Re: [RTEMS 5 PATCH] bsp/motorola_powerp: Print RTEMS_VERSION from the bootloader

2021-02-08 Thread Gedare Bloom
On Mon, Feb 8, 2021 at 2:04 PM Chris Johns wrote: > On 9/2/21 5:18 am, Gedare Bloom wrote: > > If you put this on master/6, you can switch that align to use > > RTEMS_ALIGN_UP(addr, PAGE_SIZE) -- not PAGE_MASK > > Sorry, I had already pushed the patch. > > A quick grep shows there are a few of th

Re: Coverity Unchecked Return Value Issues

2021-02-08 Thread Gedare Bloom
On Mon, Feb 8, 2021 at 1:53 PM Joel Sherrill wrote: > > > On Mon, Feb 8, 2021 at 2:18 PM Joel Sherrill wrote: > >> >> >> On Mon, Feb 8, 2021 at 1:53 PM Gedare Bloom wrote: >> >>> >>> >>> On Mon, Feb 8, 2021 at 11:59 AM Joel Sherrill wrote: >>> On Mon, Feb 8, 2021 at 12:39 PM Ged

Re: [PATCH] libcsupport: Have greedy allocations use consume extended memory

2021-02-08 Thread Chris Johns
On 9/2/21 8:09 am, Joel Sherrill wrote: > > > On Mon, Feb 8, 2021, 3:00 PM Chris Johns > wrote: > > On 9/2/21 12:37 am, Joel Sherrill wrote: > > On Mon, Feb 8, 2021 at 12:44 AM Chris Johns > >

Re: [PATCH] libcsupport: Have greedy allocations use consume extended memory

2021-02-08 Thread Joel Sherrill
On Mon, Feb 8, 2021, 3:00 PM Chris Johns wrote: > On 9/2/21 12:37 am, Joel Sherrill wrote: > > On Mon, Feb 8, 2021 at 12:44 AM Chris Johns > > wrote: > > > > On 8/2/21 5:38 pm, Sebastian Huber wrote: > > > > > > On 08/02/2021 07:30, chr...@rtems.org

Re: [RTEMS 5 PATCH] bsp/motorola_powerp: Print RTEMS_VERSION from the bootloader

2021-02-08 Thread Chris Johns
On 9/2/21 5:18 am, Gedare Bloom wrote: > If you put this on master/6, you can switch that align to use > RTEMS_ALIGN_UP(addr, PAGE_SIZE) -- not PAGE_MASK Sorry, I had already pushed the patch. A quick grep shows there are a few of these ... $ grep -r PAGE_MASK * 0001-bsp-motorola_powerp-Print-R

Re: [PATCH] libcsupport: Have greedy allocations use consume extended memory

2021-02-08 Thread Chris Johns
On 9/2/21 12:37 am, Joel Sherrill wrote: > On Mon, Feb 8, 2021 at 12:44 AM Chris Johns > wrote: > > On 8/2/21 5:38 pm, Sebastian Huber wrote: > > > > On 08/02/2021 07:30, chr...@rtems.org wrote: > >> diff --git a/cpukit/libcsuppor

Hello World Program proof

2021-02-08 Thread Prateek Pardeshi
Hello everyone, I was busy with exams lately, and now I've resolved the errors which I faced during the RTEMS setup on my machine. I've attached the program of "Hello World" with this email. If anyone needs help regarding RTEMS setup can reach out to me, I would be happy to help! :)  Thanks &

Re: Coverity Unchecked Return Value Issues

2021-02-08 Thread Joel Sherrill
On Mon, Feb 8, 2021 at 2:18 PM Joel Sherrill wrote: > > > On Mon, Feb 8, 2021 at 1:53 PM Gedare Bloom wrote: > >> >> >> On Mon, Feb 8, 2021 at 11:59 AM Joel Sherrill wrote: >> >>> >>> >>> On Mon, Feb 8, 2021 at 12:39 PM Gedare Bloom wrote: >>> On Mon, Feb 8, 2021 at 11:24 AM Joe

Re: [PATCH v2 0/4] bsps/shared/ofw: Bug and Coverity defect fixes

2021-02-08 Thread Joel Sherrill
On Mon, Feb 8, 2021, 2:27 PM Christian Mauderer wrote: > Hello Gedare and Niteesh, > > the patches look fine. I pushed them. > > @Niteesh: Thanks for creating them. Thanks to you both. Coverity runs at 12:05am Central time if anything changes in the RSB or RTEMS. It could be twice a day but jus

Re: [PATCH v2 0/4] bsps/shared/ofw: Bug and Coverity defect fixes

2021-02-08 Thread Christian Mauderer
Hello Gedare and Niteesh, the patches look fine. I pushed them. @Niteesh: Thanks for creating them. Best regards Christian On 08/02/2021 19:13, Gedare Bloom wrote: Christian, These look good to me, please push if you are happy with them too. Thanks! On Sat, Feb 6, 2021 at 10:41 AM G S Nite

Re: Coverity Unchecked Return Value Issues

2021-02-08 Thread Joel Sherrill
On Mon, Feb 8, 2021 at 1:53 PM Gedare Bloom wrote: > > > On Mon, Feb 8, 2021 at 11:59 AM Joel Sherrill wrote: > >> >> >> On Mon, Feb 8, 2021 at 12:39 PM Gedare Bloom wrote: >> >>> >>> >>> On Mon, Feb 8, 2021 at 11:24 AM Joel Sherrill wrote: >>> Hi There are more than a couple of

Re: Coverity Unchecked Return Value Issues

2021-02-08 Thread Gedare Bloom
On Mon, Feb 8, 2021 at 11:59 AM Joel Sherrill wrote: > > > On Mon, Feb 8, 2021 at 12:39 PM Gedare Bloom wrote: > >> >> >> On Mon, Feb 8, 2021 at 11:24 AM Joel Sherrill wrote: >> >>> Hi >>> >>> There are more than a couple of these. in our set of CIDs. I am >>> wondering if these can be addresse

[PATCH 4/4] bsp/riscv: Add NOEL-V BSP build specification

2021-02-08 Thread Daniel Hellstrom
From: Martin Aberg --- spec/build/bsps/riscv/noel/abi.yml | 48 ++ spec/build/bsps/riscv/noel/bspnoel32im.yml | 19 + spec/build/bsps/riscv/noel/bspnoel32imafd.yml | 19 + spec/build/bsps/riscv/noel/bspnoel64imac.yml | 19 + spec/bui

[PATCH 3/4] bsp/riscv: work area size based on stack pointer

2021-02-08 Thread Daniel Hellstrom
From: Martin Aberg Remember the initial stack pointer in start.S. It can later be used to determine top of RAM. --- bsps/riscv/shared/start/bspgetworkarea-fromstack.c | 55 ++ bsps/riscv/shared/start/start.S| 15 ++ 2 files changed, 70 insertions(+) c

[PATCH 2/4] bsp/riscv: Add NOEL-V BSP

2021-02-08 Thread Daniel Hellstrom
From: Martin Aberg Added support for Cobham Gaisler NOEL-V systems. The NOEL-V support is implemented as a riscv BSP. Both 32-bit and 64-bit processor systems are supported. Cobham Gaisler's NOEL-V RISC-V processor IP is described here: https://www.gaisler.com/NOELV Compatible with the followi

[PATCH 1/4] apbuart_termios: use bsp/irq.h

2021-02-08 Thread Daniel Hellstrom
From: Martin Aberg The real dependency in this case is on rtems/irq-extension.h. The theme in other other console drivers is to get it via bsp/irq.h, so that pattern is followed. --- bsps/shared/grlib/uart/apbuart_termios.c | 1 + 1 file changed, 1 insertion(+) diff --git a/bsps/shared/grlib/ua

[PATCH 0/4] RISC-V: NOEL-V BSP

2021-02-08 Thread Daniel Hellstrom
This set of patches adds a BSP for the NOEL-V RISC-V processor IP from Cobham Gaisler: https://www.gaisler.com/noelv The patches are for the RTEMS master branch with the autoconf and new WAF build system. If accepted another patch set for the RTEMS-5 branch will follow. Patches for the doc

Re: Coverity Unchecked Return Value Issues

2021-02-08 Thread Joel Sherrill
On Mon, Feb 8, 2021 at 12:39 PM Gedare Bloom wrote: > > > On Mon, Feb 8, 2021 at 11:24 AM Joel Sherrill wrote: > >> Hi >> >> There are more than a couple of these. in our set of CIDs. I am wondering >> if these can be addressed with a macro like this: >> >> #define _IGNORED_RETURN_STATUS(_status

Re: Coverity Unchecked Return Value Issues

2021-02-08 Thread Gedare Bloom
On Mon, Feb 8, 2021 at 11:24 AM Joel Sherrill wrote: > Hi > > There are more than a couple of these. in our set of CIDs. I am wondering > if these can be addressed with a macro like this: > > #define _IGNORED_RETURN_STATUS(_status, _ok) \ > do { \ > _Assert((_status) == (_ok)); \ > Can you

Re: Completed Hello World task

2021-02-08 Thread Gedare Bloom
On Mon, Feb 8, 2021 at 10:37 AM Sanskar Khandelwal wrote: > Hello gedare, > > As you asked, I have sent you Hello world Patch with the subject name > "Sanskar's Modified Hello World" please check it and let me know. > > I went through the project list and selected a few projects which I found > i

Re: Hello World Program proof

2021-02-08 Thread Gedare Bloom
Hi Prateek, Welcome. Please send me the git-patch of your change. You can start browsing the open projects and asking questions, and also look for Joel's recent request for students, Subject: Remaining Waf Conversion Tickets for Community and GSoC Students -Gedare On Mon, Feb 8, 2021 at 9:58 AM

Re: [PATCH] basedefs: Add stringification of argument lists

2021-02-08 Thread Gedare Bloom
sorry, I saw it before and it looked reasonable/harmless to me. On Sun, Feb 7, 2021 at 11:55 PM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 14/12/2020 09:44, Sebastian Huber wrote: > > > Change RTEMS_STRING() and RTEMS_XSTRING() to accept a variable number of > > arguments w

Coverity Unchecked Return Value Issues

2021-02-08 Thread Joel Sherrill
Hi There are more than a couple of these. in our set of CIDs. I am wondering if these can be addressed with a macro like this: #define _IGNORED_RETURN_STATUS(_status, _ok) \ do { \ _Assert((_status) == (_ok)); \ (void) (_status); } while (0); Or _Assert_Ignored_return? The ones I hav

Re: [RTEMS 5 PATCH] bsp/motorola_powerp: Print RTEMS_VERSION from the bootloader

2021-02-08 Thread Joel Sherrill
On Mon, Feb 8, 2021 at 12:19 PM Gedare Bloom wrote: > If you put this on master/6, you can switch that align to use > RTEMS_ALIGN_UP(addr, PAGE_SIZE) -- not PAGE_MASK > Good catch. And seeing this again, I notice it is powerp not powerpc in the commit message. --joel > > On Sun, Feb 7, 2021 a

Re: [RTEMS 5 PATCH] bsp/motorola_powerp: Print RTEMS_VERSION from the bootloader

2021-02-08 Thread Gedare Bloom
If you put this on master/6, you can switch that align to use RTEMS_ALIGN_UP(addr, PAGE_SIZE) -- not PAGE_MASK On Sun, Feb 7, 2021 at 4:29 PM Chris Johns wrote: > On 8/2/21 9:48 am, Joel Sherrill wrote: > > Do you want another ticket to apply this to 5 as well? > > This is for 5 and the ticket i

Re: [PATCH v2 0/4] bsps/shared/ofw: Bug and Coverity defect fixes

2021-02-08 Thread Gedare Bloom
Christian, These look good to me, please push if you are happy with them too. Thanks! On Sat, Feb 6, 2021 at 10:41 AM G S Niteesh Babu wrote: > Update since v1: Using strlcpy instead of memcpy > > The following series of patches fix bugs and coverity reported > defect in bsps/shared/ofw.c. > >

Re: Completed Hello World task

2021-02-08 Thread Sanskar Khandelwal
Hello gedare, As you asked, I have sent you Hello world Patch with the subject name "Sanskar's Modified Hello World" please check it and let me know. I went through the project list and selected a few projects which I found interesting. 1. #4162 : SiFive RISC-V HiFive Unleashed BSP (Qemu) 2. #302

[PATCH] Sanskar's Modified Hello World

2021-02-08 Thread kdsanskar07
From: Sanskar Khandelwal Hello everyone, My name is sanskar khandelwal, I have completed the hello world task, please let me know if there is anything to change in this task. --- testsuites/samples/hello/init.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/testsuites/s

[PATCH v8] Confstr support for RTEMS

2021-02-08 Thread Eshan Dhawan
From: Eshan dhawan Closes #3373 Signed-off-by: Eshan Dhawan --- cpukit/Makefile.am| 1 + cpukit/posix/src/confstr.c| 151 ++ spec/build/cpukit/librtemscpu.yml | 1 + spec/build/testsuites/psxtests/grp.yml|

Re: [PATCH] libcsupport: Have greedy allocations use consume extended memory

2021-02-08 Thread Joel Sherrill
On Mon, Feb 8, 2021 at 12:44 AM Chris Johns wrote: > On 8/2/21 5:38 pm, Sebastian Huber wrote: > > > > On 08/02/2021 07:30, chr...@rtems.org wrote: > >> diff --git a/cpukit/libcsupport/src/rtems_heap_greedy.c > >> b/cpukit/libcsupport/src/rtems_heap_greedy.c > >> index 4dda39873f..2361f17d2e 1006

Re: [PATCH v7] Confstr support for RTEMS

2021-02-08 Thread Sebastian Huber
On 08/02/2021 14:27, Joel Sherrill wrote: On Mon, Feb 8, 2021 at 4:06 AM Sebastian Huber > wrote: On 08/02/2021 10:22, Eshan Dhawan wrote: > +static rtems_task Init(rtems_task_argument ignored) > +{ > +  rtems_test_run(ignored, TEST

Re: [PATCH v7] Confstr support for RTEMS

2021-02-08 Thread Joel Sherrill
On Mon, Feb 8, 2021 at 4:06 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 08/02/2021 10:22, Eshan Dhawan wrote: > > > +static rtems_task Init(rtems_task_argument ignored) > > +{ > > + rtems_test_run(ignored, TEST_STATE); > > +} > Please check the other tests which already u

Re: [PATCH v7] Confstr support for RTEMS

2021-02-08 Thread Sebastian Huber
On 08/02/2021 10:22, Eshan Dhawan wrote: +static rtems_task Init(rtems_task_argument ignored) +{ + rtems_test_run(ignored, TEST_STATE); +} Please check the other tests which already use this function and optimize your test accordingly. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr.

Re: Remaining Waf Conversion Tickets for Community and GSoC Students

2021-02-08 Thread Chris Johns
On 8/2/21 5:49 pm, Sebastian Huber wrote: > On 08/02/2021 06:04, Chris Johns wrote: > >> On 7/2/21 4:15 am, Joel Sherrill wrote: >>> Hi >>> >>> While potential GSoC students are becoming more familiar with RTEMS and the >>> community,, I wanted to pass along a few tickets that we would appreciate

[PATCH v7] Confstr support for RTEMS

2021-02-08 Thread Eshan Dhawan
From: Eshan dhawan Closes #3373 Signed-off-by: Eshan Dhawan --- cpukit/Makefile.am| 1 + cpukit/posix/src/confstr.c| 151 ++ spec/build/cpukit/librtemscpu.yml | 1 + spec/build/testsuites/psxtests/grp.yml|

Re: [PATCH v6] Confstr support for RTEMS

2021-02-08 Thread Sebastian Huber
On 08/02/2021 09:42, Eshan Dhawan wrote: + T_register(); + exit_code = T_main(&config); + if (exit_code == 0) { +TEST_END(); + } Please use rtems_test_run(). Check the file templates and fix the Doxygen markup. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim

[PATCH v6] Confstr support for RTEMS

2021-02-08 Thread Eshan Dhawan
From: Eshan dhawan Signed-off-by: Eshan Dhawan --- cpukit/Makefile.am| 1 + cpukit/posix/src/confstr.c| 151 ++ spec/build/cpukit/librtemscpu.yml | 1 + spec/build/testsuites/psxtests/grp.yml| 2 + spec/bu