Re: [PATCH 4/4] rtems-debugger-target.c: Fix Coverity Dereference before null check

On Thu, Feb 11, 2021 at 2:37 PM Chris Johns wrote: > > > > On 12/2/21 8:35 am, Gedare Bloom wrote: > > On Thu, Feb 11, 2021 at 2:33 PM Joel Sherrill wrote: > >> > >> > >> > >> On Thu, Feb 11, 2021 at 3:29 PM Chris Johns wrote: > >>> > >>> On 12/2/21 8:16 am, Gedare Bloom wrote: > On Thu,

Re: [PATCH 1/4] assert.h: Add macros to assert status and use it

On Thu, Feb 11, 2021 at 2:19 PM Joel Sherrill wrote: > > > > On Thu, Feb 11, 2021 at 3:12 PM Gedare Bloom wrote: >> >> On Thu, Feb 11, 2021 at 1:28 PM Ryan Long wrote: >> > >> > These macros are to be used to check the status from calls that are >> > flagged by >> > Coverity as 'Unchecked

Re: Remaining Waf Conversion Tickets for Community and GSoC Students

On 11/2/21 7:50 pm, Sebastian Huber wrote: > On 11/02/2021 00:20, Chris Johns wrote: > >> On 10/2/21 4:20 pm, Sebastian Huber wrote: >>> On 08/02/2021 10:40, Chris Johns wrote: > It is written in Python 3.6. We still need to support python 2. Maybe having this file support both

Re: [PATCH 4/4] rtems-debugger-target.c: Fix Coverity Dereference before null check

On 12/2/21 8:35 am, Gedare Bloom wrote: > On Thu, Feb 11, 2021 at 2:33 PM Joel Sherrill wrote: >> >> >> >> On Thu, Feb 11, 2021 at 3:29 PM Chris Johns wrote: >>> >>> On 12/2/21 8:16 am, Gedare Bloom wrote: On Thu, Feb 11, 2021 at 2:00 PM Chris Johns wrote: > > On 12/2/21 7:27

Re: [PATCH 4/4] rtems-debugger-target.c: Fix Coverity Dereference before null check

On 12/2/21 8:33 am, Joel Sherrill wrote: > > > On Thu, Feb 11, 2021 at 3:29 PM Chris Johns > wrote: > > On 12/2/21 8:16 am, Gedare Bloom wrote: > > On Thu, Feb 11, 2021 at 2:00 PM Chris Johns > wrote: > >> > >> On 12/2/21

Re: [PATCH 4/4] rtems-debugger-target.c: Fix Coverity Dereference before null check

On Thu, Feb 11, 2021 at 2:33 PM Joel Sherrill wrote: > > > > On Thu, Feb 11, 2021 at 3:29 PM Chris Johns wrote: >> >> On 12/2/21 8:16 am, Gedare Bloom wrote: >> > On Thu, Feb 11, 2021 at 2:00 PM Chris Johns wrote: >> >> >> >> On 12/2/21 7:27 am, Ryan Long wrote: >> >>> Fixes CID #1468682 where

Re: [PATCH 4/4] rtems-debugger-target.c: Fix Coverity Dereference before null check

On Thu, Feb 11, 2021 at 3:29 PM Chris Johns wrote: > On 12/2/21 8:16 am, Gedare Bloom wrote: > > On Thu, Feb 11, 2021 at 2:00 PM Chris Johns wrote: > >> > >> On 12/2/21 7:27 am, Ryan Long wrote: > >>> Fixes CID #1468682 where target is dereferenced before it has been > >>> checked as to whether

Re: [PATCH 4/4] rtems-debugger-target.c: Fix Coverity Dereference before null check

On 12/2/21 8:16 am, Gedare Bloom wrote: > On Thu, Feb 11, 2021 at 2:00 PM Chris Johns wrote: >> >> On 12/2/21 7:27 am, Ryan Long wrote: >>> Fixes CID #1468682 where target is dereferenced before it has been >>> checked as to whether it is null or not in the >>>

Re: [PATCH 4/4] rtems-debugger-target.c: Fix Coverity Dereference before null check

On 12/2/21 8:03 am, Joel Sherrill wrote: > On Thu, Feb 11, 2021, 3:00 PM Chris Johns > wrote: > > On 12/2/21 7:27 am, Ryan Long wrote: > > Fixes CID #1468682 where target is dereferenced before it has been > > checked as to whether it is null or not in the >

Re: [PATCH 1/4] assert.h: Add macros to assert status and use it

On Thu, Feb 11, 2021 at 3:12 PM Gedare Bloom wrote: > On Thu, Feb 11, 2021 at 1:28 PM Ryan Long > wrote: > > > > These macros are to be used to check the status from calls that are > flagged by > > Coverity as 'Unchecked return value'. > > --- > > cpukit/include/rtems/score/assert.h | 30

Re: Revisiting Minimum with Static Allocation

On 12/2/21 1:17 am, Joel Sherrill wrote: > > > On Thu, Feb 11, 2021 at 3:04 AM Sebastian Huber > > > wrote: > > On 10/02/2021 21:36, Gedare Bloom wrote: > > > > > > > On Wed, Feb 10, 2021 at 10:57 AM Joel Sherrill

Re: [PATCH 4/4] rtems-debugger-target.c: Fix Coverity Dereference before null check

On Thu, Feb 11, 2021 at 2:00 PM Chris Johns wrote: > > On 12/2/21 7:27 am, Ryan Long wrote: > > Fixes CID #1468682 where target is dereferenced before it has been > > checked as to whether it is null or not in the > > rtems_debugger_target_swbreak_control function. > > --- > >

Re: [PATCH 4/4] rtems-debugger-target.c: Fix Coverity Dereference before null check

On Thu, Feb 11, 2021 at 1:28 PM Ryan Long wrote: > > Fixes CID #1468682 where target is dereferenced before it has been > checked as to whether it is null or not in the > rtems_debugger_target_swbreak_control function. > --- > cpukit/libdebugger/rtems-debugger-target.c | 5 +++-- > 1 file

Re: [PATCH 1/4] assert.h: Add macros to assert status and use it

On Thu, Feb 11, 2021 at 1:28 PM Ryan Long wrote: > > These macros are to be used to check the status from calls that are flagged by > Coverity as 'Unchecked return value'. > --- > cpukit/include/rtems/score/assert.h | 30 ++ > 1 file changed, 30 insertions(+) > > diff

Re: [PATCH 4/4] rtems-debugger-target.c: Fix Coverity Dereference before null check

On Thu, Feb 11, 2021, 3:00 PM Chris Johns wrote: > On 12/2/21 7:27 am, Ryan Long wrote: > > Fixes CID #1468682 where target is dereferenced before it has been > > checked as to whether it is null or not in the > > rtems_debugger_target_swbreak_control function. > > --- > >

Re: [PATCH 3/4] rtems-debugger-threads.c: Fix Coverity Dereference before null check

On 12/2/21 7:27 am, Ryan Long wrote: > Fixes CID #1468681, 1468690, and 1468694 by checking if threads is null in > the rtems_debugger_thread_find_index, rtems_debugger_thread_system_resume, > and rtems_debugger_thread_continue_all functions. Looks good. Thanks Chris

Re: [PATCH 4/4] rtems-debugger-target.c: Fix Coverity Dereference before null check

On 12/2/21 7:27 am, Ryan Long wrote: > Fixes CID #1468682 where target is dereferenced before it has been > checked as to whether it is null or not in the > rtems_debugger_target_swbreak_control function. > --- > cpukit/libdebugger/rtems-debugger-target.c | 5 +++-- > 1 file changed, 3

[PATCH 3/4] rtems-debugger-threads.c: Fix Coverity Dereference before null check

Fixes CID #1468681, 1468690, and 1468694 by checking if threads is null in the rtems_debugger_thread_find_index, rtems_debugger_thread_system_resume, and rtems_debugger_thread_continue_all functions. --- cpukit/libdebugger/rtems-debugger-threads.c | 14 +++--- 1 file changed, 11

[PATCH 4/4] rtems-debugger-target.c: Fix Coverity Dereference before null check

Fixes CID #1468682 where target is dereferenced before it has been checked as to whether it is null or not in the rtems_debugger_target_swbreak_control function. --- cpukit/libdebugger/rtems-debugger-target.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH 2/4] consolesimpletask.c: Fix Coverity Unchecked return value

Fixes CID #1437625 and #1472765 where the return value of rtems_task_create and rtems_task_start is discarded. --- cpukit/libcsupport/src/consolesimpletask.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/cpukit/libcsupport/src/consolesimpletask.c

[PATCH 1/4] assert.h: Add macros to assert status and use it

These macros are to be used to check the status from calls that are flagged by Coverity as 'Unchecked return value'. --- cpukit/include/rtems/score/assert.h | 30 ++ 1 file changed, 30 insertions(+) diff --git a/cpukit/include/rtems/score/assert.h

[PATCH 0/4] Fix for Coverity issues

Hi, I created some macros to assert the status returned from function calls, and use that status based on Gedare and Joel's suggestions. I implemented the macros in consolesimpletask.c. I fixed some issues for the 'Dereference before null check' in a couple of files. This mainly entailed moving

Re: Requests Patches to be Applied to 4.10

On Thu, Feb 11, 2021 at 1:47 PM Gedare Bloom wrote: > Hi Joel, > > On Thu, Feb 11, 2021 at 12:30 PM Joel Sherrill wrote: > > > > Hi > > > > Phillip Smith pinged me at the FSW via Slack about this set of patches > he proposed be added to the 4.10 branch. > > > >

Re: Requests Patches to be Applied to 4.10

Hi Joel, On Thu, Feb 11, 2021 at 12:30 PM Joel Sherrill wrote: > > Hi > > Phillip Smith pinged me at the FSW via Slack about this set of patches he > proposed be added to the 4.10 branch. > > https://lists.rtems.org/pipermail/devel/2019-April/025610.html > > I assume this matches what their

Requests Patches to be Applied to 4.10

Hi Phillip Smith pinged me at the FSW via Slack about this set of patches he proposed be added to the 4.10 branch. https://lists.rtems.org/pipermail/devel/2019-April/025610.html I assume this matches what their project requires. Given that 4.10 is the last unirprocessor version and we appear to

Re: Question regarding RSB and open projects

Thank-you very much for help and clarification , I think i didn't bootstrap the source code last time because this time I did get configure file which i then used for make and make install , this time I used enable-test=samples option and while using rtems-test on erc32 , 11 test were performed.

[PATCH 1/1] misc: tools: fix mkimage.py script type processing

From: Andre Nahrwold --- misc/tools/mkimage.py | 10 ++ 1 file changed, 10 insertions(+) diff --git a/misc/tools/mkimage.py b/misc/tools/mkimage.py index fd75f0a..111e224 100755 --- a/misc/tools/mkimage.py +++ b/misc/tools/mkimage.py @@ -121,6 +121,16 @@ outputfile.seek(struct.size);

[PATCH 0/1] misc: tools: fix mkimage.py script type processing

Here is the patch from Andre also in git send-email format. It would be great if we could integrate it in master and the 5 braches. Best regards, Jan Andre Nahrwold (1): misc: tools: fix mkimage.py script type processing misc/tools/mkimage.py | 10 ++ 1 file changed, 10

[PATCH] bsps/arm/imxrt: Add FDT and FDT helper for QTMR

Makes it simpler to access the QTMR in an application via a FDT name or link in an application specific FDT entry. --- bsps/arm/imxrt/include/fsl_qtmr.h | 34 bsps/arm/imxrt/include/imxrt/imxrt1050.dtsi | 24 +++ .../nxp/devices/MIMXRT1052/drivers/fsl_qtmr.c

Minimal Pi Support Library for Bare Metal

Hi https://github.com/jasLogic/mipea is a minimalistic peripheral access for the Raspberry Pi under BSD-3 license. Not sure if it has anything that we don't already but it may make a good reference in the future. The README.md says it supports all variants and has been tested on a variety of

Re: Revisiting Minimum with Static Allocation

On Thu, Feb 11, 2021 at 3:04 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 10/02/2021 21:36, Gedare Bloom wrote: > > > > > > > On Wed, Feb 10, 2021 at 10:57 AM Joel Sherrill > > wrote: > > > > Hi > > > > The minimum sample is intended to show

Re: [PATCH v2 12/12] c-user: Generate clock manager documentation

Hello Sebastian, On 2/10/21 5:28 PM, Sebastian Huber wrote: > The documentation is a consolidation of the comments in Doxygen markup > and the documentation sources in Sphinx markup. The documentation was > transfered to interface specification items. The documentation source > files were

Re: [PATCH] STM32H7 doc update

Hello, Just another bump for the small doc patch and a reminder for another patch I sent, which still needs some smaller adaptations for lwIP ([PATCH] Basic lwIP for STM32H7 BSP) Kind Regards Robin Müller On Thu, 21 Jan 2021 at 13:52, Robin Müller wrote: > I'd just like to bump my patch. The

Re: Remaining Waf Conversion Tickets for Community and GSoC Students

On 11/02/2021 00:30, Chris Johns wrote: No source code change for Kinsey's BSPs -- just different GCC settings. Do these settings change the ABI? I think we need to be careful having options to vary a BSP's ABI with the same name. Yes, I think each ABI variant of a BSP should have its own

Re: Remaining Waf Conversion Tickets for Community and GSoC Students

On 11/02/2021 00:20, Chris Johns wrote: On 10/2/21 4:20 pm, Sebastian Huber wrote: On 08/02/2021 10:40, Chris Johns wrote: It is written in Python 3.6. We still need to support python 2. Maybe having this file support both could be part of the project. I think this BSP builder is a