Re: Need help in deciding GSoC project also want to know project Scope

Hello Prateek Pardeshi, an interesting LLVM related project could be trying out MULL with RTEMS. https://github.com/mull-project/mull I had only a brief look at it and I am not sure if it is feasible or makes sense for RTEMS. Maybe someone on the mailing list has already experience with

Re: About HEAP error

Oh, that makes sense. Thank you. I got this: (gdb) p *(Heap_Error_context*)(0x00206d7c) $5 = { heap = 0x202ba8 <_Workspace_Area>, block = 0x206fec, reason = HEAP_ERROR_FREE_PATTERN } HEAP_ERROR_FREE_PATTERN There is an unexpected value in the free pattern of a free heap block. I will try

Re: [PATCH 00/22] tester: Update covoar for new build system

On 2/3/21 7:01 am, Alex White wrote: > This patch set updates the covoar tool to allow it to work with the > outputs of the current build system. It includes various fixes and > improvements needed to successfully produce coverage reports for the > following BSP configurations: griscv-sis,

Re: [PATCH rtems-libbsd 1/2] racoon/session: Honor file descriptor maximum

On 1/3/21 7:24 pm, Christian MAUDERER wrote: > Hello Chris, > > thanks for the review. > > Am 26.02.21 um 19:04 schrieb Chris Johns: >> On 26/2/21 2:01 am, Christian Mauderer wrote: >>> Dynamically allocate a big enough file descriptor set for select(). A >>> better solution would be to use

RE: [PATCH v1 1/2] score: Enforce stack_end alignment

I think this got lost in the deluge. For the second comment, were you suggesting that the allocated size isn't guaranteed to be correctly aligned? Kinsey -Original Message- From: devel On Behalf Of Kinsey Moore Sent: Friday, February 19, 2021 11:56 To: Sebastian Huber ; devel@rtems.org

Announcement: Legacy libnetworking will be removed from RTEMS and will be placed in a separate repository

Hello all, In RTEMS 6, there will be no cpukit/libnetworking in the RTEMS repository and it will be moved to its own separate repository. There are ongoing efforts in this direction and it is very close to completion. What's remaining, is to collect feedback from the users of the libnetworking

Re: [PATCH 1/3] fdt_rw.c: Fix Unchecked return value (CID #1047324)

On Mon, Mar 1, 2021 at 1:00 PM Sebastian Huber wrote: > > On 01/03/2021 20:35, Gedare Bloom wrote: > > > On Mon, Mar 1, 2021 at 12:26 PM Ryan Long wrote: > >> So just send this patch to them? > >> > > Without the ifdef construct > And with a more detailed commit message. > > yes, thanks for

[PATCH 22/22] covoar/Reports: Fix empty branch report

This makes the branch report more consistent with the other reports when there is no branch information found. --- tester/covoar/ReportsBase.cc | 12 ++ tester/covoar/ReportsHtml.cc | 82 2 files changed, 39 insertions(+), 55 deletions(-) diff --git

[PATCH 21/22] covoar: Fix overflow of high PC address

This fixes an integer overflow that would occur if a function's high PC address were zero in the DWARF info. --- tester/covoar/ExecutableInfo.cc | 5 + 1 file changed, 5 insertions(+) diff --git a/tester/covoar/ExecutableInfo.cc b/tester/covoar/ExecutableInfo.cc index 30828a6..7f33f20 100644

[PATCH 19/22] covoar: Catch exceptional case

--- tester/covoar/ExecutableInfo.cc | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tester/covoar/ExecutableInfo.cc b/tester/covoar/ExecutableInfo.cc index 187bb77..5a730fd 100644 --- a/tester/covoar/ExecutableInfo.cc +++ b/tester/covoar/ExecutableInfo.cc @@ -201,6 +201,16 @@

[PATCH 20/22] covoar: Allow symbols from objdump to be skipped

There is at least one symbol that is shown as having no machine code in the DWARF info but obviously contains machine code if inspected using objdump. This results in an exception being thrown when that symbol's coverage map is looked up. That exception is now caught and a message is printed to

[PATCH 18/22] covoar: Add option to create named objdumps

This adds a new macro USE_TEMPLFILE which allows the creation of named objdump outputs in the /tmp directory. This allows the outputs to be reused on subsequent runs of covoar rather than running objdump again. --- rtemstoolkit/rld-process.cpp | 12 rtemstoolkit/rld-process.h

[PATCH 17/22] covoar: Fix null pointer dereference

--- tester/covoar/ExecutableInfo.cc | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tester/covoar/ExecutableInfo.cc b/tester/covoar/ExecutableInfo.cc index 1396519..187bb77 100644 --- a/tester/covoar/ExecutableInfo.cc +++ b/tester/covoar/ExecutableInfo.cc @@ -82,13

[PATCH 13/22] covoar: Handle periods in symbols from objdump

Occasionally the compiler will generate symbols that look similar to symbols defined in RTEMS code except that they contain some suffix. This looks to be related to compiler optimizations. Such symbols were being treated as unique. For our purposes, they should be mapped to the equivalent symbols

[PATCH 08/22] covoar/TargetBase: Fix QEMU branch info

The taken/not taken bit was being interpreted incorrectly. This led to branches being marked "always taken" when they were never taken. This has been fixed. --- tester/covoar/TargetBase.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tester/covoar/TargetBase.cc

[PATCH 09/22] covoar: Fix DWARF reading

There were a couple of issues with the way the DWARF info was being read. The first issue was that it inefficiently included all symbols, even symbols that were not desired. The second issue is that it did not handle inline functions correctly. These have been fixed. ---

[PATCH 10/22] dwarf: Fix get_source

The file::get_source method was giving "unknown:-1" for valid addresses. This has been fixed. --- rtemstoolkit/rld-dwarf.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/rtemstoolkit/rld-dwarf.cpp b/rtemstoolkit/rld-dwarf.cpp index acb4fd4..2fce0e4 100644 ---

[PATCH 12/22] covoar: Fix NOP execution marking

Some NOP instructions were not being marked as executed because they are located at the end of uncovered ranges. This has been fixed. --- tester/covoar/CoverageMapBase.cc | 10 +++ tester/covoar/CoverageMapBase.h | 4 ++ tester/covoar/DesiredSymbols.cc | 38 --

[PATCH 11/22] covoar: Account for build path change

Covoar had not been updated to account for the paths used by the new build system. This has been fixed. --- tester/covoar/covoar.cc | 5 - 1 file changed, 5 deletions(-) diff --git a/tester/covoar/covoar.cc b/tester/covoar/covoar.cc index 84d883a..bf95cb4 100644 --- a/tester/covoar/covoar.cc

[PATCH 07/22] covoar/CoverageReaderQEMU: Fix infinite loop

There was a potential that the branch info loop never terminated. This has been fixed by adding a more reliable termination condition and logging an error if it cannot find the branch target. --- tester/covoar/CoverageReaderQEMU.cc | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-)

[PATCH 06/22] covoar: Add aarch64 target

--- tester/covoar/TargetFactory.cc | 2 + tester/covoar/Target_aarch64.cc | 100 tester/covoar/Target_aarch64.h | 77 tester/covoar/wscript | 1 + 4 files changed, 180 insertions(+) create mode 100644

[PATCH 05/22] covoar/Target_arm: Add THUMB branch instructions

The ".n" and ".w" variants of the THUMB branch instructions were not included in the list of conditional branch instructions. They have been added. --- tester/covoar/Target_arm.cc | 34 ++ 1 file changed, 34 insertions(+) diff --git a/tester/covoar/Target_arm.cc

[PATCH 04/22] covoar/Target_i386: Add NOP patterns

A couple of NOP patterns found with the pc686 BSP were not detected. This has been fixed. --- tester/covoar/Target_i386.cc | 9 + 1 file changed, 9 insertions(+) diff --git a/tester/covoar/Target_i386.cc b/tester/covoar/Target_i386.cc index e0c9c0f..4567c1e 100644 ---

[PATCH 03/22] covoar/TargetBase: Update branchInstructions variable name

The TargetBase class contains a member variable named branchInstructions. The name omits the fact that it is only meant to contain conditional branch instructions. Its name has been changed to conditionalBranchInstructions to avoid confusion. --- tester/covoar/TargetBase.cc | 10 +++-

[PATCH 02/22] tester: Add coverage variants for a few BSPs

Adds coverage variants for the following BSPs: a53_qemu, pc686, xilinx_zynq_a9_qemu, and xilinx_zynqmp. --- tester/rtems/testing/bsps/a53_qemu-cov.ini| 41 ++ tester/rtems/testing/bsps/pc-qemu-cov.ini | 42 +++ .../testing/bsps/xilinx_zynq_a9_qemu-cov.ini

[PATCH 01/22] tester: Update to support new build system

The tester configurations had not been updated to match the paths and conventions used by the new build system. These have been updated, and a few more libraries have been enabled in symbol-sets.ini. --- tester/rtems/testing/bsps/griscv-sis-cov.ini | 4 +-

[PATCH 00/22] tester: Update covoar for new build system

This patch set updates the covoar tool to allow it to work with the outputs of the current build system. It includes various fixes and improvements needed to successfully produce coverage reports for the following BSP configurations: griscv-sis, leon3-sis, pc-qemu, xilinx_zynqmp, and

Re: [PATCH 1/3] fdt_rw.c: Fix Unchecked return value (CID #1047324)

On 01/03/2021 20:35, Gedare Bloom wrote: On Mon, Mar 1, 2021 at 12:26 PM Ryan Long wrote: So just send this patch to them? Without the ifdef construct And with a more detailed commit message. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email:

Re: [PATCH 1/3] fdt_rw.c: Fix Unchecked return value (CID #1047324)

On Mon, Mar 1, 2021 at 12:26 PM Ryan Long wrote: > > So just send this patch to them? > Without the ifdef construct > -Original Message- > From: devel On Behalf Of Gedare Bloom > Sent: Monday, March 1, 2021 1:03 PM > To: Sebastian Huber > Cc: Ryan Long ; devel@rtems.org > Subject: Re:

RE: [PATCH 1/3] fdt_rw.c: Fix Unchecked return value (CID #1047324)

So just send this patch to them? -Original Message- From: devel On Behalf Of Gedare Bloom Sent: Monday, March 1, 2021 1:03 PM To: Sebastian Huber Cc: Ryan Long ; devel@rtems.org Subject: Re: [PATCH 1/3] fdt_rw.c: Fix Unchecked return value (CID #1047324) On Mon, Mar 1, 2021 at 11:49 AM

Re: Standalone repository for libnetworking stack

On Mon, Mar 1, 2021 at 1:05 PM Gedare Bloom wrote: > On Mon, Mar 1, 2021 at 11:28 AM Vijay Kumar Banerjee > wrote: > > > > Hi, > > > > I have shifted the testsuites and have checked that all the tests run > successfully with pc-qemu. I have also updated the README.waf as per the > review and

Re: Standalone repository for libnetworking stack

On Mon, Mar 1, 2021 at 11:28 AM Vijay Kumar Banerjee wrote: > > Hi, > > I have shifted the testsuites and have checked that all the tests run > successfully with pc-qemu. I have also updated the README.waf as per the > review and have fixed formatting according to PEP8. Please review the repos

Re: [PATCH v2 3/3] main_edit.c: Fix Unchecked return value (CID #1255318)

On Mon, Mar 1, 2021 at 11:47 AM Ryan Long wrote: > > CID 1255318: Unchecked return value in display_line(). > > Updates #4257 > --- > cpukit/libmisc/shell/main_edit.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/cpukit/libmisc/shell/main_edit.c >

Re: [PATCH 1/3] fdt_rw.c: Fix Unchecked return value (CID #1047324)

On Mon, Mar 1, 2021 at 11:49 AM Sebastian Huber wrote: > > On 01/03/2021 17:56, Gedare Bloom wrote: > > > On Mon, Mar 1, 2021 at 9:24 AM Ryan Long wrote: > >> CID 1047324: Unchecked return value in fdt_add_subnode_namelen(). > >> > >> Updates #4256 > >> --- > >> cpukit/dtc/libfdt/fdt_rw.c | 6

Re: [PATCH 1/3] fdt_rw.c: Fix Unchecked return value (CID #1047324)

On 01/03/2021 17:56, Gedare Bloom wrote: On Mon, Mar 1, 2021 at 9:24 AM Ryan Long wrote: CID 1047324: Unchecked return value in fdt_add_subnode_namelen(). Updates #4256 --- cpukit/dtc/libfdt/fdt_rw.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[PATCH v2 1/3] fdt_rw.c: Fix Unchecked return value (CID #1047324)

CID 1047324: Unchecked return value in fdt_add_subnode_namelen(). Updates #4256 --- cpukit/dtc/libfdt/fdt_rw.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/cpukit/dtc/libfdt/fdt_rw.c b/cpukit/dtc/libfdt/fdt_rw.c index 1385425..41abd8c 100644 ---

[PATCH v2 3/3] main_edit.c: Fix Unchecked return value (CID #1255318)

CID 1255318: Unchecked return value in display_line(). Updates #4257 --- cpukit/libmisc/shell/main_edit.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/cpukit/libmisc/shell/main_edit.c b/cpukit/libmisc/shell/main_edit.c index a011049..9819a94 100644 ---

[PATCH v2 2/3] grspw.c: Fix Unchecked return value (CID #1399781)

CID 1399781: Unchecked return value in grspw_device_init(). Closes #4259 --- bsps/shared/grlib/spw/grspw.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/bsps/shared/grlib/spw/grspw.c b/bsps/shared/grlib/spw/grspw.c index 1b50cc6..32740d4 100644 ---

[PATCH v2 0/3] Fix upstream Unchecked return value Coverity errors

Hi, Here are the patches with the suggested changes. Thanks, Ryan Ryan Long (3): fdt_rw.c: Fix Unchecked return value (CID #1047324) grspw.c: Fix Unchecked return value (CID #1399781) main_edit.c: Fix Unchecked return value (CID #1255318) bsps/shared/grlib/spw/grspw.c| 7 +--

Re: Standalone repository for libnetworking stack

Hi, I have shifted the testsuites and have checked that all the tests run successfully with pc-qemu. I have also updated the README.waf as per the review and have fixed formatting according to PEP8. Please review the repos and let me know if there's something else that needs to be improved to

Re: [PATCH 3/3] main_edit.c: Fix Unchecked return value (CID #1255318)

On Mon, Mar 1, 2021 at 9:24 AM Ryan Long wrote: > > CID 1255318: Unchecked return value in display_line(). > > Updates #4257 > --- > cpukit/libmisc/shell/main_edit.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/cpukit/libmisc/shell/main_edit.c >

Re: [PATCH 2/3] grspw.c: Fix Unchecked return value (CID #1399781)

Someone (Daniel) from Gaisler should review. On Mon, Mar 1, 2021 at 9:24 AM Ryan Long wrote: > > CID 1399781: Unchecked return value in grspw_device_init(). > > Closes #4259 > --- > bsps/shared/grlib/spw/grspw.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH 1/3] fdt_rw.c: Fix Unchecked return value (CID #1047324)

On Mon, Mar 1, 2021 at 9:24 AM Ryan Long wrote: > > CID 1047324: Unchecked return value in fdt_add_subnode_namelen(). > > Updates #4256 > --- > cpukit/dtc/libfdt/fdt_rw.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/cpukit/dtc/libfdt/fdt_rw.c

[PATCH 3/3] main_edit.c: Fix Unchecked return value (CID #1255318)

CID 1255318: Unchecked return value in display_line(). Updates #4257 --- cpukit/libmisc/shell/main_edit.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/cpukit/libmisc/shell/main_edit.c b/cpukit/libmisc/shell/main_edit.c index a011049..8730b21 100644 ---

[PATCH 2/3] grspw.c: Fix Unchecked return value (CID #1399781)

CID 1399781: Unchecked return value in grspw_device_init(). Closes #4259 --- bsps/shared/grlib/spw/grspw.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/bsps/shared/grlib/spw/grspw.c b/bsps/shared/grlib/spw/grspw.c index 1b50cc6..74a0fc7 100644 ---

[PATCH 1/3] fdt_rw.c: Fix Unchecked return value (CID #1047324)

CID 1047324: Unchecked return value in fdt_add_subnode_namelen(). Updates #4256 --- cpukit/dtc/libfdt/fdt_rw.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/cpukit/dtc/libfdt/fdt_rw.c b/cpukit/dtc/libfdt/fdt_rw.c index 1385425..d6f7d93 100644 ---

[PATCH 0/3] Fix Unchecked return value Coverity errors upstream

Hi, These are patches for the third party Coverity issues. I forgot to include them with the other patch last week. The only file that I used the _Assert_Unused_variable_equals() macro with was grspw.c. The others, I just used (void) to "use" them. Thanks, Ryan Ryan Long (3): fdt_rw.c: Fix

Re: [PATCH] score: Simplify _Objects_Name_to_id_u32()

Looks good. On Mon, Mar 1, 2021 at 12:25 AM Sebastian Huber wrote: > > Remove superfluous check for the objects maximum since the maximum is > also used as a loop limit. > > Fix formatting. > --- > cpukit/score/src/objectnametoid.c | 41 --- > 1 file changed, 21

Re: About HEAP error

On Sun, Feb 28, 2021 at 10:53 PM Richi Dubey wrote: > > Hi, > > I get this error on sp02: > > *** FATAL *** > fatal source: 13 (RTEMS_FATAL_SOURCE_HEAP) > CPU: 0 > fatal code: 2125180 (0x00206d7c) > RTEMS version: 6.0.0.44ae183090f3bc1a4ee281ff98525209b3fda7a7-modified > RTEMS tools: 10.2.1

[PATCH 1/4] validation: Add comments to barrier tests

Unify code sections across tests. --- testsuites/validation/tc-barrier-create.c | 86 +- testsuites/validation/tc-barrier-delete.c | 27 +++ testsuites/validation/tc-barrier-release.c | 44 +++ testsuites/validation/tc-barrier-wait.c| 53 + 4

[PATCH 3/4] validation: Add comments to message queue tests

Split up post-condition. --- .../validation/tc-message-construct-errors.c | 1364 + 1 file changed, 1056 insertions(+), 308 deletions(-) diff --git a/testsuites/validation/tc-message-construct-errors.c b/testsuites/validation/tc-message-construct-errors.c index

[PATCH 2/4] validation: Add comments to signal tests

--- testsuites/validation/tc-signal-catch.c | 106 testsuites/validation/tc-signal-send.c | 78 + 2 files changed, 184 insertions(+) diff --git a/testsuites/validation/tc-signal-catch.c b/testsuites/validation/tc-signal-catch.c index

[PATCH 4/4] validation: Add comments to task tests

--- .../validation/tc-task-construct-errors.c | 123 ++ testsuites/validation/tc-task-create-errors.c | 108 +++ 2 files changed, 231 insertions(+) diff --git a/testsuites/validation/tc-task-construct-errors.c b/testsuites/validation/tc-task-construct-errors.c

Re: [PATCH rtems-libbsd 1/2] racoon/session: Honor file descriptor maximum

Hello Chris, thanks for the review. Am 26.02.21 um 19:04 schrieb Chris Johns: On 26/2/21 2:01 am, Christian Mauderer wrote: Dynamically allocate a big enough file descriptor set for select(). A better solution would be to use kqueue() instead of select(). ---