Re: [PATCH] grtc.c: Fix four Missing break in switch Coverity errors

Hi, The patch looks good. The fall through is by design intended. Thanks, Daniel Hellstrom Software Section Head T : +46 (0) 31 775 8657 F : +46 (0) 31 421407 dan...@gaisler.com To receive update notifications, please subscribe tohttps://gaisler.com/newsletter

Re: [PATCH] aarch64: Fix context switch

Hello Kinsey, On 04/03/2021 08:17, Sebastian Huber wrote: The Per_CPU_Control::isr_dispatch_disable is a 32-bit integer. Close #4206. could you please have a look at this. I think it is a serious bug. Maybe you should also review the aarch64 assembler files in general for invalid load/store

Re: [PATCH v1 7/7] spec/aarch64: Force strict alignment for ZynqMP

On 04/03/2021 23:15, Kinsey Moore wrote: Real hardware running AArch64 does not appreciate accesses misaligned relative to the data size. This prevents generation of misaligned writes which would throw exceptions. The patch set is fine independent of the following comment. To me this problem

Re: About HEAP error

Hi, Thanks to both of you for helping me out with this! When I backtrace on _Terminate: I get this: Init -> rtems_task_create -> ... -> _Heap_Allocate -> ... ->_Heap_Protection_check_free_block -> _Heap_Protection_block_error ->_Heap_Protection_block_error_default -> _Terminate

Re: [PATCH] wscript: Add post-build processing support

On 5/3/21 6:29 am, Sebastian Huber wrote: > On 04/03/2021 20:15, Kinsey Moore wrote: > >> -Original Message- >> From: Sebastian Huber >> Sent: Thursday, March 4, 2021 12:57 >> To: Kinsey Moore ; devel@rtems.org >> Subject: Re: [PATCH] wscript: Add post-build processing support >> >>> On

Re: Announcement: Legacy libnetworking will be removed from RTEMS and will be placed in a separate repository

On 5/3/21 4:42 am, Johnson, Andrew N. wrote: > On Mar 3, 2021, at 6:45 PM, Chris Johns via Core-talk > wrote: >> >> We should encourage users to add BSP build stacks to the RSB. I remember >> Andrew >> Johnson posted on for a Coldfire. We should merge that one. > >

Re: Announcement: Legacy libnetworking will be removed from RTEMS and will be placed in a separate repository

On 5/3/21 1:26 am, Joel Sherrill wrote: > Eventually the NFSv2 client will need to be in the legacy stack  > package. But until the port of the FreeBSD NFSv4 client is available > in libbsd, the existing NFSv2 client has to be used for both stacks. The NFSv2 (and RPC?) code can be moved from

RE: [PATCH v3 2/2] bsps/aarch64: Resolve usage of SUBALIGN()

There's some additional bsp_set_align cruft that I'll pull out when I commit this since it was exclusively used for SUBALIGN(). Kinsey -Original Message- From: Kinsey Moore Sent: Wednesday, March 3, 2021 07:37 To: devel@rtems.org Cc: Kinsey Moore Subject: [PATCH v3 2/2] bsps/aarch64:

[PATCH v1 4/7] spec: Move hypervisor start for use by AArch64

AArch64 on hardware is often started at EL2 instead of EL1 from either u-boot or a first stage bootloader. This allows RTEMS to drop from EL2 execution to EL1 to operate as normal. --- spec/build/bsps/arm/raspberrypi/grp.yml | 2 +- spec/build/bsps/{arm => }/optstarthyp.yml | 0 2 files

[PATCH v1 6/7] bsps/aarch64: Add support for EL2 start

Add the stub necessary to boot on AArch64 under EL2 and drop to EL1 for normal operation. --- bsps/aarch64/shared/start/start.S | 25 + 1 file changed, 25 insertions(+) diff --git a/bsps/aarch64/shared/start/start.S b/bsps/aarch64/shared/start/start.S index

[PATCH v1 7/7] spec/aarch64: Force strict alignment for ZynqMP

Real hardware running AArch64 does not appreciate accesses misaligned relative to the data size. This prevents generation of misaligned writes which would throw exceptions. --- spec/build/bsps/aarch64/xilinx-zynqmp/abi.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v1 5/7] bsps/aarch64: RTEMS_DEBUG stack alignment faults

Run with stack alignment faults enabled under RTEMS_DEBUG to catch any stack misalignments early. This makes it easier to track them down should they ever occur. --- bsps/aarch64/shared/start/start.S| 8 cpukit/score/cpu/aarch64/aarch64-exception-default.S | 10

[PATCH v1 3/7] spec/aarch64: Remove sp37 from intermittent tests

From: Alex White --- spec/build/bsps/aarch64/a53/tsta53.yml| 1 - spec/build/bsps/aarch64/xilinx-zynqmp/tstqemu.yml | 1 - 2 files changed, 2 deletions(-) diff --git a/spec/build/bsps/aarch64/a53/tsta53.yml b/spec/build/bsps/aarch64/a53/tsta53.yml index 4ecef03641..4e5f28add1

[PATCH v1 2/7] score/aarch64: Fix interrupt level reads

From: Alex White --- cpukit/score/cpu/aarch64/cpu.c | 2 +- cpukit/score/cpu/aarch64/include/rtems/score/cpu.h | 8 ++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/cpukit/score/cpu/aarch64/cpu.c b/cpukit/score/cpu/aarch64/cpu.c index

[PATCH v1 1/7] bsps: Allow override of ARM TM27 IRQs

ZynqMP hardware appears to have an odd hard-wired SGI implementation in which the SGIs are permanently set as enabled or disabled. Allow the TM27 IRQs to be overridden as necessary. --- bsps/aarch64/xilinx-zynqmp/include/tm27.h | 8 bsps/include/dev/irq/arm-gic-tm27.h | 4 2

Re: [PATCH 00/12] Fix grlib/gr device driver Coverity errors

Hi Daniel, Can you have a look at these patches, and the follow-up one with the /* fall-through */ comments? Do you guys host your own version that you would like to keep synch'ed with the one in RTEMS, or how would you like to handle patches to grlib / gr drivers in rtems? Thanks, Gedare On

[PATCH] grtc.c: Fix four Missing break in switch Coverity errors

CID 1399761: Missing break in switch in process_dma(). CID 1399765: Missing break in switch in process_dma(). CID 1399766: Missing break in switch in process_dma(). CID 1399777: Missing break in switch in process_dma(). Closes #4277 --- bsps/shared/grlib/tmtc/grtc.c | 4 1 file changed, 4

[PATCH] Fix for grtc.c

Hi, I forgot to include this patch. Sorry about that. Thanks, Ryan Ryan Long (1): grtc.c: Fix four Missing break in switch Coverity errors bsps/shared/grlib/tmtc/grtc.c | 4 1 file changed, 4 insertions(+) -- 1.8.3.1 ___ devel mailing list

[PATCH 12/12] grcan.c: Fix Unused value (CID #1437613)

CID 1437613: Unused value in grcan_set_filter(). This fix was recommended by Daniel Hellstrom (dan...@gaisler.com). Closes #4301 --- bsps/shared/grlib/can/grcan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bsps/shared/grlib/can/grcan.c b/bsps/shared/grlib/can/grcan.c

[PATCH 11/12] b1553brm.c: Fix Unsigned compared against 0 (CID #1399773)

CID 1399773: Unsigned compared against 0 in brm_write(). Closes #4295 --- bsps/shared/grlib/1553/b1553brm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bsps/shared/grlib/1553/b1553brm.c b/bsps/shared/grlib/1553/b1553brm.c index 694f585..484ee6d 100644 ---

[PATCH 10/12] satcan.c: Fix Unsigned compared against 0 (CID #1399768)

CID 1399768: Unsigned compared against 0 in satcan_ioctl(). Closes #4294 --- bsps/shared/grlib/can/satcan.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/bsps/shared/grlib/can/satcan.c b/bsps/shared/grlib/can/satcan.c index c3fdc15..52e674c 100644 ---

[PATCH 09/12] gr_cpci_gr740.c: Unchecked return value from library (CID #1437630)

CID 1437630: Unchecked return value from library in gr_cpci_gr740_init1(). Closes #4290 --- bsps/sparc/shared/pci/gr_cpci_gr740.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/sparc/shared/pci/gr_cpci_gr740.c b/bsps/sparc/shared/pci/gr_cpci_gr740.c index

[PATCH 08/12] gr_tmtc_1553.c: Unchecked return value from library (CID #1399785)

CID 1399785: Unchecked return value from library in gr_tmtc_1553_init1(). Closes #4289 --- bsps/shared/grlib/pci/gr_tmtc_1553.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/grlib/pci/gr_tmtc_1553.c b/bsps/shared/grlib/pci/gr_tmtc_1553.c index

[PATCH 07/12] gr_701.c: Unchecked return value from library (CID #1399783)

CID 1399783: Unchecked return value from library in gr701_init1(). Closes #4288 --- bsps/shared/grlib/pci/gr_701.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/grlib/pci/gr_701.c b/bsps/shared/grlib/pci/gr_701.c index c9ac0db..25dc680 100644 ---

[PATCH 06/12] gr_rasta_tmtc.c: Fix Unchecked return value from library (CID #1399780)

CID 1399780: Unchecked return value from library in gr_rasta_adcdac_init1(). Closes #4287 --- bsps/shared/grlib/pci/gr_rasta_adcdac.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/grlib/pci/gr_rasta_adcdac.c b/bsps/shared/grlib/pci/gr_rasta_adcdac.c index

[PATCH 05/12] gr_rasta_tmtc.c: Fix Unchecked return value from library (CID #1399771)

CID 1399771: Unchecked return value from library in gr_rasta_tmtc_init1(). Closes #4286 --- bsps/shared/grlib/pci/gr_rasta_tmtc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/grlib/pci/gr_rasta_tmtc.c b/bsps/shared/grlib/pci/gr_rasta_tmtc.c index

[PATCH 04/12] gr_leon4_n2x.c: Fix Unchecked return value from library (CID #1399767)

CID 1399767: Unchecked return value error from library in gr_cpci_leon4_n2x_init1(). Closes #4285 --- bsps/sparc/shared/pci/gr_leon4_n2x.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/sparc/shared/pci/gr_leon4_n2x.c b/bsps/sparc/shared/pci/gr_leon4_n2x.c index

[PATCH 01/12] grspw.c: Fix Unchecked return value (CID #1399781)

CID 1399781: Unchecked return value in grspw_device_init(). Closes #4259 --- bsps/shared/grlib/spw/grspw.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/bsps/shared/grlib/spw/grspw.c b/bsps/shared/grlib/spw/grspw.c index 1b50cc6..32740d4 100644 ---

[PATCH 03/12] gr_rasta_io.c: Fix Unchecked return value from library (CID #1399763)

CID 1399763: Unchecked return value from library in gr_rasta_io_init1(). Closes #4284 --- bsps/shared/grlib/pci/gr_rasta_io.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/grlib/pci/gr_rasta_io.c b/bsps/shared/grlib/pci/gr_rasta_io.c index f4c9d50..f93f73c

[PATCH 02/12] gr_rasta_spw_router.c: Fix Unchecked return value from library (CID #1399760)

CID 1399760: Unchecked return value from library in gr_rasta_spw_router_init1(). Closes #4283 --- bsps/shared/grlib/pci/gr_rasta_spw_router.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/grlib/pci/gr_rasta_spw_router.c

[PATCH 00/12] Fix grlib/gr device driver Coverity errors

Hi, Here are the fixes for the Coverity errors with grlib/gr device drivers. The types of issues fixed were: - Unchecked return value - Unchecked return value from library - Unsigned compared against 0 - Unused value For the "Unsigned compared against 0" errors in satcan.c, the first if

Re: [PATCH] wscript: Add post-build processing support

On 04/03/2021 20:15, Kinsey Moore wrote: -Original Message- From: Sebastian Huber Sent: Thursday, March 4, 2021 12:57 To: Kinsey Moore ; devel@rtems.org Subject: Re: [PATCH] wscript: Add post-build processing support On 04/03/2021 17:18, Kinsey Moore wrote: This allows packaging of

RE: [PATCH] wscript: Add post-build processing support

-Original Message- From: Sebastian Huber Sent: Thursday, March 4, 2021 12:57 To: Kinsey Moore ; devel@rtems.org Subject: Re: [PATCH] wscript: Add post-build processing support >On 04/03/2021 17:18, Kinsey Moore wrote: > >> This allows packaging of the compiled binaries to occur

Re: [PATCH] wscript: Add post-build processing support

On Thu, Mar 4, 2021 at 11:57 AM Sebastian Huber wrote: > > On 04/03/2021 17:18, Kinsey Moore wrote: > > > This allows packaging of the compiled binaries to occur automatically > > and be bundled with other scripts and build items as convenient. > > This is not how a build system should work. When

Re: [PATCH v3 1/2] cpukit: Explicitly enforce alignment requirements

On 03/03/2021 14:37, Kinsey Moore wrote: According to commentary on GCC bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99143, the alignment behavior of linker sections on which RTEMS has relied was never guaranteed to be consistent across platforms and any alignment requirements for linker

Re: [6-freebsd-12 PATCH 1/2] rtemsbsd/bus: Add PCI support to the nexus bus

On 5/3/21 2:41 am, Gedare Bloom wrote: > On Thu, Mar 4, 2021 at 12:32 AM Chris Johns wrote: >> >> On 4/3/21 5:53 pm, Sebastian Huber wrote: >>> On 04/03/2021 00:18, Chris Johns wrote: On 3/3/21 7:48 pm, Sebastian Huber wrote: > On 03/03/2021 08:52, Chris Johns wrote: >> Then I hit

Re: [PATCH] wscript: Add post-build processing support

On 04/03/2021 17:18, Kinsey Moore wrote: This allows packaging of the compiled binaries to occur automatically and be bundled with other scripts and build items as convenient. This is not how a build system should work. When an item changes it is the job of the build system to automatically

RE: [PATCH] wscript: Add post-build processing support

Hi Gedare, -Original Message- From: Gedare Bloom Sent: Thursday, March 4, 2021 11:21 To: Kinsey Moore Cc: devel@rtems.org Subject: Re: [PATCH] wscript: Add post-build processing support > Hi Kinsey, > > On Thu, Mar 4, 2021 at 9:32 AM Kinsey Moore wrote: >> >> Currently, I’m using it

Re: Status for open projects for gsoc

On Thu, Mar 4, 2021 at 10:27 AM Dev Agrawal wrote: > > It's quite interesting, how can I proceed with lwip integration? > What will be a good start? > Begin to work with Vijay to scope out some tasks and a plan, and start to write the proposal toward that plan. For this work, we will expect

Re: Status for open projects for gsoc

It's quite interesting, how can I proceed with lwip integration? What will be a good start? On Wed, Mar 3, 2021 at 3:30 AM Joel Sherrill wrote: > > > On Tue, Mar 2, 2021 at 2:59 PM Vijay Kumar Banerjee > wrote: > >> On Tue, Mar 2, 2021 at 1:46 PM Joel Sherrill wrote: >> > >> > >> > >> > On

Re: [PATCH] wscript: Add post-build processing support

Hi Kinsey, On Thu, Mar 4, 2021 at 9:32 AM Kinsey Moore wrote: > > Currently, I’m using it to perform automated u-boot packaging of all the test > executables in my development branch and CI versus having to manually > generate these images or managing external scripts to do the automated >

[PATCH] user: Update ZynqMP QEMU BSP name

The ZynqMP QEMU BSPs have had _qemu added to their names to better identify them as QEMU BSPs similar to other BSPs which are meant to run exclusively on QEMU and not hardware. --- user/bsps/aarch64/xilinx-zynqmp.rst | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git

[PATCH] tester: Update for ZynqMP QEMU BSP name change

The ZynqMP QEMU BSPs were renamed to include _qemu for more consistent identification. This updates the tester configurations to match. --- ...{xilinx_zynqmp_lp64.ini => xilinx_zynqmp_ilp32_qemu.ini} | 6 +++--- ...{xilinx_zynqmp_ilp32.ini => xilinx_zynqmp_lp64_qemu.ini} | 6 +++--- 2 files

[PATCH] spec/aarch64: Rename ZynqMP QEMU BSPs

The current ZynqMP BSPs don't have _qemu in their name as do all other RTEMS BSPs that are specifically made to run on QEMU. This fixes the naming for those ZynqMP BSP variants for easier identification. --- spec/build/bsps/aarch64/xilinx-zynqmp/abi.yml | 2 +-

RE: [PATCH] wscript: Add post-build processing support

Currently, I’m using it to perform automated u-boot packaging of all the test executables in my development branch and CI versus having to manually generate these images or managing external scripts to do the automated packaging. I'm on the fence as to whether I submit that portion for merging

Re: [PATCH 00/12] Fix Unchecked return value from library errors

Resubmit the non-Gaisler patches with the fixes for review/approval. On Thu, Mar 4, 2021 at 9:26 AM Gedare Bloom wrote: > > separate all the grlib/gr device driver fixes, and submit them as a > separate patch set for review/approval by Daniel. We may need to > collect a set of these and poke

Re: [PATCH 12/12] main_help.c: Unchecked return value from library (CID #1437650)

On Thu, Mar 4, 2021 at 7:06 AM Ryan Long wrote: > > CID 1437650: Unchecked return value from library in rtems_shell_help(). > > Closes #4291 > --- > cpukit/libmisc/shell/main_help.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/cpukit/libmisc/shell/main_help.c >

Re: [PATCH 01/12] gen_uuid.c: Fix two Unchecked return value from library errors

On Thu, Mar 4, 2021 at 7:05 AM Ryan Long wrote: > > CID 1049146: Unchecked return value from library in get_clock(). > CID 1049147: Unchecked return value from library in get_random_fd(). > > Closes #4280 > --- > cpukit/libmisc/uuid/gen_uuid.c | 12 ++-- > 1 file changed, 10

Re: [PATCH 00/12] Fix Unchecked return value from library errors

separate all the grlib/gr device driver fixes, and submit them as a separate patch set for review/approval by Daniel. We may need to collect a set of these and poke him, but we want to make sure we keep some consistency with them, in case they have any patches outside our tree waiting to merge.

Re: [PATCH] wscript: Add post-build processing support

Can you explain this a bit more? What is the need this solves, and how will it be used? On Thu, Mar 4, 2021 at 9:18 AM Kinsey Moore wrote: > > This allows packaging of the compiled binaries to occur automatically > and be bundled with other scripts and build items as convenient. > --- > wscript

[PATCH] wscript: Add post-build processing support

This allows packaging of the compiled binaries to occur automatically and be bundled with other scripts and build items as convenient. --- wscript | 22 ++ 1 file changed, 22 insertions(+) diff --git a/wscript b/wscript index 6626fafb74..e263681716 100755 --- a/wscript +++

Re: Announcement: Legacy libnetworking will be removed from RTEMS and will be placed in a separate repository

On Thu, Mar 4, 2021 at 8:33 AM Vijay Kumar Banerjee wrote: > > On Thu, Mar 4, 2021 at 7:26 AM Joel Sherrill wrote: > > > > > > > > On Thu, Mar 4, 2021 at 8:22 AM Heinz Junkes > > wrote: > >> > >> I have installed the legacy package but the files are not there. > >> I guess they were just

Re: [PATCH v2] score: Ensure stack alignment requirement

It looks fine to me. I agree with the general perspective that a user can't explicitly control down to the last byte their stack usage, so my complaints are not real problems. On Thu, Mar 4, 2021 at 2:17 AM Sebastian Huber wrote: > > Make sure that a user-provided stack size is the minimum size

Re: [6-freebsd-12 PATCH 1/2] rtemsbsd/bus: Add PCI support to the nexus bus

On Thu, Mar 4, 2021 at 12:32 AM Chris Johns wrote: > > On 4/3/21 5:53 pm, Sebastian Huber wrote: > > On 04/03/2021 00:18, Chris Johns wrote: > >> On 3/3/21 7:48 pm, Sebastian Huber wrote: > >>> On 03/03/2021 08:52, Chris Johns wrote: > Then I hit minimum and some validation tests and they

Re: Announcement: Legacy libnetworking will be removed from RTEMS and will be placed in a separate repository

On Thu, Mar 4, 2021 at 7:26 AM Joel Sherrill wrote: > > > > On Thu, Mar 4, 2021 at 8:22 AM Heinz Junkes wrote: >> >> I have installed the legacy package but the files are not there. >> I guess they were just forgotten in the legacy package. > > > I'd guess Vijay forgot to install them. Certainly

RE: [PATCH v2] score: Ensure stack alignment requirement

-Original Message- From: Sebastian Huber Sent: Thursday, March 4, 2021 09:23 To: Kinsey Moore ; devel@rtems.org Subject: Re: [PATCH v2] score: Ensure stack alignment requirement > On 04/03/2021 16:20, Kinsey Moore wrote: >>> + alignment_overhead = CPU_STACK_ALIGNMENT - 1; >> This

Re: [PATCH v2] score: Ensure stack alignment requirement

On 04/03/2021 16:20, Kinsey Moore wrote: + /* + * In order to make sure that a user-provided stack size is the minimum which + * can be allocated for the stack, we have to align it up to the next stack + * boundary. + */ + alignment_overhead = CPU_STACK_ALIGNMENT - 1; This should be

RE: [PATCH v2] score: Ensure stack alignment requirement

Looks good other than a minor tweak. Kinsey -Original Message- From: devel On Behalf Of Sebastian Huber Sent: Thursday, March 4, 2021 03:17 To: devel@rtems.org Subject: [PATCH v2] score: Ensure stack alignment requirement > Make sure that a user-provided stack size is the minimum size

Re: Announcement: Legacy libnetworking will be removed from RTEMS and will be placed in a separate repository

On Thu, Mar 4, 2021 at 8:22 AM Heinz Junkes wrote: > I have installed the legacy package but the files are not there. > I guess they were just forgotten in the legacy package. > I'd guess Vijay forgot to install them. Certainly easy enough to do. Eventually the NFSv2 client will need to be in

Re: Announcement: Legacy libnetworking will be removed from RTEMS and will be placed in a separate repository

I have installed the legacy package but the files are not there. I guess they were just forgotten in the legacy package. Heinz > On 4. Mar 2021, at 14:52, Joel Sherrill wrote: > > Did you install the legacy package? If you installed it in the same place > as the RTEMS 5 BSP, I would expect it

[PATCH 11/12] gr_cpci_gr740.c: Unchecked return value from library (CID #1437630)

CID 1437630: Unchecked return value from library in gr_cpci_gr740_init1(). Closes #4290 --- bsps/sparc/shared/pci/gr_cpci_gr740.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/sparc/shared/pci/gr_cpci_gr740.c b/bsps/sparc/shared/pci/gr_cpci_gr740.c index

[PATCH 12/12] main_help.c: Unchecked return value from library (CID #1437650)

CID 1437650: Unchecked return value from library in rtems_shell_help(). Closes #4291 --- cpukit/libmisc/shell/main_help.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cpukit/libmisc/shell/main_help.c b/cpukit/libmisc/shell/main_help.c index 611f2e0..c76139e 100644 ---

[PATCH 10/12] gr_tmtc_1553.c: Unchecked return value from library (CID #1399785)

CID 1399785: Unchecked return value from library in gr_tmtc_1553_init1(). Closes #4289 --- bsps/shared/grlib/pci/gr_tmtc_1553.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/grlib/pci/gr_tmtc_1553.c b/bsps/shared/grlib/pci/gr_tmtc_1553.c index

[PATCH 09/12] gr_701.c: Unchecked return value from library (CID #1399783)

CID 1399783: Unchecked return value from library in gr701_init1(). Closes #4288 --- bsps/shared/grlib/pci/gr_701.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/grlib/pci/gr_701.c b/bsps/shared/grlib/pci/gr_701.c index c9ac0db..25dc680 100644 ---

[PATCH 08/12] gr_rasta_tmtc.c: Fix Unchecked return value from library (CID #1399780)

CID 1399780: Unchecked return value from library in gr_rasta_adcdac_init1(). Closes #4287 --- bsps/shared/grlib/pci/gr_rasta_adcdac.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/grlib/pci/gr_rasta_adcdac.c b/bsps/shared/grlib/pci/gr_rasta_adcdac.c index

[PATCH 07/12] gr_rasta_tmtc.c: Fix Unchecked return value from library (CID #1399771)

CID 1399771: Unchecked return value from library in gr_rasta_tmtc_init1(). Closes #4286 --- bsps/shared/grlib/pci/gr_rasta_tmtc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/grlib/pci/gr_rasta_tmtc.c b/bsps/shared/grlib/pci/gr_rasta_tmtc.c index

[PATCH 06/12] gr_leon4_n2x.c: Fix Unchecked return value from library (CID #1399767)

CID 1399767: Unchecked return value error from library in gr_cpci_leon4_n2x_init1(). Closes #4285 --- bsps/sparc/shared/pci/gr_leon4_n2x.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/sparc/shared/pci/gr_leon4_n2x.c b/bsps/sparc/shared/pci/gr_leon4_n2x.c index

[PATCH 05/12] gr_rasta_io.c: Fix Unchecked return value from library (CID #1399763)

CID 1399763: Unchecked return value from library in gr_rasta_io_init1(). Closes #4284 --- bsps/shared/grlib/pci/gr_rasta_io.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/grlib/pci/gr_rasta_io.c b/bsps/shared/grlib/pci/gr_rasta_io.c index f4c9d50..f93f73c

[PATCH 04/12] gr_rasta_spw_router.c: Fix Unchecked return value from library (CID #1399760)

CID 1399760: Unchecked return value from library in gr_rasta_spw_router_init1(). Closes #4283 --- bsps/shared/grlib/pci/gr_rasta_spw_router.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/grlib/pci/gr_rasta_spw_router.c

[PATCH 03/12] pwdgrp.c: Fix Unchecked return value from library (CID #1255518)

CID 1255518: Unchecked return value from library in pwdgrp_init(). Closes #4282 --- cpukit/libcsupport/src/pwdgrp.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/cpukit/libcsupport/src/pwdgrp.c b/cpukit/libcsupport/src/pwdgrp.c index a97d397..f4a10f7 100644 ---

[PATCH 02/12] main_chmod.c: Fix Unchecked return value from library (CID #1063856)

CID 1063856: Unchecked return value from library in rtems_shell_main_chmod(). Closes #4281 --- cpukit/libmisc/shell/main_chmod.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cpukit/libmisc/shell/main_chmod.c b/cpukit/libmisc/shell/main_chmod.c index 0c39072..df18ef1

[PATCH 01/12] gen_uuid.c: Fix two Unchecked return value from library errors

CID 1049146: Unchecked return value from library in get_clock(). CID 1049147: Unchecked return value from library in get_random_fd(). Closes #4280 --- cpukit/libmisc/uuid/gen_uuid.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/cpukit/libmisc/uuid/gen_uuid.c

[PATCH 00/12] Fix Unchecked return value from library errors

Hi, Here are the fixes for the "Unchecked return value from library" Coverity errors. For most of these, I added a status code variable, returned the value, and used the _Assert_Unused_variable_equal/unequal macros. For main_help.c, a (void) was just added because we don't care about the value

Re: [PATCH v2] tests/validation: Fix 64bit test failure

On 04/03/2021 14:50, Joel Sherrill wrote: I will fix the error condition in the specification and adjust the implementation accordingly without changing the API. Can the calculation of allocated size be done in terms of uint64_t and then we can easily check if the allocation is to

Re: Announcement: Legacy libnetworking will be removed from RTEMS and will be placed in a separate repository

On Thu, Mar 4, 2021 at 6:39 AM junkes wrote: > Hallo Vijay, > > the next question ;-) I am trying to build EPICS. > > with the external legacy stack there are some files missing: > > rtems/rtems_bsdnet.h > librtemsNfs.h > rtems/telnetd.h > > with RTEMS5 (with networking) one can find e.g.

Re: [PATCH v2] tests/validation: Fix 64bit test failure

On Wed, Mar 3, 2021 at 3:10 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 24/02/2021 18:30, Gedare Bloom wrote: > > > On Wed, Feb 24, 2021 at 9:58 AM Sebastian Huber > > wrote: > >> On 24/02/2021 17:54, Gedare Bloom wrote: > >> > >>> On Wed, Feb 24, 2021 at 2:52 AM

Re: Announcement: Legacy libnetworking will be removed from RTEMS and will be placed in a separate repository

Hallo Vijay, the next question ;-) I am trying to build EPICS. with the external legacy stack there are some files missing: rtems/rtems_bsdnet.h librtemsNfs.h rtems/telnetd.h with RTEMS5 (with networking) one can find e.g. rtems_bsdnet.h here:

[PATCH v2] score: Ensure stack alignment requirement

Make sure that a user-provided stack size is the minimum size allocated for the stack. Make sure we meet the stack alignment requirement also for CPU ports with CPU_STACK_ALIGNMENT > CPU_HEAP_ALIGNMENT. --- cpukit/include/rtems/score/context.h | 3 +-- cpukit/include/rtems/score/stackimpl.h |

RE: [PATCH v2 1/1] bsps/shared: Allow setting baud rate for zynq uart

Could someone please have a look a this patch and approve it? Should I then still add a new section to the docs regarding the console behavior for the zynq? With this patch applied it would be that the baud rate of the fsbl is overwritten by default to 115200, but can be changed using the

Re: [PATCH v2] tests/validation: Fix 64bit test failure

Hello, this turned out to be a simple shortcoming of the validation test. This error case can happen also on 64-bit targets. There was no specification, API, and implementation change necessary, just a fix in the test code:

RE: [PATCH] MAINTAINERS: Add myself to write after approval

Thanks. Pushed successfully. Best regards, Jan > -Original Message- > From: Chris Johns > Sent: Thursday, March 4, 2021 8:35 AM > To: Sommer, Jan ; devel@rtems.org > Subject: Re: [PATCH] MAINTAINERS: Add myself to write after approval > > Approved. > > Welcome and congratulations

Re: [PATCH 4/4] score: Ensure stack alignment requirement

On 03/03/2021 23:08, Gedare Bloom wrote: I think it is just invalid to shrink the stack size smaller than it is requested. If I call pthread_attr_setstacksize(), then "The stacksize attribute shall define the minimum stack size (in bytes) allocated for the created threads stack." I should not