[PATCH] rtems-examples: Add CoreMark Benchmark

2021-03-12 Thread Hesham Almatary
CoreMark's primary goals are simplicity and providing a method for testing only a processor's core features. It is used primarily here as a performance benchmark. Built and tested for RISC-V rv64imafdc_medany on QEMU and HW --- .gitmodules | 3 +++ benchmarks/coremark/coremark

[PATCH] GSoC initial Work Proof

2021-03-12 Thread Daman Bir Singh
--- testsuites/samples/hello/hello.scn | 3 ++- testsuites/samples/hello/init.c| 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/testsuites/samples/hello/hello.scn b/testsuites/samples/hello/hello.scn index d9e92d81d5..e9fc49520f 100644 ---

Re: GSoC Introduction, completed getting started guide.

2021-03-12 Thread Eshan Dhawan
Hi daman, You have to send the patch using git send-email. To any of the maintainers. - Eshan > On 13-Mar-2021, at 11:20 AM, Daman Bir Singh > wrote: > >  > Hello everyone, > > I am Daman from Bits Pilani, K K Birla Campus Goa, India. I am very > interested in working with your

GSoC Introduction, completed getting started guide.

2021-03-12 Thread Daman Bir Singh
Hello everyone, I am Daman from Bits Pilani, K K Birla Campus Goa, India. I am very interested in working with your organization for GSoC 2021. I have followed the GSoC Getting Started Guide and was successfully able to build and

Re: [PATCH 1/1] Hello World - Ida's proof to work on rtems

2021-03-12 Thread Ida Delphine
Here's a screenshot as requested on the guide. Thanks, Ida. On Sat, Mar 13, 2021 at 5:13 AM Ida Delphine wrote: > From: Meh Mbeh Ida Delphine > > Modified rtems/testsuites/samples/hello/init.c to prove I can work on the > RTEMS project for GSoC. > --- > testsuites/samples/hello/init.c | 2 +-

[PATCH 1/1] Hello World - Ida's proof to work on rtems

2021-03-12 Thread Ida Delphine
From: Meh Mbeh Ida Delphine Modified rtems/testsuites/samples/hello/init.c to prove I can work on the RTEMS project for GSoC. --- testsuites/samples/hello/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testsuites/samples/hello/init.c

[PATCH 0/1] My First Contribution

2021-03-12 Thread Ida Delphine
I modified init.c and tested it successfully as proof I can work on the RTEMS Project for GSoC. Meh Mbeh Ida Delphine (1): Hello World - Ida's proof to work on rtems testsuites/samples/hello/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1

Re: [PATCH] covoar: Fix DWARF reading

2021-03-12 Thread Chris Johns
These are design question and not review issues On 12/3/21 5:33 am, Alex White wrote: > + // Create data based on target. > + TargetInfo = Target::TargetFactory( buildTarget ); Any pointers in this object given there is a copy operator at work here? > + // Create the set of desired

[PATCH] coverage/symbol-sets.ini : Add libtrace

2021-03-12 Thread Alex White
--- tester/rtems/testing/coverage/symbol-sets.ini | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tester/rtems/testing/coverage/symbol-sets.ini b/tester/rtems/testing/coverage/symbol-sets.ini index 9617dd8..52e25ff 100644 --- a/tester/rtems/testing/coverage/symbol-sets.ini

[PATCH 2/3] covoar: Improve findCoverageMap error message

2021-03-12 Thread Alex White
--- tester/covoar/ExecutableInfo.cc | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tester/covoar/ExecutableInfo.cc b/tester/covoar/ExecutableInfo.cc index 5a730fd..30828a6 100644 --- a/tester/covoar/ExecutableInfo.cc +++ b/tester/covoar/ExecutableInfo.cc @@ -177,7

[PATCH 3/3] covoar: Fix overflow of high PC address

2021-03-12 Thread Alex White
This fixes an integer overflow that would occur if a function's high PC address were zero in the DWARF info. --- tester/covoar/ExecutableInfo.cc | 5 + 1 file changed, 5 insertions(+) diff --git a/tester/covoar/ExecutableInfo.cc b/tester/covoar/ExecutableInfo.cc index 30828a6..7f33f20 100644

[PATCH 0/3] covoar: Improve error handling

2021-03-12 Thread Alex White
This patch set contains a few improvements to error handling in covoar that result in more meaningful error messages. Alex White (3): covoar: Catch exceptional case covoar: Improve findCoverageMap error message covoar: Fix overflow of high PC address tester/covoar/ExecutableInfo.cc | 23

[PATCH] covoar: Add option to create named objdumps

2021-03-12 Thread Alex White
This adds a new behavior to the -d option which allows the creation of named objdump outputs in the /tmp directory. This allows the outputs to be reused on subsequent runs of covoar rather than running objdump again. --- tester/covoar/ObjdumpProcessor.cc | 22 +-

[PATCH] covoar: Fix null pointer dereference

2021-03-12 Thread Alex White
A null pointer dereference happens later in the program execution if the files are cleaned up at the end of the ExecutableInfo constructor. This change fixes the null pointer dereference. --- tester/covoar/ExecutableInfo.cc | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff

[PATCH 3/4] coverage/reports: Share common JS and CSS in reports

2021-03-12 Thread Alex White
This moves all of the javascript and CSS files that are shared by the symbol set HTML reports to the shared parent directory. It also includes the javascript and CSS in the top-level index file. --- tester/covoar/ReportsHtml.cc | 4 ++-- tester/rt/coverage.py| 11 ++- 2 files

[PATCH 4/4] coverage: Give coverage bars red background

2021-03-12 Thread Alex White
--- tester/rt/coverage.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tester/rt/coverage.py b/tester/rt/coverage.py index ec3957c..a561d26 100644 --- a/tester/rt/coverage.py +++ b/tester/rt/coverage.py @@ -129,6 +129,9 @@ class report_gen_html: head_section += 'width:

[PATCH 0/4] coverage/reports: Improve coverage reports

2021-03-12 Thread Alex White
This patch set includes a few improvements to the coverage reports. Alex White (4): covoar/reports: Add new statistics to summary coverage/reports: Improve formatting and clarity coverage/reports: Share common JS and CSS in reports coverage: Give coverage bars red background

[PATCH] covoar: Handle periods in symbols from objdump

2021-03-12 Thread Alex White
Occasionally the compiler will generate symbols that look similar to symbols defined in RTEMS code except that they contain some suffix. This looks to be related to compiler optimizations. Such symbols were being treated as unique. For our purposes, they should be mapped to the equivalent symbols

[PATCH] covoar: Account for build path change

2021-03-12 Thread Alex White
Covoar had not been updated to account for the paths used by the new build system. This has been fixed. --- tester/covoar/covoar.cc | 5 - 1 file changed, 5 deletions(-) diff --git a/tester/covoar/covoar.cc b/tester/covoar/covoar.cc index 84d883a..bf95cb4 100644 --- a/tester/covoar/covoar.cc

[PATCH v1 1/3] cpukit/aarch64: Add ESR register decoding

2021-03-12 Thread Kinsey Moore
From: Alex White --- .../aarch64/aarch64-exception-frame-print.c | 83 ++- 1 file changed, 79 insertions(+), 4 deletions(-) diff --git a/cpukit/score/cpu/aarch64/aarch64-exception-frame-print.c b/cpukit/score/cpu/aarch64/aarch64-exception-frame-print.c index

[PATCH v1 2/3] score/aarch64: Align context validation frame

2021-03-12 Thread Kinsey Moore
Ensure the stack remains aligned when validating the context frame to avoid stack alignment exceptions. --- .../cpu/aarch64/aarch64-context-validate.S | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/cpukit/score/cpu/aarch64/aarch64-context-validate.S

[PATCH v1 3/3] bsps/xilinx-zynqmp: Avoid constant UART reinit

2021-03-12 Thread Kinsey Moore
Constantly reinitializing the Cadence UART on every character output causes data corruption/loss. Only initialize the UART once for early output. --- bsps/aarch64/xilinx-zynqmp/console/console.c | 1 + 1 file changed, 1 insertion(+) diff --git a/bsps/aarch64/xilinx-zynqmp/console/console.c

[PATCH v3 0/2] Fix NOP recognition

2021-03-12 Thread Alex White
v3: - Fix double increment of rangeIndex in Coverage::finalizeSymbol() v2: - Fix leftover debugging code in Coverage::finalizeSymbol() This patch set fixes a couple cases where NOP instructions were showing up as unexecuted in coverage reports. Alex White (2): covoar: Fix NOP execution

[PATCH v3 1/2] covoar: Fix NOP execution marking

2021-03-12 Thread Alex White
Some NOP instructions were not being marked as executed because they are located at the end of uncovered ranges. This has been fixed. --- tester/covoar/CoverageMapBase.cc | 10 +++ tester/covoar/CoverageMapBase.h | 4 ++ tester/covoar/DesiredSymbols.cc | 38 --

[PATCH v3 2/2] covoar/Target_i386: Add NOP patterns

2021-03-12 Thread Alex White
A couple of NOP patterns found with the pc686 BSP were not detected. This has been fixed. --- tester/covoar/Target_i386.cc | 9 + 1 file changed, 9 insertions(+) diff --git a/tester/covoar/Target_i386.cc b/tester/covoar/Target_i386.cc index e0c9c0f..4567c1e 100644 ---

[PATCH 5/5] rtl-shell.c: Resource leak (CID #1444140)

2021-03-12 Thread Ryan Long
CID 1444140: Resource leak in rtems_rtl_shell_object(). Closes #4300 --- cpukit/libdl/rtl-shell.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cpukit/libdl/rtl-shell.c b/cpukit/libdl/rtl-shell.c index 9f8a136..bcecdd4 100644 --- a/cpukit/libdl/rtl-shell.c +++ b/cpukit/libdl/rtl-shell.c

[PATCH 4/5] flashdisk.c: Fix Resource leak (CID #1439298)

2021-03-12 Thread Ryan Long
CID 1439298: Resource leak in rtems_fdisk_initialize(). Closes #4299 --- cpukit/libblock/src/flashdisk.c | 42 ++--- 1 file changed, 31 insertions(+), 11 deletions(-) diff --git a/cpukit/libblock/src/flashdisk.c b/cpukit/libblock/src/flashdisk.c index

[PATCH 1/5] hexdump-parse.c: Fix Resource leak (CID #26032)

2021-03-12 Thread Ryan Long
CID 26032: Resource leak in rtems_shell_hexdump_rewrite(). Closes #4296 --- cpukit/libmisc/shell/hexdump-parse.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cpukit/libmisc/shell/hexdump-parse.c b/cpukit/libmisc/shell/hexdump-parse.c index 88b9d56..5b56bbf 100644 ---

[PATCH 3/5] nvdisk.c: Fix Resource leak (CID #1439297)

2021-03-12 Thread Ryan Long
CID 1439297: Resource leak in rtems_nvdisk_initialize(). Closes #4298 --- cpukit/libblock/src/nvdisk.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/cpukit/libblock/src/nvdisk.c b/cpukit/libblock/src/nvdisk.c index a7f4167..d742baf 100644 ---

[PATCH 0/5] Fix Resource leak Coverity issues

2021-03-12 Thread Ryan Long
Hi, For these issues I just needed to free dynamically allocated variables. Most of these additions were in areas that were error-checking and returning early. For flashdisk.c, this was the case as well, but it had nested, dynamically allocated list of values that had to be freed using a for

[PATCH 2/5] rtems-fdt.c: Fix Resource leak (CID #1437645)

2021-03-12 Thread Ryan Long
CID 1437645: Resource leak in rtems_fdt_load(). Closes #4297 --- cpukit/libmisc/rtems-fdt/rtems-fdt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/cpukit/libmisc/rtems-fdt/rtems-fdt.c b/cpukit/libmisc/rtems-fdt/rtems-fdt.c index 0ea3653..5bb7ce0 100644 ---

[PATCH 2/2] main_rtrace.c: Fix Dereference after null check (CID #1399709)

2021-03-12 Thread Ryan Long
CID 1399709: Dereference after null check in rtems_trace_buffering_shell_save(). Closes #4329 --- cpukit/libmisc/shell/main_rtrace.c | 1 + 1 file changed, 1 insertion(+) diff --git a/cpukit/libmisc/shell/main_rtrace.c b/cpukit/libmisc/shell/main_rtrace.c index 753ab9d..e4f59c4 100644 ---

[PATCH 1/2] objectextendinformation.c: Fix Dereference after null check (CID #26033)

2021-03-12 Thread Ryan Long
CID 26033: Dereference after null check in _Objects_Extend_information(). Closes #4326 --- cpukit/score/src/objectextendinformation.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/cpukit/score/src/objectextendinformation.c b/cpukit/score/src/objectextendinformation.c index

[PATCH 0/2] Fix Dereference after null check Coverity issues

2021-03-12 Thread Ryan Long
Hi, For these issues, I needed to make sure that a value that could be NULL would not be dereferenced. For objectextendinformation.c, an assert was added, and in main_rtrace.c a return was added to the check. Thanks, Ryan Ryan Long (2): objectextendinformation.c: Fix Dereference after null

Re: Fwd: New Defects reported by Coverity Scan for RTEMS

2021-03-12 Thread Joel Sherrill
Luckily I think it is an easy one. Checking if an unsigned value is less than 0. Look back in the history. Ryan may have fixed it once and you just accidentally reverted it. He fixed a handful like this. I'm sorry you were the first to be caught by it but I am thrilled to have Coverity run

Re: Fwd: New Defects reported by Coverity Scan for RTEMS

2021-03-12 Thread Daniel Hellstrom
yes, it must have, so I will look into that. /Daniel On 2021-03-12 14:07, Joel Sherrill wrote: Without looking, I would assume this was introduced by Daniel's recent patches. -- Forwarded message - From: mailto:scan-ad...@coverity.com>> Date: Fri, Mar 12, 2021, 12:55

Fwd: New Defects reported by Coverity Scan for RTEMS

2021-03-12 Thread Joel Sherrill
Without looking, I would assume this was introduced by Daniel's recent patches. -- Forwarded message - From: Date: Fri, Mar 12, 2021, 12:55 AM Subject: New Defects reported by Coverity Scan for RTEMS To: Hi, Please find the latest report on new defect(s) introduced to RTEMS

qoriq_e500 U-Boot Support in RTEMS

2021-03-12 Thread junkes
to use qoriq_e500 with legacy stack, I tried to define HAS_UBOOT to get tcsec-interfaces to work with RTEMS-5. There is no u-boot-config.h in the qoriq_e500 bsp files. This file is required by bsp/u-boot.h Danke, Heinz ___ devel mailing list