Re: #3860 - GSoC enquiries

On 06/04/2021 18:12, Gedare Bloom wrote: On Mon, Apr 5, 2021 at 10:37 PM Sebastian Huber wrote: On 04/04/2021 22:18, Joel Sherrill wrote: On Sun, Apr 4, 2021 at 2:25 PM Ida Delphine mailto:idad...@gmail.com>> wrote: Hello, Please who are the possible mentors for this project?

Re: [PATCH 1/2] Added FAQ page

On 6/4/21 2:26 am, Gedare Bloom wrote: > On Sat, Apr 3, 2021 at 5:15 PM Chris Johns wrote: >> >> On 3/4/21 6:29 am, Gedare Bloom wrote: >>> On Fri, Apr 2, 2021 at 12:55 PM Joel Sherrill wrote: On Fri, Apr 2, 2021 at 1:50 PM Ayushman Mishra wrote: > > Sir, It was given as an is

Re: [PATCH rtems-net-legacy] nfsclient: Build nfsclient from the top level netlegacy script

On Tue, Apr 6, 2021 at 4:26 PM Chris Johns wrote: > > On 7/4/21 7:40 am, Gedare Bloom wrote: > > On Tue, Apr 6, 2021 at 2:24 PM Chris Johns wrote: > >> > >> > >> > >>> On 4 Apr 2021, at 11:06 am, Vijay Kumar Banerjee wrote: > >>> > >>> --- > >>> netlegacy.py | 18 +- > >>> n

Re: [PATCH 1/4] main_cp.c: Unused value (CID #1255344)

On 7/4/21 6:36 am, Ryan Long wrote: > Oh, I definitely missed that. I'm not sure though, but other patches have > used #ifdef. So I should only resubmit this patch then? No. Please submit the whole patch set with a new patch set version number. And this is what needs to happen from now on. Spli

Re: [PATCH rtems-net-legacy] nfsclient: Build nfsclient from the top level netlegacy script

On 7/4/21 7:40 am, Gedare Bloom wrote: > On Tue, Apr 6, 2021 at 2:24 PM Chris Johns wrote: >> >> >> >>> On 4 Apr 2021, at 11:06 am, Vijay Kumar Banerjee wrote: >>> >>> --- >>> netlegacy.py | 18 +- >>> nfsclient/wscript | 1 + >>> wscript | 2 +- >>> 3 files changed

Re: [PATCH 0/2] covoar: Trailing white space and Tab Removal fixes

On Tue, Apr 6, 2021, 4:43 PM Gedare Bloom wrote: > Hi Joel, > > I think this is fine for you to push, since it will only cause > headaches for you and Alex if there are whitespace-induced merge > conflicts ;) > If only one of the cats were in my lap so I could stroke it while making an evil laug

[PATCH v4 2/3] fastlz.c: Unused value (CID #1399751)

CID 1399751: Unused value in fastlz2_compress(). Closes #4341 --- cpukit/libdl/fastlz.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/cpukit/libdl/fastlz.c b/cpukit/libdl/fastlz.c index 3c9d6f6..7257c98 100644 --- a/cpukit/libdl/fastlz.c +++ b/cpukit/libdl/fastlz.c

[PATCH v4 3/3] disp_hcms29xx.c: Unused value (CID #1399752)

CID 1399752: Unused value in disp_hcms29xx_update_task(). Closes #4342 --- bsps/shared/dev/display/disp_hcms29xx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/dev/display/disp_hcms29xx.c b/bsps/shared/dev/display/disp_hcms29xx.c index 740aa56..5ad7063 10064

[PATCH v4 1/3] print-ls.c: Unused value (CID #1255346)

CID 1255346: Unused value in rtems_shell_ls_printacol(). Closes #4340 --- cpukit/libmisc/shell/print-ls.c | 9 + 1 file changed, 9 insertions(+) diff --git a/cpukit/libmisc/shell/print-ls.c b/cpukit/libmisc/shell/print-ls.c index 15702b4..95a2cdf 100644 --- a/cpukit/libmisc/shell/print-l

Re: [PATCH 0/2] covoar: Trailing white space and Tab Removal fixes

Hi Joel, I think this is fine for you to push, since it will only cause headaches for you and Alex if there are whitespace-induced merge conflicts ;) Gedare On Tue, Apr 6, 2021 at 2:43 PM Joel Sherrill wrote: > > Hi > > In committing a patch from Alex, I noticed that git complained about white

Re: [PATCH rtems-net-legacy] nfsclient: Build nfsclient from the top level netlegacy script

On Tue, Apr 6, 2021 at 2:24 PM Chris Johns wrote: > > > > > On 4 Apr 2021, at 11:06 am, Vijay Kumar Banerjee wrote: > > > > --- > > netlegacy.py | 18 +- > > nfsclient/wscript | 1 + > > wscript | 2 +- > > 3 files changed, 19 insertions(+), 2 deletions(-) > > > > d

Re: #3860 - GSoC enquiries

On Tue, Apr 6, 2021 at 2:20 PM Ida Delphine wrote: > > Does this mean I won't have to work with uncrustify anymore? > It seems like there is encouragement to consider working with clang. I think it is a good idea to work with clang anyway. There are other possible projects that you might be able t

Re: [PATCH 0/4] Unused value Coverity issues

On Tue, Apr 6, 2021 at 2:04 PM Chris Johns wrote: > > > > On 7 Apr 2021, at 2:07 am, Gedare Bloom wrote: > > > > 1/3/4 are fine, fix 2 and resend the set, or resent 1/3/4 as a set now > > to ACK and send 2 separately later. > > Can we please only post full revised patch sets? I would like to co

Re: [PATCH v4] main_cp.c: Unused value (CID #1255344)

This Patch is fine to go in. please resent the other three as a set so I can ACK them, thanks On Tue, Apr 6, 2021 at 3:35 PM Gedare Bloom wrote: > > this looks right now. however, the full set of patches has not been > sent, so I can't ACK the entire set at once. > > On Tue, Apr 6, 2021 at 3:19 P

Re: [PATCH v4] main_cp.c: Unused value (CID #1255344)

this looks right now. however, the full set of patches has not been sent, so I can't ACK the entire set at once. On Tue, Apr 6, 2021 at 3:19 PM Ryan Long wrote: > > CID 1255344: Unused value in copy(). > > Closes #4339 > --- > cpukit/libmisc/shell/main_cp.c | 32

[PATCH v4] main_cp.c: Unused value (CID #1255344)

CID 1255344: Unused value in copy(). Closes #4339 --- cpukit/libmisc/shell/main_cp.c | 32 1 file changed, 32 insertions(+) diff --git a/cpukit/libmisc/shell/main_cp.c b/cpukit/libmisc/shell/main_cp.c index cddbc95..913ece1 100644 --- a/cpukit/libmisc/shell/main_

Re: [PATCH 1/4] main_cp.c: Unused value (CID #1255344)

On Tue, Apr 6, 2021 at 3:49 PM Ryan Long wrote: > Joel says the two are equivalent. > And Joel was wrong in that private conversation. :( -DVAR ==> VAR is 1 #define VAR == VAR is nothing The first case is required behavior from POSIX on a C compiler invocation. --joel > > -Original Messa

Re: [PATCH 1/4] main_cp.c: Unused value (CID #1255344)

On Tue, Apr 6, 2021 at 3:28 PM Chris Johns wrote: > > > On 6 Apr 2021, at 5:38 am, Ryan Long wrote: > > > > CID 1255344: Unused value in copy(). > > > > Closes #4339 > > --- > > cpukit/libmisc/shell/main_cp.c | 64 > ++ > > 1 file changed, 64 insertions(+)

RE: [PATCH 1/4] main_cp.c: Unused value (CID #1255344)

Joel says the two are equivalent. -Original Message- From: devel On Behalf Of Ryan Long Sent: Tuesday, April 6, 2021 3:36 PM To: Chris Johns Cc: devel@rtems.org Subject: RE: [PATCH 1/4] main_cp.c: Unused value (CID #1255344) Oh, I definitely missed that. I'm not sure though, but other p

[PATCH 2/2] covoar: Eliminate tabs

--- tester/covoar/CoverageReaderTSIM.cc | 16 +- tester/covoar/CoverageWriterTSIM.cc | 4 +- tester/covoar/GcovData.cc | 719 ++-- tester/covoar/GcovData.h| 80 ++-- tester/covoar/GcovFunctionData.cc | 43 +-- tester/covoar/GcovFunctionD

[PATCH 1/2] covoar: Remove training white spaces

--- tester/covoar/ConfigFile.cc | 4 +-- tester/covoar/ConfigFile.h | 8 ++--- tester/covoar/CoverageMap.h | 4 +-- tester/covoar/CoverageRanges.cc | 2 +- tester/covoar/CoverageRanges.h | 16 - tester/covoar/CoverageReaderBase.h | 4 +-- teste

[PATCH 0/2] covoar: Trailing white space and Tab Removal fixes

Hi In committing a patch from Alex, I noticed that git complained about white space at the end of the line. I checked and there were ~225 lines that applied to. Then I looked for tabs. As I looked for tabs, I tried to control myself as there were some places I was itching to clean up but resisted.

RE: [PATCH 1/4] main_cp.c: Unused value (CID #1255344)

Oh, I definitely missed that. I'm not sure though, but other patches have used #ifdef. So I should only resubmit this patch then? -Original Message- From: Chris Johns Sent: Tuesday, April 6, 2021 3:29 PM To: Ryan Long Cc: devel@rtems.org Subject: Re: [PATCH 1/4] main_cp.c: Unused valu

Re: [PATCH 1/4] main_cp.c: Unused value (CID #1255344)

> On 6 Apr 2021, at 5:38 am, Ryan Long wrote: > > CID 1255344: Unused value in copy(). > > Closes #4339 > --- > cpukit/libmisc/shell/main_cp.c | 64 ++ > 1 file changed, 64 insertions(+) > > diff --git a/cpukit/libmisc/shell/main_cp.c b/cpukit/libmisc/sh

Re: [PATCH rtems-net-legacy] nfsclient: Build nfsclient from the top level netlegacy script

> On 4 Apr 2021, at 11:06 am, Vijay Kumar Banerjee wrote: > > --- > netlegacy.py | 18 +- > nfsclient/wscript | 1 + > wscript | 2 +- > 3 files changed, 19 insertions(+), 2 deletions(-) > > diff --git a/netlegacy.py b/netlegacy.py > index 89176e6..f470da2 100644

Re: #3860 - GSoC enquiries

Does this mean I won't have to work with uncrustify anymore? On Tue, 6 Apr 2021, 5:12 pm Gedare Bloom, wrote: > On Mon, Apr 5, 2021 at 10:37 PM Sebastian Huber > wrote: > > > > On 04/04/2021 22:18, Joel Sherrill wrote: > > > > > > > > > > > On Sun, Apr 4, 2021 at 2:25 PM Ida Delphine > >

Re: [PATCH 0/4] Unused value Coverity issues

> On 7 Apr 2021, at 2:07 am, Gedare Bloom wrote: > > 1/3/4 are fine, fix 2 and resend the set, or resent 1/3/4 as a set now > to ACK and send 2 separately later. Can we please only post full revised patch sets? I would like to comment on a patch here as well so creating and positing parts of

[PATCH v3 4/4] disp_hcms29xx.c: Unused value (CID #1399752)

CID 1399752: Unused value in disp_hcms29xx_update_task(). Closes #4342 --- bsps/shared/dev/display/disp_hcms29xx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/dev/display/disp_hcms29xx.c b/bsps/shared/dev/display/disp_hcms29xx.c index 740aa56..5ad7063 10064

[PATCH v3 3/4] fastlz.c: Unused value (CID #1399751)

CID 1399751: Unused value in fastlz2_compress(). Closes #4341 --- cpukit/libdl/fastlz.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/cpukit/libdl/fastlz.c b/cpukit/libdl/fastlz.c index 3c9d6f6..7257c98 100644 --- a/cpukit/libdl/fastlz.c +++ b/cpukit/libdl/fastlz.c

[PATCH v3 1/4] main_cp.c: Unused value (CID #1255344)

CID 1255344: Unused value in copy(). Closes #4339 --- cpukit/libmisc/shell/main_cp.c | 32 1 file changed, 32 insertions(+) diff --git a/cpukit/libmisc/shell/main_cp.c b/cpukit/libmisc/shell/main_cp.c index cddbc95..3131263 100644 --- a/cpukit/libmisc/shell/main_

[PATCH v3 2/4] print-ls.c: Unused value (CID #1255346)

CID 1255346: Unused value in rtems_shell_ls_printacol(). Closes #4340 --- cpukit/libmisc/shell/print-ls.c | 9 + 1 file changed, 9 insertions(+) diff --git a/cpukit/libmisc/shell/print-ls.c b/cpukit/libmisc/shell/print-ls.c index 15702b4..95a2cdf 100644 --- a/cpukit/libmisc/shell/print-l

[PATCH v3 0/4] Unused value Coverity issues

Hi, Here are the patches with the #ifdefs taken out of the sections with a break'. Thanks, Ryan Ryan Long (4): main_cp.c: Unused value (CID #1255344) print-ls.c: Unused value (CID #1255346) fastlz.c: Unused value (CID #1399751) disp_hcms29xx.c: Unused value (CID #1399752) bsps/shared/d

RE: [PATCH v2 1/4] main_cp.c: Unused value (CID #1255344)

The Coverity issue says: assigned_value: Assigning value from rval to badcp here, but that stored value is overwritten before it can be used. I thought this would apply to the sections with a 'break' in them, but those sections aren't being marked by Coverity. I'll take those out and resend it.

Re: [PATCH v2 1/4] main_cp.c: Unused value (CID #1255344)

On Tue, Apr 6, 2021 at 12:49 PM Ryan Long wrote: > > CID 1255344: Unused value in copy(). > > Closes #4339 > --- > cpukit/libmisc/shell/main_cp.c | 88 > ++ > 1 file changed, 88 insertions(+) > > diff --git a/cpukit/libmisc/shell/main_cp.c b/cpukit/libmisc

[PATCH v2 4/4] disp_hcms29xx.c: Unused value (CID #1399752)

CID 1399752: Unused value in disp_hcms29xx_update_task(). Closes #4342 --- bsps/shared/dev/display/disp_hcms29xx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/dev/display/disp_hcms29xx.c b/bsps/shared/dev/display/disp_hcms29xx.c index 740aa56..5ad7063 10064

[PATCH v2 3/4] fastlz.c: Unused value (CID #1399751)

CID 1399751: Unused value in fastlz2_compress(). Closes #4341 --- cpukit/libdl/fastlz.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/cpukit/libdl/fastlz.c b/cpukit/libdl/fastlz.c index 3c9d6f6..7257c98 100644 --- a/cpukit/libdl/fastlz.c +++ b/cpukit/libdl/fastlz.c

[PATCH v2 1/4] main_cp.c: Unused value (CID #1255344)

CID 1255344: Unused value in copy(). Closes #4339 --- cpukit/libmisc/shell/main_cp.c | 88 ++ 1 file changed, 88 insertions(+) diff --git a/cpukit/libmisc/shell/main_cp.c b/cpukit/libmisc/shell/main_cp.c index cddbc95..3f2b100 100644 --- a/cpukit/libmisc/s

[PATCH v2 2/4] print-ls.c: Unused value (CID #1255346)

CID 1255346: Unused value in rtems_shell_ls_printacol(). Closes #4340 --- cpukit/libmisc/shell/print-ls.c | 9 + 1 file changed, 9 insertions(+) diff --git a/cpukit/libmisc/shell/print-ls.c b/cpukit/libmisc/shell/print-ls.c index 15702b4..95a2cdf 100644 --- a/cpukit/libmisc/shell/print-l

[PATCH v2 0/4] Unused value Coverity issues

Hi, Here are the patches with the changes for main_cp.c. Thanks, Ryan Ryan Long (4): main_cp.c: Unused value (CID #1255344) print-ls.c: Unused value (CID #1255346) fastlz.c: Unused value (CID #1399751) disp_hcms29xx.c: Unused value (CID #1399752) bsps/shared/dev/display/disp_hcms29xx.c

Re: #4328: New APIs added to POSIX Standard (2021)

On Thu, Apr 1, 2021 at 8:06 AM Gedare Bloom wrote: > On Thu, Apr 1, 2021 at 6:21 AM Matthew Joyce > wrote: > > > > Hi Dr. Joel and Dr. Gedare, > > > > I posted my draft proposal on the GSOC 2021 page > > (https://devel.rtems.org/wiki/GSoC/2021). At your convenience, I would > > be very grateful

Re: [PATCH v2 2/2] score: Replace Objects_Name_or_id_lookup_errors

I'm fine with both of these v2 patches. On Tue, Apr 6, 2021 at 8:07 AM Sebastian Huber wrote: > > Replace Objects_Name_or_id_lookup_errors with new Status_Control codes. > Get rid of the _Status_Object_name_errors_to_status lookup table. > --- > cpukit/Makefile.am | 1

[PATCH rtems-net-legacy v2] nfsclient: Build nfsclient from the top level netlegacy script

--- netlegacy.py | 18 ++- nfsclient/wscript | 56 --- wscript | 2 +- 3 files changed, 18 insertions(+), 58 deletions(-) delete mode 100644 nfsclient/wscript diff --git a/netlegacy.py b/netlegacy.py index 89176e6..f470da2 1

Re: [PATCH rtems-net-legacy] nfsclient: Build nfsclient from the top level netlegacy script

On Mon, Apr 5, 2021 at 10:34 AM Gedare Bloom wrote: > > ok, push on Wednesday if no one complains > Thanks for the review. I think I found a complaint myself. :) This patch builds the nfsclient from the netlegacy script, so the nfsclient/wscript is not needed. I'll send a v2 of the patch with thi

Re: GSOC project: #4272 BSP Executable Conversion

On Tue, Apr 6, 2021 at 6:22 AM Ayushman Mishra wrote: > I checked all the BSPs having bsp-post-link in their config file (find > . -name *.cfg | xargs -e grep define | grep bsp-post-link) but > couldn't find similarity between them (other than "$(OBJCOPY) -O > binary --strip-all \ $(basename $@)$

RE: [PATCH 1/2] covoar: Split symbols by symbol set

On Tue, Apr 6, 2021 at 10:56 AM Gedare Bloom wrote: > > looks ok, it's a lot to try to process though. > > In a future patch it would be good to provide more useful names, I > don't know what 'ha' and 'la' mean, if anything. at least 'a' I > understand to be an address. > > Also, the typedef with

Re: [PATCH v2] coverage.py: Call covoar once

Pythonic! Looks good to me. On Tue, Apr 6, 2021 at 10:12 AM Alex White wrote: > > Updates #4374 > --- > tester/rt/coverage.py | 60 +-- > 1 file changed, 30 insertions(+), 30 deletions(-) > > diff --git a/tester/rt/coverage.py b/tester/rt/coverage.py > ind

Re: GSOC project: #4272 BSP Executable Conversion

On Tue, Apr 6, 2021 at 5:22 AM Ayushman Mishra wrote: > > I checked all the BSPs having bsp-post-link in their config file (find > . -name *.cfg | xargs -e grep define | grep bsp-post-link) but > couldn't find similarity between them (other than "$(OBJCOPY) -O > binary --strip-all \ $(basename $@)

[PATCH v2] coverage.py: Call covoar once

Updates #4374 --- tester/rt/coverage.py | 60 +-- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/tester/rt/coverage.py b/tester/rt/coverage.py index 29ed60b..beda207 100644 --- a/tester/rt/coverage.py +++ b/tester/rt/coverage.py @@ -304,22 +

Re: #3860 - GSoC enquiries

On Mon, Apr 5, 2021 at 10:37 PM Sebastian Huber wrote: > > On 04/04/2021 22:18, Joel Sherrill wrote: > > > > > > > On Sun, Apr 4, 2021 at 2:25 PM Ida Delphine > > wrote: > > > > Hello, > > > > Please who are the possible mentors for this project? > > > > > > IMO

Re: [PATCH 0/4] Unused value Coverity issues

1/3/4 are fine, fix 2 and resend the set, or resent 1/3/4 as a set now to ACK and send 2 separately later. On Mon, Apr 5, 2021 at 1:39 PM Ryan Long wrote: > > Hi, > > For these patches, I got rid of variables that are being reassigned > before their previous value is being used, and those changes

Re: [PATCH 1/4] main_cp.c: Unused value (CID #1255344)

On Mon, Apr 5, 2021 at 1:38 PM Ryan Long wrote: > > CID 1255344: Unused value in copy(). > > Closes #4339 > --- > cpukit/libmisc/shell/main_cp.c | 64 > ++ > 1 file changed, 64 insertions(+) > > diff --git a/cpukit/libmisc/shell/main_cp.c b/cpukit/libmisc/

Re: [PATCH 1/2] covoar: Split symbols by symbol set

looks ok, it's a lot to try to process though. In a future patch it would be good to provide more useful names, I don't know what 'ha' and 'la' mean, if anything. at least 'a' I understand to be an address. Also, the typedef with appending _t at the end should be removed, _t is reserved by POSIX.

[PATCH v2 2/2] score: Replace Objects_Name_or_id_lookup_errors

Replace Objects_Name_or_id_lookup_errors with new Status_Control codes. Get rid of the _Status_Object_name_errors_to_status lookup table. --- cpukit/Makefile.am | 1 - cpukit/include/rtems/rtems/statusimpl.h | 8 cpukit/include/rtems/score/objectimpl.h |

[PATCH v2 1/2] score: Fix internal error status number

The value of STATUS_CLASSIC_INTERNAL_ERROR must be equal to RTEMS_INTERNAL_ERROR. Add static assertions to ensure that the status codes match. --- cpukit/include/rtems/score/status.h | 4 ++-- cpukit/rtems/src/taskconstruct.c| 22 ++ 2 files changed, 24 insertions(+), 2 d

Re: [PATCH] score: Fix internal error number status

Fix doesn't say what was wrong. Please have a message which indicates what was wrong and why it needs to be changed. On Tue, Apr 6, 2021, 8:43 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > --- > cpukit/include/rtems/score/status.h | 4 ++-- > cpukit/rtems/src/taskconstruct.c

[PATCH] score: Fix internal error number status

--- cpukit/include/rtems/score/status.h | 4 ++-- cpukit/rtems/src/taskconstruct.c| 22 ++ 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/cpukit/include/rtems/score/status.h b/cpukit/include/rtems/score/status.h index 352f76e34d..a1c3c84b4d 100644 --- a/c

Re: [rtems commit] shell: Add i2c and spi commands

Just a reminder that there is a Shell Manual and these commands should be in there. --joel On Tue, Apr 6, 2021 at 8:16 AM Jan Sommer wrote: > Module:rtems > Branch:5 > Commit:a274b6fdcb7b39b3d67aad33dba0360a47f20204 > Changeset: > http://git.rtems.org/rtems/commit/?id=a274b6fdcb7b39

RE: [rtems5 PATCH 0/5] Backport zynq SPI drivers to rtems5

> -Original Message- > From: Chris Johns > Sent: Thursday, April 1, 2021 2:15 AM > To: Sommer, Jan ; devel@rtems.org > Subject: Re: [rtems5 PATCH 0/5] Backport zynq SPI drivers to rtems5 > > Hi Jan, > > This looks good. Has this been tested on zync hardware? If no then some > testing

Re: GSOC project: #4272 BSP Executable Conversion

I checked all the BSPs having bsp-post-link in their config file (find . -name *.cfg | xargs -e grep define | grep bsp-post-link) but couldn't find similarity between them (other than "$(OBJCOPY) -O binary --strip-all \ $(basename $@)$(EXEEXT) $(basename $@)$(BINEXT) " in most of them . Sir I wante

Re: [PATCH] STM32H743ZI Nucleo and basic lwIP support

Hello Robin, sorry for the delay. I checked in some patches to add a "arm/nucleo-h743zi" BSP variant. Could you please check if this variant works on the board. Could you please split up the remaining pieces of the patch into separate commits. -- embedded brains GmbH Herr Sebastian HUBER D