Re: [GSoC 2021] Beagle BSP USB OTG Support

2021-05-12 Thread Ahamed Husni
Hi, I couldn't set up the JTAG using Launchpad as it requires some adapters. While discussing in the Element14 forum, it seems it would require a lot of work to set up JTAG

Re: [PATCH v2] rtems: Constify rtems_task_wake_when()

2021-05-12 Thread Gedare Bloom
On Wed, May 12, 2021 at 1:28 PM Sebastian Huber wrote: > > On 12/05/2021 18:46, Gedare Bloom wrote: > > I understand the efficiency, but the interface is awkward. At least > > maybe put UINT32_MAX behind a macro to make the intent more clear > > #define RTEMS_TICKS_MASK 0xU > > or

Re: code review: help implementing clock_montonic

2021-05-12 Thread zack_on_the_speed_chanel
> This ticket mostly references the need for a test. Have you tried to > write a test for the missing functionality? > How I made a test for it was to create the timer using timer_create() . It also said to use a previous test with timer_realtime and i tested it with sometime similar to

Re: GSoC - Code Formatting and Style Checking for RTEMS score

2021-05-12 Thread Ida Delphine
Hello everyone, Still waiting for some feedback :) Cheers, Ida. On Mon, 10 May 2021, 5:59 am Ida Delphine, wrote: > Hello everyone, > Went through some previous emails and it turns out Sebastian already came > up with a configuration for clang format which works well for RTEMS except > for the

Re: [PATCH v2] rtems: Constify rtems_task_wake_when()

2021-05-12 Thread Sebastian Huber
On 12/05/2021 18:46, Gedare Bloom wrote: I understand the efficiency, but the interface is awkward. At least maybe put UINT32_MAX behind a macro to make the intent more clear #define RTEMS_TICKS_MASK 0xU or UINT32_MAX is fine there too, equivalent. Otherwise, go ahead. I added two

[PATCH v6] rtems-debugger: Fixed 32bit pointers

2021-05-12 Thread Stephen Clark
Using 32bit types like uint32_t for pointers creates issues on 64 bit architectures like AArch64. Replaced occurrences of these with uintptr_t, which will work for both 32 and 64 bit architectures. Added hex_decode_uintptr function to rtems-debugger. --- cpukit/include/rtems/shellconfig.h

Re: [PATCH 2/5] bsps/imxrt: Reduce devicetree size

2021-05-12 Thread Christian Mauderer
Hello Gedare, thanks for the review. On 12/05/2021 18:49, Gedare Bloom wrote: is it already clear in the related doco that overlays and adding stuff during run-time are not supported? the device tree for this BSP is linked in. So adding an overlay would need support from libfdt. To be

Re: [PATCH] c-user: Add task priority glossary terms

2021-05-12 Thread Sebastian Huber
On 12/05/2021 18:54, Gedare Bloom wrote: +eligible priority +An eligible priority of a :term:`task` is the :term:`task priority` with +respect to the corresponding :term:`eligible scheduler` of the task. An +eligible priority is either the :term:`current priority`

Re: [PATCH v3 1/5] libcsupport: Added futimens() and utimensat()

2021-05-12 Thread Gedare Bloom
On Wed, May 12, 2021 at 11:33 AM Gedare Bloom wrote: > > On Wed, May 12, 2021 at 7:33 AM Ryan Long wrote: > > > > Created futimens.c and utimensat.c to add support for the POSIX > > methods futimens() and utimensat(). > > > > utime() and utimes() are considered obsolote by POSIX, but RTEMS > >

Re: [PATCH v3 3/5] libcsupport: Implement utimes() in terms of utimensat()

2021-05-12 Thread Gedare Bloom
On Wed, May 12, 2021 at 7:34 AM Ryan Long wrote: > > utimes() now calls utimensat() to update file access > and modification timestamps. > > Updated license. > > Closes #4398 > --- > cpukit/libcsupport/src/utimes.c | 53 > +++-- > 1 file changed, 40

Re: [PATCH v3 2/5] libcsupport: Implement utime() in terms of utimensat()

2021-05-12 Thread Gedare Bloom
On Wed, May 12, 2021 at 7:34 AM Ryan Long wrote: > > utime() now calls utimensat() to update file access > and modification timestamps. > > Updated license. > > Closes #4397 > --- > cpukit/libcsupport/src/utime.c | 77 > +++--- > 1 file changed, 43

Re: [PATCH v3 1/5] libcsupport: Added futimens() and utimensat()

2021-05-12 Thread Gedare Bloom
On Wed, May 12, 2021 at 7:33 AM Ryan Long wrote: > > Created futimens.c and utimensat.c to add support for the POSIX > methods futimens() and utimensat(). > > utime() and utimes() are considered obsolote by POSIX, but RTEMS > will continue to support them. > > Closes #4396 > --- >

Re: [PATCH] c-user: Add task priority glossary terms

2021-05-12 Thread Gedare Bloom
On Wed, May 12, 2021 at 8:50 AM Joel Sherrill wrote: > > Looks good. > > On Wed, May 12, 2021 at 8:07 AM Sebastian Huber > wrote: >> >> --- >> c-user/glossary.rst | 41 ++--- >> 1 file changed, 38 insertions(+), 3 deletions(-) >> >> diff --git

Re: [PATCH] c-user: Document rtems_task_set_scheduler() errors

2021-05-12 Thread Gedare Bloom
ok On Wed, May 12, 2021 at 7:06 AM Sebastian Huber wrote: > > --- > c-user/task/directives.rst | 24 ++-- > 1 file changed, 22 insertions(+), 2 deletions(-) > > diff --git a/c-user/task/directives.rst b/c-user/task/directives.rst > index 2bfb8af..c0ef4e7 100644 > ---

Re: [PATCH 5/5] bsps/imxrt: Enable DMA clock

2021-05-12 Thread Gedare Bloom
the patch set is fine with the minor nit. On Wed, May 12, 2021 at 3:49 AM Christian Mauderer wrote: > > The EDMA is intialized so make sure the the clock is initialized too. > > Update #4180 > --- > bsps/arm/imxrt/start/bspstarthooks.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

Re: [PATCH 2/5] bsps/imxrt: Reduce devicetree size

2021-05-12 Thread Gedare Bloom
is it already clear in the related doco that overlays and adding stuff during run-time are not supported? On Wed, May 12, 2021 at 3:49 AM Christian Mauderer wrote: > > Remove symbols that would be necessary for overlays and decrease padding > that would be necessary for adding stuff during

Re: [PATCH 1/5] bsps/imxrt: Fix documentation error

2021-05-12 Thread Gedare Bloom
On Wed, May 12, 2021 at 3:49 AM Christian Mauderer wrote: > > Update #4180 > --- > bsps/arm/imxrt/include/fsl_qtmr.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/bsps/arm/imxrt/include/fsl_qtmr.h > b/bsps/arm/imxrt/include/fsl_qtmr.h > index a675413f8d..eb1d612ac3

Re: [PATCH 1/3] _TOD_Validate(): Fix incorrect return code

2021-05-12 Thread Gedare Bloom
> > These three files in bsps/ should not be calling score functions > > directly, unless they implement part of the score CPU port. These > > don't seem to be doing that. This issue exists before this patch, but > > a ticket should be opened to fix this. A new API should be added for > >

Re: [PATCH v2] rtems: Constify rtems_task_wake_when()

2021-05-12 Thread Gedare Bloom
I understand the efficiency, but the interface is awkward. At least maybe put UINT32_MAX behind a macro to make the intent more clear #define RTEMS_TICKS_MASK 0xU or UINT32_MAX is fine there too, equivalent. Otherwise, go ahead. On Tue, May 11, 2021 at 10:46 PM Sebastian Huber wrote: >

Re: [PATCH] c-user: Add task priority glossary terms

2021-05-12 Thread Joel Sherrill
Looks good. On Wed, May 12, 2021 at 8:07 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > --- > c-user/glossary.rst | 41 ++--- > 1 file changed, 38 insertions(+), 3 deletions(-) > > diff --git a/c-user/glossary.rst b/c-user/glossary.rst >

[PATCH v3 3/5] libcsupport: Implement utimes() in terms of utimensat()

2021-05-12 Thread Ryan Long
utimes() now calls utimensat() to update file access and modification timestamps. Updated license. Closes #4398 --- cpukit/libcsupport/src/utimes.c | 53 +++-- 1 file changed, 40 insertions(+), 13 deletions(-) diff --git a/cpukit/libcsupport/src/utimes.c

[PATCH v3 2/5] libcsupport: Implement utime() in terms of utimensat()

2021-05-12 Thread Ryan Long
utime() now calls utimensat() to update file access and modification timestamps. Updated license. Closes #4397 --- cpukit/libcsupport/src/utime.c | 77 +++--- 1 file changed, 43 insertions(+), 34 deletions(-) diff --git a/cpukit/libcsupport/src/utime.c

[PATCH v3 5/5] Change filesystem utime_h handler to utimens_h

2021-05-12 Thread Ryan Long
Also updated licenses. Closes #4400 --- bsps/arm/csb337/umon/tfsDriver.c| 2 +- cpukit/Makefile.am | 4 +- cpukit/include/rtems/confdefs/libio.h | 4 +- cpukit/include/rtems/imfs.h | 7 ++-- cpukit/include/rtems/libio.h

[PATCH v3 4/5] psx13: Added tests for utimensat() and futimens()

2021-05-12 Thread Ryan Long
Improved tests for utime() and utimes() and update license. Close #4399 --- testsuites/psxtests/psx13/main.c | 5 +- testsuites/psxtests/psx13/test.c | 517 +-- 2 files changed, 498 insertions(+), 24 deletions(-) diff --git

[PATCH v3 1/5] libcsupport: Added futimens() and utimensat()

2021-05-12 Thread Ryan Long
Created futimens.c and utimensat.c to add support for the POSIX methods futimens() and utimensat(). utime() and utimes() are considered obsolote by POSIX, but RTEMS will continue to support them. Closes #4396 --- cpukit/Makefile.am | 2 + cpukit/include/rtems/libio_.h

[PATCH v3 0/5] Add nanosecond support patch

2021-05-12 Thread Ryan Long
Hi, The notable changes in this iteration are: - got rid of rtems_filesystem_utime_tv_sec_valid() created _Timespec_Is_non_negative() in rtems/score/timespec.h to take its place. - Fixed some license issues Thanks, Ryan Ryan Long (5): libcsupport: Added futimens() and utimensat()

[PATCH] c-user: Add task priority glossary terms

2021-05-12 Thread Sebastian Huber
--- c-user/glossary.rst | 41 ++--- 1 file changed, 38 insertions(+), 3 deletions(-) diff --git a/c-user/glossary.rst b/c-user/glossary.rst index b3527a7..5a06c10 100644 --- a/c-user/glossary.rst +++ b/c-user/glossary.rst @@ -194,6 +194,14 @@ Glossary

[PATCH] c-user: Document rtems_task_set_scheduler() errors

2021-05-12 Thread Sebastian Huber
--- c-user/task/directives.rst | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/c-user/task/directives.rst b/c-user/task/directives.rst index 2bfb8af..c0ef4e7 100644 --- a/c-user/task/directives.rst +++ b/c-user/task/directives.rst @@ -1702,12 +1702,32

Re: Spidev different ioctl structure

2021-05-12 Thread Sebastian Huber
Hello Andre, being compatible to Linux is the goal. If this doesn't work, then this is a bug. You can add a ticket for this and fix the issues. On 12/05/2021 08:36, andre.nahrw...@dlr.de wrote: I discovered that the Spidev include (linux/spi/spidev.h) contains different implementations of

question about posix timer expiration

2021-05-12 Thread Gabriel.Moyano
Hello everyone, Currently I am trying to get running ptpd on rtems (following the Chris' work, thx btw). Ptpd uses posix timers and when a timer expires a handler with this signature void(int sig, siginfo_t *info, void *ucontext) is called. Unfortunately (*info) doesn't have the right values,

[PATCH 4/5] bsps/imxrt: Fix OCRAM, ITCM and DTCM sizes

2021-05-12 Thread Christian Mauderer
The sizes are configurable via fuses or per software via some registers. At the moment the registers are not changed. Changing the registers destroys data stored in the RAM areas (like application code or data). So either the fuses or some bootloader should be used to set them before the

[PATCH 2/5] bsps/imxrt: Reduce devicetree size

2021-05-12 Thread Christian Mauderer
Remove symbols that would be necessary for overlays and decrease padding that would be necessary for adding stuff during run-time. Update #4180 --- bsps/arm/imxrt/dts/imxrt1050-evkb.c | 1235 ++--- bsps/arm/imxrt/dts/imxrt1050-evkb.dts |2 +- 2 files changed, 472

[PATCH 5/5] bsps/imxrt: Enable DMA clock

2021-05-12 Thread Christian Mauderer
The EDMA is intialized so make sure the the clock is initialized too. Update #4180 --- bsps/arm/imxrt/start/bspstarthooks.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/bsps/arm/imxrt/start/bspstarthooks.c b/bsps/arm/imxrt/start/bspstarthooks.c index 2b6b59f66b..b8149691e7 100644 ---

[PATCH 1/5] bsps/imxrt: Fix documentation error

2021-05-12 Thread Christian Mauderer
Update #4180 --- bsps/arm/imxrt/include/fsl_qtmr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bsps/arm/imxrt/include/fsl_qtmr.h b/bsps/arm/imxrt/include/fsl_qtmr.h index a675413f8d..eb1d612ac3 100644 --- a/bsps/arm/imxrt/include/fsl_qtmr.h +++

[PATCH 0/5] bsps/imxrt: Various improvements

2021-05-12 Thread Christian Mauderer
Hello, this patch set contains a number of improvements for the i.MXRT1050 BSP. Best regards Christian ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

Spidev different ioctl structure

2021-05-12 Thread Andre.Nahrwold
Hello, I discovered that the Spidev include (linux/spi/spidev.h) contains different implementations of the ioctl structure when comparing rtems and linux. I used the mode value of the structure and wanted to compile the application for rtems and linux, that is where I got some errors. A few