Looks good. It's odd that we can't step down from EL3->EL2S->EL1S
and have the timer work on the versal. It'd be nice if we could just flip
the security bit one way or the other on the way down and share the
cascade from EL3 to EL1 without skipping parts of it. This might be
something to look into
I tried to do some testing with the code I write. I tired to test it by making
a rtems app. I modified the code from the ubuntu manpage ( here
https://manpages.ubuntu.com/manpages/bionic/man2/timer_create.2.html)so it does
not need command line arguments and my code was able to compile. When I r
On Wed, Jun 23, 2021 at 12:16 PM zack_on_the_speed_chanel
wrote:
>
> I tried to do some testing with the code I write. I tired to test it by
> making a rtems app. I modified the code from the ubuntu manpage ( here
> https://manpages.ubuntu.com/manpages/bionic/man2/timer_create.2.html)so it
> do
This patch set looks ok, but it touches a lot of assembly. Try to
ensure all variants have been thoroughly tested, including the
different ways to setup the FPU on sparc (lazy, hard/soft), with SMP,
and Profiling.
On Wed, Jun 23, 2021 at 12:50 AM Sebastian Huber
wrote:
>
> Move _ISR_Handler() to
On Wed, Jun 23, 2021 at 1:24 PM Joel Sherrill wrote:
>
> Assuming you built the bsps in question, I'm ok with this.
>
I tested the build and install for both the bsps involved.
> Any insight info the tftp code? Did it really need rtems_bsdnet.h?
>
It looks like, the tftp code uses the hostname an
---
bsp_drivers.py| 1 +
bsps/include/grlib/greth.h| 165 +++
bsps/include/grlib/network_interface_add.h| 47 ++
bsps/powerpc/beatnik/include/bsp/if_em_pub.h | 22 +
bsps/powerpc/beatnik/include/bsp/if_gfe_pub.h | 30 ++
bsps/powerp
---
bsps/headers.am |3 -
bsps/include/grlib/greth.h| 165 --
bsps/include/grlib/network_interface_add.h| 47 -
bsps/powerpc/beatnik/headers.am |3 -
bsps/powerpc/beatnik/include/bsp/if_em_pub.h | 22 -
bsps/powerpc/
On 23/06/2021 18:10, Gedare Bloom wrote:
I'm good with the patch set.
Thanks for the review.
--
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.hu...@embedded-brains.de
phone: +49-89-18 94 741 - 16
fax: +49-89-18 94 741 - 08
Registergericht: A
On 23/06/2021 18:07, Gedare Bloom wrote:
diff --git a/bsps/m68k/genmcf548x/irq/irq.c b/bsps/m68k/genmcf548x/irq/irq.c
index d010865152..547e851cdd 100644
--- a/bsps/m68k/genmcf548x/irq/irq.c
+++ b/bsps/m68k/genmcf548x/irq/irq.c
@@ -19,7 +19,7 @@
static inline bool is_valid_vector(rtems_vector
On 23/06/2021 18:10, Gedare Bloom wrote:
Is this bug worth fixing on 5?
It is not really a severe bug. The function would return an error for an
invalid vector number which is ignored by the test.
My guess is not worthwhile.
Yes.
--
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
On 23/06/2021 18:59, Gedare Bloom wrote:
+#if (CPU_SIMPLE_VECTORED_INTERRUPTS == TRUE)
+ ISR_Handler_entry _ISR_Vector_table[ CPU_INTERRUPT_NUMBER_OF_VECTORS ];
+#elif defined(CPU_INTERRUPT_NUMBER_OF_VECTORS)
Do we want to change this to _VECTOR_COUNT to be consistent with the
other patch set/A
On 23/06/2021 19:06, Gedare Bloom wrote:
+ BAD_TRAP(0x0f)! 0F undefined
+ BAD_TRAP(0x10)! 10 undefined
This code could be simplified using assembly macros (.irp) something
like what I did in bsps/sparc64/shared/start/trap_table.S
On Wed, Jun 23, 2021 at 12:49 AM Sebastian Huber
wrote:
>
> This makes it easier to review start.o and set break points to trap table
> entries. This change was checked by inspecting the trap table in start.o with
> objdump.
>
> Update #4458.
> ---
> bsps/sparc/shared/start/start.S | 359 +++
On Wed, Jun 23, 2021 at 12:49 AM Sebastian Huber
wrote:
>
> The _ISR_Handler_initialization() does not touch the _ISR_Vector_table[].
> Move
> the definition of _ISR_Vector_table[] to a separate file.
>
> Change license to BSD-2-Clause according to file history and re-licensing
> agreement.
>
>
Is this bug worth fixing on 5?
My guess is not worthwhile.
On Sat, Jun 19, 2021 at 8:05 AM Sebastian Huber
wrote:
>
> This define represents the last valid interrupt vector number.
>
> Update #3269.
> ---
> testsuites/smptests/smpcapture02/init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 dele
I'm good with the patch set.
On Sat, Jun 19, 2021 at 8:05 AM Sebastian Huber
wrote:
>
> Fix an off by one error.
>
> Update #3269.
> ---
> bsps/arm/atsam/include/bsp/irq.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bsps/arm/atsam/include/bsp/irq.h
> b/bsps/arm/atsa
On Sat, Jun 19, 2021 at 8:05 AM Sebastian Huber
wrote:
>
> Use BSP_INTERRUPT_VECTOR_COUNT instead of BSP_INTERRUPT_VECTOR_MAX.
>
> Update #3269.
> ---
> bsps/arm/atsam/start/bspstart.c | 2 +-
> bsps/arm/beagle/irq/irq.c | 2 +-
> bsps/arm/lpc176x/irq/irq.c | 2
Hello Chris,
Am 23.06.21 um 10:41 schrieb Chris Johns:
Hi Christian,
Thanks for the reply.
My uboot SD card does not have any FDT blobs so this is the reason for the
failure. We seem to now have a dependency on an FDT. I have played a bit and
found the cause of the error:
https://git.rtems.or
Hi Christian,
Thanks for the reply.
My uboot SD card does not have any FDT blobs so this is the reason for the
failure. We seem to now have a dependency on an FDT. I have played a bit and
found the cause of the error:
https://git.rtems.org/rtems/tree/bsps/shared/ofw/ofw.c#n86
I have no problem
Hello Chris,
there is no new requirement that I know of. The driver should parse the
same FDT fields that have been parsed by libbsd earlier. It only want's
to avoid the double initialization that had been done by RTEMS and libbsd.
But there is a simple method how we can find out whether it's
20 matches
Mail list logo
