Re: [PATCH v1 1/5] rtems-utils.h: Remove ostream_guard

2021-08-04 Thread Chris Johns
On 5/8/21 9:13 am, Gedare Bloom wrote: > On Wed, Aug 4, 2021 at 4:47 PM Chris Johns wrote: >> >> On 5/8/21 1:54 am, Ryan Long wrote: >>> ostream_guard did not fix the "Not restoring ostream format" Coverity >>> issues as hoped, so there's no reason to have it. >> >> Can you capture the missing

Re: [PATCH v1 1/5] rtems-utils.h: Remove ostream_guard

2021-08-04 Thread Gedare Bloom
On Wed, Aug 4, 2021 at 4:47 PM Chris Johns wrote: > > On 5/8/21 1:54 am, Ryan Long wrote: > > ostream_guard did not fix the "Not restoring ostream format" Coverity > > issues as hoped, so there's no reason to have it. > > Can you capture the missing pieces here? > Also, just because it didn't fix

Re: [PATCH v1 1/5] rtems-utils.h: Remove ostream_guard

2021-08-04 Thread Chris Johns
On 5/8/21 1:54 am, Ryan Long wrote: > ostream_guard did not fix the "Not restoring ostream format" Coverity > issues as hoped, so there's no reason to have it. Can you capture the missing pieces here? Chris ___ devel mailing list devel@rtems.org

Re: [PATCH v1 0/5] Fix ostream format errors

2021-08-04 Thread Chris Johns
On 5/8/21 1:54 am, Ryan Long wrote: > > The last "Restore ostream format" patch set didn't fix the Coverity issues. > We verified that resetiosflags() will get rid of the issues complaints about > std::left and std::right changing the stream's format, I noticed that it > didn't complain if

Re: [PATCH rtems-libbsd 0/5] RTEMS LibBSD Documentation

2021-08-04 Thread Chris Johns
On 5/8/21 2:22 am, Christian Mauderer wrote: > On 04/08/2021 18:09, Gedare Bloom wrote: >> On Wed, Aug 4, 2021 at 9:05 AM Christian MAUDERER >> wrote: >>> Am 04.08.21 um 16:55 schrieb Gedare Bloom: On Wed, Aug 4, 2021 at 4:18 AM Christian MAUDERER wrote: My preference would be to

Re: [PATCH] bsps/arm: fix off-by-1 in gicv3 processor count

2021-08-04 Thread Gedare Bloom
On Wed, Aug 4, 2021 at 11:50 AM Sebastian Huber wrote: > > On 04/08/2021 19:45, Sebastian Huber wrote: > > On 04/08/2021 19:18, Gedare Bloom wrote: > >> Hi Sebastian, > >> > >> > >> On Wed, Aug 4, 2021 at 11:15 AM Gedare Bloom wrote: > >>> --- > >>> bsps/shared/dev/irq/arm-gicv3.c | 4 ++-- >

Re: [PATCH] bsps/arm: fix off-by-1 in gicv3 processor count

2021-08-04 Thread Sebastian Huber
On 04/08/2021 19:45, Sebastian Huber wrote: On 04/08/2021 19:18, Gedare Bloom wrote: Hi Sebastian, On Wed, Aug 4, 2021 at 11:15 AM Gedare Bloom  wrote: ---   bsps/shared/dev/irq/arm-gicv3.c | 4 ++--   1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] bsps/arm: fix off-by-1 in gicv3 processor count

2021-08-04 Thread Sebastian Huber
On 04/08/2021 19:18, Gedare Bloom wrote: Hi Sebastian, On Wed, Aug 4, 2021 at 11:15 AM Gedare Bloom wrote: --- bsps/shared/dev/irq/arm-gicv3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bsps/shared/dev/irq/arm-gicv3.c b/bsps/shared/dev/irq/arm-gicv3.c index

Re: [PATCH] bsps/arm: fix off-by-1 in gicv3 processor count

2021-08-04 Thread Gedare Bloom
On Wed, Aug 4, 2021 at 11:18 AM Gedare Bloom wrote: > > Hi Sebastian, > > > On Wed, Aug 4, 2021 at 11:15 AM Gedare Bloom wrote: > > > > --- > > bsps/shared/dev/irq/arm-gicv3.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/bsps/shared/dev/irq/arm-gicv3.c > >

Re: [PATCH] bsps/arm: fix off-by-1 in gicv3 processor count

2021-08-04 Thread Gedare Bloom
Hi Sebastian, On Wed, Aug 4, 2021 at 11:15 AM Gedare Bloom wrote: > > --- > bsps/shared/dev/irq/arm-gicv3.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/bsps/shared/dev/irq/arm-gicv3.c b/bsps/shared/dev/irq/arm-gicv3.c > index ea123d325e..95021f6ddf 100644 > ---

[PATCH] bsps/arm: fix off-by-1 in gicv3 processor count

2021-08-04 Thread Gedare Bloom
--- bsps/shared/dev/irq/arm-gicv3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bsps/shared/dev/irq/arm-gicv3.c b/bsps/shared/dev/irq/arm-gicv3.c index ea123d325e..95021f6ddf 100644 --- a/bsps/shared/dev/irq/arm-gicv3.c +++ b/bsps/shared/dev/irq/arm-gicv3.c @@ -551,11

Re: [PATCH rtems-libbsd 0/5] RTEMS LibBSD Documentation

2021-08-04 Thread Christian Mauderer
On 04/08/2021 18:09, Gedare Bloom wrote: On Wed, Aug 4, 2021 at 9:05 AM Christian MAUDERER wrote: Hello Gedare, Am 04.08.21 um 16:55 schrieb Gedare Bloom: On Wed, Aug 4, 2021 at 4:18 AM Christian MAUDERER wrote: Hello Chris, Am 04.08.21 um 11:17 schrieb Chris Johns: On 4/8/21 6:34

Re: [PATCH rtems-libbsd 0/5] RTEMS LibBSD Documentation

2021-08-04 Thread Gedare Bloom
On Wed, Aug 4, 2021 at 9:05 AM Christian MAUDERER wrote: > > Hello Gedare, > > Am 04.08.21 um 16:55 schrieb Gedare Bloom: > > On Wed, Aug 4, 2021 at 4:18 AM Christian MAUDERER > > wrote: > >> > >> Hello Chris, > >> > >> Am 04.08.21 um 11:17 schrieb Chris Johns: > >>> > >>> > >>> On 4/8/21 6:34

Re: [PATCH v2] Test needed for timer_create with CLOCK_MONOTONIC

2021-08-04 Thread Gedare Bloom
On Wed, Jul 28, 2021 at 6:28 PM Zacchaeus Leung wrote: > > the timer_create() method can use CLOCK_MONOTONIC but there was no test for > this > > Closes #3888 > --- > cpukit/include/rtems/posix/timer.h| 1 + > cpukit/posix/src/psxtimercreate.c | 3 +- >

[PATCH v1 5/5] ReportsText.cc: Restore ostream format

2021-08-04 Thread Ryan Long
CID 1505940: Not restoring ostream format Remove ostream_guard, add call to resetiosflags(), store precision value before changing it and restore it afterwards. Closes #4472 --- tester/covoar/ReportsText.cc | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git

[PATCH v1 3/5] CoverageMapBase.cc: Restore ostream format

2021-08-04 Thread Ryan Long
CID 1503022: Not restoring ostream format Remove ostream_guard, change ostream format back to defaults. Closes #4470 --- tester/covoar/CoverageMapBase.cc | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tester/covoar/CoverageMapBase.cc b/tester/covoar/CoverageMapBase.cc

[PATCH v1 4/5] ReportsHtml.cc: Restore ostream format

2021-08-04 Thread Ryan Long
CID 1505939: Not restoring ostream format Remove ostream_guard, add call to resetiosflags(), store precision value before changing it and restore it afterwards. Closes #4471 --- tester/covoar/ReportsHtml.cc | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git

[PATCH v1 2/5] rtems-exeinfo.cpp: Reset cout stream flags

2021-08-04 Thread Ryan Long
CID 1503006: Not restoring ostream format CID 1503007: Not restoring ostream format Remove ostream_guard, add restiosflags() call, and store the value of precision before it is changed restore it afterwards. Closes #4469 --- linkers/rtems-exeinfo.cpp | 11 --- 1 file changed, 4

[PATCH v1 0/5] Fix ostream format errors

2021-08-04 Thread Ryan Long
Hi, The last "Restore ostream format" patch set didn't fix the Coverity issues. We verified that resetiosflags() will get rid of the issues complaints about std::left and std::right changing the stream's format, I noticed that it didn't complain if std::setfill(' ') was used after changing the

[PATCH v1 1/5] rtems-utils.h: Remove ostream_guard

2021-08-04 Thread Ryan Long
ostream_guard did not fix the "Not restoring ostream format" Coverity issues as hoped, so there's no reason to have it. --- rtemstoolkit/rtems-utils.h | 20 1 file changed, 20 deletions(-) diff --git a/rtemstoolkit/rtems-utils.h b/rtemstoolkit/rtems-utils.h index

Re: [PATCH rtems-libbsd 0/5] RTEMS LibBSD Documentation

2021-08-04 Thread Christian MAUDERER
Hello Gedare, Am 04.08.21 um 16:55 schrieb Gedare Bloom: On Wed, Aug 4, 2021 at 4:18 AM Christian MAUDERER wrote: Hello Chris, Am 04.08.21 um 11:17 schrieb Chris Johns: On 4/8/21 6:34 pm, Christian MAUDERER wrote: Hello Chris, Am 04.08.21 um 09:28 schrieb Chris Johns: On 3/8/21 5:00

Re: [PATCH rtems-libbsd 0/5] RTEMS LibBSD Documentation

2021-08-04 Thread Gedare Bloom
On Wed, Aug 4, 2021 at 4:18 AM Christian MAUDERER wrote: > > Hello Chris, > > Am 04.08.21 um 11:17 schrieb Chris Johns: > > > > > > On 4/8/21 6:34 pm, Christian MAUDERER wrote: > >> Hello Chris, > >> > >> Am 04.08.21 um 09:28 schrieb Chris Johns: > >>> On 3/8/21 5:00 pm, Christian MAUDERER wrote:

Re: [PATCH] bsps/arm: More robust SMP start

2021-08-04 Thread Gedare Bloom
seems fine to me On Wed, Aug 4, 2021 at 6:41 AM Sebastian Huber wrote: > > Do not continue execution on processors which are not configured to prevent > the > use of arbitrary memory for the initialization stack. > --- > bsps/arm/fvp/start/bspstarthooks.c | 5 + >

Re: [PATCH] tester: Add realview_pbx_a9_qemu_smp configuration

2021-08-04 Thread Gedare Bloom
ok On Wed, Aug 4, 2021 at 6:41 AM Sebastian Huber wrote: > > Add a configuration for the arm/realview_pbx_a9_qemu BSP to run the tests if > it > was built with SMP support enabled. > --- > .../testing/bsps/realview_pbx_a9_qemu_smp.ini | 38 +++ > 1 file changed, 38

Re: [PATCH v2] Test needed for timer_create with CLOCK_MONOTONIC

2021-08-04 Thread zack leung
bump On Thu, 29 Jul 2021 at 00:28, Zacchaeus Leung wrote: > the timer_create() method can use CLOCK_MONOTONIC but there was no test > for this > > Closes #3888 > --- > cpukit/include/rtems/posix/timer.h| 1 + > cpukit/posix/src/psxtimercreate.c | 3 +- >

[PATCH] bsps/arm: More robust SMP start

2021-08-04 Thread Sebastian Huber
Do not continue execution on processors which are not configured to prevent the use of arbitrary memory for the initialization stack. --- bsps/arm/fvp/start/bspstarthooks.c | 5 + bsps/arm/realview-pbx-a9/start/bspstarthooks.c | 6 +- bsps/arm/shared/start/start.S

[PATCH] tester: Add realview_pbx_a9_qemu_smp configuration

2021-08-04 Thread Sebastian Huber
Add a configuration for the arm/realview_pbx_a9_qemu BSP to run the tests if it was built with SMP support enabled. --- .../testing/bsps/realview_pbx_a9_qemu_smp.ini | 38 +++ 1 file changed, 38 insertions(+) create mode 100644

Re: [PATCH rtems-libbsd 0/5] RTEMS LibBSD Documentation

2021-08-04 Thread Christian MAUDERER
Hello Chris, Am 04.08.21 um 11:17 schrieb Chris Johns: On 4/8/21 6:34 pm, Christian MAUDERER wrote: Hello Chris, Am 04.08.21 um 09:28 schrieb Chris Johns: On 3/8/21 5:00 pm, Christian MAUDERER wrote: Hello, Am 03.08.21 um 04:07 schrieb Chris Johns: On 3/8/21 3:24 am, Sebastian Huber

Re: [PATCH rtems-libbsd 0/5] RTEMS LibBSD Documentation

2021-08-04 Thread Chris Johns
On 4/8/21 6:34 pm, Christian MAUDERER wrote: > Hello Chris, > > Am 04.08.21 um 09:28 schrieb Chris Johns: >> On 3/8/21 5:00 pm, Christian MAUDERER wrote: >>> Hello, >>> >>> Am 03.08.21 um 04:07 schrieb Chris Johns: On 3/8/21 3:24 am, Sebastian Huber wrote: > On 02/08/2021 18:37, Vijay

[PATCH rtems-libbsd v4 12/19] kern: Add kernel trace support (KTR)

2021-08-04 Thread chrisj
From: Chris Johns Update #4475 --- README.md | 9 + freebsd/sys/kern/kern_intr.c | 6 ++ freebsd/sys/kern/kern_ktr.c| 14 +++--- freebsd/sys/kern/kern_synch.c | 10 ++

[PATCH rtems-libbsd v4 11/19] kern: Import kern_ktr.c

2021-08-04 Thread chrisj
From: Chris Johns Update #4475 --- freebsd/sys/kern/kern_ktr.c | 476 1 file changed, 476 insertions(+) create mode 100644 freebsd/sys/kern/kern_ktr.c diff --git a/freebsd/sys/kern/kern_ktr.c b/freebsd/sys/kern/kern_ktr.c new file mode 100644 index

[PATCH rtems-libbsd v4 09/19] kern: Import kern_prot.c fnd kern_resource.c for proc0

2021-08-04 Thread chrisj
From: Chris Johns Update #4475 --- freebsd/sys/kern/kern_prot.c | 2247 ++ freebsd/sys/kern/kern_resource.c | 1539 2 files changed, 3786 insertions(+) create mode 100644 freebsd/sys/kern/kern_prot.c create mode 100644

[PATCH rtems-libbsd v4 08/19] sys/kern: Add lockmgr support

2021-08-04 Thread chrisj
From: Chris Johns - See `man lockmgr` - Implement the lock_object and move the RTEMS mutex to that object - Add debug support to track the locks with gdb Update #4475 --- freebsd/sys/kern/subr_lock.c | 2 - freebsd/sys/sys/_lock.h | 10 +-

[PATCH rtems-libbsd v4 07/19] testsuite: Optionally allow all command in a shell

2021-08-04 Thread chrisj
From: Chris Johns Update #4475 --- testsuite/include/rtems/bsd/test/default-network-init.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/testsuite/include/rtems/bsd/test/default-network-init.h b/testsuite/include/rtems/bsd/test/default-network-init.h index ce1fc015..fffb739c 100644 ---

[PATCH rtems-libbsd v4 06/19] rtemsbsd: Catch timeout overflows

2021-08-04 Thread chrisj
From: Chris Johns Update #4475 --- rtemsbsd/rtems/rtems-kernel-timesupport.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/rtemsbsd/rtems/rtems-kernel-timesupport.c b/rtemsbsd/rtems/rtems-kernel-timesupport.c index ef14d1fa..bc2e7b9f 100644 ---

[PATCH rtems-libbsd v4 04/19] kern-symbols: Add symbols from the everything build set

2021-08-04 Thread chrisj
From: Chris Johns Update #4475 --- .../machine/rtems-bsd-kernel-namespace.h | 127 ++ 1 file changed, 127 insertions(+) diff --git a/rtemsbsd/include/machine/rtems-bsd-kernel-namespace.h b/rtemsbsd/include/machine/rtems-bsd-kernel-namespace.h index 70bcd29a..293c6115

[PATCH rtems-libbsd v4 02/19] waf: Fix clashing symbols in the user land symbols

2021-08-04 Thread chrisj
From: Chris Johns Update #4475 --- libbsd.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libbsd.py b/libbsd.py index 09a1fbc4..2318e470 100644 --- a/libbsd.py +++ b/libbsd.py @@ -5019,7 +5019,7 @@ class dhcpcd(builder.Module): 'dhcpcd/compat/pselect.c',

[PATCH rtems-libbsd v4 03/19] sys/netinet/libalias: Fix symbols clashes

2021-08-04 Thread chrisj
From: Chris Johns Update #4475 --- freebsd/sys/netinet/libalias/alias_cuseeme.c | 3 +++ freebsd/sys/netinet/libalias/alias_dummy.c | 4 +++- freebsd/sys/netinet/libalias/alias_ftp.c | 3 +++ freebsd/sys/netinet/libalias/alias_irc.c | 3 +++ freebsd/sys/netinet/libalias/alias_nbt.c

[PATCH rtems-libbsd v4] NFSv4 Patches

2021-08-04 Thread chrisj
Hi, This the first group of patches for the NFSv4 port. This is the only part of the patches posted to devel, the complete series of patches can be downloaded from: https://ftp.rtems.org/pub/rtems/people/chrisj/nfsv4/patches/4/ I have pushed the patch series to my personal repo:

Re: [PATCH rtems-libbsd 0/5] RTEMS LibBSD Documentation

2021-08-04 Thread Christian MAUDERER
Hello Chris, Am 04.08.21 um 09:28 schrieb Chris Johns: On 3/8/21 5:00 pm, Christian MAUDERER wrote: Hello, Am 03.08.21 um 04:07 schrieb Chris Johns: On 3/8/21 3:24 am, Sebastian Huber wrote: On 02/08/2021 18:37, Vijay Kumar Banerjee wrote: I think there should be a high-level user manual

Re: [PATCH rtems-libbsd 0/5] RTEMS LibBSD Documentation

2021-08-04 Thread Chris Johns
On 3/8/21 5:00 pm, Christian MAUDERER wrote: > Hello, > > Am 03.08.21 um 04:07 schrieb Chris Johns: >> On 3/8/21 3:24 am, Sebastian Huber wrote: >>> On 02/08/2021 18:37, Vijay Kumar Banerjee wrote: I think there should be a high-level user manual subsection for networking that describes