Re: [PATCH 2/5] score: Fix blocking message queue receive

On 01/09/2021 18:58, Gedare Bloom wrote: On Tue, Aug 31, 2021 at 5:24 AM Sebastian Huber wrote: In order to ensure FIFO fairness across schedulers, the thread queue surrender operation must be used to dequeue a thread from the thread queue. The thread queue extract operation is intended for

[PATCH] score: Document thread queue operations

--- cpukit/include/rtems/score/threadq.h | 44 ++-- cpukit/include/rtems/score/threadqimpl.h | 17 + 2 files changed, 51 insertions(+), 10 deletions(-) diff --git a/cpukit/include/rtems/score/threadq.h b/cpukit/include/rtems/score/threadq.h index

Re: [PATCH v1 3/3] rld-dwarf.cpp: Initialize member variables

On 25/8/21 3:12 am, Ryan Long wrote: > Initialize member variables not listed. > > CID 1503019: Uninitialized scalar field. > > Closes #4500 > --- > rtemstoolkit/rld-dwarf.cpp | 12 > 1 file changed, 12 insertions(+) > > diff --git a/rtemstoolkit/rld-dwarf.cpp

Re: [PATCH rtems-libbsd] imx: Remove ccm functions alredy defined in RTEMS

On 1/9/21 4:24 pm, Christian MAUDERER wrote: > Hello Gedare and Chris, > > Am 01.09.21 um 07:55 schrieb Chris Johns: >> On 1/9/21 7:26 am, Gedare Bloom wrote: >>> Sorry, i think libbsd is still a bit slushy, wait for Chris to ok thx > > I planned to wait for Chris work anyway. I have pushed the

Key press to reset

Hi, I know there has been a configuration option to wait for a key press before a reset in some cases, ie PC BSP. I am now seeing it on BSPs that did not do this before but do now. This is with the waf build. Has something changed that effect the default for this setting? Chris

Re: [PATCH] TraceWriterQEMU.cc: Initialize header._pad

On Wed, Sep 1, 2021 at 3:13 PM Gedare Bloom wrote: > > ok And stupidly necessary to avoid having uninitialized fields spotted by static analysis. :( --joel > > On Wed, Sep 1, 2021 at 12:52 PM Ryan Long wrote: > > > > CID 1506204: Uninitialized scalar variable > > > > Closes #4488 > > --- > >

Re: [PATCH] TraceWriterQEMU.cc: Change strncpy to memcpy

On Wed, Sep 1, 2021 at 3:26 PM Ryan Long wrote: > > > > -Original Message- > From: Gedare Bloom > Sent: Wednesday, September 1, 2021 3:21 PM > To: Ryan Long > Cc: devel@rtems.org > Subject: Re: [PATCH] TraceWriterQEMU.cc: Change strncpy to memcpy > > On Thu, Aug 19, 2021 at 7:42 AM Ryan

RE: [PATCH] TraceWriterQEMU.cc: Change strncpy to memcpy

-Original Message- From: Gedare Bloom Sent: Wednesday, September 1, 2021 3:21 PM To: Ryan Long Cc: devel@rtems.org Subject: Re: [PATCH] TraceWriterQEMU.cc: Change strncpy to memcpy On Thu, Aug 19, 2021 at 7:42 AM Ryan Long wrote: > > CID 1506207: Buffer not null terminated > >

Re: [PATCH] TraceWriterQEMU.cc: Change strncpy to memcpy

On Thu, Aug 19, 2021 at 7:42 AM Ryan Long wrote: > > CID 1506207: Buffer not null terminated > > Closes #4491 > --- > tester/covoar/TraceWriterQEMU.cc | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tester/covoar/TraceWriterQEMU.cc >

Re: [PATCH rtems-tools v1 4/4] ObjdumpProcessor.h: Remove inputBuffer_m

On Wed, Sep 1, 2021 at 2:00 PM Ryan Long wrote: > > Accidentally got left in, so it is being removed. > Change the commit message to say you're removing it because it is unused. If you want to refer when it accidentally got left in, you can include the commit hash, but it's not necessary to do

Re: [PATCH] TraceWriterQEMU.cc: Initialize header._pad

ok On Wed, Sep 1, 2021 at 12:52 PM Ryan Long wrote: > > CID 1506204: Uninitialized scalar variable > > Closes #4488 > --- > tester/covoar/TraceWriterQEMU.cc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tester/covoar/TraceWriterQEMU.cc > b/tester/covoar/TraceWriterQEMU.cc > index

[PATCH rtems-tools v1 4/4] ObjdumpProcessor.h: Remove inputBuffer_m

Accidentally got left in, so it is being removed. CID 1506210: Uninitialized pointer field Closes #4492 --- tester/covoar/ObjdumpProcessor.h | 5 - 1 file changed, 5 deletions(-) diff --git a/tester/covoar/ObjdumpProcessor.h b/tester/covoar/ObjdumpProcessor.h index ed36981..6a207dd 100644

[PATCH rtems-tools v1 3/4] record-filter-zlib.cc: Initialize stream_'s fields

CID 1503020: Uninitialized pointer field Closes #4434 --- trace/record/record-filter-zlib.cc | 13 + 1 file changed, 13 insertions(+) diff --git a/trace/record/record-filter-zlib.cc b/trace/record/record-filter-zlib.cc index 87b2cfe..62f1171 100644 ---

[PATCH rtems-tools v1 1/4] DesiredSymbols.h: Initialize symbolInfo

CID 1399627: Uninitialized pointer field Closes #4433 --- tester/covoar/DesiredSymbols.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tester/covoar/DesiredSymbols.h b/tester/covoar/DesiredSymbols.h index 7ea3a9a..dbeeb2c 100644 --- a/tester/covoar/DesiredSymbols.h +++

[PATCH rtems-tools v1 2/4] GcovFunctionData.cc: Initialize member variables

CID 1399640: Uninitialized pointer field Closes #4432 --- tester/covoar/GcovFunctionData.cc | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tester/covoar/GcovFunctionData.cc b/tester/covoar/GcovFunctionData.cc index aec04ce..847439b 100644 ---

[PATCH rtems-tools v1 0/4] Initialize pointer fields

Hi, These patches will get rid of the "Uninitialized pointer field" Coverity issues. I noticed that some other member variables were not initialized while doing this, so I initialized them as well. Thanks, Ryan Ryan Long (4): DesiredSymbols.h: Initialize symbolInfo GcovFunctionData.cc:

[PATCH] TraceWriterQEMU.cc: Initialize header._pad

CID 1506204: Uninitialized scalar variable Closes #4488 --- tester/covoar/TraceWriterQEMU.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/tester/covoar/TraceWriterQEMU.cc b/tester/covoar/TraceWriterQEMU.cc index c417745..cc849b6 100644 --- a/tester/covoar/TraceWriterQEMU.cc +++

Re: [PATCH v1 3/5] cpukit/aarch64: Add Exception Manager support

On 9/1/2021 10:58, Sebastian Huber wrote: On 01/09/2021 17:48, Sebastian Huber wrote: So, my proposal would be something like this: 1. Processor jumps to exception prologue 2. Exception prologue saves the context to CPU exception frame 3. Exception prologue calls rtems_fatal() which does not

Re: [PATCH v1 3/3] rld-dwarf.cpp: Initialize member variables

seems alright to me. On Tue, Aug 24, 2021 at 11:14 AM Ryan Long wrote: > > Initialize member variables not listed. > > CID 1503019: Uninitialized scalar field. > > Closes #4500 > --- > rtemstoolkit/rld-dwarf.cpp | 12 > 1 file changed, 12 insertions(+) > > diff --git

Re: [PATCH rtems v1 1/2] bsps/zynq: Moved general i2c files to shared directories

looks fine to me. On Mon, Aug 23, 2021 at 4:41 PM Stephen Clark wrote: > > Certain files related to the Zynq BSP's I2C driver are useable by the ZynqMP > BSP as well. > Moved these files to shared directory in anticipation of I2C support for > ZynqMP. > --- > .../include/bsp =>

Re: [PATCH 5/5] score: Update priority only if necessary

ok, just the one note about doxygen. thanks! On Tue, Aug 31, 2021 at 5:24 AM Sebastian Huber wrote: > > In _Thread_queue_Flush_critical(), update the priority of the thread > queue owner only if necessary. The scheduler update priority operation > could be expensive. > --- >

Re: [PATCH 2/5] score: Fix blocking message queue receive

On Tue, Aug 31, 2021 at 5:24 AM Sebastian Huber wrote: > > In order to ensure FIFO fairness across schedulers, the thread queue > surrender operation must be used to dequeue a thread from the thread > queue. The thread queue extract operation is intended for timeouts. > Please add a note like

Re: [PATCH rtems] bsps/imxrt: Improve SPI driver

looks ok, touching imxrt driver only On Wed, Sep 1, 2021 at 7:55 AM Christian Mauderer wrote: > > It wasn't possible to keep the CS line low between multiple message > descriptors in one transfer. This patch reworks the driver so that it is > possible. > > Update #4180 > --- >

Re: [PATCH v1 3/5] cpukit/aarch64: Add Exception Manager support

On 01/09/2021 17:48, Sebastian Huber wrote: So, my proposal would be something like this: 1. Processor jumps to exception prologue 2. Exception prologue saves the context to CPU exception frame 3. Exception prologue calls rtems_fatal() which does not return For the signal mapping you provide

Re: [PATCH v1 3/5] cpukit/aarch64: Add Exception Manager support

On 24/08/2021 01:50, Kinsey Moore wrote: diff --git a/cpukit/score/cpu/aarch64/aarch64-exception-default.c b/cpukit/score/cpu/aarch64/aarch64-exception-default.c index 2ebb3dee9f..e51e9453e1 100644 --- a/cpukit/score/cpu/aarch64/aarch64-exception-default.c +++

[PATCH rtems] bsps/imxrt: Improve SPI driver

It wasn't possible to keep the CS line low between multiple message descriptors in one transfer. This patch reworks the driver so that it is possible. Update #4180 --- bsps/arm/imxrt/spi/imxrt-lpspi.c | 197 +++ 1 file changed, 124 insertions(+), 73 deletions(-) diff

Re: [PATCH] score: Document Futex Handler

On 01/09/2021 14:45, Joel Sherrill wrote: The comment says behaviour. Do we provide a compatible API at some level? To some extent the API is compatible. The futex support is used for the OpenMP support in GCC (libgomp). We are able to use the Linux futex barrier implementation nearly

Re: [PATCH] score: Document Futex Handler

On Wed, Sep 1, 2021 at 7:04 AM Sebastian Huber wrote: > > > > On 01/09/2021 14:03, Joel Sherrill wrote: > > > > > > On Wed, Sep 1, 2021, 12:06 AM Sebastian Huber > > > > wrote: > > > > On 31/08/2021 22:31, Joel Sherrill wrote: > > > On Tue, Aug

Re: [PATCH] score: Document Futex Handler

On 01/09/2021 14:03, Joel Sherrill wrote: On Wed, Sep 1, 2021, 12:06 AM Sebastian Huber > wrote: On 31/08/2021 22:31, Joel Sherrill wrote: > On Tue, Aug 31, 2021, 7:31 AM Sebastian Huber > mailto:sebastian.hu...@embedded-brains.de>

Re: [PATCH] score: Document Futex Handler

On Wed, Sep 1, 2021, 12:06 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 31/08/2021 22:31, Joel Sherrill wrote: > > On Tue, Aug 31, 2021, 7:31 AM Sebastian Huber > > > > wrote: > > > > Use EAGIN instead of EWOULDBLOCK to be in

Re: [PATCH rtems-libbsd] imx: Remove ccm functions alredy defined in RTEMS

Hello Gedare and Chris, Am 01.09.21 um 07:55 schrieb Chris Johns: On 1/9/21 7:26 am, Gedare Bloom wrote: Sorry, i think libbsd is still a bit slushy, wait for Chris to ok thx I planned to wait for Chris work anyway. It is so please wait a day or so. I have just finished the last stage of