Re: [PATCH v1 00/10] Convert and reformat rtems-tools pt. 1

On 3/9/21 5:24 am, Ryan Long wrote: > For this and the following series of patches I followed this series of > steps. > > 1. Convert a file from the C way of doing things to C++ > 2. Go through all the files that had to do with the converted file and > make the formatting consistent. Looks good

Re: [PATCH v1 3/3] rld-dwarf.cpp: Initialize member variables

On 3/9/21 12:08 am, Ryan Long wrote: > I remember prototyped_ being one that the issue was complaining about, but I > can't remember the others. I just went ahead and added the rest of the member > variables because Coverity doesn't always identify all the subsequent issues. May I suggest you

Re: Ticket #4203 clarification

On Thu, Sep 2, 2021 at 8:01 PM zack leung wrote: > > Hello! > > I'd like to begin working on 4203. It involves improving the exception output > I'd like to know how I spot exceptions that could be reported better by the > system? How do I also know how do I test it and what BSPs i can test

Ticket #4203 clarification

Hello! I'd like to begin working on 4203. It involves improving the exception output I'd like to know how I spot exceptions that could be reported better by the system? How do I also know how do I test it and what BSPs i can test with only my computer Also joel told me The list of exception

[PATCH RSB] Update newlib to 9069cb9 hash

This update is to include a fix for building rtems-libbsd using the previous newlib hash. was using a macro specific to the newlib implementation of . When building rtems-libbsd, -ffreestanding is used and that switches to the gcc and there was a compilation error. ---

[PATCH v1 10/10] CoverageReaderTSIM.cc: Fix formatting

--- tester/covoar/CoverageReaderTSIM.cc | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tester/covoar/CoverageReaderTSIM.cc b/tester/covoar/CoverageReaderTSIM.cc index 9c6ff7d..11f0be6 100644 --- a/tester/covoar/CoverageReaderTSIM.cc +++

[PATCH v1 09/10] CoverageReaderSkyeye.cc: Fix formatting

--- tester/covoar/CoverageReaderSkyeye.cc | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/tester/covoar/CoverageReaderSkyeye.cc b/tester/covoar/CoverageReaderSkyeye.cc index de0d4ad..abb3878 100644 --- a/tester/covoar/CoverageReaderSkyeye.cc +++

[PATCH v1 08/10] CoverageReaderRTEMS.cc: Fix formatting

--- tester/covoar/CoverageReaderRTEMS.cc | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/tester/covoar/CoverageReaderRTEMS.cc b/tester/covoar/CoverageReaderRTEMS.cc index e869fc2..6331a81 100644 --- a/tester/covoar/CoverageReaderRTEMS.cc +++

[PATCH v1 05/10] CoverageFactory.h: Fix formatting

--- tester/covoar/CoverageFactory.h | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/tester/covoar/CoverageFactory.h b/tester/covoar/CoverageFactory.h index f71860d..52443e8 100644 --- a/tester/covoar/CoverageFactory.h +++ b/tester/covoar/CoverageFactory.h @@ -32,9

[PATCH v1 04/10] CoverageMapBase.cc: Fix formatting

--- tester/covoar/CoverageMapBase.cc | 261 --- 1 file changed, 159 insertions(+), 102 deletions(-) diff --git a/tester/covoar/CoverageMapBase.cc b/tester/covoar/CoverageMapBase.cc index 334426b..7073260 100644 --- a/tester/covoar/CoverageMapBase.cc +++

[PATCH v1 02/10] CoverageReader: Convert to C++

--- tester/covoar/CoverageFactory.cc | 10 +- tester/covoar/CoverageFactory.h | 2 +- tester/covoar/CoverageReaderBase.h| 2 +- tester/covoar/CoverageReaderQEMU.cc | 35 ++- tester/covoar/CoverageReaderQEMU.h| 4 +++-

[PATCH v1 03/10] CoverageFactory.cc: Fix formatting

--- tester/covoar/CoverageFactory.cc | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/tester/covoar/CoverageFactory.cc b/tester/covoar/CoverageFactory.cc index e6c3774..89f8376 100644 --- a/tester/covoar/CoverageFactory.cc +++

[PATCH v1 01/10] CoverageMap.cc: Fix formatting

--- tester/covoar/CoverageMap.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tester/covoar/CoverageMap.cc b/tester/covoar/CoverageMap.cc index b470fea..3e0b9ce 100644 --- a/tester/covoar/CoverageMap.cc +++ b/tester/covoar/CoverageMap.cc @@ -13,7 +13,7 @@ namespace Coverage

[PATCH v1 00/10] Convert and reformat rtems-tools pt. 1

Hi, For this and the following series of patches I followed this series of steps. 1. Convert a file from the C way of doing things to C++ 2. Go through all the files that had to do with the converted file and make the formatting consistent. Thanks, Ryan Ryan Long (10): CoverageMap.cc: Fix

Re: [PATCH] eng: Remove bogus coding rule

This change looks good. On 9/2/2021 04:21, Sebastian Huber wrote: Declaring functions used only through function pointers as inline makes absolutely no sense at all. --- eng/coding-conventions.rst | 2 -- 1 file changed, 2 deletions(-) diff --git a/eng/coding-conventions.rst

RE: [PATCH v1 3/3] rld-dwarf.cpp: Initialize member variables

I remember prototyped_ being one that the issue was complaining about, but I can't remember the others. I just went ahead and added the rest of the member variables because Coverity doesn't always identify all the subsequent issues. -Original Message- From: Chris Johns Sent:

[PATCH] eng: Remove bogus coding rule

Declaring functions used only through function pointers as inline makes absolutely no sense at all. --- eng/coding-conventions.rst | 2 -- 1 file changed, 2 deletions(-) diff --git a/eng/coding-conventions.rst b/eng/coding-conventions.rst index 668a917..575dd44 100644 ---

[PATCH] c-user: Add LIFO to glossary

--- c-user/glossary.rst | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/c-user/glossary.rst b/c-user/glossary.rst index 99f7c60..63876ac 100644 --- a/c-user/glossary.rst +++ b/c-user/glossary.rst @@ -334,7 +334,8 @@ Glossary This term is an acronym for

Re: [PATCH rtems-libbsd] imx: Remove ccm functions alredy defined in RTEMS

On 2/9/21 5:40 pm, Christian MAUDERER wrote: > Am 02.09.21 um 09:33 schrieb Chris Johns: >> On 2/9/21 5:18 pm, Christian MAUDERER wrote: >> My compromise solution was adding a report option to help you see what is >> happening with the symbols. The intention is to aid managing those symbols >>

Re: [PATCH rtems-libbsd] imx: Remove ccm functions alredy defined in RTEMS

Hello Chris, Am 02.09.21 um 09:33 schrieb Chris Johns: On 2/9/21 5:18 pm, Christian MAUDERER wrote: And already a question regarding the new branch: You cleaned up the rtems-bsd-kernel-namespace.h (which is great). Thanks. It came as a surprise the script broke on FreeBSD. My patch removes

Re: [PATCH rtems-libbsd] imx: Remove ccm functions alredy defined in RTEMS

Am 02.09.21 um 08:44 schrieb Christian MAUDERER: Am 02.09.21 um 08:40 schrieb Chris Johns: On 2/9/21 4:35 pm, Christian MAUDERER wrote: Am 02.09.21 um 04:57 schrieb Chris Johns: On 1/9/21 4:24 pm, Christian MAUDERER wrote: Hello Gedare and Chris, Am 01.09.21 um 07:55 schrieb Chris Johns:

Re: [PATCH v2] score: Document thread queue operations

Looks good. Thanks. Chris On 2/9/21 5:13 pm, Sebastian Huber wrote: > --- > cpukit/include/rtems/score/threadq.h | 48 +++- > cpukit/include/rtems/score/threadqimpl.h | 21 +++ > cpukit/score/src/threadqops.c| 4 +- > 3 files changed, 62

Re: [PATCH] score: Document thread queue operations

On 2/9/21 5:09 pm, Sebastian Huber wrote: > Hello Chris, > > thanks for the review, I will send a v2 of the patch. > > On 02/09/2021 08:38, Chris Johns wrote: >>> */ >>>     Thread_queue_Enqueue_operation enqueue; >>>       /** >>> -   * @brief Thread queue extract operation. >>> +   *

[PATCH v2] score: Document thread queue operations

--- cpukit/include/rtems/score/threadq.h | 48 +++- cpukit/include/rtems/score/threadqimpl.h | 21 +++ cpukit/score/src/threadqops.c| 4 +- 3 files changed, 62 insertions(+), 11 deletions(-) diff --git a/cpukit/include/rtems/score/threadq.h

Re: [PATCH] score: Document thread queue operations

Hello Chris, thanks for the review, I will send a v2 of the patch. On 02/09/2021 08:38, Chris Johns wrote: */ Thread_queue_Enqueue_operation enqueue; /** - * @brief Thread queue extract operation. + * @brief This operation is used to extract the thread from the thread

Re: [PATCH rtems-libbsd] imx: Remove ccm functions alredy defined in RTEMS

Am 02.09.21 um 08:40 schrieb Chris Johns: On 2/9/21 4:35 pm, Christian MAUDERER wrote: Am 02.09.21 um 04:57 schrieb Chris Johns: On 1/9/21 4:24 pm, Christian MAUDERER wrote: Hello Gedare and Chris, Am 01.09.21 um 07:55 schrieb Chris Johns: On 1/9/21 7:26 am, Gedare Bloom wrote: Sorry, i

Re: [PATCH rtems] bsps/imxrt: Improve SPI driver

Thanks. Am 01.09.21 um 18:50 schrieb Gedare Bloom: looks ok, touching imxrt driver only On Wed, Sep 1, 2021 at 7:55 AM Christian Mauderer wrote: It wasn't possible to keep the CS line low between multiple message descriptors in one transfer. This patch reworks the driver so that it is

Re: [PATCH rtems-libbsd] imx: Remove ccm functions alredy defined in RTEMS

On 2/9/21 4:35 pm, Christian MAUDERER wrote: > Am 02.09.21 um 04:57 schrieb Chris Johns: >> On 1/9/21 4:24 pm, Christian MAUDERER wrote: >>> Hello Gedare and Chris, >>> >>> Am 01.09.21 um 07:55 schrieb Chris Johns: On 1/9/21 7:26 am, Gedare Bloom wrote: > Sorry, i think libbsd is still

Re: [PATCH] score: Document thread queue operations

On 2/9/21 3:50 pm, Sebastian Huber wrote: > --- > cpukit/include/rtems/score/threadq.h | 44 ++-- > cpukit/include/rtems/score/threadqimpl.h | 17 + > 2 files changed, 51 insertions(+), 10 deletions(-) > > diff --git a/cpukit/include/rtems/score/threadq.h >

Re: [PATCH rtems-libbsd] imx: Remove ccm functions alredy defined in RTEMS

Am 02.09.21 um 04:57 schrieb Chris Johns: On 1/9/21 4:24 pm, Christian MAUDERER wrote: Hello Gedare and Chris, Am 01.09.21 um 07:55 schrieb Chris Johns: On 1/9/21 7:26 am, Gedare Bloom wrote: Sorry, i think libbsd is still a bit slushy, wait for Chris to ok thx I planned to wait for Chris