Ok to push.
Thanks
On 11/9/21 4:03 am, Ryan Long wrote:
> Hi,
>
> For these patches I
>
> - Changed the data type of bytes_before so that it builds with clang
> - Replaced instances of "\n" with std::endl
> - Changed .c_str() argument to just a string
>
> Thanks,
> Ryan
>
> Ryan Long (10):
>
---
tester/covoar/CoverageWriterTSIM.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tester/covoar/CoverageWriterTSIM.h
b/tester/covoar/CoverageWriterTSIM.h
index 5ae57f8..9325a6a 100644
--- a/tester/covoar/CoverageWriterTSIM.h
+++ b/tester/covoar/CoverageWriterTSIM.h
---
tester/covoar/CoverageWriterTSIM.cc | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/tester/covoar/CoverageWriterTSIM.cc
b/tester/covoar/CoverageWriterTSIM.cc
index 9ec12e4..ed9da96 100644
--- a/tester/covoar/CoverageWriterTSIM.cc
+++
---
tester/covoar/CoverageWriterSkyeye.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tester/covoar/CoverageWriterSkyeye.h
b/tester/covoar/CoverageWriterSkyeye.h
index 8f11959..5ef6432 100644
--- a/tester/covoar/CoverageWriterSkyeye.h
+++
---
tester/covoar/CoverageWriterSkyeye.cc | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tester/covoar/CoverageWriterSkyeye.cc
b/tester/covoar/CoverageWriterSkyeye.cc
index fcc7052..f7c71c4 100644
--- a/tester/covoar/CoverageWriterSkyeye.cc
+++
---
tester/covoar/CoverageWriterRTEMS.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tester/covoar/CoverageWriterRTEMS.h
b/tester/covoar/CoverageWriterRTEMS.h
index c760936..9110303 100644
--- a/tester/covoar/CoverageWriterRTEMS.h
+++
---
tester/covoar/CoverageWriterRTEMS.cc | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/tester/covoar/CoverageWriterRTEMS.cc
b/tester/covoar/CoverageWriterRTEMS.cc
index fc8a241..a451999 100644
--- a/tester/covoar/CoverageWriterRTEMS.cc
+++
---
tester/covoar/covoar.cc | 300 +++-
1 file changed, 167 insertions(+), 133 deletions(-)
diff --git a/tester/covoar/covoar.cc b/tester/covoar/covoar.cc
index 710294b..ec126d6 100644
--- a/tester/covoar/covoar.cc
+++ b/tester/covoar/covoar.cc
@@
---
tester/covoar/CoverageWriterBase.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tester/covoar/CoverageWriterBase.h
b/tester/covoar/CoverageWriterBase.h
index fca501a..ee8c148 100644
--- a/tester/covoar/CoverageWriterBase.h
+++ b/tester/covoar/CoverageWriterBase.h
Got rid of C-strings, changed FILE pointer to ifstream.
---
tester/covoar/covoar.cc | 50 +++--
1 file changed, 23 insertions(+), 27 deletions(-)
diff --git a/tester/covoar/covoar.cc b/tester/covoar/covoar.cc
index f9d4814..710294b 100644
---
Hi,
For these patches I
- Changed the data type of bytes_before so that it builds with clang
- Replaced instances of "\n" with std::endl
- Changed .c_str() argument to just a string
Thanks,
Ryan
Ryan Long (10):
CoverageWriter: Convert to C++
covoar.cc: Convert to C++
---
tester/covoar/CoverageWriterBase.h| 4 +++-
tester/covoar/CoverageWriterRTEMS.cc | 26 +--
tester/covoar/CoverageWriterRTEMS.h | 4 +++-
tester/covoar/CoverageWriterSkyeye.cc | 39 +++
tester/covoar/CoverageWriterSkyeye.h | 4 +++-
I have chatted with Zack a fair amount about this series of patches. I
wanted to get on the mailing list to make sure some things got done as
intended.
hex numbers (%x) should be preceded by 0x. The format string would be like 0x%x
Many hex numbers (e.g. task IDs, registers, etc) should be
A register block may be used to specify the memory-mapped interface to
the hardware. Register blocks consist of register block members.
Register block members are either instances of registers or instances of
other register blocks. Registers consists of bit fields.
Update #3715.
---
For
Hi Zack,
Use git-rebase --interactive option, and reword the commit message.
The email comes through with an additional subject line, I'm not sure
if that is intended. You don't need to repeat the first line of the
commit message. It seems like the commit message you have used is:
---
improve the
Where are the duplicates been trying to fix the commit messages?
Thanks zack
Il gio 9 set 2021, 22:30 Gedare Bloom ha scritto:
> Hi Zack,
>
> It looks like something got a little messed up with your commit
> message. Please see if you can fix it to remove the duplication(s).
>
> On Thu, Sep 9,
Hello Chris,
thanks for the review.
On 10/09/2021 10:55, Chris Johns wrote:
Nice set of changes. My comments are below
On 10/9/21 6:11 pm, Sebastian Huber wrote:
Remove the duplicated description which is an out dated copy and paste
from the Classic API Guide. Instead, thoroughly
Nice set of changes. My comments are below
On 10/9/21 6:11 pm, Sebastian Huber wrote:
> Remove the duplicated description which is an out dated copy and paste
> from the Classic API Guide. Instead, thoroughly document the individual
> extensions.
>
> Change license to BSD-2-Clause
The Cache Manager directives are available via . Document most
of them in the Classic API Guide.
Not documented are the following directive since the API is not yet
stable:
* rtems_cache_coherent_allocate()
* rtems_cache_coherent_free()
* rtems_cache_coherent_add_area()
Not documented are the
Remove the duplicated description which is an out dated copy and paste
from the Classic API Guide. Instead, thoroughly document the individual
extensions.
Change license to BSD-2-Clause according to file histories and
documentation re-licensing agreement.
Update #3899.
Update #3993.
---
20 matches
Mail list logo
