Re: [PATCH rtems-lwip v1 0/9] Bring in devel patches and add ZynqMP

2022-07-01 Thread Vijay Kumar Banerjee
On Fri, Jul 1, 2022 at 8:19 PM Kinsey Moore wrote: > > On 7/1/2022 18:50, Vijay Kumar Banerjee wrote: > > On Fri, Jul 1, 2022 at 5:49 PM Vijay Kumar Banerjee wrote: > > Hi Kinsey, > > This patchset is looking great. Thank you! > Unfortunately, I won't be able to test the BBB right away but I see

Re: [PATCH rtems-lwip v1 0/9] Bring in devel patches and add ZynqMP

2022-07-01 Thread Kinsey Moore
On 7/1/2022 18:50, Vijay Kumar Banerjee wrote: On Fri, Jul 1, 2022 at 5:49 PM Vijay Kumar Banerjee wrote: Hi Kinsey, This patchset is looking great. Thank you! Unfortunately, I won't be able to test the BBB right away but I see that most patches are probably from the devel branch of lwip, whic

Re: [PATCH rtems-lwip v1 0/9] Bring in devel patches and add ZynqMP

2022-07-01 Thread Vijay Kumar Banerjee
On Fri, Jul 1, 2022 at 5:49 PM Vijay Kumar Banerjee wrote: > > Hi Kinsey, > > This patchset is looking great. Thank you! > Unfortunately, I won't be able to test the BBB right away but I see > that most patches are probably from the devel branch of lwip, which I correction: most of BBB related cha

Re: [PATCH rtems-lwip v1 0/9] Bring in devel patches and add ZynqMP

2022-07-01 Thread Vijay Kumar Banerjee
Hi Kinsey, This patchset is looking great. Thank you! Unfortunately, I won't be able to test the BBB right away but I see that most patches are probably from the devel branch of lwip, which I tested before. I am going to wait till Tuesday, to get any comments or objections from others. If no chang

[PATCH rtems-lwip v1 7/9] rtemslwip: Add zynqmp xilinx adapter code

2022-07-01 Thread Kinsey Moore
--- rtemslwip/include/arch/eth_lwip_default.h | 0 rtemslwip/include/bspconfig.h | 0 rtemslwip/xilinx/FreeRTOS.h | 38 +++ rtemslwip/xilinx/semphr.h | 0 rtemslwip/xilinx/sleep.h | 34 ++ rtemslwip/xilinx/timers.h

[PATCH rtems-lwip v1 8/9] lwip.py: Add zynqmp driver build

2022-07-01 Thread Kinsey Moore
--- lwip.py | 49 + 1 file changed, 49 insertions(+) diff --git a/lwip.py b/lwip.py index ec8481e..335fb18 100644 --- a/lwip.py +++ b/lwip.py @@ -29,6 +29,34 @@ from rtems_waf import rtems import yaml import os +xilinx_drv_incl = '' +xilinx_drv_

[PATCH rtems-lwip v1 9/9] lwip.py: Remove dead code

2022-07-01 Thread Kinsey Moore
--- lwip.py | 8 1 file changed, 8 deletions(-) diff --git a/lwip.py b/lwip.py index 335fb18..3e89026 100644 --- a/lwip.py +++ b/lwip.py @@ -75,14 +75,6 @@ def build(bld): source_files.append('./uLan/ports/os/rtems/arch/sys_arch.c') source_files.append('./rtemslwip/common/syslo

[PATCH rtems-lwip v1 6/9] xemacps: Avoid using memset on device memory

2022-07-01 Thread Kinsey Moore
It is not safe to use memset with device memory. Device memory has strict access alignment requirements that memset may not respect since it can be optimized to use unaligned accesses. This avoids use of memset with device memory. --- .../drivers/emacps/src/xemacps_bdring.c | 9 ++

[PATCH rtems-lwip v1 4/9] lwip: Add support for SMP systems

2022-07-01 Thread Kinsey Moore
For BSPs that support SMP, the sys_arch_protect and sys_arch_unprotect calls must use a global mutex instead of a local CPU interrupt disable to protect critical sections. --- uLan/ports/os/rtems/arch/sys_arch.c | 21 + 1 file changed, 21 insertions(+) diff --git a/uLan/ports/

[PATCH rtems-lwip v1 3/9] telnetd01: Break out network startup

2022-07-01 Thread Kinsey Moore
This moves network startup in to a BSP-defined function so that tests can be more generic. --- rtemslwip/beaglebone/netstart.c | 43 + rtemslwip/include/netstart.h| 41 +++ rtemslwip/test/telnetd01/init.c | 26 +--- 3

[PATCH rtems-lwip v1 0/9] Bring in devel patches and add ZynqMP

2022-07-01 Thread Kinsey Moore
This brings in a significantly cleaned up version of the remaining patches on the devel branch and adds support for ZynqMP CGEMs. I have tested CGEM0 on QEMU and CGEM3 on hardware. I am unable to test on the BeagleBoneBlack at the moment, so I'd appreciate a double-check to ensure I haven't broken

[PATCH rtems-lwip v1 1/9] uLan: Update sys_arch and fix additions

2022-07-01 Thread Kinsey Moore
This updates sys_arch.c and sys_arch.h to the latest versions from the upstream repository at hash 9e6ce84f2071bf0fbe3922db1cacf00823b2bdc1 and updates the modifications to be compliant with how this project handles modifications to upstream sources. --- uLan/ports/os/rtems/arch/sys_arch.c | 7 ++

Re: Integrating the Formal Methods part of Qualification

2022-07-01 Thread andrew.butterfi...@scss.tcd.ie
-Original Message- From: Chris Johns On 28/6/2022 11:09 pm, andrew.butterfi...@scss.tcd.ie wrote: > Dear RTEMS Developers, > > While the validation tests from the RTEMS pre-qualification activity are > now merged into the RTEMS master, the work done in investigating

Re: Integrating the Formal Methods part of Qualification

2022-07-01 Thread andrew.butterfi...@scss.tcd.ie
On 1 Jul 2022, at 00:59, Chris Johns mailto:chr...@rtems.org>> wrote: On 28/6/2022 11:09 pm, andrew.butterfi...@scss.tcd.ie wrote: Dear RTEMS Developers, While the validation tests from the RTEMS pre-qualification activity are now merged into the RTEMS m

[PATCH v2] irq/arm-gicv3.h: Customize ICC_IGRPEN0/1 init

2022-07-01 Thread Sebastian Huber
Use the existing WRITE_SR() abstraction to access the interrupt group 0 and 1 enable registers. This fixes the build for the AArch32 target. --- bsps/include/dev/irq/arm-gicv3.h | 30 --- spec/build/bsps/aarch64/a53/grp.yml | 2 ++ spec/build/bsps/aarch64/a

Re: [gcc v2] Enable some features for RTEMS in libstdc++

2022-07-01 Thread Sebastian Huber
On 09.06.22 20:19, Sebastian Huber wrote: Remove RTEMS support from crossconfig.m4 since this code is not used due to "with_newlib" being "yes". libstdc++-v3/ChangeLog: * configure: Regnerate. * configure.ac (newlib, *-rtems*): Enable TLS support for all RTEMS targets ex

[PATCH v2 10/13] gcov: Add wrapper to dump the gcov info

2022-07-01 Thread Sebastian Huber
Update #4670. --- cpukit/libtest/testgcovbspreset.c | 54 +++ cpukit/libtest/testgcovcpufatalhalt.c | 54 +++ spec/build/cpukit/librtemstest.yml| 2 + 3 files changed, 110 insertions(+) create mode 100644 cpukit/libtest/testgcovbspreset.c

[PATCH v2 11/13] build: Add RTEMS_GCOV_COVERAGE option

2022-07-01 Thread Sebastian Huber
Update #4670. --- spec/build/bsps/optcflags.yml | 2 +- spec/build/cpukit/cpuopts.yml | 10 + spec/build/cpukit/grp.yml | 2 ++ spec/build/cpukit/optcoverage.yml | 16 ++ spec/build/cpukit/optcoveragecflags.yml| 20 +

[PATCH v2 08/13] gcov: Add fork(), etc. gcov wrappers

2022-07-01 Thread Sebastian Huber
The compiler wraps fork(), etc. system calls if coverage generation is enabled. These functions must be provided by the system. For RTEMS, they just return an error status. Update #4670. --- cpukit/libcsupport/src/gcovfork.c | 94 +++ spec/build/cpukit/librtemscpu.yml

[PATCH v2 05/13] build: Add cppflags, cflags, cxxflags to groups

2022-07-01 Thread Sebastian Huber
Propagate the group defined cppflags, cflags, and cxxflags from parent groups to child items through the build item context. Update #4670. --- spec/build/bsps/aarch64/a53/grp.yml | 3 +++ spec/build/bsps/aarch64/a72/grp.yml | 3 +++ spec/build/bsps/aarch64/grp.ym

[PATCH v2 12/13] samples/minimum: Prevent a stack overflow

2022-07-01 Thread Sebastian Huber
Prevent a stack overflow if RTEMS_COVERAGE is enabled. --- testsuites/samples/minimum/init.c | 5 + 1 file changed, 5 insertions(+) diff --git a/testsuites/samples/minimum/init.c b/testsuites/samples/minimum/init.c index c988d6d750..4238c47659 100644 --- a/testsuites/samples/minimum/init.c +

[PATCH v2 13/13] libtests/crypt01: Avoid stack overflows

2022-07-01 Thread Sebastian Huber
The SHA512 functions may use huge amounts of stack space if compiled without optimization. --- testsuites/libtests/crypt01/init.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/testsuites/libtests/crypt01/init.c b/testsuites/libtests/crypt01/init.c index 0944aa60f7..26ba

[PATCH v2 06/13] build: Fix optimization flags definition order

2022-07-01 Thread Sebastian Huber
OPTIMIZATION_FLAGS must be defined before /build/bsp/bspopts is processed. Update #4670. --- spec/build/bsps/arm/beagle/bspboardorig.yml | 4 ++-- spec/build/bsps/arm/beagle/bspboardxm.yml | 4 ++-- spec/build/bsps/arm/beagle/bspboneblack.yml

[PATCH v2 09/13] gcov: Add functions to dump the gcov information

2022-07-01 Thread Sebastian Huber
Update #4670. --- cpukit/include/rtems/score/gcov.h | 66 ++ cpukit/include/rtems/score/io.h | 4 + cpukit/include/rtems/test-info.h| 6 ++ cpukit/libtest/testgcovdumpinfo.c | 66 ++ cpukit/score/src/gcovinfoset.c | 42 +

[PATCH v2 00/13] Support gcov instrumentation

2022-07-01 Thread Sebastian Huber
This patch set adds support to build the RTEMS libraries with gcov instrumentation to get code and branch coverage. There are some improvements necessary in the build system to support different compiler flags for libraries and tests. In general, code coverage is enabled by the new RTEMS_COVERAGE

[PATCH v2 07/13] build: Allow separate optimization flags

2022-07-01 Thread Sebastian Huber
Allow separate optimization flags for the BSP, cpukit, and tests. For example, the BSP and cpukit may be built without optimization if coverage instrumentation is enabled, however, the tests may still use optimization. Update #4670. --- spec/build/bsps/bspopts.yml | 8 spec/b

[PATCH v2 01/13] build: Add more flags to BuildItemContext

2022-07-01 Thread Sebastian Huber
Add cppflags, cflags, and cxxflags to BuildItemContext. This allows to propagate the flags from parent items to child items. Update #4670. --- wscript | 93 +++-- 1 file changed, 70 insertions(+), 23 deletions(-) diff --git a/wscript b/wscript

[PATCH v2 04/13] build: Improve value substitution

2022-07-01 Thread Sebastian Huber
The waf build system uses lists for tool flags. The build items may use variable substitution. Add the ability to use the variable substitution in lists. For example: MORE_FLAGS = ['-more', '-flags'] flags: - -some-flag - ${MORE_FLAGS} Before this change, the ${MORE_FLAGS} was substituted to

[PATCH v2 03/13] build: Fix identifier pattern

2022-07-01 Thread Sebastian Huber
Allow upper case characters in identifiers. Update #4670. --- wscript | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wscript b/wscript index 38910f2816..731d1402ff 100755 --- a/wscript +++ b/wscript @@ -112,7 +112,7 @@ class EnvWrapper(object): class Template(string.Temp

[PATCH v2 02/13] build: Move BSP_INCLUDES split

2022-07-01 Thread Sebastian Huber
The goal is to let the build items define as much as possible. --- spec/build/bsps/optincludes.yml | 1 + wscript | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/spec/build/bsps/optincludes.yml b/spec/build/bsps/optincludes.yml index 0b4a71031c..ea57fe

[PATCH] samples/cdtest: Test execeptions during system init

2022-07-01 Thread Sebastian Huber
Update #4668. Update #4672. --- testsuites/samples/cdtest/main.cc | 44 --- 1 file changed, 35 insertions(+), 9 deletions(-) diff --git a/testsuites/samples/cdtest/main.cc b/testsuites/samples/cdtest/main.cc index 894e404ba1..44cdaf84bb 100644 --- a/testsuites/samples