Re: [PATCH] tftpDriver.c: Fix Coverity issues

2022-09-16 Thread Joel Sherrill
I'm ok with this. FYI Coverity Scans are limited to three times a day but a check for changes runs more frequently to trigger them. On Fri, Sep 16, 2022, 1:13 PM Frank Kuehndel < frank.kuehn...@embedded-brains.de> wrote: > From: Frank Kühndel > > CID 1506523: Unchecked return value from library

[PATCH] tftpDriver.c: Fix Coverity issues

2022-09-16 Thread Frank Kuehndel
From: Frank Kühndel CID 1506523: Unchecked return value from library (CHECKED_RETURN) CID 1506522: Unchecked return value from library (CHECKED_RETURN) CID 1437618: Unchecked return value from library (CHECKED_RETURN) Close #4718 --- cpukit/libfs/src/ftpfs/tftpDriver.c | 27

Re: [PATCH 1/2] sb/setbuilder: Install the build when stagging or configured to install

2022-09-16 Thread Joel Sherrill
Push it Chris. On Fri, Sep 16, 2022, 10:01 AM Frank Kühndel < frank.kuehn...@embedded-brains.de> wrote: > Hi Chris, > > I checked your two patches in an opensuse leap 15.4 container building > the tools (rtems-source-builder git) for RTEMS 6 and ARM BSP. The build > was OK; the dependencies on "e

Re: [PATCH 1/2] sb/setbuilder: Install the build when stagging or configured to install

2022-09-16 Thread Frank Kühndel
Hi Chris, I checked your two patches in an opensuse leap 15.4 container building the tools (rtems-source-builder git) for RTEMS 6 and ARM BSP. The build was OK; the dependencies on "expat-devel" and "gmp-devel" are gone. Thanks and have a nice weekend Frank On 9/16/22 08:59, chr...@rtems.or

Re: [PATCH] Do not use RTEMS_INLINE_ROUTINE

2022-09-16 Thread Joel Sherrill
None other than nostalgia. Lol On Fri, Sep 16, 2022, 3:18 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 08.09.22 10:52, Sebastian Huber wrote: > > Directly use "static inline" which is available in C99 and later. This > brings > > the RTEMS implementation closer to standar

Re: [PATCH] Do not use RTEMS_INLINE_ROUTINE

2022-09-16 Thread Sebastian Huber
On 08.09.22 10:52, Sebastian Huber wrote: Directly use "static inline" which is available in C99 and later. This brings the RTEMS implementation closer to standard C. Close #3935. Any objections? -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebasti

Re: [PATCH] c-user: Add application config info directives

2022-09-16 Thread Sebastian Huber
On 09.09.22 16:33, Sebastian Huber wrote: Close #4267. Close #4269. --- c-user/config/directives.rst | 1197 c-user/config/index.rst|2 + c-user/config/intro.rst| 43 -- c-user/config/introduction.rst | 221 ++ 4 files changed, 1