Re: [PATCH 1/2] testsuites/libtests/can01: Serialize CAN write and read messages among the tasks

2022-12-14 Thread Prashanth S
>> >> +++ b/testsuites/libtests/can01/init.c >> >> @@ -48,7 +48,7 @@ >> >> if (c3 == '9') { \ >> >> if (c2 == 'z') { \ >> >> if (c1 == 'z') { \ >> >> - printf("not enough task letters for names >>

Re: [PATCH 1/4] cpukit/include/dev/can: Added debug print configuration under RTEMS_CAN_DEBUG macro.

2022-12-14 Thread Prashanth S
>How does this debugging get turned on/off? -DRTEMS_CAN_DEBUG as a Compiler Flag will enable the debug prints. > >maybe use CAN_ERROR? unless there's a reason not to. The debug #defines helps us to have control over the debug prints based on the entity (isr, locks, rx, tx). This helps the BSP

Re: [PATCH 1/2] testsuites/libtests/can01: Serialize CAN write and read messages among the tasks

2022-12-14 Thread Sebastian Huber
On 15/12/2022 08:19, Prashanth S wrote: >> +++ b/testsuites/libtests/can01/init.c >> @@ -48,7 +48,7 @@ >>                     if (c3 == '9') {     \ >>                       if (c2 == 'z') {   \ >>                         if (c1 == 'z') { \ >> -                         printf("not enough

Re: [PATCH 2/2] cpukit/dev/can: Fix 64 bit build compilation warnings

2022-12-14 Thread Sebastian Huber
On 14/12/2022 22:29, Gedare Bloom wrote: On Sat, Dec 3, 2022 at 2:02 AM Prashanth S wrote: --- cpukit/dev/can/can.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/dev/can/can.c b/cpukit/dev/can/can.c index 7098ce16c2..2462df7e25 100644 ---

Re: [PATCH 1/2] testsuites/libtests/can01: Serialize CAN write and read messages among the tasks

2022-12-14 Thread Prashanth S
>> >> The CAN framework has minimal Rx implementation, so to test loopback >> driver the test application is modified to write and read atomically >> --- >> testsuites/libtests/can01/init.c | 71 ++-- >> 1 file changed, 31 insertions(+), 40 deletions(-) >> >> diff

[PATCH] rtems_shell_main_mmove problem

2022-12-14 Thread zack leung
Closes #4556 --- cpukit/libmisc/shell/main_mmove.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/libmisc/shell/main_mmove.c b/cpukit/libmisc/shell/main_mmove.c index 38731b10a2..0029882d62 100644 --- a/cpukit/libmisc/shell/main_mmove.c +++

[rtems-docs 5.x v2] eng/vc-users.rst: Add commit message guidance

2022-12-14 Thread Joel Sherrill
Closes #4275. --- eng/vc-users.rst | 83 1 file changed, 77 insertions(+), 6 deletions(-) diff --git a/eng/vc-users.rst b/eng/vc-users.rst index 31de516..0ef7a66 100644 --- a/eng/vc-users.rst +++ b/eng/vc-users.rst @@ -422,20 +422,91 @@

[rtems-docs 5.x v2] eng/vc-users.rst: Add commit message guidance

2022-12-14 Thread Joel Sherrill
Closes #4274. --- eng/vc-users.rst | 83 1 file changed, 77 insertions(+), 6 deletions(-) diff --git a/eng/vc-users.rst b/eng/vc-users.rst index 680c004..fcb7ce6 100644 --- a/eng/vc-users.rst +++ b/eng/vc-users.rst @@ -422,20 +422,91 @@

Re: Moving ticket milestones to a different RTEMS version

2022-12-14 Thread Gedare Bloom
That makes sense to me too, with a backward pointer (dependency) to the previous release's ticket. On Thu, Dec 1, 2022 at 9:35 PM Chris Johns wrote: > > Hi, > > Joel and I have been cleaning up the 6 tickets and some have been moved to 7 > (thanks) which may be appropriate however I am wondering

Re: [PATCH 2/2] cpukit/dev/can: Fix 64 bit build compilation warnings

2022-12-14 Thread Gedare Bloom
On Sat, Dec 3, 2022 at 2:02 AM Prashanth S wrote: > > --- > cpukit/dev/can/can.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/cpukit/dev/can/can.c b/cpukit/dev/can/can.c > index 7098ce16c2..2462df7e25 100644 > --- a/cpukit/dev/can/can.c > +++ b/cpukit/dev/can/can.c >

Re: [PATCH 1/2] testsuites/libtests/can01: Serialize CAN write and read messages among the tasks

2022-12-14 Thread Gedare Bloom
On Sat, Dec 3, 2022 at 2:02 AM Prashanth S wrote: > > The CAN framework has minimal Rx implementation, so to test loopback > driver the test application is modified to write and read atomically > --- > testsuites/libtests/can01/init.c | 71 ++-- > 1 file changed, 31

Re: [PATCH 1/4] cpukit/include/dev/can: Added debug print configuration under RTEMS_CAN_DEBUG macro.

2022-12-14 Thread Gedare Bloom
How does this debugging get turned on/off? On Sat, Dec 3, 2022 at 2:00 AM Prashanth S wrote: > > --- > cpukit/include/dev/can/can.h | 27 +-- > 1 file changed, 21 insertions(+), 6 deletions(-) > > diff --git a/cpukit/include/dev/can/can.h b/cpukit/include/dev/can/can.h

[rtems-docs 5.x] eng/vc-users.rst: Add commit message guidance

2022-12-14 Thread Joel Sherrill
Closes #4275. --- eng/vc-users.rst | 77 +++- 1 file changed, 71 insertions(+), 6 deletions(-) diff --git a/eng/vc-users.rst b/eng/vc-users.rst index 31de516..5d2dfb4 100644 --- a/eng/vc-users.rst +++ b/eng/vc-users.rst @@ -422,20 +422,85 @@