Re: Add Formal Verification chapter v3

Hi Gedare, pull request done Regards, Andrew On 10/03/2023, 21:23, "Gedare Bloom" mailto:ged...@rtems.org>> wrote: On Fri, Mar 10, 2023 at 8:19 AM andrew.butterfi...@scss.tcd.ie mailto:andrew.butterfi...@scss.tcd.ie>> wrote: > > Hi Gedare, > the qui

Re: Help regarding Building x86_64 BSP

Hello Karel, On 3/12/23 13:03, Karel Gardas wrote: On 3/8/23 11:08, Frank Kühndel wrote: Hello, On 3/8/23 01:42, Joel Sherrill wrote: Subject: Re: Help regarding Building x86_64 BSP From: Joel Sherrill Date: 3/8/23, 01:42 To: Karel Gardas CC: "rtems-de...@rtems.org" Did you build the x8

[PATCH] Provide kernel space items only if needed

The kernel space parts of standard system header files were protected against misuse by an preprocessor error directive. This approach does not work well with tools such as Doxygen. Provide the kernel space items only if the required defines are present. --- cpukit/include/machine/_kernel_in.h

[PATCH] doxygen: Add groups for related test suites

--- cpukit/doxygen/top-level-groups.h | 24 1 file changed, 24 insertions(+) diff --git a/cpukit/doxygen/top-level-groups.h b/cpukit/doxygen/top-level-groups.h index 8a439feee1..25bf8faae2 100644 --- a/cpukit/doxygen/top-level-groups.h +++ b/cpukit/doxygen/top-level-grou

[PATCH v2] doxygen: Add groups for related test suites

--- v2: Adjust group membership of related test suites. cpukit/doxygen/top-level-groups.h | 24 +++ testsuites/unit/ts-unit-no-clock-0.c | 2 +- ...boot-processor-not-assigned-to-scheduler.c | 2 +- .../ts-fatal-idle-thread-create-failed.c | 2 +- .../

Re: Add Formal Verification chapter v3

I closed it, and instead created a Pull Request from your new-eng-chapter branch to the `master` branch on your fork of rtems-docs On Mon, Mar 13, 2023 at 3:17 AM andrew.butterfi...@scss.tcd.ie wrote: > > Hi Gedare, > pull request done > > Regards, > Andrew > > > > On 10/03/2023, 21:23, "Gedar

Re: Add Formal Verification chapter v3

On Mon, Mar 13, 2023 at 8:07 AM Gedare Bloom wrote: > > I closed it, and instead created a Pull Request from your > new-eng-chapter branch to the `master` branch on your fork of > rtems-docs > I have added comments to https://github.com/andrewbutterfield/rtems-docs/pull/1 > On Mon, Mar 13, 2023 a

[PATCH] spsysinit01: Fix sem_open() call

The O_CREAT flag requires a mode and initial value as third and fourth argument. Close #4878. --- testsuites/sptests/spsysinit01/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testsuites/sptests/spsysinit01/init.c b/testsuites/sptests/spsysinit01/init.c index 1f7c1ada

Re: [PATCH 1/2] spec: add riscv Kendryte K210 variant options

I'm not 100% sure it matters, but I think the spec/build commit should come after the source is added. This is a generally good approach when integrating code vs build changes, so that you don't try to build something that doesn't exist. On Thu, Mar 9, 2023 at 8:48 PM Alan Cudmore wrote: > > Thi

Re: [PATCH 2/2] bsps/riscv: add riscv/kendrytek210 BSP variant

On Thu, Mar 9, 2023 at 8:48 PM Alan Cudmore wrote: > > This patch set adds support for the Kendryte K210 RISC-V BSP variant. > The SoC uses existing PLIC, Timer, and console UART. It only needs > SoC specific initalization and an embedded device tree binary similar > to the polarfire SoC BSP. > >

Re: [PATCH 1/2] spec: add riscv Kendryte K210 variant options

Good idea. With the number of changes, do you think one commit for the spec/build options and one for the code is sufficient? On Mon, Mar 13, 2023 at 10:55 AM Gedare Bloom wrote: > I'm not 100% sure it matters, but I think the spec/build commit should > come after the source is added. This is a

Re: [PATCH 2/2] bsps/riscv: add riscv/kendrytek210 BSP variant

Thanks for taking a look. Comments below. On Mon, Mar 13, 2023 at 11:04 AM Gedare Bloom wrote: > On Thu, Mar 9, 2023 at 8:48 PM Alan Cudmore > wrote: > > > > This patch set adds support for the Kendryte K210 RISC-V BSP variant. > > The SoC uses existing PLIC, Timer, and console UART. It only ne

Re: [PATCH 1/2] spec: add riscv Kendryte K210 variant options

On Mon, Mar 13, 2023 at 9:31 AM Alan Cudmore wrote: > > Good idea. With the number of changes, do you think one commit for the > spec/build options and one for the code is sufficient? > I'm fine with 2 commits, but you might also consider separating the addition of the generated file (dtb) on its

Re: [PATCH 2/2] bsps/riscv: add riscv/kendrytek210 BSP variant

On Mon, Mar 13, 2023 at 9:53 AM Alan Cudmore wrote: > > Thanks for taking a look. Comments below. > > On Mon, Mar 13, 2023 at 11:04 AM Gedare Bloom wrote: >> >> On Thu, Mar 9, 2023 at 8:48 PM Alan Cudmore wrote: >> > >> > This patch set adds support for the Kendryte K210 RISC-V BSP variant. >> >

Re: [PATCH 2/2] bsps/riscv: add riscv/kendrytek210 BSP variant

On Mon, Mar 13, 2023 at 12:16 PM Gedare Bloom wrote: > On Mon, Mar 13, 2023 at 9:53 AM Alan Cudmore > wrote: > > > > Thanks for taking a look. Comments below. > > > > On Mon, Mar 13, 2023 at 11:04 AM Gedare Bloom wrote: > >> > >> On Thu, Mar 9, 2023 at 8:48 PM Alan Cudmore > wrote: > >> > > >>

Re: [PATCH] Provide kernel space items only if needed

Looks good Thanks Chris On 13/3/2023 9:36 pm, Sebastian Huber wrote: > The kernel space parts of standard system header files were protected > against misuse by an preprocessor error directive. This approach does > not work well with tools such as Doxygen. Provide the kernel space > items only

Re: [PATCH] doxygen: Add groups for related test suites

OK to push Chris On 13/3/2023 9:49 pm, Sebastian Huber wrote: > --- > cpukit/doxygen/top-level-groups.h | 24 > 1 file changed, 24 insertions(+) > > diff --git a/cpukit/doxygen/top-level-groups.h > b/cpukit/doxygen/top-level-groups.h > index 8a439feee1..25bf8faae2 1006

Re: [PATCH v2] doxygen: Add groups for related test suites

OK Does this catch all RTEMSTestSuites cases? Chris On 14/3/2023 10:16 pm, Sebastian Huber wrote: > --- > v2: Adjust group membership of related test suites. > > cpukit/doxygen/top-level-groups.h | 24 +++ > testsuites/unit/ts-unit-no-clock-0.c | 2 +- > .