Re: [PATCH rtems-tools] rtemstoolkit: Fix shlex.split to use posix mode and add unit test for pipe operation

2023-06-20 Thread Chris Johns
On 21/6/2023 2:22 pm, Muhammad Sulthan Mazaya wrote: >> On 21/6/2023 11:55 am, Muhammad Sulthan Mazaya wrote: >> > Turns out subprocess.Popen operates on posix mode. >> >> Is this true for non-POSIX systems? >> >> Where is this documented? > > It's not, turns out it is also dependent on the

Re: [PATCH rtems-tools] rtemstoolkit: Fix shlex.split to use posix mode and add unit test for pipe operation

2023-06-20 Thread Muhammad Sulthan Mazaya
> On 21/6/2023 11:55 am, Muhammad Sulthan Mazaya wrote: > > Turns out subprocess.Popen operates on posix mode. > > Is this true for non-POSIX systems? > > Where is this documented? It's not, turns out it is also dependent on the system too. It is documented here

Re: [PATCH rtems-tools] rtemstoolkit: Fix shlex.split to use posix mode and add unit test for pipe operation

2023-06-20 Thread Chris Johns
On 21/6/2023 11:55 am, Muhammad Sulthan Mazaya wrote: > Turns out subprocess.Popen operates on posix mode. Is this true for non-POSIX systems? Where is this documented? Chris Also, there is an > issue with previous implementation of pipe command that is fixed by > Chris. Now, it can also

[PATCH rtems-tools] rtemstoolkit: Fix shlex.split to use posix mode and add unit test for pipe operation

2023-06-20 Thread Muhammad Sulthan Mazaya
Turns out subprocess.Popen operates on posix mode. Also, there is an issue with previous implementation of pipe command that is fixed by Chris. Now, it can also accepts command in form of a string. The unit test for that is added via this patch. --- rtemstoolkit/execute.py | 21

Re: [PATCH rtems-tools] tester/rt: use shlex.split to split command args

2023-06-20 Thread Chris Johns
Pushed Thanks Chris On 20/6/2023 8:47 am, Muhammad Sulthan Mazaya wrote: > The regular split-by-space function used to split command arguments > creates compatibility issues with many shell command syntaxes. A > specific example is the handling of string arguments, as shown below: > > %define

Re: [PATCH rtems-tools v2] rtemstoolkit: add support for executing pipe command

2023-06-20 Thread Chris Johns
Hi, I applied the patch and ran the unit tests and they passed however the change has broken the execute class. The FreeBSD host runs sysctl to detect the number of cores when options are loaded and the `e.shell()` at the top of `freebsd.py` is failing with: $ ./tester/rtems-test --help s: /: