Re: [PATCH v3] cpukit/cache: Report coherent add area failures

2024-01-25 Thread Sebastian Huber
On 25.01.24 21:24, Kinsey Moore wrote: This alters the API for rtems_cache_coherent_add_area to allow reporting of failures that can occur during the process of adding a new area to the coherent cache heap. Looks good, thanks. -- embedded brains GmbH & Co. KG Herr Sebastian HUBER Dornierstr. 4

[PATCH v3] cpukit/cache: Report coherent add area failures

2024-01-25 Thread Kinsey Moore
This alters the API for rtems_cache_coherent_add_area to allow reporting of failures that can occur during the process of adding a new area to the coherent cache heap. --- cpukit/include/rtems/rtems/cache.h | 7 - cpukit/libcsupport/src/cachecoherentalloc.c | 30 -

Re: [PATCH v2] cpukit/cache: Report coherent add area failures

2024-01-25 Thread Kinsey Moore
On Thu, Jan 25, 2024 at 1:04 PM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 25.01.24 16:00, Kinsey Moore wrote: > > -void rtems_cache_coherent_add_area( > > +rtems_status_code rtems_cache_coherent_add_area( > > void *area_begin, > > uintptr_t area_size > > ) > > {

Re: [Patch] bsp/tms570/sci: fix bug in tms570_sci_read_received_chars()

2024-01-25 Thread Sebastian Huber
Hello Adrien, the change looks good. I would remove the tms570_sci_read_received_chars() and TMS570_SCI_BUFFER_SIZE: static void tms570_sci_interrupt_handler(void * arg) { rtems_termios_tty *tty = arg; tms570_sci_context *ctx = rtems_termios_get_device_context(tty); /* * Check if we

[PATCH v2 3/5] base64: Add decoder

2024-01-25 Thread Sebastian Huber
From: Matthew Joyce --- cpukit/base64/base64-decode.c | 165 cpukit/include/rtems/base64.h | 63 ++ spec/build/cpukit/librtemscpu.yml | 1 + .../build/testsuites/unit/unit-no-clock-0.yml | 1 + testsuites/unit/tc-base64-decode

[PATCH v2 0/5] libtest: Add packet processor

2024-01-25 Thread Sebastian Huber
The RTEMS Test Framework packet processor provides a simple mechanism to exchange reliable and in-order data through transmitting and receiving one character at a time. The packet processor does not buffer data. The processor uses a stop-and-wait automatic repeat request method. There is at most

[PATCH v2 4/5] crc: Add a CRC-24Q implementation

2024-01-25 Thread Sebastian Huber
--- cpukit/crc/crc24q.c | 148 ++ cpukit/include/rtems/crc.h| 106 + spec/build/cpukit/librtemscpu.yml | 2 + .../build/testsuites/unit/unit-no-clock-0.yml | 2 + testsuites/unit/tc-crc.c

[PATCH v2 5/5] libtest: Add packet processor

2024-01-25 Thread Sebastian Huber
The RTEMS Test Framework packet processor provides a simple mechanism to exchange reliable and in-order data through transmitting and receiving one character at a time. The packet processor does not buffer data. The processor uses a stop-and-wait automatic repeat request method. There is at most

[PATCH v2 1/5] base64: Move base64 encoding support

2024-01-25 Thread Sebastian Huber
--- .../iobase64.c => base64/base64-encode.c} | 48 +++ cpukit/include/rtems/base64.h | 125 ++ cpukit/include/rtems/dev/io.h | 62 - cpukit/libtest/gcovdumpinfobase64.c | 6 +- cpukit/libtest/t-test-hash-sha256.c

[PATCH v2 2/5] base64: Make base64 encoding tables public

2024-01-25 Thread Sebastian Huber
This makes them reusable. Change the character type to uint8_t. --- cpukit/base64/base64-encode.c | 24 +--- cpukit/include/rtems/base64.h | 10 ++ 2 files changed, 27 insertions(+), 7 deletions(-) diff --git a/cpukit/base64/base64-encode.c b/cpukit/base64/base64-enco

Re: [PATCH v2] cpukit/cache: Report coherent add area failures

2024-01-25 Thread Sebastian Huber
On 25.01.24 16:00, Kinsey Moore wrote: -void rtems_cache_coherent_add_area( +rtems_status_code rtems_cache_coherent_add_area( void *area_begin, uintptr_t area_size ) { + rtems_status_code sc; + if ( _System_state_Is_up( _System_state_Get()) ) { _RTEMS_Lock_allocator(); + }

[PATCH rtems-central v2] spec/cache/coherent: Add return value for add area

2024-01-25 Thread Kinsey Moore
This changes the return type for rtems_cache_coherent_add_area from void to rtems_status_code so that the function can report errors when they occur. --- spec/rtems/cache/if/coherent-add-area.yml | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/spec/rtems/cache/if/

[PATCH v2] cpukit/cache: Report coherent add area failures

2024-01-25 Thread Kinsey Moore
This alters the API for rtems_cache_coherent_add_area to allow reporting of failures that can occur during the process of adding a new area to the coherent cache heap. --- cpukit/include/rtems/rtems/cache.h | 7 +- cpukit/libcsupport/src/cachecoherentalloc.c | 27

Re: [PATCH rtems-central] spec/cache/coherent: Add return value for add area

2024-01-25 Thread Kinsey Moore
On Thu, Jan 25, 2024 at 2:17 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > > > On 24.01.24 18:19, Kinsey Moore wrote: > > This changes the return type for rtems_cache_coherent_add_area from void > > to rtems_status_code so that the function can report errors when they > > occur

[Patch] bsp/tms570/sci: fix bug in tms570_sci_read_received_chars()

2024-01-25 Thread Adrien Chardon
Hi all, (First time posting on a Mailing List, I apologize if I'm breaking any rule) (For the record: this work is done during my work hours at Reflex Aerospace) I believe that I found a bug in the TMS570 BSP, more specifically the receiving part of the SCI driver. Please find attached the git di

Re: [PATCH rtems-central] spec/cache/coherent: Add return value for add area

2024-01-25 Thread Sebastian Huber
On 24.01.24 18:19, Kinsey Moore wrote: This changes the return type for rtems_cache_coherent_add_area from void to rtems_status_code so that the function can report errors when they occur. --- spec/rtems/cache/if/coherent-add-area.yml | 14 -- 1 file changed, 12 insertions(+), 2

Re: [PATCH] cpukit/cache: Report coherent add area failures

2024-01-25 Thread Sebastian Huber
On 24.01.24 18:19, Kinsey Moore wrote: -static void add_area( +static int add_area( void *area_begin, uintptr_t area_size ) If you return a status code here, you can directly return it in rtems_cache_coherent_add_area(). -- embedded brains GmbH & Co. KG Herr Sebastian HUBER Dornier