Re: [PATCH] bsps/aarch64/raspberrypi: Add system timer support

2024-04-11 Thread Ning Yang
Hi Mr. Kinsey Moore, I will send the patch based on the current RTEMS master as soon as possible. I am an applicant for GSOC2024 and will continue to improve RPi4 BSP the year. I'm currently working on debugging UART interrupt mode. Please let me know if there's anything I can do to help. Best

Re: [PATCH] bsps/aarch64/raspberrypi: Add system timer support

2024-04-11 Thread Kinsey Moore
Ah, that makes sense. If your patch depends on Utkarsh's work, then we'll need to work on getting that into upstream RTEMS as well. If your patch can be rebased on to current RTEMS master, that would be ideal. Regarding Utkarsh's work not being merged into RTEMS, patches sometimes slip through the

Re: [PATCH] bsps/aarch64/raspberrypi: Add system timer support

2024-04-11 Thread Ning Yang
Hi Mr. Kinsey Moore: I am using the RPi4 BSP (project of GSOC2023) written by Utkarsh Verma. For some reason it wasn't merged. https://lists.rtems.org/pipermail/devel/2023-August/076152.html I got the code from his github: https://github.com/UtkarshVerma/rtems Best regards, Ning > 2024年4月11日 2

Re: [PATCH] bsps/aarch64/raspberrypi: Add system timer support

2024-04-11 Thread Kinsey Moore
I couldn't get this patch to apply. Are you sure it came from the right branch and has no merge commits ahead of it? Kinsey On Wed, Apr 10, 2024 at 9:24 AM Ning Yang wrote: > The clock from the ARM timer is derived from the system clock. This clock > can change dynamically e.g. if the system go

Re: [PATCH 0/3] Improve Xilinx TTC clock driver

2024-04-11 Thread Sebastian Huber
On 11.04.24 16:56, Kinsey Moore wrote: Beyond the rebase issue, this patch set looks good. Thanks for the review, I checked it in. -- embedded brains GmbH & Co. KG Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 f

Re: [PATCH 0/3] Improve Xilinx TTC clock driver

2024-04-11 Thread Kinsey Moore
Beyond the rebase issue, this patch set looks good. Kinsey On Wed, Apr 10, 2024 at 6:16 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > Sebastian Huber (3): > bsps/xil-ttc: Use interrupt entry > bsps/xil-ttc: Add XIL_FATAL_TTC_IRQ_INSTALL > bsps/xil-ttc: Improve clock dri

Re: [PATCH 1/3] bsps/xil-ttc: Use interrupt entry

2024-04-11 Thread Sebastian Huber
On 11.04.24 16:27, Kinsey Moore wrote:  static void zynqmp_ttc_clock_driver_support_install_isr(    rtems_interrupt_handler handler  )  {    rtems_status_code sc; -  sc = rtems_interrupt_handler_install( -    BSP_SELECTED_TTC_IRQ, -    "Clock", -    RTEMS

Re: [PATCH 1/3] bsps/xil-ttc: Use interrupt entry

2024-04-11 Thread Kinsey Moore
On Wed, Apr 10, 2024 at 6:16 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > --- > bsps/shared/dev/clock/xil-ttc.c | 14 ++ > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/bsps/shared/dev/clock/xil-ttc.c > b/bsps/shared/dev/clock/xil-ttc.c > index