[PATCH 5/5] grlib/l2c: Prevent concurrent register access

Accesses to the L2C registers performed by the L2C driver are now serialized with spin locks. This avoids concurrent access to the L2C registers by multiple processors. Proposed by GRLIB-TN-0021. Update #4925. --- bsps/shared/grlib/l2c/l2c.c | 35 --- 1 file change

[PATCH 3/5] grlib/l2c: Access registers with helper functions

--- bsps/shared/grlib/l2c/l2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bsps/shared/grlib/l2c/l2c.c b/bsps/shared/grlib/l2c/l2c.c index ef2a524d33..d3832cdd51 100644 --- a/bsps/shared/grlib/l2c/l2c.c +++ b/bsps/shared/grlib/l2c/l2c.c @@ -2107,8 +2107,8 @@ int l2cach

[PATCH 4/5] grlib/l2c: Write to flush registers using atomic instructions

All writes to the L2C flush registers performed by the driver are now done using atomic write instructions. Proposed by GRLIB-TN-0021. Update #4925. --- bsps/shared/grlib/l2c/l2c.c | 64 + 1 file changed, 50 insertions(+), 14 deletions(-) diff --git a/bsps/sha

[PATCH 2/5] grlib/l2c: Use printk for debug print

--- bsps/shared/grlib/l2c/l2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bsps/shared/grlib/l2c/l2c.c b/bsps/shared/grlib/l2c/l2c.c index 4be29c56a4..ef2a524d33 100644 --- a/bsps/shared/grlib/l2c/l2c.c +++ b/bsps/shared/grlib/l2c/l2c.c @@ -50,7 +50,7 @@ /*#define DEBUG 1

[PATCH 0/5] Update GRLIB L2C driver for technical note TN-0021

Implement workarounds for GRLIB-TN-0021 ("Level-2 Cache Issues H1 2023") in the GRLIB L2C driver manager device driver. Martin Åberg (5): grlib/l2c: Fix whitespace grlib/l2c: Use printk for debug print grlib/l2c: Access registers with helper functions grlib/l2c: Write to flush

[PATCH 1/5] grlib/l2c: Fix whitespace

No functional change --- bsps/shared/grlib/l2c/l2c.c | 168 ++-- 1 file changed, 84 insertions(+), 84 deletions(-) diff --git a/bsps/shared/grlib/l2c/l2c.c b/bsps/shared/grlib/l2c/l2c.c index 17d96874ae..4be29c56a4 100644 --- a/bsps/shared/grlib/l2c/l2c.c +++ b/bsp

[PATCH] LEON3: Update power-down function

This updates the implementation of the LEON3 processor power-down function. It now contains the workaround for the GR712RC power-down errata described in GR712RC-UM, version 2.16, section 1.7.8. The workaround is compatible with other LEON3/LEON4 components. Update #4875. --- bsps/sparc/leon3/st

Re: [PATCH v2 3/9] bsps/leon3: Make GPTIMER fall back mandatory

Hello Sebastian, On 2023-10-19 15:44, Sebastian Huber wrote: On 19.10.23 12:22, Martin Åberg wrote: On 2023-10-13 13:00, Sebastian Huber wrote >> LEON3_Timer_Regs is probed in amba.c. There is a link time option to set GPTIMER core index (leon3_timer_core_index). Instances could have

Re: [PATCH v2 9/9] bsps/leon3: Use DSU time tag for GR712RC

activated by mistake. For example "LEON3_USE_GR712RC_DSU_COUNTER", or use an additional condition like "&& defined(RTEMS_BSP_GR712RC)". Another option would be to "#error" out if building a non-GR712RC BSP. -- Best regards, Martin Åberg Software

Re: [PATCH v2 8/9] bsps/leon3: leon3_counter_use_irqamp_timestamp()

OK On 2023-09-21 17:19, Sebastian Huber wrote: Simplify leon3_counter_use_irqamp_timestamp(). Update #4954. --- bsps/sparc/leon3/start/cpucounter.c | 4 1 file changed, 4 deletions(-) -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com

Re: [PATCH v2 7/9] bsps/leon3: Statically initialize get timecount

OK On 2023-09-21 17:19, Sebastian Huber wrote: Update #4954. --- bsps/sparc/leon3/include/bsp/leon3.h | 2 +- bsps/sparc/leon3/start/cpucounter.c | 30 +--- 2 files changed, 19 insertions(+), 13 deletions(-) -- Best regards, Martin Åberg Software Engineer

Re: [PATCH v2 6/9] bsps/leon3: Move code blocks

OK On 2023-09-21 17:19, Sebastian Huber wrote: Move code blocks to simplify C preprocessor usage. Update #4954. --- bsps/sparc/leon3/start/cpucounter.c | 110 ++-- 1 file changed, 57 insertions(+), 53 deletions(-) -- Best regards, Martin Åberg Software Engineer

Re: [PATCH v2 5/9] bsps/leon3: Use custom CPU counter implementation

, 134 insertions(+), 91 deletions(-) -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com Frontgrade Gaisler AB, Kungsgatan 12, SE-411 19 GÖTEBORG, Sweden. +46 (0) 31 775 8650, www.gaisler.com ___ devel mailing list

Re: [PATCH v2 4/9] bsps/leon3: Simplify clock and CPU counter

| 130 +-- bsps/sparc/leon3/include/bsp/leon3.h | 9 ++ bsps/sparc/leon3/start/cpucounter.c | 46 +++--- 3 files changed, 62 insertions(+), 123 deletions(-) -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com

Re: [PATCH v2 2/9] sparc: Move CPU counter implementation

insertions(+), 79 deletions(-) rename cpukit/score/cpu/sparc/include/rtems/score/sparcimpl.h => bsps/sparc/include/bsp/sparc-counter.h (63%) rename {cpukit/score/cpu/sparc => bsps/sparc/shared/start}/sparc-counter-asm.S (86%) -- Best regards, Martin Åberg Software Engineer Frontgrade G

Re: [PATCH v2 1/9] bsps/leon3: Optional IRQ(A)MP timestamp support

est regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com Frontgrade Gaisler AB, Kungsgatan 12, SE-411 19 GÖTEBORG, Sweden. +46 (0) 31 775 8650, www.gaisler.com This e-mail and any files transmitted with it ("E-mail") is intended solely for the address

Re: [PATCH v2 3/9] bsps/leon3: Make GPTIMER fall back mandatory

clarified, this commit is OK. On 2023-10-13 13:00, Sebastian Huber wrote: Hello Martin, On 13.10.23 12:09, Martin Åberg wrote: What are the implications when using RTEMS_MULTIPROCESSING together with "use_gptimer"? In bsps/sparc/leon3/include/bsp/leon3.h, we have:  >

Re: [PATCH v2 3/9] bsps/leon3: Make GPTIMER fall back mandatory

ON3_CLOCK_INDEX of CPU1 here? Best Regards, -- Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com Frontgrade Gaisler AB, Kungsgatan 12, SE-411 19 GÖTEBORG, Sweden. +46 (0) 31 775 8650, www.gaisler.com On 2023-09-21 17:19, Sebastian Huber wrote: Using the auto reload c

Re: [PATCH] sparc: Fix stack corruption

Hello Sebastian, I have reviewed the ticket and the patch. The fix is OK. -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com Frontgrade Gaisler AB, Kungsgatan 12, SE-411 19 GÖTEBORG, Sweden. +46 (0) 31 775 8650, www.gaisler.com On 2023-09-20 09:38

Re: [PATCH v3 00/38] Integrate pre-qualified LEON3 BSP

great. Thanks! All commits in the patch set are OK now. -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com Frontgrade Gaisler AB, Kungsgatan 12, SE-411 19 GÖTEBORG, Sweden. +46 (0) 31 775 8650, www.gaisler.com

Re: [PATCH v2 31/32] validation: Test sparc/leon3 BSP family

100644 testsuites/validation/bsps/ts-fatal-sparc-leon3-shutdown.c -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com Frontgrade Gaisler AB, Kungsgatan 12, SE-411 19 GÖTEBORG, Sweden. +46 (0) 31 775 8650, www.gaisler.com

Re: [PATCH v2 30/32] validation: grlib

-io.c create mode 100644 testsuites/validation/tc-dev-grlib-irqamp-get-timestamp.c -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com Frontgrade Gaisler AB, Kungsgatan 12, SE-411 19 GÖTEBORG, Sweden. +46 (0) 31 775 8650, www.gaisler.com

Re: [PATCH v2 29/32] bsp/leon3: Add specialized target hash

-- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com Frontgrade Gaisler AB, Kungsgatan 12, SE-411 19 GÖTEBORG, Sweden. +46 (0) 31 775 8650, www.gaisler.com ___ devel mailing list devel@rtems.org http://lists.rtems.org

Re: [PATCH v2 28/32] bsp/leon3: Fix group memberships

+- bsps/sparc/leon3/start/bspsmp.c | 2 +- bsps/sparc/leon3/start/setvec.c | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com Frontgrade Gaisler AB, Kungsgatan 12, SE-411 19 GÖTEBORG

Re: [PATCH v2 27/32] bsps/sparc: Remove BSP_POWER_DOWN_AT_FATAL_HALT

/bsps/sparc/leon3/optpwrdwnhlt.yml -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com Frontgrade Gaisler AB, Kungsgatan 12, SE-411 19 GÖTEBORG, Sweden. +46 (0) 31 775 8650, www.gaisler.com ___ devel mailing list

Re: [PATCH v2 26/32] bsp/leon3: Enable up-counter conditionally

OK On 2023-07-05 13:18, Sebastian Huber wrote: --- bsps/sparc/leon3/clock/ckinit.c | 5 +++-- bsps/sparc/leon3/start/cpucounter.c | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com

Re: [PATCH v2 25/32] bsp/leon3: Use LEON3_GPTIMER_BASE

OK On 2023-07-05 13:18, Sebastian Huber wrote: --- bsps/sparc/leon3/start/cpucounter.c | 4 1 file changed, 4 insertions(+) -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com Frontgrade Gaisler AB, Kungsgatan 12, SE-411 19 GÖTEBORG, Sweden

Re: [PATCH v2 24/32] bsp/leon3: Add LEON3_IRQAMP_EXTENDED_INTERRUPT

+++ 4 files changed, 33 insertions(+) create mode 100644 spec/build/bsps/sparc/leon3/optirqampextirq.yml -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com Frontgrade Gaisler AB, Kungsgatan 12, SE-411 19 GÖTEBORG, Sweden. +46 (0) 31 775 8650

Re: [PATCH v2 23/32] bsp/leon3: Add LEON3_PROBE_ASR_22_23_UP_COUNTER

+++ 4 files changed, 31 insertions(+) create mode 100644 spec/build/bsps/sparc/leon3/optasrupcntprobe.yml -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com Frontgrade Gaisler AB, Kungsgatan 12, SE-411 19 GÖTEBORG, Sweden. +46 (0) 31 775 8650

Re: [PATCH v2 22/32] bsp/leon3: Simplify fatal error handling

ROM boot loader. The _CPU_Fatal_halt looks like a path of no return (error mode) and no more user hooks. But would it perhaps be possibility for the application to provide an extension with CONFIGURE_INITIAL_EXTENSIONS to have application specific actions like the ones above? -- Best re

Re: [PATCH v2 21/32] bsp/leon3: Move leon3_power_down_loop()

deletions(-) -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com Frontgrade Gaisler AB, Kungsgatan 12, SE-411 19 GÖTEBORG, Sweden. +46 (0) 31 775 8650, www.gaisler.com ___ devel mailing list devel@rtems.org http

Re: [PATCH v2 20/32] bsp/leon3: Add LEON3_L2CACHE_BASE

(-) create mode 100644 spec/build/bsps/sparc/leon3/optl2cachebase.yml -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com Frontgrade Gaisler AB, Kungsgatan 12, SE-411 19 GÖTEBORG, Sweden. +46 (0) 31 775 8650, www.gaisler.com

Re: [PATCH v2 19/32] bsp/leon3: Add LEON3_HAS_ASR_22_23_UP_COUNTER

/sparc/leon3/optasrupcnt.yml | 17 + 5 files changed, 35 insertions(+) create mode 100644 spec/build/bsps/sparc/leon3/optasrupcnt.yml -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com Frontgrade Gaisler AB, Kungsgatan 12, SE-411 19

Re: [PATCH v2 18/32] bsp/leon3: Add LEON3_IRQAMP_PROBE_TIMESTAMP

+++ 4 files changed, 207 insertions(+), 118 deletions(-) create mode 100644 spec/build/bsps/sparc/leon3/optirqampts.yml -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com Frontgrade Gaisler AB, Kungsgatan 12, SE-411 19 GÖTEBORG, Sweden. +46 (0) 31

Re: [PATCH v2 17/32] bsp/leon3: Add LEON3_IRQAMP_BASE

+++ 4 files changed, 35 insertions(+), 1 deletion(-) create mode 100644 spec/build/bsps/sparc/leon3/optirqampbase.yml -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com Frontgrade Gaisler AB, Kungsgatan 12, SE-411 19 GÖTEBORG, Sweden. +46 (0

Re: [PATCH v2 16/32] bsp/leon3: Add LEON3_GPTIMER_BASE

+++ 4 files changed, 30 insertions(+) create mode 100644 spec/build/bsps/sparc/leon3/optgptimerbase.yml -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com Frontgrade Gaisler AB, Kungsgatan 12, SE-411 19 GÖTEBORG, Sweden. +46 (0) 31 775 8650

Re: [PATCH v2 15/32] bsp/leon3: LEON3_PLB_FREQUENCY_DEFINED_BY_GPTIMER

++ spec/build/bsps/sparc/leon3/optplbfreq.yml | 21 + 5 files changed, 61 insertions(+), 6 deletions(-) create mode 100644 spec/build/bsps/sparc/leon3/optplbfreq.yml -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com Frontgrade Gaisler

Re: [PATCH v2 14/32] bsp/leon3: Add LEON3_APBUART_BASE

+ .../build/bsps/sparc/leon3/optapbuartbase.yml | 20 ++ 5 files changed, 58 insertions(+), 8 deletions(-) create mode 100644 spec/build/bsps/sparc/leon3/optapbuartbase.yml -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com Frontgrade Gaisler AB

Re: [PATCH v2 13/32] bsp/leon3: Use new L2CACHE register block API

OK On 2023-07-05 13:18, Sebastian Huber wrote: --- bsps/sparc/leon3/start/cache.c | 38 -- 1 file changed, 23 insertions(+), 15 deletions(-) -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com Frontgrade Gaisler AB

Re: [PATCH v2 12/32] bsp/leon3: Use new GPTIMER register block API

stop the subtimer, disable its interrupt generation and unpend a possibly pending interrupt indication. -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com Frontgrade Gaisler AB, Kungsgatan 12, SE-411 19 GÖTEBORG, Sweden. +46 (0) 31 775 8650, www.gaisle

Re: [PATCH v2 11/32] bsp/leon3: Move system control register support

- bsps/sparc/leon3/start/bspstart.c| 2 +- bsps/sparc/leon3/start/cache.c | 2 +- 5 files changed, 176 insertions(+), 102 deletions(-) -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com Frontgrade Gaisler AB, Kungsgatan 12, SE-411 19

Re: [PATCH v2 10/32] bsp/leon3: Use new IRQ(A)MP register block API

nterrupt_broadcast are still accessing the register by dereferencing LEON3_IrqCtrl_Regs->bcast directly, in contrast to the other changes in the file. (These two macros are not used anywhere at the moment.) -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisle

Re: [PATCH v2 09/32] bsp/leon3: Move and simplify bsp_irq_fixup()

-- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com Frontgrade Gaisler AB, Kungsgatan 12, SE-411 19 GÖTEBORG, Sweden. +46 (0) 31 775 8650, www.gaisler.com ___ devel mailing list devel@rtems.org http

Re: [PATCH v2 08/32] bsp/leon3: Untangle interrupt controller support

--- bsps/sparc/leon3/start/eirq.c | 15 - spec/build/bsps/sparc/leon3/obj.yml| 1 + 5 files changed, 97 insertions(+), 21 deletions(-) create mode 100644 bsps/sparc/leon3/include/bsp/irqimpl.h -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab

Re: [PATCH v2 07/32] bsps: Use new APBUART register block API

regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com Frontgrade Gaisler AB, Kungsgatan 12, SE-411 19 GÖTEBORG, Sweden. +46 (0) 31 775 8650, www.gaisler.com ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman

Re: [PATCH v2 06/32] bsps/grlib: Fix SPWTDP register name

OK On 2023-07-05 13:18, Sebastian Huber wrote: Update #4842. --- bsps/include/grlib/spwtdp-regs.h | 32 1 file changed, 16 insertions(+), 16 deletions(-) -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com

Re: [PATCH v2 05/32] bsps/grlib: Expand SpaceWire port bit fields

files changed, 4 insertions(+), 4 deletions(-) -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com Frontgrade Gaisler AB, Kungsgatan 12, SE-411 19 GÖTEBORG, Sweden. +46 (0) 31 775 8650, www.gaisler.com ___ devel

Re: [PATCH v2 04/32] bsps/grlib: Fix SpaceWire RMAP - Product ID

OK On 2023-07-05 13:18, Sebastian Huber wrote: Update #4842. --- bsps/include/grlib/spwrmap-regs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com Frontgrade Gaisler AB, Kungsgatan 12

Re: [PATCH v2 03/32] bsps/grlib: Fix GRGPIO - IRQMAP bit fields

OK On 2023-07-05 13:18, Sebastian Huber wrote: Update #4842. --- bsps/include/grlib/grgpio-regs.h | 37 +--- 1 file changed, 24 insertions(+), 13 deletions(-) -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com

Re: [PATCH v2 02/32] bsps/grlib: Fix FTMCTRL - MCFG1 bit fields

OK On 2023-07-05 13:18, Sebastian Huber wrote: There was an off by one error in all bit fields. Add the R flag. Update #4842. --- bsps/include/grlib/ftmctrl-regs.h | 127 -- 1 file changed, 70 insertions(+), 57 deletions(-) -- Best regards, Martin Åberg

Re: [PATCH v2 01/32] bsps/grlib: Add generated headers

rlib/spw/grspw_pkt.c bsps/shared/grlib/spw/grspw_router.c With these updates in place, the headers will be compatible with current and future GRLIB systems with SpaceWire. Including GR740, GR712RC, UT700, GR765, aswell as custom FPGAs and ASICs. -- Best regards, Martin Åberg Softwa