Re: [PATCH] bsps/raspberrypi/console: Fix default console device

2021-05-27 Thread Niteesh G. S.
Hello Alan, On Sun, May 23, 2021 at 9:06 PM Alan Cudmore wrote: > Hi Niteesh, > Here are my latest tests: > - Using your firmware and the rtems.img in your firmware repo, I can > see that it runs on my Raspberry Pi 3. The hello example reports RTEMS > 5.1. Was this from the 5

Re: [PATCH] bsps/raspberrypi/console: Fix default console device

2021-05-19 Thread Niteesh G. S.
ping. On Tue, May 11, 2021 at 1:09 AM Niteesh G. S. wrote: > Hello Gedare, > > On Mon, May 10, 2021 at 8:57 PM Gedare Bloom wrote: > >> On Thu, May 6, 2021 at 8:49 AM Niteesh G. S. >> wrote: >> > >> > Hi Alan, >> > >> > On Thu, M

Re: [PATCH] bsps/raspberrypi/console: Fix default console device

2021-05-10 Thread Niteesh G. S.
Hello Gedare, On Mon, May 10, 2021 at 8:57 PM Gedare Bloom wrote: > On Thu, May 6, 2021 at 8:49 AM Niteesh G. S. wrote: > > > > Hi Alan, > > > > On Thu, May 6, 2021 at 6:12 PM Alan Cudmore > wrote: > >> > >> Hi Niteesh, > >> >

Re: [PATCH] bsps/raspberrypi/console: Fix default console device

2021-05-10 Thread Niteesh G. S.
Hello Alan, On Mon, May 10, 2021 at 8:04 PM Alan Cudmore wrote: > Hi Niteesh, > I was able to build the current RTEMS master (raspberrypi BSP) and I > was also able to successfully apply your patch and rebuild. > However, I am having trouble getting RTEMS running on the Raspberry

Re: [PATCH v3] bsps/shared/ofw: Fix coverity defects

2021-05-06 Thread Niteesh G. S.
On Fri, May 7, 2021 at 4:16 AM Vijay Kumar Banerjee wrote: > On Thu, May 6, 2021 at 10:57 AM Gedare Bloom wrote: > > > > ok, Vijay please push > > Pushed. Thanks. > Thanks for pushing. > > > > > On Thu, May 6, 2021 at 2:06 AM G S Niteesh Babu >

Re: [PATCH] bsps/raspberrypi/console: Fix default console device

2021-05-06 Thread Niteesh G. S.
Hi Alan, On Thu, May 6, 2021 at 6:12 PM Alan Cudmore wrote: > Hi Niteesh, > > I was hoping to try this out as soon as I get some time. No later than > weekend. So if nobody else is able to check it out, I will be able to > provide some feedback soon. > > I should be able to

Re: [PATCH] bsps/raspberrypi/console: Fix default console device

2021-05-06 Thread Niteesh G. S.
ping. On Sat, May 1, 2021 at 9:47 PM Niteesh G. S. wrote: > On Sat, May 1, 2021 at 8:31 PM Joel Sherrill wrote: > >> >> >> On Sat, May 1, 2021, 8:53 AM Niteesh G. S. wrote: >> >>> Just to provide more context, >>> When the CONFIGURE

Re: [PATCH v2] bsps/shared/ofw: Fix coverity defects

2021-05-06 Thread Niteesh G. S.
again. I have sent a v3 please take a look at that. I tested the patch by creating a new branch, applying the patch, and then building and testing. So I am sure it will work. Thanks, Niteesh On Thu, May 6, 2021 at 7:17 AM Vijay Kumar Banerjee wrote: > Hi all, > > On Wed, May 5, 2021 a

[PATCH v3] bsps/shared/ofw: Fix coverity defects

2021-05-06 Thread G S Niteesh Babu
This patch adds asserts to fix coverity defects 1) CID 1474437 (Out-of-bounds access) 2) CID 1474436 (Out-of-bounds access) >From manual inspection, out of bounds access cannot occur due to bounds checking but coverity fails to detect the checks. We are adding asserts as a secondary check. ---

Re: [PATCH v2] bsps/shared/ofw: Fix coverity defects

2021-05-05 Thread Niteesh G. S.
On Mon, May 3, 2021 at 11:23 PM Gedare Bloom wrote: > Hi Niteesh, > > This looks good to me. What/how did you test it? > I tested it using the ofw01 test https://git.rtems.org/rtems/tree/testsuites/libtests/ofw01/init.c and read EEPROM using i2c. > Gedare > > On Sat, May 1

Re: [PATCH] bsps/raspberrypi/console: Fix default console device

2021-05-01 Thread Niteesh G. S.
On Sat, May 1, 2021 at 8:31 PM Joel Sherrill wrote: > > > On Sat, May 1, 2021, 8:53 AM Niteesh G. S. wrote: > >> Just to provide more context, >> When the CONFIGURE_APPLICATION_NEEDS_CONSOLE_DRIVER option is used >> and no --console option is provided, the co

Re: [PATCH] bsps/raspberrypi/console: Fix default console device

2021-05-01 Thread Niteesh G. S.
the primary UART to the console device. Thanks, Niteesh On Sat, May 1, 2021 at 7:05 PM G S Niteesh Babu wrote: > When no console argument is given, the driver defaults to pl011 > this results in no output in case of Rpi3 whose primary uart is > miniuart. > This patch fixes that b

[PATCH] bsps/raspberrypi/console: Fix default console device

2021-05-01 Thread G S Niteesh Babu
When no console argument is given, the driver defaults to pl011 this results in no output in case of Rpi3 whose primary uart is miniuart. This patch fixes that by defaulting to the primary uart when no console option is provided. --- bsps/arm/raspberrypi/console/console-config.c | 12 +---

[PATCH v2] bsps/shared/ofw: Fix coverity defects

2021-05-01 Thread G S Niteesh Babu
This patch adds asserts to fix coverity defects 1) CID 1474437 (Out-of-bounds access) 2) CID 1474436 (Out-of-bounds access) >From manual inspection, out of bounds access cannot occur due to bounds checking but coverity fails to detect the checks. We are adding asserts as a secondary check. ---

Re: [PATCH] bsps/shared/ofw: Fix coverity defects

2021-05-01 Thread Niteesh G. S.
On Thu, Apr 29, 2021 at 9:25 PM Gedare Bloom wrote: > On Wed, Apr 28, 2021 at 9:04 PM Niteesh G. S. > wrote: > > > > > > > > On Thu, Apr 29, 2021 at 12:50 AM Gedare Bloom wrote: > >> > >> On Wed, Apr 28, 2021 at 11:30 AM G S Niteesh Babu >

Re: [PATCH] bsps/shared/ofw: Fix coverity defects

2021-04-28 Thread Niteesh G. S.
On Thu, Apr 29, 2021 at 12:50 AM Gedare Bloom wrote: > On Wed, Apr 28, 2021 at 11:30 AM G S Niteesh Babu > wrote: > > > > This patch adds asserts to fix coverity defects > > 1) CID 1474437 (Out-of-bounds access) > > 2) CID 1474436 (Out-of-bounds access) >

[PATCH] bsps/shared/ofw: Fix coverity defects

2021-04-28 Thread G S Niteesh Babu
This patch adds asserts to fix coverity defects 1) CID 1474437 (Out-of-bounds access) 2) CID 1474436 (Out-of-bounds access) >From manual inspection, out of bounds access cannot occur due to bounds checking but coverity fails to detect the checks. We are adding asserts as a secondary check. ---

Re: [PATCH RTEMS v2 0/1] bsp/beagle: Refactored i2c driver and Updated

2021-04-22 Thread Niteesh G. S.
Hello Christian, On Thu, Apr 22, 2021 at 10:24 PM Christian Mauderer wrote: > Hello Niteesh, > > thanks for the reminder and the patches. I pushed them. > Thanks for pushing them Thank you, Niteesh. > > Best regards > > Christian > > On 22/04/2021 05:54,

Re: [PATCH RTEMS v2 0/1] bsp/beagle: Refactored i2c driver and Updated

2021-04-21 Thread Niteesh G. S.
Hello Christian, Reminder to push the patches. Thanks, Niteesh On Sun, Apr 18, 2021 at 11:57 PM Christian Mauderer wrote: > Hello Niteesh, > > looks good to me. I'll wait two or three days before pushing so that > others can review the libbsd patch too. Please ping me on We

Re: [PATCH libBSD] iicbus/rtems-i2c.c: Add rtems, path as an additional bus path

2021-04-19 Thread Niteesh G. S.
Hello Christian, On Mon, Apr 19, 2021 at 10:18 PM Christian Mauderer wrote: > Hello Niteesh, > > On 19/04/2021 18:45, Niteesh G. S. wrote: > > > > > > On Mon, Apr 19, 2021 at 9:55 PM Gedare Bloom > <mailto:ged...@rtems.org>> wrote: > > > >

[PATCH libBSD v2] iicbus/rtems-i2c.c: Add rtems, path as an additional bus path

2021-04-19 Thread G S Niteesh Babu
Adds "rtems,path" as an additional bus path for the i2c driver. Previously the bus path was provided in "rtems,i2c-path" property only. --- rtemsbsd/sys/dev/iicbus/rtems-i2c.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/rtemsbsd/sys/dev/iicbus/rtems-i2c.c

Re: [PATCH libBSD] iicbus/rtems-i2c.c: Add rtems, path as an additional bus path

2021-04-19 Thread Niteesh G. S.
On Mon, Apr 19, 2021 at 9:55 PM Gedare Bloom wrote: > On Sun, Apr 18, 2021 at 9:12 AM G S Niteesh Babu > wrote: > > > > Adds "rtems,path" as an additional bus path for the i2c driver. > > Previously the bus path was provided in "rtems,i2c-path" prop

Re: [PATCH RTEMS v2 0/1] bsp/beagle: Refactored i2c driver and Updated

2021-04-18 Thread Niteesh G. S.
Hello Christian, On Sun, Apr 18, 2021 at 4:54 PM Christian Mauderer wrote: > Hello Niteesh, > > sorry for not taking a look earlier. > No problem > > The patches seem OK for me. Just a tiny change request: > > I know that I suggested the "rtems,path" for the d

[PATCH libBSD] iicbus/rtems-i2c.c: Add rtems, path as an additional bus path

2021-04-18 Thread G S Niteesh Babu
Adds "rtems,path" as an additional bus path for the i2c driver. Previously the bus path was provided in "rtems,i2c-path" property only. --- rtemsbsd/sys/dev/iicbus/rtems-i2c.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/rtemsbsd/sys/dev/iicbus/rtems-i2c.c

Re: [PATCH RTEMS v2 0/1] bsp/beagle: Refactored i2c driver and Updated

2021-04-17 Thread Niteesh G. S.
ping. On Sun, Apr 11, 2021 at 12:45 AM G S Niteesh Babu wrote: > The following two patches update the Beagle BSP i2c driver to use > device tree based initialization and the documentation related to > it. > > G S Niteesh Babu (1): > bsps/beagle: Refactored i2c driver > &

[PATCH RTEMS v2 0/1] bsp/beagle: Refactored i2c driver and Updated

2021-04-10 Thread G S Niteesh Babu
The following two patches update the Beagle BSP i2c driver to use device tree based initialization and the documentation related to it. G S Niteesh Babu (1): bsps/beagle: Refactored i2c driver bsps/arm/beagle/i2c/bbb-i2c.c | 122 ++ bsps/arm/beagle/include

[PATCH RTEMS v2 1/1] bsps/beagle: Refactored i2c driver

2021-04-10 Thread G S Niteesh Babu
Refactored the i2c driver to parse register values from the device tree rather than hardcoding them. But still the clocks have to initialized manually. --- bsps/arm/beagle/i2c/bbb-i2c.c | 122 ++ bsps/arm/beagle/include/bsp.h | 4 +

[PATCH RTEMS-docs] user/bsps/arm/beagle: Update i2c initialization instructions

2021-04-10 Thread G S Niteesh Babu
The new i2c driver in the beagle BSP uses FDT based initialization. This updates the documentation of the BSP about the same. --- user/bsps/arm/beagle.rst | 41 +++- 1 file changed, 28 insertions(+), 13 deletions(-) diff --git a/user/bsps/arm/beagle.rst

Re: [PATCH RTEMS] bsps/beagle: Refactored i2c driver

2021-04-07 Thread Niteesh G. S.
Hello Vijay, On Sun, Mar 28, 2021 at 1:42 AM Vijay Kumar Banerjee wrote: > Hi Niteesh, > > Thanks for the patch. I have some questions below. > > On Mon, Mar 22, 2021 at 11:48 AM G S Niteesh Babu > wrote: > > > > Refactored the i2c driver to parse register v

Re: [PATCH RTEMS] bsps/beagle: Refactored i2c driver

2021-03-22 Thread Niteesh G. S.
Hii, I have tested this patch by reading out the values from the EEPROM in i2c-0 and also reading out data from a sensor connected to i2c-1. For reading data from the sensor, I used RTEMS Shell with i2cget and i2cset. All this was done on a PocketBeagle. Thanks, Niteesh. On Mon, Mar 22, 2021

[PATCH RTEMS] bsps/beagle: Refactored i2c driver

2021-03-22 Thread G S Niteesh Babu
Refactored the i2c driver to parse register values from the device tree rather than hardcoding them. But still the clocks have to initialized manually. --- bsps/arm/beagle/i2c/bbb-i2c.c | 100 -- bsps/arm/beagle/include/bsp.h | 4 ++

Re: [PATCH] rtems-fdt/rtems-fdt.c: Fix bug in loop termination

2021-03-22 Thread Niteesh G. S.
On Sun, Mar 21, 2021 at 5:13 PM Christian Mauderer wrote: > Hello Gedare and Niteesh, > > I pushed the patch on master and 5. > > Niteesh: Thanks for finding and fixing that bug. > Thanks for pushing this and Beagle patches. Thank you, Niteesh > Best regards > > Chr

Re: [PATCH] rtems-fdt/rtems-fdt.c: Fix bug in loop termination

2021-03-21 Thread Niteesh G. S.
ares to push this please go ahead. I wouldn't get to it > until next week sometime. Niteesh, ping it on Tuesday if no one has > pushed. > OK > > On Wed, Mar 17, 2021 at 8:51 PM G S Niteesh Babu > wrote: > > > > The while loop, loops infinitely in case of raw FDT data. >

Re: [PATCH 2/5] rtems-fdt.c: Fix Resource leak (CID #1437645)

2021-03-18 Thread Niteesh G. S.
On Thu, Mar 18, 2021 at 1:01 AM Chris Johns wrote: > I do not know. Maybe ask or post a patch? > I have sent a patch please take a look at it https://lists.rtems.org/pipermail/devel/2021-March/065610.html > > On 18 Mar 2021, at 2:14 am, Niteesh G. S. wrote: > >  > > &

[PATCH] rtems-fdt/rtems-fdt.c: Fix bug in loop termination

2021-03-17 Thread G S Niteesh Babu
The while loop, loops infinitely in case of raw FDT data. The loop condition (size) is not modified during iterations. --- cpukit/libmisc/rtems-fdt/rtems-fdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/libmisc/rtems-fdt/rtems-fdt.c

Re: [PATCH 2/5] rtems-fdt.c: Fix Resource leak (CID #1437645)

2021-03-16 Thread Niteesh G. S.
On Tue, 16 Mar 2021, 1:37 am Gedare Bloom, wrote: > This one looks ok to me, Niteesh? > +1 The below question is not related to this patch. Out of interest, I started going through the code and I am a bit confused in the following statement https://git.rtems.org/rtems/tree/cpukit/l

[PATCH libBSD] arm/ti/ti_pinmux: Remove TI pinmux driver

2021-03-13 Thread G S Niteesh Babu
The TI driver has been moved to RTEMS so the driver can be removed from libBSD. The following files have been removed from libBSD and moved to RTEMS. 1) ti/am335x/am335x_scm_padconf.c 2) ti/am335x/am335x_scm_padconf.h 3) ti/ti_pinmux.c 4) ti/ti_pinmux.h Update #3784 ---

Re: [PATCH 4/4] bsp/beagle: Ported Beagle pinmux driver to RTEMS

2021-03-13 Thread Niteesh G. S.
that the driver works in libBSD too. I kindly request people owning beagle hardware to test the driver. I also apologies for the long inactivity, I was consumed with other activities which left me no free time to work on this post-GSoC. Thanks, Niteesh. On Sat, Mar 13, 2021 at 4:32 PM G S Niteesh

[PATCH 3/4] bsps/beagle: Added SOC detection using FDT

2021-03-13 Thread G S Niteesh Babu
*/ + +/** + * @file + * + * @ingroup arm_Beagle + * + * @brief + */ + +/* + * Copyright (C) <2020> Niteesh Babu + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistrib

[PATCH 2/4] bsp/beagle: Import Beagle pinmux from FreeBSD

2021-03-13 Thread G S Niteesh Babu
This patch imports the beagle pinmux driver from FreeBSD into RTEMS. Previously this driver was placed in RTEMS-libBSD but this caused double initialization of few pins once during RTEMS initialization and second time during libBSD initialization. The following patches port the driver from FreeBSD

[PATCH 1/4] bsps/shared/ofw: Add rtems_ofw_is_node_compatible

2021-03-13 Thread G S Niteesh Babu
This patch extends the RTEMS OFW API by adding rtems_ofw_find_device_by_compat This function checks if a node has the expected compatible property. --- bsps/include/ofw/ofw.h | 17 + bsps/shared/ofw/ofw.c | 12 2 files changed, 29 insertions(+) diff --git

[PATCH 0/4] Import and Port Beagle pinmux driver

2021-03-13 Thread G S Niteesh Babu
The following series of patches import and port the beagle pinmux driver from FreeBSD to RTEMS. Porting this driver will avoid double initialization of pin multiplexers once during RTEMS initialization and second time during libBSD initialization. UPDATE #3782 G S Niteesh Babu (4): bsps

Re: [PATCH v2 0/4] bsps/shared/ofw: Bug and Coverity defect fixes

2021-02-09 Thread Niteesh G. S.
Hello, Thank's to both of you for reviewing and pushing the patches :) On Tue, Feb 9, 2021 at 2:02 AM Joel Sherrill wrote: > > > On Mon, Feb 8, 2021, 2:27 PM Christian Mauderer wrote: > >> Hello Gedare and Niteesh, >> >> the patches look fine. I pushe

[PATCH v2 3/4] bsps/shared/ofw: Make rtems_ofw_get_effective_phandle iterative

2021-02-06 Thread G S Niteesh Babu
Refactored recursive rtems_ofw_get_effective_phandle into a iterative function. --- bsps/shared/ofw/ofw.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/bsps/shared/ofw/ofw.c b/bsps/shared/ofw/ofw.c index 886ad0252b..78576ecf45 100644 --- a/bsps/shared/ofw/ofw.c +++

[PATCH v2 4/4] bsps/shared/ofw: Bug fixes

2021-02-06 Thread G S Niteesh Babu
Fixed bugs in rtems_ofw_get_prop, rtems_ofw_get_prop_len and removed hardcoded value. --- bsps/shared/ofw/ofw.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/bsps/shared/ofw/ofw.c b/bsps/shared/ofw/ofw.c index 78576ecf45..1c3a81785d 100644 --- a/bsps/shared/ofw/ofw.c

[PATCH v2 0/4] bsps/shared/ofw: Bug and Coverity defect fixes

2021-02-06 Thread G S Niteesh Babu
Update since v1: Using strlcpy instead of memcpy The following series of patches fix bugs and coverity reported defect in bsps/shared/ofw.c. G S Niteesh Babu (4): bsps/shared/ofw: Fix coverity reported defects bsps/shared/ofw: Use strlcpy instead of strncpy bsps/shared/ofw: Make

[PATCH v2 1/4] bsps/shared/ofw: Fix coverity reported defects

2021-02-06 Thread G S Niteesh Babu
Fixed use after free and null pointer dereference defects FIXES: 1) CID 1472601 (NULL_RETURNS) 2) CID 1472600 (USE_AFTER_FREE) 3) CID 1472599 (USE_AFTER_FREE) 4) CID 1472598 (USE_AFTER_FREE) 5) CID 1472596 (USE_AFTER_FREE) The below two defects have to marked false positive 1) CID 1472597

[PATCH v2 2/4] bsps/shared/ofw: Use strlcpy instead of strncpy

2021-02-06 Thread G S Niteesh Babu
Changed rtems_ofw_get_prop to use strlcpy instead of strncpy to ensure the buffer is null terminated incase of overflow. --- bsps/shared/ofw/ofw.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/bsps/shared/ofw/ofw.c b/bsps/shared/ofw/ofw.c index

Re: [PATCH 2/4] bsps/shared/ofw: Use memcpy instead of strncpy

2021-02-05 Thread Niteesh G. S.
On Fri, Feb 5, 2021 at 11:52 PM Gedare Bloom wrote: > > > On Fri, Feb 5, 2021 at 10:41 AM G S Niteesh Babu > wrote: > >> Changed rtems_ofw_get_prop to use memcpy instead of strncpy >> --- >> bsps/shared/ofw/ofw.c | 10 +- >> 1 file changed, 9

Re: [PATCH 2/4] bsps/shared/ofw: Use memcpy instead of strncpy

2021-02-05 Thread Niteesh G. S.
Hello Christian, On Sat, Feb 6, 2021 at 2:33 AM Christian Mauderer wrote: > On 05/02/2021 19:22, Gedare Bloom wrote: > > > > > > On Fri, Feb 5, 2021 at 10:41 AM G S Niteesh Babu > <mailto:niteesh...@gmail.com>> wrote: > > > > Changed rtems_

Re: [PATCH 3/4] bsps/shared/ofw: Make rtems_ofw_get_effective_phandle iterative

2021-02-05 Thread Niteesh G. S.
Hello Gedare, On Fri, Feb 5, 2021 at 11:53 PM Gedare Bloom wrote: > > > On Fri, Feb 5, 2021 at 10:41 AM G S Niteesh Babu > wrote: > >> Refactored recursive rtems_ofw_get_effective_phandle into a >> iterative function. >> --- >> bsps/shared/ofw/of

[PATCH 4/4] bsps/shared/ofw: Bug fixes

2021-02-05 Thread G S Niteesh Babu
Fixed bugs in rtems_ofw_get_prop, rtems_ofw_get_prop_len and removed hardcoded value. --- bsps/shared/ofw/ofw.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/bsps/shared/ofw/ofw.c b/bsps/shared/ofw/ofw.c index e3626747fa..8b7f77311d 100644 --- a/bsps/shared/ofw/ofw.c

[PATCH 3/4] bsps/shared/ofw: Make rtems_ofw_get_effective_phandle iterative

2021-02-05 Thread G S Niteesh Babu
Refactored recursive rtems_ofw_get_effective_phandle into a iterative function. --- bsps/shared/ofw/ofw.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/bsps/shared/ofw/ofw.c b/bsps/shared/ofw/ofw.c index 9dec310247..e3626747fa 100644 --- a/bsps/shared/ofw/ofw.c +++

[PATCH 2/4] bsps/shared/ofw: Use memcpy instead of strncpy

2021-02-05 Thread G S Niteesh Babu
Changed rtems_ofw_get_prop to use memcpy instead of strncpy --- bsps/shared/ofw/ofw.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/bsps/shared/ofw/ofw.c b/bsps/shared/ofw/ofw.c index fa94bfbf05..9dec310247 100644 --- a/bsps/shared/ofw/ofw.c +++

[PATCH 1/4] bsps/shared/ofw: Fix coverity reported defects

2021-02-05 Thread G S Niteesh Babu
Fixed use after free and null pointer dereference defects FIXES: 1) CID 1472601 (NULL_RETURNS) 2) CID 1472600 (USE_AFTER_FREE) 3) CID 1472599 (USE_AFTER_FREE) 4) CID 1472598 (USE_AFTER_FREE) 5) CID 1472596 (USE_AFTER_FREE) The below two defects have to marked false positive 1) CID 1472597

[PATCH 0/4] bsps/shared/ofw: Bug and Coverity defect fixes

2021-02-05 Thread G S Niteesh Babu
The following series of patches fix bugs and coverity reported defect in bsps/shared/ofw.c. G S Niteesh Babu (4): bsps/shared/ofw: Fix coverity reported defects bsps/shared/ofw: Use memcpy instead of strncpy bsps/shared/ofw: Make rtems_ofw_get_effective_phandle iterative bsps/shared/ofw

Re: [PATCH v3] bsps/shared/ofw: Fix coverity reported defects

2021-02-05 Thread Niteesh G. S.
On Fri, Feb 5, 2021 at 12:22 AM Christian Mauderer wrote: > > > On 04/02/2021 17:34, Gedare Bloom wrote: > > > > > > On Thu, Feb 4, 2021 at 1:58 AM Niteesh G. S. > <mailto:niteesh...@gmail.com>> wrote: > > > > > > > >

Re: [PATCH v3] bsps/shared/ofw: Fix coverity reported defects

2021-02-04 Thread Niteesh G. S.
On Thu, Feb 4, 2021 at 1:21 AM Gedare Bloom wrote: > > > On Wed, Feb 3, 2021 at 2:48 AM G S Niteesh Babu > wrote: > >> Fixed use after free and null pointer dereference defects >> >> FIXES: >> 1) CID 1472601 (NULL_RETURNS) >> 2) CID 1472600 (USE_

Re: [PATCH docs] user: remove old build system cmd

2021-02-03 Thread Niteesh G. S.
ection under quick start. mkdir -p $HOME/quick-start/build/b-erc32 > On Wed, Feb 3, 2021, 11:33 AM Gedare Bloom wrote: > >> pushed, thx >> >> On Wed, Feb 3, 2021 at 10:27 AM G S Niteesh Babu >> wrote: >> >>> --- >>> user/start/gsoc.rs

Re: [PATCH v3] bsps/shared/ofw: Fix coverity reported defects

2021-02-03 Thread Niteesh G. S.
On Wed, Feb 3, 2021 at 11:05 PM Gedare Bloom wrote: > Is this second patch ok to check? > Yes, please go through this patch. Again adding a link to the patch to avoid confusion https://lists.rtems.org/pipermail/devel/2021-February/064203.html Thanks, Niteesh. > On Wed, Feb 3, 2021 a

[PATCH docs] user: remove old build system cmd

2021-02-03 Thread G S Niteesh Babu
--- user/start/gsoc.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/user/start/gsoc.rst b/user/start/gsoc.rst index f8167b9..2c7df7c 100644 --- a/user/start/gsoc.rst +++ b/user/start/gsoc.rst @@ -114,8 +114,8 @@ running `make` in the BSP build directory. ..

Re: Unable to use make command to build "Hello world" Program

2021-02-03 Thread Niteesh G. S.
src/rtems' as per the output from waf. Once that is done you should find your executable in /home/rohan/devlopment/src/rtems/build/sparc/erc32/testsuites/samples PS: I haven't tried these commands, maybe the directories differ but the commands should be same. Thanks, Niteesh. On Wed, Fe

[PATCH v3] bsps/shared/ofw: Fix coverity reported defects

2021-02-03 Thread G S Niteesh Babu
Fixed use after free and null pointer dereference defects FIXES: 1) CID 1472601 (NULL_RETURNS) 2) CID 1472600 (USE_AFTER_FREE) 3) CID 1472599 (USE_AFTER_FREE) 4) CID 1472598 (USE_AFTER_FREE) 5) CID 1472596 (USE_AFTER_FREE) 6) CID 1472597 (ARRAY_VS_SINGLETON) 7) CID 1472595 (ARRAY_VS_SINGLETON)

Re: [PATCH v2] bsps/shared/ofw: Fix coverity reported defects

2021-02-03 Thread Niteesh G. S.
Hello, Please ignore this patch. Thanks, Niteesh. On Wed, Feb 3, 2021 at 3:14 PM G S Niteesh Babu wrote: > Fixed use after free and null pointer dereference defects > > FIXES: > 1) CID 1472601 (NULL_RETURNS) > 2) CID 1472600 (USE_AFTER_FREE) > 3) CID 1472599 (USE_AFTER_FREE

[PATCH v2] bsps/shared/ofw: Fix coverity reported defects

2021-02-03 Thread G S Niteesh Babu
Fixed use after free and null pointer dereference defects FIXES: 1) CID 1472601 (NULL_RETURNS) 2) CID 1472600 (USE_AFTER_FREE) 3) CID 1472599 (USE_AFTER_FREE) 4) CID 1472598 (USE_AFTER_FREE) 5) CID 1472596 (USE_AFTER_FREE) 6) CID 1472597 (ARRAY_VS_SINGLETON) 7) CID 1472595 (ARRAY_VS_SINGLETON)

Re: [PATCH] bsps/shared/ofw: Fix coverity reported defects

2021-01-29 Thread Niteesh G. S.
Hello Christian, On Fri, Jan 29, 2021 at 1:47 PM Christian MAUDERER < christian.maude...@embedded-brains.de> wrote: > Hello Niteesh, > > Am 29.01.21 um 07:33 schrieb Niteesh G. S.: > > Hello, > > > > https://lists.rtems.org/pipermail/devel/2021-January/064115.

Re: [patch libBSD] dev/ofw: Use RTEMS OFW FDT implementation

2021-01-28 Thread Niteesh G. S.
Hello Christian, On Thu, Jan 28, 2021 at 1:15 PM Christian MAUDERER < christian.maude...@embedded-brains.de> wrote: > Am 28.01.21 um 06:28 schrieb Chris Johns: > > On 28/1/21 4:12 am, Niteesh G. S. wrote: > >> Hello Christian, > >> > >> On Wed,

Re: [PATCH] bsps/shared/ofw: Fix coverity reported defects

2021-01-28 Thread Niteesh G. S.
. But coverity reports this as an defect how can I fix this? Thanks, Niteesh. On Fri, Jan 29, 2021 at 11:48 AM G S Niteesh Babu wrote: > Fixed use after free and null pointer dereference defects > > FIXES: > 1) CID 1472601 (NULL_RETURNS) > 2) CID 1472600 (USE_AFTER_FREE) &

[PATCH] bsps/shared/ofw: Fix coverity reported defects

2021-01-28 Thread G S Niteesh Babu
Fixed use after free and null pointer dereference defects FIXES: 1) CID 1472601 (NULL_RETURNS) 2) CID 1472600 (USE_AFTER_FREE) 3) CID 1472599 (USE_AFTER_FREE) 4) CID 1472598 (USE_AFTER_FREE) 5) CID 1472596 (USE_AFTER_FREE) --- bsps/shared/ofw/ofw.c | 10 +- 1 file changed, 5

Re: devel Digest, Vol 110, Issue 38

2021-01-28 Thread Niteesh G. S.
approach? On Thu, Jan 28, 2021 at 11:10 AM Chris Johns wrote: > On 28/1/21 4:25 am, Niteesh G. S. wrote: > > Date: Fri, 22 Jan 2021 04:28:37 +1100 > > From: Chris Johns mailto:chr...@rtems.org>> > > To: devel@rtems.org <mailto:devel@rtems.org> > >

Re: devel Digest, Vol 110, Issue 38

2021-01-27 Thread Niteesh G. S.
> > Date: Fri, 22 Jan 2021 04:28:37 +1100 > From: Chris Johns > To: devel@rtems.org > Subject: Re: [patch libBSD] dev/ofw: Use RTEMS OFW FDT implementation > Message-ID: > Content-Type: text/plain; charset=utf-8 > > On 20/1/21 7:31 pm, G S Niteesh Babu wrote: >

Re: [patch libBSD] dev/ofw: Use RTEMS OFW FDT implementation

2021-01-27 Thread Niteesh G. S.
Hello Christian, On Wed, Jan 27, 2021 at 3:59 PM Christian MAUDERER < christian.maude...@embedded-brains.de> wrote: > Hello Niteesh, > > I think there is an open Question from Chris for that patch: > > https://lists.rtems.org/pipermail/devel/2021-January/063988.html I nev

Re: [patch libBSD] dev/ofw: Use RTEMS OFW FDT implementation

2021-01-27 Thread Niteesh G. S.
ping. On Wed, Jan 20, 2021 at 2:01 PM G S Niteesh Babu wrote: > This commit modifies the OFW interface to the RTEMS FDT > implementation instead of the default FreeBSD. > --- > freebsd/sys/dev/ofw/openfirm.c| 2 ++ > freebsd/sys/dev/ofw/openfirm.h

[patch libBSD] dev/ofw: Use RTEMS OFW FDT implementation

2021-01-20 Thread G S Niteesh Babu
This commit modifies the OFW interface to the RTEMS FDT implementation instead of the default FreeBSD. --- freebsd/sys/dev/ofw/openfirm.c| 2 ++ freebsd/sys/dev/ofw/openfirm.h| 9 .../machine/rtems-bsd-kernel-namespace.h | 22 --- 3

Re: [PATCH] Implement FreeBSD helper structures

2021-01-20 Thread Niteesh G. S.
Hello Sebastian, On Wed, Jan 20, 2021 at 10:47 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > Hello Niteesh, > > On 19/01/2021 17:20, G S Niteesh Babu wrote: > > The following structures and functions have been implemented to > > make porting of

Re: [PATCH] Implement FreeBSD helper structures

2021-01-20 Thread Niteesh G. S.
implements functions and structures that are quite frequently used but also have a simple RTEMS implementation. The real use of this patch can be seen in the ported beagle pinmux driver https://github.com/gs-niteesh/rtems/commit/42590fb1c8c8e4228500f995ff6a7c0e0e607133 I have also written about the things

[PATCH] Implement FreeBSD helper structures

2021-01-19 Thread G S Niteesh Babu
020> Niteesh Babu + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the fol

Re: [PATCH v3 2/2] libtests/ofw01: Added a test for RTEMS OFW

2020-12-27 Thread Niteesh G. S.
Hello Christian, On Sun, Dec 27, 2020 at 2:39 PM Christian Mauderer wrote: > Hello Niteesh, > > I pushed the two patches. > Thanks for pushing the patches. Thanks, Niteesh. > Best regards > > Christian > > On 22/12/2020 19:01, Niteesh G. S. wrote: > > Hello

Re: [PATCH v3 2/2] libtests/ofw01: Added a test for RTEMS OFW

2020-12-22 Thread Niteesh G. S.
Hello Christian, On Tue, Dec 22, 2020 at 6:33 PM Christian Mauderer wrote: > Hello Niteesh, > > On 19/12/2020 16:57, Niteesh G. S. wrote: > > Hello Christian, > > > > On Sat, Dec 19, 2020 at 7:11 PM Christian Mauderer > <mailto:o...@c-mauderer.de&g

Re: [PATCH v3 2/2] libtests/ofw01: Added a test for RTEMS OFW

2020-12-19 Thread Niteesh G. S.
Hello Christian, On Sat, Dec 19, 2020 at 7:11 PM Christian Mauderer wrote: > Hello Niteesh, > > sorry, I somehow forget to check that patch set. I'll do it in the next > few days. > No problem, please take your time :). If you are on vacation, enjoy your vacations :)

Re: [PATCH v3 2/2] libtests/ofw01: Added a test for RTEMS OFW

2020-12-17 Thread Niteesh G. S.
ping. On Fri, Dec 4, 2020 at 1:41 PM G S Niteesh Babu wrote: > This commit adds a basic test that tests all the implemented > RTEMS OFW functions. > --- > spec/build/testsuites/libtests/grp.yml | 2 + > spec/build/testsuites/libtests/ofw01.yml | 21 +++ > testsuites/lib

Re: [PATCH v3 1/2] bsps/shared/ofw: Implement RTEMS OFW interface

2020-12-04 Thread Niteesh G. S.
Hello, In this set of patches, I have added a test header which allows us to reinitialize the OFW API with test FDT. Other than that, I have also added a few explicit casts to suppress warnings. Thanks, Niteesh On Fri, Dec 4, 2020 at 1:41 PM G S Niteesh Babu wrote: > RTEMS OFW is a FDT o

[PATCH v3 2/2] libtests/ofw01: Added a test for RTEMS OFW

2020-12-04 Thread G S Niteesh Babu
+++ b/spec/build/testsuites/libtests/ofw01.yml @@ -0,0 +1,21 @@ +SPDX-License-Identifier: CC-BY-SA-4.0 OR BSD-2-Clause +build-type: test-program +cflags: [] +copyrights: +- Copyright (C) 2020 Niteesh G S +cppflags: [] +cxxflags: [] +enabled-by: true +features: c cprogram +includes: [] +ldflags: +- -Wl

[PATCH v3 1/2] bsps/shared/ofw: Implement RTEMS OFW interface

2020-12-04 Thread G S Niteesh Babu
of OpenFirmWare Interface. + * + * RTEMS OFW is a FDT only implementation of the OpenFirmWare interface. + * This API is created to be compatible with FreeBSD OpenFirmWare interface. + * The main intention is to make porting of FreeBSD drivers to RTEMS easier. + */ + +/* + * Copyright (C) 2020 Niteesh

Re: [PATCH v2 2/2] libtests/ofw01: Added a test for RTEMS OFW

2020-11-20 Thread Niteesh G. S.
sorry since it has been a couple of months now I don't exactly remember what all I tried. > > Am 03.11.20 um 19:18 schrieb G S Niteesh Babu: > > Added a basic test for the implemented RTEMS OFW > > API. > > --- > > spec/build/testsuites/libtests/grp.yml

Re: [PATCH v2 1/2] bsps/shared/ofw: Implement RTEMS OFW interface

2020-11-16 Thread Niteesh G. S.
ys, I'll commit them. > Thanks for testing the patches. Thanks, Niteesh. > Best regards > > Christian > > On 03/11/2020 19:18, G S Niteesh Babu wrote: > > RTEMS OFW is a FDT only implementation of the OpenFirmWare > > interface. This API is created to be compa

Re: [PATCH v2 2/2] libtests/ofw01: Added a test for RTEMS OFW

2020-11-09 Thread Niteesh G. S.
Hello Christian, On Tue, Nov 10, 2020 at 12:59 AM Christian Mauderer wrote: > Hello Niteesh, > > I've seen the patches. I have to run a test at least on one BSP with and > one without a FDT to make sure they don't break test runs. > OK Great. Please take your time. I just want

Re: [PATCH v2 2/2] libtests/ofw01: Added a test for RTEMS OFW

2020-11-08 Thread Niteesh G. S.
Hello, Pinging again incase this patch missed your attention. Thanks, Niteesh. On Tue, Nov 3, 2020 at 11:49 PM G S Niteesh Babu wrote: > Added a basic test for the implemented RTEMS OFW > API. > --- > spec/build/testsuites/libtests/grp.yml | 2 + > spec/build/testsuites

[PATCH v2 1/2] bsps/shared/ofw: Implement RTEMS OFW interface

2020-11-03 Thread G S Niteesh Babu
interface. + * This API is created to be compatible with FreeBSD OpenFirmWare interface. + * The main intention is to make porting of FreeBSD drivers to RTEMS easier. + */ + +/* + * Copyright (C) 2020 Niteesh Babu G S + * + * Redistribution and use in source and binary forms, with or without

[PATCH v2 2/2] libtests/ofw01: Added a test for RTEMS OFW

2020-11-03 Thread G S Niteesh Babu
/libtests/ofw01.yml @@ -0,0 +1,21 @@ +SPDX-License-Identifier: CC-BY-SA-4.0 OR BSD-2-Clause +build-type: test-program +cflags: [] +copyrights: +- Copyright (C) 2020 Niteesh G S +cppflags: [] +cxxflags: [] +enabled-by: true +features: c cprogram +includes: [] +ldflags: +- -Wl,--wrap=bsp_fdt_get +links

Re: [PATCH v1 1/2] bsps/shared/ofw: Implement RTEMS OFW interface

2020-11-02 Thread Niteesh G. S.
ping. On Thu, Sep 24, 2020 at 9:00 AM Niteesh G. S. wrote: > Hello, > > On Sat, Sep 19, 2020 at 4:13 PM Christian Mauderer > wrote: > >> Hello Niteesh, >> >> sorry for adding another delay: I think the new build system needs a bit >> of time to sett

Re: Beagle SPI driver update

2020-10-14 Thread Niteesh G. S.
Hello, Update: I got the condition in the while loop wrong. After fixing this it works now. I'll try to post a working patch of the SPI driver as soon as possible. Thanks, Niteesh On Wed, Oct 14, 2020 at 12:39 PM Niteesh G. S. wrote: > Hello, > > First of all really sorry for the l

Beagle SPI driver update

2020-10-14 Thread Niteesh G. S.
down the problem I decided to write a simple polled driver. This driver can be found here https://github.com/gs-niteesh/rtems/blob/8a75a2f5eb6b4eb852da9563b53b6c021463a8c7/bsps/arm/beagle/spi/simple-spi.c Commit: https://github.com/gs-niteesh/rtems/commit/8a75a2f5eb6b4eb852da9563b53b6c021463a8c7

Re: [PATCH v1 1/2] bsps/shared/ofw: Implement RTEMS OFW interface

2020-09-23 Thread Niteesh G. S.
Hello, On Sat, Sep 19, 2020 at 4:13 PM Christian Mauderer wrote: > Hello Niteesh, > > sorry for adding another delay: I think the new build system needs a bit > of time to settle. As soon as there are some more PASS in the table that > Sebastian created [1] (especially for beagle

[RTEMS-libBSD OFW v1] dev/ofw: Use RTEMS OFW FDT implementation

2020-09-16 Thread G S Niteesh Babu
This commit modifies the OFW interface to the RTEMS FDT implementation instead of the default FreeBSD. --- freebsd/sys/dev/ofw/openfirm.c| 2 ++ freebsd/sys/dev/ofw/openfirm.h| 9 .../machine/rtems-bsd-kernel-namespace.h | 22 --- 3

Re: [PATCH v1 1/2] bsps/shared/ofw: Implement RTEMS OFW interface

2020-09-16 Thread Niteesh G. S.
. Thanks, Niteesh. On Wed, Sep 16, 2020 at 10:33 PM G S Niteesh Babu wrote: > RTEMS OFW is a FDT only implementation of the OpenFirmWare > interface. This API is created to be compatible with FreeBSD > OpenFirmWare interface. The main intention is to make > porting of FreeBSD drivers to

[PATCH v1 2/2] libtests/ofw01: Added a test for RTEMS OFW

2020-09-16 Thread G S Niteesh Babu
+++ b/spec/build/testsuites/libtests/ofw01.yml @@ -0,0 +1,21 @@ +SPDX-License-Identifier: CC-BY-SA-4.0 OR BSD-2-Clause +build-type: test-program +cflags: [] +copyrights: +- Copyright (C) 2020 Niteesh G S +cppflags: [] +cxxflags: [] +enabled-by: true +features: c cprogram +includes: [] +ldflags: +- -Wl

[PATCH v1 1/2] bsps/shared/ofw: Implement RTEMS OFW interface

2020-09-16 Thread G S Niteesh Babu
interface. + * This API is created to be compatible with FreeBSD OpenFirmWare interface. + * The main intention is to make porting of FreeBSD drivers to RTEMS easier. + */ + +/* + * Copyright (C) 2020 Niteesh Babu G S + * + * Redistribution and use in source and binary forms, with or without

Re: GSoC 2020: Final Report (Beagle BSP: Add FDT based initialization)

2020-08-31 Thread Niteesh G. S.
Hello, I have submitted the final eval. Thank you, everyone, for all the support throughout the project. Though I couldn't get any of my patches merged. I expect to spend a lot of time post-GSoC to get the work merged and contribute even more :). Thanks, Niteesh. On Sun, Aug 30, 2020 at 8:46 PM

Re: GSoC 2020: Final Report (Beagle BSP: Add FDT based initialization)

2020-08-30 Thread Niteesh G. S.
Hello, On Sun, Aug 30, 2020 at 4:12 PM Christian Mauderer wrote: > Hello Niteesh, > > On 30/08/2020 08:58, Niteesh G. S. wrote: > > Hello, > > > > I have updated the blog to contain the links to the commits > > instead of the branches. Please have a look again.

  1   2   3   4   5   >