Re: [PATCH] (2 commits squashed into one) Beagle BSP for review

2014-11-04 Thread Ben Gras
I just checked, it runs on the bbxm hardware too, not just the emulator. On Mon, Nov 3, 2014 at 1:20 PM, Ben Gras wrote: > All, > > Ok, as promised, I rebased and re-tested and have found & included a > portable way of making the SD card image (included in sdcard.sh), to be > merged with RSB (i

Re: [PATCH] (2 commits squashed into one) Beagle BSP for review

2014-11-03 Thread Ben Gras
Good idea, I did it. On Mon, Nov 3, 2014 at 10:32 PM, Gedare Bloom wrote: > Please send a note to rtems-users, some may be interested to hear this > addition. -Gedare > > On Mon, Nov 3, 2014 at 4:28 PM, Ben Gras wrote: > > Indeed. I did right away verify I can build & run & test everything for

Re: [PATCH] (2 commits squashed into one) Beagle BSP for review

2014-11-03 Thread Gedare Bloom
Please send a note to rtems-users, some may be interested to hear this addition. -Gedare On Mon, Nov 3, 2014 at 4:28 PM, Ben Gras wrote: > Indeed. I did right away verify I can build & run & test everything for the > beaglebones and the bbxm from mainline. So that seems to have gone fine. > > The

Re: [PATCH] (2 commits squashed into one) Beagle BSP for review

2014-11-03 Thread Ben Gras
Indeed. I did right away verify I can build & run & test everything for the beaglebones and the bbxm from mainline. So that seems to have gone fine. The supporting tools and RSB stuff I am in contact with Chris about. On Mon, Nov 3, 2014 at 10:23 PM, Joel Sherrill wrote: > > On 11/3/2014 3:06

Re: [PATCH] (2 commits squashed into one) Beagle BSP for review

2014-11-03 Thread Joel Sherrill
On 11/3/2014 3:06 PM, Ben Gras wrote: > All, > > > Joel merged these and I updated my blog post to reflect the mainline > repo. Thanks Joel! > Thank you Ben for the nice submission!!! Now to make sure it is reproducible from here and we have merged all the bits into the tools, etc. > On Mon, Nov

Re: [PATCH] (2 commits squashed into one) Beagle BSP for review

2014-11-03 Thread Ben Gras
All, Joel merged these and I updated my blog post to reflect the mainline repo. Thanks Joel! On Mon, Nov 3, 2014 at 8:40 PM, Ben Gras wrote: > All, > > I have new patches with some last-minute smoothings added; removed > obsolete beagle.cfg, TODO, and separated the more generic ARM headers int

Re: [PATCH] (2 commits squashed into one) Beagle BSP for review

2014-11-03 Thread Gedare Bloom
Hi, I don't have time to review, but am OK in principle with committing this code as it is tested, with the caveat that my previous comments be addressed post-merge. If you have a diff / commits on top of what you sent before, I'd be glad to give those a quick look. Thanks for your contribution!

Re: [PATCH] (2 commits squashed into one) Beagle BSP for review

2014-08-30 Thread Ben Gras
All, OK, that seems like a fruitful way to proceed to me. Then I will do some minor cleanups, rebase, do all the tests again, and re-submit. There's just one problem I know of that I want to fix before the first commit happens, and that is that the FAT fs made by mtools doesn't boot on the HW it

Re: [PATCH] (2 commits squashed into one) Beagle BSP for review

2014-08-20 Thread Brandon Matthews
Thanks for the update and input, all. I'll make sure it's included in our current issue tracking. FYI, work on this has briefly stalled, as Ben is on holiday and I'm working on wrapping up my current employment in favor of something new. I intend to begin working again when I have some free time n

Re: [PATCH] (2 commits squashed into one) Beagle BSP for review

2014-08-20 Thread Ritesh Harjani
Hi Ben/Joel, On Wed, Aug 20, 2014 at 10:16 PM, Joel Sherrill wrote: > > On 8/20/2014 11:23 AM, Ritesh Harjani wrote: > > Hi Ben, > > Great work I must admit. > > I just have few question/suggestion. I am new to the community so high > chances that I might be wrong here, but I noticed something

Re: [PATCH] (2 commits squashed into one) Beagle BSP for review

2014-08-20 Thread Joel Sherrill
On 8/20/2014 11:23 AM, Ritesh Harjani wrote: > Hi Ben, > > Great work I must admit. > > I just have few question/suggestion. I am new to the community so high > chances that I might be wrong here, but I noticed something so I > thought I should tell/ask. > > > diff --git a/c/src/lib/libbsp/arm/b

Re: [PATCH] (2 commits squashed into one) Beagle BSP for review

2014-08-20 Thread Ritesh Harjani
Hi Ben, Great work I must admit. I just have few question/suggestion. I am new to the community so high chances that I might be wrong here, but I noticed something so I thought I should tell/ask. diff --git a/c/src/lib/libbsp/arm/beagle/include/bsp.h b/c/src/lib/libbsp/arm/beagle/include/bsp.h

Re: [PATCH] (2 commits squashed into one) Beagle BSP for review

2014-08-20 Thread Gedare Bloom
Ben, As far as getting this merged, all of my comments can be done as a follow-on commit. -Gedare On Thu, Jul 24, 2014 at 4:28 PM, Ben Gras wrote: > Thanks for the fast & detailed review. Let me get back to it/you. > > In the meantime, any other feedback? From anyone I mean. > > > > On Thu, Jul 2

Re: [PATCH] (2 commits squashed into one) Beagle BSP for review

2014-07-24 Thread Ben Gras
Thanks for the fast & detailed review. Let me get back to it/you. In the meantime, any other feedback? From anyone I mean. On Thu, Jul 24, 2014 at 4:45 PM, Gedare Bloom wrote: > Hi Ben, > Great work. I have a few comments. I skipped the i2c.h and i2c.c > files. Most of my comments are about s

Re: [PATCH] (2 commits squashed into one) Beagle BSP for review

2014-07-24 Thread Gedare Bloom
Hi Ben, Great work. I have a few comments. I skipped the i2c.h and i2c.c files. Most of my comments are about style and a few requests to refactor some of the larger files. The refactoring can be added to your TODO if you like. Please fix the style issues if it is not a burden. +++ b/c/src/lib/lib