Re: [PATCH] bsps/shared/ofw: Added and Documented RTEMS OFW interface

On Thu, Aug 13, 2020 at 4:31 AM Niteesh G. S. wrote: > > Hello, > On Thu, Aug 13, 2020 at 12:09 PM Christian Mauderer > wrote: >> >> Hello Niteesh, >> >> On 13/08/2020 07:05, Niteesh G. S. wrote: >> > On Thu, Aug 13, 2020 at 12:36 AM Gedare Bloom > > > wrote: >> > >> >

Re: [PATCH] bsps/shared/ofw: Added and Documented RTEMS OFW interface

Hello, On Thu, Aug 13, 2020 at 12:09 PM Christian Mauderer < christian.maude...@embedded-brains.de> wrote: > Hello Niteesh, > > On 13/08/2020 07:05, Niteesh G. S. wrote: > > On Thu, Aug 13, 2020 at 12:36 AM Gedare Bloom > > wrote: > > > > I make a few comments below

Re: [PATCH] bsps/shared/ofw: Added and Documented RTEMS OFW interface

Hello Niteesh, On 13/08/2020 07:05, Niteesh G. S. wrote: > On Thu, Aug 13, 2020 at 12:36 AM Gedare Bloom > wrote: > > I make a few comments below for you to consider. At a high level, I > think the interface looks reasonable, although plainly mimics the >

Re: [PATCH] bsps/shared/ofw: Added and Documented RTEMS OFW interface

On Thu, Aug 13, 2020 at 12:36 AM Gedare Bloom wrote: > I make a few comments below for you to consider. At a high level, I > think the interface looks reasonable, although plainly mimics the > freebsd naming conventions. I wonder if we should prefer our naming > conventions, which is to aim to

Re: [PATCH] bsps/shared/ofw: Added and Documented RTEMS OFW interface

I make a few comments below for you to consider. At a high level, I think the interface looks reasonable, although plainly mimics the freebsd naming conventions. I wonder if we should prefer our naming conventions, which is to aim to use _ to separate different words, and to limit use of

Re: [PATCH] bsps/shared/ofw: Added and Documented RTEMS OFW interface

Hello, I have resent the patches onto the mailing list as per Gedare's suggestion in the IRC. The current implementation is not 100% OF compliant. I have avoided a few functions like OF_call, OF_write etc since these don't have a valid implementation in the FDT implementation of OF interface.

[PATCH] bsps/shared/ofw: Added and Documented RTEMS OFW interface

--- bsps/shared/dev/ofw/ofw.c | 0 bsps/shared/dev/ofw/ofw.h | 437 ++ 2 files changed, 437 insertions(+) create mode 100644 bsps/shared/dev/ofw/ofw.c create mode 100644 bsps/shared/dev/ofw/ofw.h diff --git a/bsps/shared/dev/ofw/ofw.c