Re: [PATCH] build: Add "family/" prefix to BSP familiy enable

2021-07-22 Thread Chris Johns
> On 22 Jul 2021, at 6:53 pm, Sebastian Huber > wrote: >> On 22/07/2021 10:47, Chris Johns wrote: >>> On 22/7/21 6:37 pm, Sebastian Huber wrote: >>> On 22/07/2021 10:33, Chris Johns wrote: >> and so the arch part is not >> really needed. My concern is this type code ... >> >>

Re: [PATCH] build: Add "family/" prefix to BSP familiy enable

2021-07-22 Thread Sebastian Huber
On 22/07/2021 10:47, Chris Johns wrote: On 22/7/21 6:37 pm, Sebastian Huber wrote: On 22/07/2021 10:33, Chris Johns wrote: and so the arch part is not really needed. My concern is this type code ... https://git.rtems.org/rtems_waf/tree/rtems.py#n758 that breaks. Is this an issue? I think a

Re: [PATCH] build: Add "family/" prefix to BSP familiy enable

2021-07-22 Thread Chris Johns
On 22/7/21 6:37 pm, Sebastian Huber wrote: > On 22/07/2021 10:33, Chris Johns wrote: and so the arch part is not really needed. My concern is this type code ... https://git.rtems.org/rtems_waf/tree/rtems.py#n758 that breaks. Is this an issue? I think a single `/` in a

Re: [PATCH] build: Add "family/" prefix to BSP familiy enable

2021-07-22 Thread Sebastian Huber
On 22/07/2021 10:33, Chris Johns wrote: and so the arch part is not really needed. My concern is this type code ... https://git.rtems.org/rtems_waf/tree/rtems.py#n758 that breaks. Is this an issue? I think a single `/` in a BSP or family is cleaner. Why is this an issue? This BSP family stuff

Re: [PATCH] build: Add "family/" prefix to BSP familiy enable

2021-07-22 Thread Chris Johns
On 22/7/21 4:44 pm, Sebastian Huber wrote: > On 22/07/2021 08:37, Chris Johns wrote: >> On 22/7/21 4:20 pm, Sebastian Huber wrote: >>> On 22/07/2021 02:39, Chris Johns wrote: On 22/7/21 5:22 am, Sebastian Huber wrote: > BSP family and BSP variant names may be equal.  This prefix avoids

Re: [PATCH] build: Add "family/" prefix to BSP familiy enable

2021-07-22 Thread Sebastian Huber
On 22/07/2021 08:37, Chris Johns wrote: On 22/7/21 4:20 pm, Sebastian Huber wrote: On 22/07/2021 02:39, Chris Johns wrote: On 22/7/21 5:22 am, Sebastian Huber wrote: BSP family and BSP variant names may be equal.  This prefix avoids ambiguity in the enabled-by expressions. ---   wscript | 2

Re: [PATCH] build: Add "family/" prefix to BSP familiy enable

2021-07-22 Thread Chris Johns
On 22/7/21 4:20 pm, Sebastian Huber wrote: > On 22/07/2021 02:39, Chris Johns wrote: >> On 22/7/21 5:22 am, Sebastian Huber wrote: >>> BSP family and BSP variant names may be equal.  This prefix avoids >>> ambiguity in the enabled-by expressions. >>> --- >>>   wscript | 2 +- >>>   1 file changed,

Re: [PATCH] build: Add "family/" prefix to BSP familiy enable

2021-07-22 Thread Sebastian Huber
On 22/07/2021 02:39, Chris Johns wrote: On 22/7/21 5:22 am, Sebastian Huber wrote: BSP family and BSP variant names may be equal. This prefix avoids ambiguity in the enabled-by expressions. --- wscript | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wscript b/wscript

Re: [PATCH] build: Add "family/" prefix to BSP familiy enable

2021-07-21 Thread Chris Johns
On 22/7/21 5:22 am, Sebastian Huber wrote: > BSP family and BSP variant names may be equal. This prefix avoids > ambiguity in the enabled-by expressions. > --- > wscript | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/wscript b/wscript > index f27dba6831..b7a0412150

[PATCH] build: Add "family/" prefix to BSP familiy enable

2021-07-21 Thread Sebastian Huber
BSP family and BSP variant names may be equal. This prefix avoids ambiguity in the enabled-by expressions. --- wscript | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wscript b/wscript index f27dba6831..b7a0412150 100755 --- a/wscript +++ b/wscript @@ -1394,7 +1394,7 @@ def