Please work on fixing the commit message for your patch locally as
discussed before, and use git-format-patch to look at how your commit
looks like in a file before you send it to the mailing list.
Use -v2 with git-format-patch to prepare the patch for submission, to
provide the email subject
adds
---
cpukit/include/rtems/posix/timer.h| 1 +
cpukit/posix/src/psxtimercreate.c | 5 +-
cpukit/posix/src/timergettime.c | 59 +--
testsuites/psxtests/psxtimer02/psxtimer.c | 26 ++
4 files changed, 63 insertions(+), 28 deletions(-)
On Sat, Jul 24, 2021 at 6:10 PM zack leung wrote:
>
> > - remaining = 0;
> > + result->tv_nsec=0;
> > + result->tv_sec=0;
> This isn't correct. result is an uninitialized pointer.
>
> So then how do I set the timespec's value to 0? I have changed the timespec
> variables i have
> - remaining = 0;
> + result->tv_nsec=0;
> + result->tv_sec=0;
This isn't correct. result is an uninitialized pointer.
So then how do I set the timespec's value to 0? I have changed the
timespec variables i have declared from pointers to regular variables.
in the original code
I concur with Gedare's comments.
I would think your commit message would be similar to the subject of the ticket.
This looks like a decent example:
https://git.rtems.org/rtems/commit/?id=6c23252cdd8ea63d0fe13d9f99b7befbf070fe80
Please update and submit. Pay attention to compiler warnings.
On
Hi Zak,
Please provide a useful first commit line. I think I've mentioned this
before, but the current guidance is found at
https://devel.rtems.org/wiki/Developer/Git#GitCommits
Put the ticket closing line within the commit message, usually on its
own line at the end of your commit message
On
---
cpukit/include/rtems/posix/timer.h | 1 +
cpukit/posix/src/psxtimercreate.c | 1 +
cpukit/posix/src/timergettime.c| 61 +++---
3 files changed, 41 insertions(+), 22 deletions(-)
diff --git a/cpukit/include/rtems/posix/timer.h
