On 03/11/14 02:59, Alan Cudmore wrote:
-libbsp_a_SOURCES += ../shared/abort/simple_abort.c
+libbsp_a_SOURCES += ../shared/abort/abort.c
Since this BSP uses the shared start.S file, I would prefer to remove
simple_abort.c and abort.c from the Makefile.am. These files should go away in
the lon
OK, that makes sense. I'll fix it and resubmit the patch. Any other ARM
BSPs?
Alan
On Nov 3, 2014 2:03 AM, "Sebastian Huber" <
sebastian.hu...@embedded-brains.de> wrote:
> On 03/11/14 02:59, Alan Cudmore wrote:
>
>> -libbsp_a_SOURCES += ../shared/abort/simple_abort.c
>> +libbsp_a_SOURCES += ../sha
On 11/3/2014 5:22 AM, Alan Cudmore wrote:
>
> OK, that makes sense. I'll fix it and resubmit the patch. Any other
> ARM BSPs?
>
The warning only shows up in these:
$ grep abort.c warnings-20141030a.txt
2
c/src/lib/libbsp/arm/rtl22xx/../shared/abort/simple_abort.c:56:6:
warning: no previous
I'm not sure any of the ARM BSPs use the abort.c or simple_abort.c, even if
they have the code included.
I don't have access to the code right now, but I will take a look at the
ARM BSPs and remove it from the ones that use the shared start.S.
If the ARM BSPs that do not use the shared start.S inc
On 05/11/14 15:35, Alan Cudmore wrote:
If the ARM BSPs that do not use the shared start.S include the code, but never
call it, I can remove it, if that is what is best. We could even remove abort.c
and simple_abort.c completely. Just let me know.
It would be best to get rid of these files.
--
On 11/5/2014 9:39 AM, Sebastian Huber wrote:
On 05/11/14 15:35, Alan Cudmore wrote:
If the ARM BSPs that do not use the shared start.S include the code,
but never
call it, I can remove it, if that is what is best. We could even
remove abort.c
and simple_abort.c completely. Just let me know.
On Sat, Nov 8, 2014 at 11:50 AM, Alan Cudmore wrote:
> On 11/5/2014 9:39 AM, Sebastian Huber wrote:
>>
>> On 05/11/14 15:35, Alan Cudmore wrote:
>>>
>>> If the ARM BSPs that do not use the shared start.S include the code, but
>>> never
>>> call it, I can remove it, if that is what is best. We coul
On 08/11/14 18:04, Gedare Bloom wrote:
On Sat, Nov 8, 2014 at 11:50 AM, Alan Cudmore wrote:
>On 11/5/2014 9:39 AM, Sebastian Huber wrote:
>>
>>On 05/11/14 15:35, Alan Cudmore wrote:
>>>
>>>If the ARM BSPs that do not use the shared start.S include the code, but
>>>never
>>>call it, I can remo