[PATCH] part of implimenting a monotonic clock in rtems part of this is not the final patch.

2021-06-09 Thread zack
From: zack --- cpukit/include/rtems/posix/timer.h| 6 ++- cpukit/posix/src/psxtimercreate.c | 5 +- cpukit/posix/src/timergettime.c | 61 --- testsuites/psxtests/psxtimer02/psxtimer.c | 26 +++--- 4 files changed, 81 insertions(+), 17 deletions

Re: [PATCH] part of implimenting a monotonic clock in rtems part of this is not the final patch.

2021-06-11 Thread Christian Mauderer
Hello Zack, you say: "part of this is not the final patch" in the subject. So what is the intention of this patch? Do you need a complete review? Is it some kind of preview and you need input? If yes: For what parts do you need input? Best regards Christian On 11/06/2021 17:20, zack_on_the

Re: [PATCH] part of implimenting a monotonic clock in rtems part of this is not the final patch.

2021-06-11 Thread zack_on_the_speed_chanel
ping Sent with ProtonMail Secure Email. ‐‐‐ Original Message ‐‐‐ On Wednesday, June 9th, 2021 at 6:27 PM, zack wrote: > From: zack zack_on_the_speed_cha...@protonmail.ch > > cpukit/include/rtems/posix/timer.h | 6 ++- > > cpukit/posix/src/psxtimercreate.c | 5 +- > > cpukit/posix/src/t

Re: [PATCH] part of implimenting a monotonic clock in rtems part of this is not the final patch.

2021-06-11 Thread zack_on_the_speed_chanel
So the intention of the patch was to implement a timer_create function for monotonic clocks. A monotonic clock is a clock that keeps track of the time that has elapsed since the Linux epoch. I did the following so far. - I added a field in the RTEMS_timer_control so that in create_timer it's ab

Re: [PATCH] part of implimenting a monotonic clock in rtems part of this is not the final patch.

2021-06-12 Thread Christian Mauderer
Hello Zack, I don't really know a lot about the timer toppic. So this is more of a style and general suggestion review. On 09/06/2021 20:27, zack wrote: From: zack --- cpukit/include/rtems/posix/timer.h| 6 ++- cpukit/posix/src/psxtimercreate.c | 5 +- cpukit/posix/src

Re: [PATCH] part of implimenting a monotonic clock in rtems part of this is not the final patch.

2021-06-15 Thread Christian Mauderer
If you add a new functionallity you _should_ add a test that tests the expected behaviour. You just shouldn't replace one but add a new test or a new test case to an existing test. Best regards Christian On 14/06/2021 22:18, zack_on_the_speed_chanel wrote: also i'll revert the posix test t

Re: [PATCH] part of implimenting a monotonic clock in rtems part of this is not the final patch.

2021-06-17 Thread zack_on_the_speed_chanel
so I tested it with the but I have not made a new test file I'll do that soon. How do I add a new test? All the tests that test the timer functionality do work. I"m confident that all the changes I had to made to implement a monotonic clock should be there. Thanks Zack Sent with ProtonMail Se

Re: [PATCH] part of implimenting a monotonic clock in rtems part of this is not the final patch.

2021-06-18 Thread Christian Mauderer
Hello Zack, On 18/06/2021 04:34, zack_on_the_speed_chanel wrote: so I tested it with the but I have not made a new test file I'll do that soon. How do I add a new test? All the tests that test the timer functionality do work. I"m confident that all the changes I had to made to implement a mono

Re: [PATCH] part of implimenting a monotonic clock in rtems part of this is not the final patch.

2021-06-19 Thread zack_on_the_speed_chanel
I have added the tests and added the ones that create the timer. My idea for testing is that if I change the wall clock and I'll check the monotonic clock's time. But I think I have to make a signal and arm the timer. Thanks Zack Sent with ProtonMail Secure Email. ‐‐‐ Original Message ‐‐‐

Re: [PATCH] part of implimenting a monotonic clock in rtems part of this is not the final patch.

2021-06-23 Thread Gedare Bloom
On Wed, Jun 23, 2021 at 12:16 PM zack_on_the_speed_chanel wrote: > > I tried to do some testing with the code I write. I tired to test it by > making a rtems app. I modified the code from the ubuntu manpage ( here > https://manpages.ubuntu.com/manpages/bionic/man2/timer_create.2.html)so it > do

Re: [PATCH] part of implimenting a monotonic clock in rtems part of this is not the final patch.

2021-06-23 Thread zack_on_the_speed_chanel
I tried to do some testing with the code I write. I tired to test it by making a rtems app. I modified the code from the ubuntu manpage ( here https://manpages.ubuntu.com/manpages/bionic/man2/timer_create.2.html)so it does not need command line arguments and my code was able to compile. When I r

Re: [PATCH] part of implimenting a monotonic clock in rtems part of this is not the final patch.

2021-06-24 Thread zack_on_the_speed_chanel
I wrote a test for the psxtimer using timer_monotonic. The timer create function worked and all of the get and set time functions work. Cristian told me to verify that the monotonic timer is unaffected by the wall clock. I found some code that I'm just using to test it. I'm using that excerpt fr