Re: [PATCH] riscv/console: Updated the console-config.c file

2021-04-30 Thread Hesham Almatary
On Fri, 30 Apr 2021 at 04:44, somesh deshmukh wrote: > > > On Thu, Apr 29, 2021 at 10:59 PM Hesham Almatary < > hesham.almat...@cl.cam.ac.uk> wrote: > >> On Wed, 28 Apr 2021 at 15:23, Somesh Deshmukh >> wrote: >> > >> > - Parsing the sub-node should be available generic not specific to >> Freedo

Re: [PATCH] riscv/console: Updated the console-config.c file

2021-04-29 Thread somesh deshmukh
On Thu, Apr 29, 2021 at 10:59 PM Hesham Almatary < hesham.almat...@cl.cam.ac.uk> wrote: > On Wed, 28 Apr 2021 at 15:23, Somesh Deshmukh > wrote: > > > > - Parsing the sub-node should be available generic not specific to > Freedom > > Arty310 board. If we remove the Freedom Arty macro now, it wi

Re: [PATCH] riscv/console: Updated the console-config.c file

2021-04-29 Thread Hesham Almatary
On Wed, 28 Apr 2021 at 15:23, Somesh Deshmukh wrote: > > - Parsing the sub-node should be available generic not specific to Freedom > Arty310 board. If we remove the Freedom Arty macro now, it will lose > backward compatibility.The proposed change will retain the backward > compatibility and

Re: [PATCH] riscv/console: Updated the console-config.c file

2021-04-29 Thread Gedare Bloom
Hesham, please review. I'm not certain. On Wed, Apr 28, 2021 at 7:23 AM Somesh Deshmukh wrote: > > - Parsing the sub-node should be available generic not specific to Freedom > Arty310 board. If we remove the Freedom Arty macro now, it will lose > backward compatibility.The proposed change wil

[PATCH] riscv/console: Updated the console-config.c file

2021-04-28 Thread Somesh Deshmukh
- Parsing the sub-node should be available generic not specific to Freedom Arty310 board. If we remove the Freedom Arty macro now, it will lose backward compatibility.The proposed change will retain the backward compatibility and also adds the necessary fix for parsing sub-node. - Line 234 a