Re: [PATCH] rtemstoolkit/mailer.py: Fix option ordering for add_arguments

2021-05-06 Thread Alex White
On Wed, May 5, 2021 at 10:15 PM Chris Johns wrote: > > On 6/5/21 4:49 am, Gedare Bloom wrote: > > On Wed, May 5, 2021 at 9:16 AM Alex White wrote: > >> > >> On Wed, May 5, 2021 at 9:47 AM Gedare Bloom wrote: > >>> > >>> Why? > >> > >> To prevent the '--mail' and '--use-gitconfig' options from

Re: [PATCH] rtemstoolkit/mailer.py: Fix option ordering for add_arguments

2021-05-05 Thread Chris Johns
On 6/5/21 4:49 am, Gedare Bloom wrote: > On Wed, May 5, 2021 at 9:16 AM Alex White wrote: >> >> On Wed, May 5, 2021 at 9:47 AM Gedare Bloom wrote: >>> >>> Why? >> >> To prevent the '--mail' and '--use-gitconfig' options from being added more >> than once to the ArgumentParser in add_arguments.

Re: [PATCH] rtemstoolkit/mailer.py: Fix option ordering for add_arguments

2021-05-05 Thread Gedare Bloom
On Wed, May 5, 2021 at 9:16 AM Alex White wrote: > > On Wed, May 5, 2021 at 9:47 AM Gedare Bloom wrote: > > > > Why? > > To prevent the '--mail' and '--use-gitconfig' options from being added more > than once to the ArgumentParser in add_arguments. > How does that happen? I'm not trying to be

Re: [PATCH] rtemstoolkit/mailer.py: Fix option ordering for add_arguments

2021-05-05 Thread Alex White
On Wed, May 5, 2021 at 9:47 AM Gedare Bloom wrote: > > Why? To prevent the '--mail' and '--use-gitconfig' options from being added more than once to the ArgumentParser in add_arguments. Alex > > On Wed, May 5, 2021 at 8:08 AM Alex White wrote: > > > > The ordering of keys cannot be

Re: [PATCH] rtemstoolkit/mailer.py: Fix option ordering for add_arguments

2021-05-05 Thread Gedare Bloom
Why? On Wed, May 5, 2021 at 8:08 AM Alex White wrote: > > The ordering of keys cannot be guaranteed in a dictionary. This changes > the options dictionary to an OrderedDict to preserve key order. This > also fixes the iteration start point in add_arguments. > > Closes #4402 > --- >

[PATCH] rtemstoolkit/mailer.py: Fix option ordering for add_arguments

2021-05-05 Thread Alex White
The ordering of keys cannot be guaranteed in a dictionary. This changes the options dictionary to an OrderedDict to preserve key order. This also fixes the iteration start point in add_arguments. Closes #4402 --- rtemstoolkit/mailer.py | 24 +--- 1 file changed, 13