Re: [PATCH 2/2] bsps/powerpc: Fix warnings with PPC_SPECIAL_PURPOSE_REGISTER

2023-04-11 Thread Chris Johns
On 11/4/2023 10:29 pm, Joel Sherrill wrote: > Anything to add to the message beyond "fix" to explain this patch? :) > > I think the software engineering guide uses a comment similar to this as an > anti-pattern. Lol How about: - This change avoids the GCC extension of blocks in expressions that

Re: [PATCH 2/2] bsps/powerpc: Fix warnings with PPC_SPECIAL_PURPOSE_REGISTER

2023-04-11 Thread Joel Sherrill
Anything to add to the message beyond "fix" to explain this patch? :) I think the software engineering guide uses a comment similar to this as an anti-pattern. Lol On Tue, Apr 11, 2023, 12:00 AM wrote: > From: Chris Johns > > --- > bsps/powerpc/include/libcpu/powerpc-utility.h | 40

[PATCH 2/2] bsps/powerpc: Fix warnings with PPC_SPECIAL_PURPOSE_REGISTER

2023-04-10 Thread chrisj
From: Chris Johns --- bsps/powerpc/include/libcpu/powerpc-utility.h | 40 +++ .../powerpc/shared/exceptions/ppc_exc_print.c | 25 +++- 2 files changed, 38 insertions(+), 27 deletions(-) diff --git a/bsps/powerpc/include/libcpu/powerpc-utility.h