Re: [PATCH 3/4] dev/io: Add a CRC-24Q implementation

2024-01-22 Thread Chris Johns
On 23/1/2024 8:01 am, Gedare Bloom wrote: > On Mon, Jan 22, 2024 at 11:13 AM Sebastian Huber > wrote: >> >> Hello Gedare, >> >> - Am 22. Jan 2024 um 17:49 schrieb Gedare Bloom ged...@rtems.org: >> >>> Similar to the other patch, this looks mostly useful. >>> >>> I think a lot of these kind of

Re: [PATCH 3/4] dev/io: Add a CRC-24Q implementation

2024-01-22 Thread Gedare Bloom
On Mon, Jan 22, 2024 at 11:13 AM Sebastian Huber wrote: > > Hello Gedare, > > - Am 22. Jan 2024 um 17:49 schrieb Gedare Bloom ged...@rtems.org: > > > Similar to the other patch, this looks mostly useful. > > > > I think a lot of these kind of support code have been imported as > > libraries th

Re: [PATCH 3/4] dev/io: Add a CRC-24Q implementation

2024-01-22 Thread Sebastian Huber
Hello Gedare, - Am 22. Jan 2024 um 17:49 schrieb Gedare Bloom ged...@rtems.org: > Similar to the other patch, this looks mostly useful. > > I think a lot of these kind of support code have been imported as > libraries through cpukit/libmisc. > > I'd be fine if we have our own versions, to d

Re: [PATCH 3/4] dev/io: Add a CRC-24Q implementation

2024-01-22 Thread Gedare Bloom
Similar to the other patch, this looks mostly useful. I think a lot of these kind of support code have been imported as libraries through cpukit/libmisc. I'd be fine if we have our own versions, to define a cpukit/lib** But cpukit/dev has so far been for device-specific frameworks and I would pr

[PATCH 3/4] dev/io: Add a CRC-24Q implementation

2024-01-15 Thread Sebastian Huber
--- cpukit/dev/iocrc24q.c | 148 ++ cpukit/include/rtems/dev/io.h | 41 + spec/build/cpukit/librtemscpu.yml | 1 + .../build/testsuites/unit/unit-no-clock-0.yml | 2 + testsuites/unit/tc-io-packet.c| 42 +