Re: [PATCH 3/4] rtemsbsd/nfsclient: Fix the error code return value

2021-10-20 Thread Chris Johns
On 21/10/21 9:59 am, Joel Sherrill wrote: > On Wed, Oct 20, 2021, 12:49 AM Sebastian Huber > > > wrote: > On 20/10/2021 05:16, chr...@rtems.org wrote: > > +     errno = 0; > > +     return 0; > > I think setting

Re: [PATCH 3/4] rtemsbsd/nfsclient: Fix the error code return value

2021-10-20 Thread Joel Sherrill
On Wed, Oct 20, 2021, 12:49 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > > > On 20/10/2021 05:16, chr...@rtems.org wrote: > > + errno = 0; > > + return 0; > > I think setting errno if no error occurred is not allowed. > Right. Convention is that errno should not be

Re: [PATCH 3/4] rtemsbsd/nfsclient: Fix the error code return value

2021-10-20 Thread Chris Johns
On 20/10/21 4:49 pm, Sebastian Huber wrote: > On 20/10/2021 05:16, chr...@rtems.org wrote: >> +    errno = 0; >> +    return 0; > > I think setting errno if no error occurred is not allowed. > I suspect you are right. Joel? Chris ___ devel mailing

Re: [PATCH 3/4] rtemsbsd/nfsclient: Fix the error code return value

2021-10-19 Thread Sebastian Huber
On 20/10/2021 05:16, chr...@rtems.org wrote: + errno = 0; + return 0; I think setting errno if no error occurred is not allowed. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 -

[PATCH 3/4] rtemsbsd/nfsclient: Fix the error code return value

2021-10-19 Thread chrisj
From: Chris Johns --- rtemsbsd/fs/nfsclient/nfs.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/rtemsbsd/fs/nfsclient/nfs.c b/rtemsbsd/fs/nfsclient/nfs.c index fe8d8412..5a6e8fae 100644 --- a/rtemsbsd/fs/nfsclient/nfs.c +++ b/rtemsbsd/fs/nfsclient/nfs.c @@