Re: [PATCH 4/4] Code refactor xilinx-zynq BSP MMU initialization

2015-08-24 Thread Pavel Pisa
Hello Chris and Rohini, I have returned and catching the emails flow. But please, consider that for some architectures it is critical to have MMU table runtime alterable. I.e. on RPi the actual memory division to cacheable and peripheral area is know only at runtime. It depends on user provided

Re: [PATCH 4/4] Code refactor xilinx-zynq BSP MMU initialization

2015-08-24 Thread Rohini Kulkarni
OK, thanks all for the views. That gave plenty insight into the details I had not thought of earlier. Clearly not the way to go. But then is such refactoring a good idea? These changes even if modified will apply only to cp15 ARM BSPs. On 24 Aug 2015 21:20, Pavel Pisa p...@cmp.felk.cvut.cz wrote:

Re: [PATCH 4/4] Code refactor xilinx-zynq BSP MMU initialization

2015-08-24 Thread Gedare Bloom
We should consider how to continue making improvements in this area of RTEMS. On Mon, Aug 24, 2015 at 1:25 PM, Rohini Kulkarni krohini1...@gmail.com wrote: OK, thanks all for the views. That gave plenty insight into the details I had not thought of earlier. Clearly not the way to go. But then

Re: [PATCH 4/4] Code refactor xilinx-zynq BSP MMU initialization

2015-08-15 Thread Chris Johns
On 15/08/2015 8:14 pm, Rohini Kulkarni wrote: On Fri, Aug 14, 2015 at 12:41 PM, Rohini Kulkarni krohini1...@gmail.com mailto:krohini1...@gmail.com wrote: On Fri, Aug 14, 2015 at 8:33 AM, Chris Johns chr...@rtems.org mailto:chr...@rtems.org wrote: On 14/08/2015 7:44

Re: [PATCH 4/4] Code refactor xilinx-zynq BSP MMU initialization

2015-08-15 Thread Rohini Kulkarni
On Fri, Aug 14, 2015 at 12:41 PM, Rohini Kulkarni krohini1...@gmail.com wrote: On Fri, Aug 14, 2015 at 8:33 AM, Chris Johns chr...@rtems.org wrote: On 14/08/2015 7:44 am, Rohini Kulkarni wrote: --- -BSP_START_DATA_SECTION static const arm_cp15_start_section_config

Re: [PATCH 4/4] Code refactor xilinx-zynq BSP MMU initialization

2015-08-14 Thread Rohini Kulkarni
On Fri, Aug 14, 2015 at 8:33 AM, Chris Johns chr...@rtems.org wrote: On 14/08/2015 7:44 am, Rohini Kulkarni wrote: --- -BSP_START_DATA_SECTION static const arm_cp15_start_section_config -zynq_mmu_config_table[] = { +BSP_START_DATA_SECTION const arm_cp15_start_section_config

[PATCH 4/4] Code refactor xilinx-zynq BSP MMU initialization

2015-08-13 Thread Rohini Kulkarni
--- c/src/lib/libbsp/arm/xilinx-zynq/Makefile.am |4 +++ .../libbsp/arm/xilinx-zynq/startup/bspstartmmu.c | 27 ++-- 2 files changed, 17 insertions(+), 14 deletions(-) diff --git a/c/src/lib/libbsp/arm/xilinx-zynq/Makefile.am

Re: [PATCH 4/4] Code refactor xilinx-zynq BSP MMU initialization

2015-08-13 Thread Chris Johns
On 14/08/2015 7:44 am, Rohini Kulkarni wrote: --- -BSP_START_DATA_SECTION static const arm_cp15_start_section_config -zynq_mmu_config_table[] = { +BSP_START_DATA_SECTION const arm_cp15_start_section_config +arm_cp15_start_mmu_config_table[] = { ARMV7_CP15_START_DEFAULT_SECTIONS, {