Re: [PATCH 4/4] score: Move per-CPU jobs support

2021-07-29 Thread Chris Johns
On 29/7/21 5:19 pm, Sebastian Huber wrote: > On 29/07/2021 02:44, Chris Johns wrote: >>> +void _Per_CPU_Add_job( Per_CPU_Control *cpu, Per_CPU_Job *job ) >>> +{ >>> +  ISR_lock_Context lock_context; >>> + >>> +  _Atomic_Store_ulong( >done, 0, ATOMIC_ORDER_RELAXED ); >>> +  _Assert( job->next ==

Re: [PATCH 4/4] score: Move per-CPU jobs support

2021-07-29 Thread Sebastian Huber
On 29/07/2021 02:44, Chris Johns wrote: +void _Per_CPU_Add_job( Per_CPU_Control *cpu, Per_CPU_Job *job ) +{ + ISR_lock_Context lock_context; + + _Atomic_Store_ulong( >done, 0, ATOMIC_ORDER_RELAXED ); + _Assert( job->next == NULL ); Given the dispatch does not check the handler is adding ...

Re: [PATCH 4/4] score: Move per-CPU jobs support

2021-07-28 Thread Chris Johns
On 28/7/21 9:18 pm, Sebastian Huber wrote: > Add percpujobs.c to contain the per-CPU jobs implementation. > --- > cpukit/Makefile.am| 1 + > cpukit/score/src/percpujobs.c | 124 ++ > cpukit/score/src/smpmulticastaction.c | 89

Re: [PATCH 4/4] score: Move per-CPU jobs support

2021-07-28 Thread Gedare Bloom
ok, other than notes I made on 2/4. Address the overlap with SMP_MESSAGE_SHUTDOWN, rest can be checked in without review. On Wed, Jul 28, 2021 at 5:18 AM Sebastian Huber wrote: > > Add percpujobs.c to contain the per-CPU jobs implementation. > --- > cpukit/Makefile.am| 1 +

[PATCH 4/4] score: Move per-CPU jobs support

2021-07-28 Thread Sebastian Huber
Add percpujobs.c to contain the per-CPU jobs implementation. --- cpukit/Makefile.am| 1 + cpukit/score/src/percpujobs.c | 124 ++ cpukit/score/src/smpmulticastaction.c | 89 +- spec/build/cpukit/objsmp.yml | 4 +- 4