Re: [PATCH rtems] bsps/imxrt: Add attribution in file headers

2021-09-27 Thread Chris Johns
On 27/9/21 6:17 pm, Christian MAUDERER wrote: > Hello, > > if I didn't miss a documentation patch regarding this, the topic is still > open. > I delayed it a bit because I didn't had the time back then and I think Chris > was > quite busy too at that time. I hope now is the right time to

Re: [PATCH rtems] bsps/imxrt: Add attribution in file headers

2021-09-27 Thread Christian MAUDERER
Hello, if I didn't miss a documentation patch regarding this, the topic is still open. I delayed it a bit because I didn't had the time back then and I think Chris was quite busy too at that time. I hope now is the right time to re-start the discussion. Am 21.07.21 um 08:58 schrieb Chris

Re: [PATCH rtems] bsps/imxrt: Add attribution in file headers

2021-07-21 Thread Christian MAUDERER
Am 21.07.21 um 10:31 schrieb Chris Johns: On 21/7/21 5:34 pm, Christian MAUDERER wrote: Hello Chris, Am 21.07.21 um 09:22 schrieb Chris Johns: On 21/7/21 5:05 pm, Christian MAUDERER wrote: Hello, I don't object to clear rules. At the moment it's a bit of a mix. Yes I understand and I

Re: [PATCH rtems] bsps/imxrt: Add attribution in file headers

2021-07-21 Thread Chris Johns
On 21/7/21 5:34 pm, Christian MAUDERER wrote: > Hello Chris, > > Am 21.07.21 um 09:22 schrieb Chris Johns: >> On 21/7/21 5:05 pm, Christian MAUDERER wrote: >>> Hello, >>> >>> I don't object to clear rules. At the moment it's a bit of a mix. >> >> Yes I understand and I think the line you posted

Re: [PATCH rtems] bsps/imxrt: Add attribution in file headers

2021-07-21 Thread Christian MAUDERER
Am 21.07.21 um 09:34 schrieb Christian MAUDERER: Hello Chris, Am 21.07.21 um 09:22 schrieb Chris Johns: On 21/7/21 5:05 pm, Christian MAUDERER wrote: Hello, I don't object to clear rules. At the moment it's a bit of a mix. Yes I understand and I think the line you posted in the patch is

Re: [PATCH rtems] bsps/imxrt: Add attribution in file headers

2021-07-21 Thread Christian MAUDERER
Hello Chris, Am 21.07.21 um 09:22 schrieb Chris Johns: On 21/7/21 5:05 pm, Christian MAUDERER wrote: Hello, I don't object to clear rules. At the moment it's a bit of a mix. Yes I understand and I think the line you posted in the patch is fine as is, it just needs to be separate from the

Re: [PATCH rtems] bsps/imxrt: Add attribution in file headers

2021-07-21 Thread Chris Johns
On 21/7/21 5:05 pm, Christian MAUDERER wrote: > Hello, > > I don't object to clear rules. At the moment it's a bit of a mix. Yes I understand and I think the line you posted in the patch is fine as is, it just needs to be separate from the license text because it could taint it and we need to

Re: [PATCH rtems] bsps/imxrt: Add attribution in file headers

2021-07-21 Thread Christian MAUDERER
Hello, I don't object to clear rules. At the moment it's a bit of a mix. Some examples of what I have found (mainly in PowerPC): Above the copyright line: https://git.rtems.org/rtems/tree/bsps/powerpc/ss555/start/vectors.S

Re: [PATCH rtems] bsps/imxrt: Add attribution in file headers

2021-07-21 Thread Chris Johns
On 21/7/21 3:51 pm, Sebastian Huber wrote: > On 21/07/2021 02:46, Chris Johns wrote: >> I think we need some guidelines. I do not agree with URL links, email >> addresses, >> phone numbers or street addreses appearing in the source. I also think a >> sponsor >> acknowledgement is never updated

Re: [PATCH rtems] bsps/imxrt: Add attribution in file headers

2021-07-20 Thread Sebastian Huber
On 21/07/2021 02:46, Chris Johns wrote: On 21/7/21 6:47 am, Gedare Bloom wrote: This seems fine to me. We don't have any standard way to document this kind of attribution. However, we have had individual authors add their names below their company's copyright. It might make sense to put the

Re: [PATCH rtems] bsps/imxrt: Add attribution in file headers

2021-07-20 Thread Chris Johns
On 21/7/21 6:47 am, Gedare Bloom wrote: > This seems fine to me. We don't have any standard way to document this > kind of attribution. However, we have had individual authors add their > names below their company's copyright. It might make sense to put the > sponsorship part beneath the copyright

Re: [PATCH rtems] bsps/imxrt: Add attribution in file headers

2021-07-20 Thread Gedare Bloom
This seems fine to me. We don't have any standard way to document this kind of attribution. However, we have had individual authors add their names below their company's copyright. It might make sense to put the sponsorship part beneath the copyright of the sponsored company/person? Not a big

[PATCH rtems] bsps/imxrt: Add attribution in file headers

2021-07-20 Thread Christian Mauderer
Onto Innovations Incorporated originally sponsored the development of this BSP. This patch adds the attribution for it. The patch also fixes an old license header in bspstarthooks.c that was accidentally copied into that file. --- bsps/arm/imxrt/console/console.c | 1 +