Re: [PATCH rtems-libbsd v3 1/4] Implement portable kernel symbol namespace tool

2021-07-28 Thread Chris Johns
On 29/7/21 12:27 am, Gedare Bloom wrote: > On Wed, Jul 28, 2021 at 12:50 AM Chris Johns wrote: >> >> On 28/7/21 4:38 pm, Sebastian Huber wrote: >>> On 28/07/2021 04:53, chr...@rtems.org wrote: +for sym in self.output['symbols']: +out += ['#define %s_bsd_%s' % (sym,

Re: [PATCH rtems-libbsd v3 1/4] Implement portable kernel symbol namespace tool

2021-07-28 Thread Gedare Bloom
On Wed, Jul 28, 2021 at 12:50 AM Chris Johns wrote: > > On 28/7/21 4:38 pm, Sebastian Huber wrote: > > On 28/07/2021 04:53, chr...@rtems.org wrote: > >> +for sym in self.output['symbols']: > >> +out += ['#define %s_bsd_%s' % (sym, sym)] > > > > If you add a tab after the

Re: [PATCH rtems-libbsd v3 1/4] Implement portable kernel symbol namespace tool

2021-07-28 Thread Chris Johns
On 28/7/21 4:38 pm, Sebastian Huber wrote: > On 28/07/2021 04:53, chr...@rtems.org wrote: >> +    for sym in self.output['symbols']: >> +    out += ['#define %s_bsd_%s' % (sym, sym)] > > If you add a tab after the #define, then the output is in line with the > FreeBSD > style and you

Re: [PATCH rtems-libbsd v3 1/4] Implement portable kernel symbol namespace tool

2021-07-28 Thread Sebastian Huber
On 28/07/2021 04:53, chr...@rtems.org wrote: +for sym in self.output['symbols']: +out += ['#define %s_bsd_%s' % (sym, sym)] If you add a tab after the #define, then the output is in line with the FreeBSD style and you have a lot less changes in the generated file compared

Re: [PATCH rtems-libbsd v3 1/4] Implement portable kernel symbol namespace tool

2021-07-28 Thread Chris Johns
On 28/7/21 4:34 pm, Sebastian Huber wrote: > On 28/07/2021 04:53, chr...@rtems.org wrote: >> -#define    zy7_slcr_postload_pl _bsd_zy7_slcr_postload_pl >> +#define AES_CBC_MAC_Final _bsd_AES_CBC_MAC_Final > > The FreeBSD coding style has a tab after the #define. This is why it was > where. >

Re: [PATCH rtems-libbsd v3 1/4] Implement portable kernel symbol namespace tool

2021-07-28 Thread Sebastian Huber
On 28/07/2021 04:53, chr...@rtems.org wrote: -#definezy7_slcr_postload_pl _bsd_zy7_slcr_postload_pl +#define AES_CBC_MAC_Final _bsd_AES_CBC_MAC_Final The FreeBSD coding style has a tab after the #define. This is why it was where. -- embedded brains GmbH Herr Sebastian HUBER