RE: [PATCH rtems-tools v2 2/7] TraceReader: Convert to C++

2021-09-24 Thread Ryan Long
Whoops. Not sure what happened there. I had it in earlier. I'll change it to sizeof() and resubmit. -Original Message- From: Chris Johns Sent: Thursday, September 23, 2021 9:24 PM To: Ryan Long ; devel@rtems.org Subject: Re: [PATCH rtems-tools v2 2/7] TraceReader: Convert to C++ On 24

Re: [PATCH rtems-tools v2 2/7] TraceReader: Convert to C++

2021-09-23 Thread Chris Johns
On 24/9/21 7:26 am, Ryan Long wrote: > -bool ReadUntilFound( FILE *file, const char *line ) > +bool ReadUntilFound( std::ifstream& file, const char* line ) > { > - char discardBuff[100]; > - size_t len = strlen( line ); > + #define BUFFER_LENGTH There is no value? > + char

[PATCH rtems-tools v2 2/7] TraceReader: Convert to C++

2021-09-23 Thread Ryan Long
--- tester/covoar/ObjdumpProcessor.cc | 4 +- tester/covoar/ObjdumpProcessor.h| 2 +- tester/covoar/TargetBase.cc | 6 +- tester/covoar/TargetBase.h | 4 +- tester/covoar/TraceReaderBase.h | 4 +- tester/covoar/TraceReaderLogQEMU.cc | 123