Re: [PATCH rtems v3 1/1] Add the Regulator Interface and test

Thanks. If you do turn up something once it is merged, there is always the option to fix it. :) Chris said I addressed his bigger concerns. Deletion and statistics. On Fri, Aug 11, 2023 at 12:32 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 11.08.23 00:14, Joel Sherrill

Re: [PATCH rtems v3 1/1] Add the Regulator Interface and test

On 11.08.23 00:14, Joel Sherrill wrote: I should have asked if you want another round of patches or just go ahead and merge. This set of changes was pretty minor. This is fine, I had only some cosmetic things. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany

Re: [PATCH rtems v3 1/1] Add the Regulator Interface and test

On 11/8/2023 8:14 am, Joel Sherrill wrote: > I should have asked if you want another round of patches or just go ahead and > merge. This set of changes was pretty minor. I am fine with the changes being pushed. Chris ___ devel mailing list

Re: [PATCH rtems v3 1/1] Add the Regulator Interface and test

I should have asked if you want another round of patches or just go ahead and merge. This set of changes was pretty minor. --joel On Thu, Aug 10, 2023 at 5:13 PM Joel Sherrill wrote: > I think I have addressed all of your comments and Chris'. > > The conversion to rtems-central might be nice

Re: [PATCH rtems v3 1/1] Add the Regulator Interface and test

I think I have addressed all of your comments and Chris'. The conversion to rtems-central might be nice but it isn't going to happen soon. --joel On Thu, Aug 10, 2023 at 12:10 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 09.08.23 17:42, Joel Sherrill wrote: > > Updates

Re: [PATCH rtems v3 1/1] Add the Regulator Interface and test

On 09.08.23 17:42, Joel Sherrill wrote: Updates #4924. The Regulator is an application support class which is used to deal with the scenario where there is a bursty input source which needs to be metered out to a destination sink. The maximum size of bursts needs to be known and the delivery

Re: [PATCH rtems v3 1/1] Add the Regulator Interface and test

Hi Joel, This looks good. A minor nit relates to pointer checks. We have: https://docs.rtems.org/branches/master/eng/coding-conventions.html#language-and-compiler I do not know how well enforced the pointer check for NULL in `if` is? Chris On 10/8/2023 1:42 am, Joel Sherrill wrote: > Updates

[PATCH rtems v3 1/1] Add the Regulator Interface and test

Updates #4924. The Regulator is an application support class which is used to deal with the scenario where there is a bursty input source which needs to be metered out to a destination sink. The maximum size of bursts needs to be known and the delivery method must be configured to deliver