Re: [PATCH v2] bsps/shared/ofw: Fix coverity defects

2021-05-06 Thread Niteesh G. S.
Hi, I am really sorry for sending the wrong patch, the crash happened because of wrong arguments to memove, bcopy has src first and dest second whereas it is vice versa in memmove. I had fixed this but had sent the old one. I am really sorry for the trouble. I'll make sure this doesn't happen agai

Re: [PATCH v2] bsps/shared/ofw: Fix coverity defects

2021-05-05 Thread Vijay Kumar Banerjee
Hi all, On Wed, May 5, 2021 at 8:42 AM Gedare Bloom wrote: > > alright looks good. Vijay or Christian please confirm and push if > you're good with it too. > ofw01.exe breaks after this patch. This probably needs some more debugging. If it helps, I'm pasting the error: ``` *** FATAL *** fatal so

Re: [PATCH v2] bsps/shared/ofw: Fix coverity defects

2021-05-05 Thread Gedare Bloom
alright looks good. Vijay or Christian please confirm and push if you're good with it too. On Wed, May 5, 2021 at 12:52 AM Niteesh G. S. wrote: > > > > On Mon, May 3, 2021 at 11:23 PM Gedare Bloom wrote: >> >> Hi Niteesh, >> >> This looks good to me. What/how did you test it? > > I tested it usi

Re: [PATCH v2] bsps/shared/ofw: Fix coverity defects

2021-05-04 Thread Niteesh G. S.
On Mon, May 3, 2021 at 11:23 PM Gedare Bloom wrote: > Hi Niteesh, > > This looks good to me. What/how did you test it? > I tested it using the ofw01 test https://git.rtems.org/rtems/tree/testsuites/libtests/ofw01/init.c and read EEPROM using i2c. > Gedare > > On Sat, May 1, 2021 at 6:31 AM G S

Re: [PATCH v2] bsps/shared/ofw: Fix coverity defects

2021-05-03 Thread Gedare Bloom
Hi Niteesh, This looks good to me. What/how did you test it? Gedare On Sat, May 1, 2021 at 6:31 AM G S Niteesh Babu wrote: > > This patch adds asserts to fix coverity defects > 1) CID 1474437 (Out-of-bounds access) > 2) CID 1474436 (Out-of-bounds access) > > From manual inspection, out of bound

[PATCH v2] bsps/shared/ofw: Fix coverity defects

2021-05-01 Thread G S Niteesh Babu
This patch adds asserts to fix coverity defects 1) CID 1474437 (Out-of-bounds access) 2) CID 1474436 (Out-of-bounds access) >From manual inspection, out of bounds access cannot occur due to bounds checking but coverity fails to detect the checks. We are adding asserts as a secondary check. --- bs