Re: [PATCH v2 2/3] dev/serial: Add ZYNQ_UART_[01]_BASE_ADDR

2024-04-04 Thread Chris Johns
On 4/4/2024 8:19 pm, Sebastian Huber wrote: > On 28.03.24 16:48, Kinsey Moore wrote: >> This patch set looks good to me. I'd suggest a different file for the versal >> unless there's a good name that can easily cover both. > > The versal BSP doesn't use this driver and seems to have a different

Re: [PATCH v2 2/3] dev/serial: Add ZYNQ_UART_[01]_BASE_ADDR

2024-04-04 Thread Sebastian Huber
On 28.03.24 16:48, Kinsey Moore wrote: This patch set looks good to me. I'd suggest a different file for the versal unless there's a good name that can easily cover both. The versal BSP doesn't use this driver and seems to have a different hardware UART interface. It uses a BSP-specific driver

Re: [PATCH v2 2/3] dev/serial: Add ZYNQ_UART_[01]_BASE_ADDR

2024-03-28 Thread Kinsey Moore
This patch set looks good to me. I'd suggest a different file for the versal unless there's a good name that can easily cover both. Kinsey On Wed, Mar 27, 2024 at 9:26 PM Chris Johns wrote: > On 28/3/2024 6:43 am, Sebastian Huber wrote: > > This helps to provide a shared implementation of the k

Re: [PATCH v2 2/3] dev/serial: Add ZYNQ_UART_[01]_BASE_ADDR

2024-03-27 Thread Chris Johns
On 28/3/2024 6:43 am, Sebastian Huber wrote: > This helps to provide a shared implementation of the kernel I/O support. > --- > bsps/aarch64/xilinx-zynqmp/console/console.c | 4 +- > bsps/aarch64/xilinx-zynqmp/include/bsp.h | 2 + > bsps/arm/xilinx-zynq/console/console-config.c | 5 +- >

[PATCH v2 2/3] dev/serial: Add ZYNQ_UART_[01]_BASE_ADDR

2024-03-27 Thread Sebastian Huber
This helps to provide a shared implementation of the kernel I/O support. --- bsps/aarch64/xilinx-zynqmp/console/console.c | 4 +- bsps/aarch64/xilinx-zynqmp/include/bsp.h | 2 + bsps/arm/xilinx-zynq/console/console-config.c | 5 +- bsps/arm/xilinx-zynq/include/bsp.h| 1 + ...