Re: [PATCH] Addded test for timer_create with clock_monotonic

2021-07-01 Thread Gedare Bloom
On Wed, Jun 30, 2021 at 6:48 PM zack leung wrote: > > > + remaining = (uint32_t)result->tv_nsec + result->tv_sec; > What does "remaining" mean here? What do you get if you add a > (truncated) nanoseconds value to a seconds value? (Hint: the units > aren't the same, so the arithmetic is

Re: [PATCH] Addded test for timer_create with clock_monotonic

2021-06-30 Thread zack leung
> + remaining = (uint32_t)result->tv_nsec + result->tv_sec; What does "remaining" mean here? What do you get if you add a (truncated) nanoseconds value to a seconds value? (Hint: the units aren't the same, so the arithmetic is meaningless.) I thought I could convert it back into the

Re: [PATCH] Addded test for timer_create with clock_monotonic

2021-06-29 Thread Gedare Bloom
Hi Zack, Please provide a full name in your git-commit author metadata (git-config.user) Please use a short tag at the start of your commit to identify the scope, in this case, it will be "posix/timer" Check typo "addded" in your commit message. I think this commit is related to a ticket? if it

[PATCH] Addded test for timer_create with clock_monotonic

2021-06-29 Thread Zack
--- cpukit/include/rtems/posix/timer.h| 1 + cpukit/posix/src/psxtimercreate.c | 5 +- cpukit/posix/src/timergettime.c | 79 --- testsuites/psxtests/psxtimer02/psxtimer.c | 38 ++- 4 files changed, 98 insertions(+), 25 deletions(-) diff

Re: [PATCH v3] updates #3889, Added test for timer_create() using CLOCK_MONOTONIC

2020-06-06 Thread Joel Sherrill
Thanks for the patch. Sorry this slipped through for so long without such simple feedback. First, there is a ticket for this: https://devel.rtems.org/ticket/3889 which should be referenced. Second, although the ticket just mentions timer_create, the capabilities (e.g. user use case) not

Re: [PATCH v3] updates #3889, Added test for timer_create() using CLOCK_MONOTONIC

2020-04-28 Thread Eshan Dhawan
Hello everyone, I sent this patch to add test for POSIX timer_create for clock_id argument as CLOCK_MONOTONIC. Other details are in the commit message. If you all could review it. thanks -Eshan On Mon, Apr 20, 2020 at 12:00 AM Eshan dhawan wrote: > >I will create a timer using timer_create()

[PATCH v3] updates #3889, Added test for timer_create() using CLOCK_MONOTONIC

2020-04-19 Thread Eshan dhawan
>I will create a timer using timer_create() function, and passing CLOCK_MONOTONIC in clock_id argument. >The test will fail as there is no support for CLOCK_MONOTONIC in cpukit/posix/src/psxtimercreate.c. >The added code compiles successfully without any errors. Signed-off-by: Eshan dhawan ---

Re: Test for timer_create() with CLOCK_MONOTONIC

2020-04-13 Thread Joel Sherrill
On Mon, Apr 13, 2020, 11:53 AM Eshan Dhawan wrote: > timer_create also has support for other clock_id arguments > like CLOCK_PROCESS_CPUTIME_ID and CLOCK_THREAD_CPUTIME_ID > should I add the tests for them as well? > > reference: http://man7.org/linux/man-pages/man2/timer_create.2.html > If

Re: Test for timer_create() with CLOCK_MONOTONIC

2020-04-13 Thread Eshan Dhawan
timer_create also has support for other clock_id arguments like CLOCK_PROCESS_CPUTIME_ID and CLOCK_THREAD_CPUTIME_ID should I add the tests for them as well? reference: http://man7.org/linux/man-pages/man2/timer_create.2.html thanks -Eshan On Fri, Apr 10, 2020 at 9:35 AM Gedare Bloom wrote:

Re: Test for timer_create() with CLOCK_MONOTONIC

2020-04-09 Thread Gedare Bloom
Please read the other thread "Test for clock_nanosleep with CLOCK_MONOTONIC (# 3890)" Have a look at the RTEMS Test Framework. On Thu, Apr 9, 2020 at 11:31 AM Eshan Dhawan wrote: > > > > On Thu, Apr 9, 2020 at 10:47 PM Joel Sherrill wrote: >> >> >> >> On Thu, Apr 9, 2020 at 12:14 PM Eshan

Re: Test for timer_create() with CLOCK_MONOTONIC

2020-04-09 Thread Eshan Dhawan
On Thu, Apr 9, 2020 at 10:47 PM Joel Sherrill wrote: > > > On Thu, Apr 9, 2020 at 12:14 PM Eshan Dhawan > wrote: > >> hello, >> >> where would the test case of timer_create() with CLOCK_MONOTONIC be added >> ?? >> would they be added in >> psxtimer01 or psxtimer02 or will it be required to

Re: Test for timer_create() with CLOCK_MONOTONIC

2020-04-09 Thread Joel Sherrill
On Thu, Apr 9, 2020 at 12:14 PM Eshan Dhawan wrote: > hello, > > where would the test case of timer_create() with CLOCK_MONOTONIC be added > ?? > would they be added in > psxtimer01 or psxtimer02 or will it be required to create a new test file > for that? > I would probably just create a new

Test for timer_create() with CLOCK_MONOTONIC

2020-04-09 Thread Eshan Dhawan
hello, where would the test case of timer_create() with CLOCK_MONOTONIC be added ?? would they be added in psxtimer01 or psxtimer02 or will it be required to create a new test file for that? thanks - Eshan ___ devel mailing list devel@rtems.org