rtems-bsps: add ability to print architecture/bsps list

2020-09-28 Thread Ryan Long
Hi, The attached patch adds the ability to print the set of bsps in the form of architecture/bsp. This is useful for feeding into other programs. Thanks, Ryan 0001-rtems-bsps-add-ability-to-print-architecture-bsp-lis.patch Description: 0001-rtems-bsps-add-ability-to-print-architecture-bsp-lis.

Oddity with address recorded for gcc instrumentation on ARM

2020-12-18 Thread Ryan Long
Hi, We turned on gcc instrumentation with a test function, and got the following records. Timestamp Channel CPU Event type Contents TID PrioPID Source 18:00:06.483 017 719 stream

rtems-record-lttng live support

2021-01-04 Thread Ryan Long
Hi, Can rtems-record-lttng provide a live feed of traces? Thanks, Ryan ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

Debugging rtems-docs Sphinx issue

2021-02-02 Thread Ryan Long
Hi, I'm working on https://devel.rtems.org/ticket/4229#ticket . The following command is being issued: /home/rlong/nta-workspace/nta-docs/sphinx/bin/sphinx-build -b html -D extensions=sphinxcontrib.bibtex -C . out contents.rst -> If I run this with the "->" at the end, I get "bash: syntax err

RE: Debugging rtems-docs Sphinx issue

2021-02-03 Thread Ryan Long
dare Bloom Sent: Wednesday, February 3, 2021 11:28 AM To: Ryan Long Cc: devel@rtems.org Subject: Re: Debugging rtems-docs Sphinx issue Hi Ryan, On Tue, Feb 2, 2021 at 2:53 PM Ryan Long mailto:ryan.l...@oarcorp.com>> wrote: Hi, I’m working on https://devel.rtems.org/ticket/4229#ticket

[PATCH 2/4] consolesimpletask.c: Fix Coverity Unchecked return value

2021-02-11 Thread Ryan Long
Fixes CID #1437625 and #1472765 where the return value of rtems_task_create and rtems_task_start is discarded. --- cpukit/libcsupport/src/consolesimpletask.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/cpukit/libcsupport/src/consolesimpletask.c b/cpukit/libcsupport/

[PATCH 1/4] assert.h: Add macros to assert status and use it

2021-02-11 Thread Ryan Long
These macros are to be used to check the status from calls that are flagged by Coverity as 'Unchecked return value'. --- cpukit/include/rtems/score/assert.h | 30 ++ 1 file changed, 30 insertions(+) diff --git a/cpukit/include/rtems/score/assert.h b/cpukit/include/rte

[PATCH 0/4] Fix for Coverity issues

2021-02-11 Thread Ryan Long
entailed moving around the dereferencing of values. Thanks, Ryan Ryan Long (4): assert.h: Add macros to assert status and use it consolesimpletask.c: Fix Coverity Unchecked return value rtems-debugger-threads.c: Fix Coverity Dereference before null check rtems-debugger-target.c: Fix Cover

[PATCH 4/4] rtems-debugger-target.c: Fix Coverity Dereference before null check

2021-02-11 Thread Ryan Long
Fixes CID #1468682 where target is dereferenced before it has been checked as to whether it is null or not in the rtems_debugger_target_swbreak_control function. --- cpukit/libdebugger/rtems-debugger-target.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/cpukit/libdebugg

[PATCH 3/4] rtems-debugger-threads.c: Fix Coverity Dereference before null check

2021-02-11 Thread Ryan Long
Fixes CID #1468681, 1468690, and 1468694 by checking if threads is null in the rtems_debugger_thread_find_index, rtems_debugger_thread_system_resume, and rtems_debugger_thread_continue_all functions. --- cpukit/libdebugger/rtems-debugger-threads.c | 14 +++--- 1 file changed, 11 insertions

[PATCH v2 0/3] Fix for Coverity issues

2021-02-12 Thread Ryan Long
function and assigned its value where I had declared and initialized it in the first version of this patch. Thanks, Ryan Ryan Long (3): assert.h: Add macros to assert status and use it consolesimpletask.c: Fix Coverity Unchecked return value rtems-debugger-target.c: Fix Coverity Dereference

[PATCH v2 1/3] assert.h: Add macros to assert status and use it

2021-02-12 Thread Ryan Long
These macros are to be used to check the status from calls that are flagged by Coverity as 'Unchecked return value'. Fix file assert.h --- cpukit/include/rtems/score/assert.h | 30 ++ 1 file changed, 30 insertions(+) diff --git a/cpukit/include/rtems/score/assert.h b

[PATCH v2 2/3] consolesimpletask.c: Fix Coverity Unchecked return value

2021-02-12 Thread Ryan Long
Fixes CID #1437625 and #1472765 where the return value of rtems_task_create and rtems_task_start is discarded. Fix file consolesimpletask.c --- cpukit/libcsupport/src/consolesimpletask.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/cpukit/libcsupport/src/consolesimpl

[PATCH v2 3/3] rtems-debugger-target.c: Fix Coverity Dereference before null check

2021-02-12 Thread Ryan Long
Fixes CID #1468682 where target is dereferenced before it has been checked as to whether it is null or not in the rtems_debugger_target_swbreak_control function. Fix file rtems-debugger-target.c --- cpukit/libdebugger/rtems-debugger-target.c | 6 -- 1 file changed, 4 insertions(+), 2 deletion

[PATCH 0/5] Fix Dereference before null check errors

2021-02-18 Thread Ryan Long
ter wasn't null before being passed to fileno(). Thanks, Ryan Ryan Long (5): b1553brm.c: Fix Dereference before null check (CID #1399829) b1553rt.c: Fix Deference before null check (CID #1399830) grtc.c: Fix Dereference before null check (CID #1399840) grspw_pkt.c: Fix Dereference be

[PATCH 1/5] b1553brm.c: Fix Dereference before null check (CID #1399829)

2021-02-18 Thread Ryan Long
CID 1399829: Dereference before null check in brm_control(). Closes #4250 --- bsps/shared/grlib/1553/b1553brm.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/bsps/shared/grlib/1553/b1553brm.c b/bsps/shared/grlib/1553/b1553brm.c index 57ef701..694f585 100644 --- a/bsp

[PATCH 2/5] b1553rt.c: Fix Deference before null check (CID #1399830)

2021-02-18 Thread Ryan Long
CID 1399830: Dereference before null check in rt_control(). Closes #4251 --- bsps/shared/grlib/1553/b1553rt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/grlib/1553/b1553rt.c b/bsps/shared/grlib/1553/b1553rt.c index d7257e4..df72ada 100644 --- a/bsps/shared/

[PATCH 3/5] grtc.c: Fix Dereference before null check (CID #1399840)

2021-02-18 Thread Ryan Long
CID 1399840: Dereference before null check in grtc_ioctl(). Closes #4252 --- bsps/shared/grlib/tmtc/grtc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/grlib/tmtc/grtc.c b/bsps/shared/grlib/tmtc/grtc.c index 44e9685..e9acea4 100644 --- a/bsps/shared/grlib/tmt

[PATCH 4/5] grspw_pkt.c: Fix Dereference before null check (CID #1399846)

2021-02-18 Thread Ryan Long
CID 1399846: Dereference before null check in grspw_addr_ctrl(). Closes #4253 --- bsps/shared/grlib/spw/grspw_pkt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/grlib/spw/grspw_pkt.c b/bsps/shared/grlib/spw/grspw_pkt.c index 2cc4e886..ca8767e 100644 --- a/bs

[PATCH 5/5] shell.c: Fix Dereference before null check (CID #1467420)

2021-02-18 Thread Ryan Long
CID 1467420: Dereference before null check in rtems_shell_line_editor(). Closes #4254 --- cpukit/libmisc/shell/shell.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cpukit/libmisc/shell/shell.c b/cpukit/libmisc/shell/shell.c index 3c357a1..1e5962b 100644 --- a/cpukit/lib

[PATCH 0/4] Fix Unchecked return value Coverity errors

2021-02-26 Thread Ryan Long
n front of the call to fsync() since that was getting flagged as well. Thanks, Ryan Ryan Long (4): printertask.c: Fix Unchecked return value (CID #1399710) record-client.c: Fix Unchecked return value (CID #1456677) getgrent.c: Fix Unchecked return value error (CID #1459004) rtems-debugger

[PATCH 1/4] printertask.c: Fix Unchecked return value (CID #1399710)

2021-02-26 Thread Ryan Long
CID 1399710: Unchecked return value in printer_task(). CID 1472764: Unchecked return value in rtems_print_printer_task(). Closes #4258 --- cpukit/libcsupport/src/printertask.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/cpukit/libcsupport/src/printertask.c b/cpuk

[PATCH 2/4] record-client.c: Fix Unchecked return value (CID #1456677)

2021-02-26 Thread Ryan Long
CID 1456677: Unchecked return value in resolve_hold_back(). Closes #4260 --- cpukit/libtrace/record/record-client.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cpukit/libtrace/record/record-client.c b/cpukit/libtrace/record/record-client.c index 5a68115..975e3a7 100644

[PATCH 3/4] getgrent.c: Fix Unchecked return value error (CID #1459004)

2021-02-26 Thread Ryan Long
CID 1459004: Unchecked return value in endgrent(). Closes #4261 --- cpukit/libcsupport/src/getgrent.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cpukit/libcsupport/src/getgrent.c b/cpukit/libcsupport/src/getgrent.c index b358cb9..534e04c 100644 --- a/cpukit/libcsuppor

[PATCH 4/4] rtems-debugger-threads.c: Fix Unchecked return value error (CID #1468688)

2021-02-26 Thread Ryan Long
CID 1468688: Unchecked return value in snapshot_thread(). Closes #4262 --- cpukit/libdebugger/rtems-debugger-threads.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cpukit/libdebugger/rtems-debugger-threads.c b/cpukit/libdebugger/rtems-debugger-threads.c index 5b96e5f..

[PATCH v2 1/4] printertask.c: Fix Unchecked return value (CID #1399710)

2021-02-26 Thread Ryan Long
CID 1399710: Unchecked return value in printer_task(). CID 1472764: Unchecked return value in rtems_print_printer_task(). Closes #4258 --- cpukit/libcsupport/src/printertask.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/cpukit/libcsupport/src/printertask.c b/c

[PATCH v2 0/4] Fix Unchecked return value Coverity errors

2021-02-26 Thread Ryan Long
Hi, Here's the patches with the changes. Thanks, Ryan Ryan Long (4): printertask.c: Fix Unchecked return value (CID #1399710) record-client.c: Fix Unchecked return value (CID #1456677) getgrent.c: Fix Unchecked return value error (CID #1459004) rtems-debugger-threads.c: Fix Unch

[PATCH v2 2/4] record-client.c: Fix Unchecked return value (CID #1456677)

2021-02-26 Thread Ryan Long
CID 1456677: Unchecked return value in resolve_hold_back(). Closes #4260 --- cpukit/libtrace/record/record-client.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cpukit/libtrace/record/record-client.c b/cpukit/libtrace/record/record-client.c index 5a68115..975e3a7 100644

[PATCH v2 3/4] getgrent.c: Fix Unchecked return value error (CID #1459004)

2021-02-26 Thread Ryan Long
CID 1459004: Unchecked return value in endgrent(). Closes #4261 --- cpukit/libcsupport/src/getgrent.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cpukit/libcsupport/src/getgrent.c b/cpukit/libcsupport/src/getgrent.c index b358cb9..de56430 100644 --- a/cpukit/libcsuppor

[PATCH v2 4/4] rtems-debugger-threads.c: Fix Unchecked return value error (CID #1468688)

2021-02-26 Thread Ryan Long
CID 1468688: Unchecked return value in snapshot_thread(). Closes #4262 --- cpukit/libdebugger/rtems-debugger-threads.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cpukit/libdebugger/rtems-debugger-threads.c b/cpukit/libdebugger/rtems-debugger-threads.c index 5b96e5f..e

[PATCH 0/3] Fix Unchecked return value Coverity errors upstream

2021-03-01 Thread Ryan Long
Hi, These are patches for the third party Coverity issues. I forgot to include them with the other patch last week. The only file that I used the _Assert_Unused_variable_equals() macro with was grspw.c. The others, I just used (void) to "use" them. Thanks, Ryan Ryan Long (3): fdt

[PATCH 1/3] fdt_rw.c: Fix Unchecked return value (CID #1047324)

2021-03-01 Thread Ryan Long
CID 1047324: Unchecked return value in fdt_add_subnode_namelen(). Updates #4256 --- cpukit/dtc/libfdt/fdt_rw.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/cpukit/dtc/libfdt/fdt_rw.c b/cpukit/dtc/libfdt/fdt_rw.c index 1385425..d6f7d93 100644 --- a/cpukit/dtc/libfdt/fdt

[PATCH 2/3] grspw.c: Fix Unchecked return value (CID #1399781)

2021-03-01 Thread Ryan Long
CID 1399781: Unchecked return value in grspw_device_init(). Closes #4259 --- bsps/shared/grlib/spw/grspw.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/bsps/shared/grlib/spw/grspw.c b/bsps/shared/grlib/spw/grspw.c index 1b50cc6..74a0fc7 100644 --- a/bsps/shared/grlib

[PATCH 3/3] main_edit.c: Fix Unchecked return value (CID #1255318)

2021-03-01 Thread Ryan Long
CID 1255318: Unchecked return value in display_line(). Updates #4257 --- cpukit/libmisc/shell/main_edit.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/cpukit/libmisc/shell/main_edit.c b/cpukit/libmisc/shell/main_edit.c index a011049..8730b21 100644 --- a/cpukit/libmisc

[PATCH v2 0/3] Fix upstream Unchecked return value Coverity errors

2021-03-01 Thread Ryan Long
Hi, Here are the patches with the suggested changes. Thanks, Ryan Ryan Long (3): fdt_rw.c: Fix Unchecked return value (CID #1047324) grspw.c: Fix Unchecked return value (CID #1399781) main_edit.c: Fix Unchecked return value (CID #1255318) bsps/shared/grlib/spw/grspw.c| 7

[PATCH v2 2/3] grspw.c: Fix Unchecked return value (CID #1399781)

2021-03-01 Thread Ryan Long
CID 1399781: Unchecked return value in grspw_device_init(). Closes #4259 --- bsps/shared/grlib/spw/grspw.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/bsps/shared/grlib/spw/grspw.c b/bsps/shared/grlib/spw/grspw.c index 1b50cc6..32740d4 100644 --- a/bsps/shared/grlib

[PATCH v2 3/3] main_edit.c: Fix Unchecked return value (CID #1255318)

2021-03-01 Thread Ryan Long
CID 1255318: Unchecked return value in display_line(). Updates #4257 --- cpukit/libmisc/shell/main_edit.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/cpukit/libmisc/shell/main_edit.c b/cpukit/libmisc/shell/main_edit.c index a011049..9819a94 100644 --- a/cpukit/libmisc

[PATCH v2 1/3] fdt_rw.c: Fix Unchecked return value (CID #1047324)

2021-03-01 Thread Ryan Long
CID 1047324: Unchecked return value in fdt_add_subnode_namelen(). Updates #4256 --- cpukit/dtc/libfdt/fdt_rw.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/cpukit/dtc/libfdt/fdt_rw.c b/cpukit/dtc/libfdt/fdt_rw.c index 1385425..41abd8c 100644 --- a/cpukit/dtc/libfdt/fdt

RE: [PATCH 1/3] fdt_rw.c: Fix Unchecked return value (CID #1047324)

2021-03-01 Thread Ryan Long
So just send this patch to them? -Original Message- From: devel On Behalf Of Gedare Bloom Sent: Monday, March 1, 2021 1:03 PM To: Sebastian Huber Cc: Ryan Long ; devel@rtems.org Subject: Re: [PATCH 1/3] fdt_rw.c: Fix Unchecked return value (CID #1047324) On Mon, Mar 1, 2021 at 11:49 AM

[PATCH 1/3] grtc.c: Fix four Missing break in switch Coverity errors

2021-03-03 Thread Ryan Long
CID 1399761: Missing break in switch in process_dma(). CID 1399765: Missing break in switch in process_dma(). CID 1399766: Missing break in switch in process_dma(). CID 1399777: Missing break in switch in process_dma(). Closes #4277 --- bsps/shared/grlib/tmtc/grtc.c | 4 1 file changed, 4 in

[PATCH 0/3] Fix Missing break in switch Coverity issues

2021-03-03 Thread Ryan Long
Hi, To fix these Coverity issues, I just needed to add a comment to tell Coverity to ignore the error. I did this using the same method as shown in this article https://www.synopsys.com/blogs/software-security/gimme-a-break/. Thanks, Ryan Ryan Long (3): grtc.c: Fix four Missing break in

[PATCH 2/3] cpuusagetop.c: Fix three Missing break in switch Coverity errors

2021-03-03 Thread Ryan Long
CID 1399726: Missing break in switch in task_usage(). CID 1399728: Missing break in switch in task_usage(). CID 1399742: Missing break in switch in task_usage(). Closes #4278 --- cpukit/libmisc/cpuuse/cpuusagetop.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cpukit/libmisc/cpuuse/cpuus

[PATCH 3/3] pci_cfg_read.c: Fix Missing break in switch (CID #1399723)

2021-03-03 Thread Ryan Long
CID 1399723: Missing break in switch in pci_read_addressable(). Closes #4279 --- cpukit/libpci/pci_cfg_read.c | 1 + 1 file changed, 1 insertion(+) diff --git a/cpukit/libpci/pci_cfg_read.c b/cpukit/libpci/pci_cfg_read.c index 0783743..3cb6f86 100644 --- a/cpukit/libpci/pci_cfg_read.c +++ b/cpuk

[PATCH 00/12] Fix Unchecked return value from library errors

2021-03-04 Thread Ryan Long
about the value that is returned. Ryan Ryan Long (12): gen_uuid.c: Fix two Unchecked return value from library errors main_chmod.c: Fix Unchecked return value from library (CID #1063856) pwdgrp.c: Fix Unchecked return value from library (CID #1255518) gr_rasta_spw_router.c: Fix Unchecked re

[PATCH 01/12] gen_uuid.c: Fix two Unchecked return value from library errors

2021-03-04 Thread Ryan Long
CID 1049146: Unchecked return value from library in get_clock(). CID 1049147: Unchecked return value from library in get_random_fd(). Closes #4280 --- cpukit/libmisc/uuid/gen_uuid.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/cpukit/libmisc/uuid/gen_uuid.c b/

[PATCH 02/12] main_chmod.c: Fix Unchecked return value from library (CID #1063856)

2021-03-04 Thread Ryan Long
CID 1063856: Unchecked return value from library in rtems_shell_main_chmod(). Closes #4281 --- cpukit/libmisc/shell/main_chmod.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cpukit/libmisc/shell/main_chmod.c b/cpukit/libmisc/shell/main_chmod.c index 0c39072..df18ef1 10

[PATCH 03/12] pwdgrp.c: Fix Unchecked return value from library (CID #1255518)

2021-03-04 Thread Ryan Long
CID 1255518: Unchecked return value from library in pwdgrp_init(). Closes #4282 --- cpukit/libcsupport/src/pwdgrp.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/cpukit/libcsupport/src/pwdgrp.c b/cpukit/libcsupport/src/pwdgrp.c index a97d397..f4a10f7 100644 --- a/cpukit

[PATCH 04/12] gr_rasta_spw_router.c: Fix Unchecked return value from library (CID #1399760)

2021-03-04 Thread Ryan Long
CID 1399760: Unchecked return value from library in gr_rasta_spw_router_init1(). Closes #4283 --- bsps/shared/grlib/pci/gr_rasta_spw_router.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/grlib/pci/gr_rasta_spw_router.c b/bsps/shared/grlib/pci/gr_rasta_spw_ro

[PATCH 05/12] gr_rasta_io.c: Fix Unchecked return value from library (CID #1399763)

2021-03-04 Thread Ryan Long
CID 1399763: Unchecked return value from library in gr_rasta_io_init1(). Closes #4284 --- bsps/shared/grlib/pci/gr_rasta_io.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/grlib/pci/gr_rasta_io.c b/bsps/shared/grlib/pci/gr_rasta_io.c index f4c9d50..f93f73c 10

[PATCH 06/12] gr_leon4_n2x.c: Fix Unchecked return value from library (CID #1399767)

2021-03-04 Thread Ryan Long
CID 1399767: Unchecked return value error from library in gr_cpci_leon4_n2x_init1(). Closes #4285 --- bsps/sparc/shared/pci/gr_leon4_n2x.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/sparc/shared/pci/gr_leon4_n2x.c b/bsps/sparc/shared/pci/gr_leon4_n2x.c index 9ba

[PATCH 07/12] gr_rasta_tmtc.c: Fix Unchecked return value from library (CID #1399771)

2021-03-04 Thread Ryan Long
CID 1399771: Unchecked return value from library in gr_rasta_tmtc_init1(). Closes #4286 --- bsps/shared/grlib/pci/gr_rasta_tmtc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/grlib/pci/gr_rasta_tmtc.c b/bsps/shared/grlib/pci/gr_rasta_tmtc.c index bef2927..cc

[PATCH 08/12] gr_rasta_tmtc.c: Fix Unchecked return value from library (CID #1399780)

2021-03-04 Thread Ryan Long
CID 1399780: Unchecked return value from library in gr_rasta_adcdac_init1(). Closes #4287 --- bsps/shared/grlib/pci/gr_rasta_adcdac.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/grlib/pci/gr_rasta_adcdac.c b/bsps/shared/grlib/pci/gr_rasta_adcdac.c index 12e

[PATCH 09/12] gr_701.c: Unchecked return value from library (CID #1399783)

2021-03-04 Thread Ryan Long
CID 1399783: Unchecked return value from library in gr701_init1(). Closes #4288 --- bsps/shared/grlib/pci/gr_701.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/grlib/pci/gr_701.c b/bsps/shared/grlib/pci/gr_701.c index c9ac0db..25dc680 100644 --- a/bsps/shared

[PATCH 10/12] gr_tmtc_1553.c: Unchecked return value from library (CID #1399785)

2021-03-04 Thread Ryan Long
CID 1399785: Unchecked return value from library in gr_tmtc_1553_init1(). Closes #4289 --- bsps/shared/grlib/pci/gr_tmtc_1553.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/grlib/pci/gr_tmtc_1553.c b/bsps/shared/grlib/pci/gr_tmtc_1553.c index ce02b8a..55a635

[PATCH 12/12] main_help.c: Unchecked return value from library (CID #1437650)

2021-03-04 Thread Ryan Long
CID 1437650: Unchecked return value from library in rtems_shell_help(). Closes #4291 --- cpukit/libmisc/shell/main_help.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cpukit/libmisc/shell/main_help.c b/cpukit/libmisc/shell/main_help.c index 611f2e0..c76139e 100644 --- a/c

[PATCH 11/12] gr_cpci_gr740.c: Unchecked return value from library (CID #1437630)

2021-03-04 Thread Ryan Long
CID 1437630: Unchecked return value from library in gr_cpci_gr740_init1(). Closes #4290 --- bsps/sparc/shared/pci/gr_cpci_gr740.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/sparc/shared/pci/gr_cpci_gr740.c b/bsps/sparc/shared/pci/gr_cpci_gr740.c index 95f5b94..96

[PATCH 00/12] Fix grlib/gr device driver Coverity errors

2021-03-04 Thread Ryan Long
e first if statements were not being used, so they were taken out. Thanks, Ryan Ryan Long (12): grspw.c: Fix Unchecked return value (CID #1399781) gr_rasta_spw_router.c: Fix Unchecked return value from library (CID #1399760) gr_rasta_io.c: Fix Unchecked return value from library (CI

[PATCH 02/12] gr_rasta_spw_router.c: Fix Unchecked return value from library (CID #1399760)

2021-03-04 Thread Ryan Long
CID 1399760: Unchecked return value from library in gr_rasta_spw_router_init1(). Closes #4283 --- bsps/shared/grlib/pci/gr_rasta_spw_router.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/grlib/pci/gr_rasta_spw_router.c b/bsps/shared/grlib/pci/gr_rasta_spw_ro

[PATCH 01/12] grspw.c: Fix Unchecked return value (CID #1399781)

2021-03-04 Thread Ryan Long
CID 1399781: Unchecked return value in grspw_device_init(). Closes #4259 --- bsps/shared/grlib/spw/grspw.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/bsps/shared/grlib/spw/grspw.c b/bsps/shared/grlib/spw/grspw.c index 1b50cc6..32740d4 100644 --- a/bsps/shared/grlib

[PATCH 03/12] gr_rasta_io.c: Fix Unchecked return value from library (CID #1399763)

2021-03-04 Thread Ryan Long
CID 1399763: Unchecked return value from library in gr_rasta_io_init1(). Closes #4284 --- bsps/shared/grlib/pci/gr_rasta_io.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/grlib/pci/gr_rasta_io.c b/bsps/shared/grlib/pci/gr_rasta_io.c index f4c9d50..f93f73c 10

[PATCH 04/12] gr_leon4_n2x.c: Fix Unchecked return value from library (CID #1399767)

2021-03-04 Thread Ryan Long
CID 1399767: Unchecked return value error from library in gr_cpci_leon4_n2x_init1(). Closes #4285 --- bsps/sparc/shared/pci/gr_leon4_n2x.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/sparc/shared/pci/gr_leon4_n2x.c b/bsps/sparc/shared/pci/gr_leon4_n2x.c index 9ba

[PATCH 05/12] gr_rasta_tmtc.c: Fix Unchecked return value from library (CID #1399771)

2021-03-04 Thread Ryan Long
CID 1399771: Unchecked return value from library in gr_rasta_tmtc_init1(). Closes #4286 --- bsps/shared/grlib/pci/gr_rasta_tmtc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/grlib/pci/gr_rasta_tmtc.c b/bsps/shared/grlib/pci/gr_rasta_tmtc.c index bef2927..cc

[PATCH 06/12] gr_rasta_tmtc.c: Fix Unchecked return value from library (CID #1399780)

2021-03-04 Thread Ryan Long
CID 1399780: Unchecked return value from library in gr_rasta_adcdac_init1(). Closes #4287 --- bsps/shared/grlib/pci/gr_rasta_adcdac.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/grlib/pci/gr_rasta_adcdac.c b/bsps/shared/grlib/pci/gr_rasta_adcdac.c index 12e

[PATCH 07/12] gr_701.c: Unchecked return value from library (CID #1399783)

2021-03-04 Thread Ryan Long
CID 1399783: Unchecked return value from library in gr701_init1(). Closes #4288 --- bsps/shared/grlib/pci/gr_701.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/grlib/pci/gr_701.c b/bsps/shared/grlib/pci/gr_701.c index c9ac0db..25dc680 100644 --- a/bsps/shared

[PATCH 08/12] gr_tmtc_1553.c: Unchecked return value from library (CID #1399785)

2021-03-04 Thread Ryan Long
CID 1399785: Unchecked return value from library in gr_tmtc_1553_init1(). Closes #4289 --- bsps/shared/grlib/pci/gr_tmtc_1553.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/shared/grlib/pci/gr_tmtc_1553.c b/bsps/shared/grlib/pci/gr_tmtc_1553.c index ce02b8a..55a635

[PATCH 09/12] gr_cpci_gr740.c: Unchecked return value from library (CID #1437630)

2021-03-04 Thread Ryan Long
CID 1437630: Unchecked return value from library in gr_cpci_gr740_init1(). Closes #4290 --- bsps/sparc/shared/pci/gr_cpci_gr740.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bsps/sparc/shared/pci/gr_cpci_gr740.c b/bsps/sparc/shared/pci/gr_cpci_gr740.c index 95f5b94..96

[PATCH 10/12] satcan.c: Fix Unsigned compared against 0 (CID #1399768)

2021-03-04 Thread Ryan Long
CID 1399768: Unsigned compared against 0 in satcan_ioctl(). Closes #4294 --- bsps/shared/grlib/can/satcan.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/bsps/shared/grlib/can/satcan.c b/bsps/shared/grlib/can/satcan.c index c3fdc15..52e674c 100644 --- a/bsp

[PATCH 11/12] b1553brm.c: Fix Unsigned compared against 0 (CID #1399773)

2021-03-04 Thread Ryan Long
CID 1399773: Unsigned compared against 0 in brm_write(). Closes #4295 --- bsps/shared/grlib/1553/b1553brm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bsps/shared/grlib/1553/b1553brm.c b/bsps/shared/grlib/1553/b1553brm.c index 694f585..484ee6d 100644 --- a/bsps/shared/gr

[PATCH 12/12] grcan.c: Fix Unused value (CID #1437613)

2021-03-04 Thread Ryan Long
CID 1437613: Unused value in grcan_set_filter(). This fix was recommended by Daniel Hellstrom (dan...@gaisler.com). Closes #4301 --- bsps/shared/grlib/can/grcan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bsps/shared/grlib/can/grcan.c b/bsps/shared/grlib/can/grcan.c inde

[PATCH] Fix for grtc.c

2021-03-04 Thread Ryan Long
Hi, I forgot to include this patch. Sorry about that. Thanks, Ryan Ryan Long (1): grtc.c: Fix four Missing break in switch Coverity errors bsps/shared/grlib/tmtc/grtc.c | 4 1 file changed, 4 insertions(+) -- 1.8.3.1 ___ devel mailing list

[PATCH] grtc.c: Fix four Missing break in switch Coverity errors

2021-03-04 Thread Ryan Long
CID 1399761: Missing break in switch in process_dma(). CID 1399765: Missing break in switch in process_dma(). CID 1399766: Missing break in switch in process_dma(). CID 1399777: Missing break in switch in process_dma(). Closes #4277 --- bsps/shared/grlib/tmtc/grtc.c | 4 1 file changed, 4 in

Checking Status of My Outstanding Patches

2021-03-05 Thread Ryan Long
Hi, Since I've sent a lot of patches this week, I just want to verify which are ready to be merged and what needs to be resubmitted. Ready to be merged: Grlib patches: * grspw.c * gr_rasta_spw_router.c * gr_rasta_tmtc.c * gr_leon4_n2x.c * gr_701.c * gr_c

[PATCH v2 0/4] Fix Unchecked return value from library issues

2021-03-05 Thread Ryan Long
Hi, Here are the patches with the recommended fixes. Thanks, Ryan Ryan Long (4): gen_uuid.c: Fix two Unchecked return value from library errors main_chmod.c: Fix Unchecked return value from library (CID #1063856) pwdgrp.c: Fix Unchecked return value from library (CID #1255518

[PATCH v2 1/4] gen_uuid.c: Fix two Unchecked return value from library errors

2021-03-05 Thread Ryan Long
CID 1049146: Unchecked return value from library in get_clock(). CID 1049147: Unchecked return value from library in get_random_fd(). Closes #4280 --- cpukit/libmisc/uuid/gen_uuid.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/cpukit/libmisc/uuid/gen_uuid.c b/cp

[PATCH v2 2/4] main_chmod.c: Fix Unchecked return value from library (CID #1063856)

2021-03-05 Thread Ryan Long
CID 1063856: Unchecked return value from library in rtems_shell_main_chmod(). Closes #4281 --- cpukit/libmisc/shell/main_chmod.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cpukit/libmisc/shell/main_chmod.c b/cpukit/libmisc/shell/main_chmod.c index 0c39072..df18ef1 10

[PATCH v2 3/4] pwdgrp.c: Fix Unchecked return value from library (CID #1255518)

2021-03-05 Thread Ryan Long
CID 1255518: Unchecked return value from library in pwdgrp_init(). Closes #4282 --- cpukit/libcsupport/src/pwdgrp.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/cpukit/libcsupport/src/pwdgrp.c b/cpukit/libcsupport/src/pwdgrp.c index a97d397..f4a10f7 100644 --- a/cpukit

[PATCH v2 4/4] main_help.c: Unchecked return value from library (CID #1437650)

2021-03-05 Thread Ryan Long
CID 1437650: Unchecked return value from library in rtems_shell_help(). Closes #4291 --- cpukit/libmisc/shell/main_help.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cpukit/libmisc/shell/main_help.c b/cpukit/libmisc/shell/main_help.c index 611f2e0..9f59e9d 100644 --- a/c

[PATCH v3 3/4] pwdgrp.c: Fix Unchecked return value from library (CID #1255518)

2021-03-05 Thread Ryan Long
CID 1255518: Unchecked return value from library in pwdgrp_init(). Closes #4282 --- cpukit/libcsupport/src/pwdgrp.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/cpukit/libcsupport/src/pwdgrp.c b/cpukit/libcsupport/src/pwdgrp.c index a97d397..f4a10f7 100644 --- a/cpukit

[PATCH v3 1/4] gen_uuid.c: Fix two Unchecked return value from library errors

2021-03-05 Thread Ryan Long
CID 1049146: Unchecked return value from library in get_clock(). CID 1049147: Unchecked return value from library in get_random_fd(). Closes #4280 --- cpukit/libmisc/uuid/gen_uuid.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/cpukit/libmisc/uuid/gen_uuid.c b/cp

[PATCH v3 4/4] main_help.c: Unchecked return value from library (CID #1437650)

2021-03-05 Thread Ryan Long
CID 1437650: Unchecked return value from library in rtems_shell_help(). Closes #4291 --- cpukit/libmisc/shell/main_help.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cpukit/libmisc/shell/main_help.c b/cpukit/libmisc/shell/main_help.c index 611f2e0..9f59e9d 100644 --- a/c

[PATCH v3 2/4] main_chmod.c: Fix Unchecked return value from library (CID #1063856)

2021-03-05 Thread Ryan Long
CID 1063856: Unchecked return value from library in rtems_shell_main_chmod(). Closes #4281 --- cpukit/libmisc/shell/main_chmod.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/cpukit/libmisc/shell/main_chmod.c b/cpukit/libmisc/shell/main_chmod.c index 0c39072..8b932fa

[PATCH v3 0/4] Fix Unchecked return value from libarary

2021-03-05 Thread Ryan Long
Hi, Here are the patches with the fix to main_chmod.c. Thanks, Ryan Ryan Long (4): gen_uuid.c: Fix two Unchecked return value from library errors main_chmod.c: Fix Unchecked return value from library (CID #1063856) pwdgrp.c: Fix Unchecked return value from library (CID #1255518

[PATCH] main_edit.c: Fix Unchecked return value (CID #1255318)

2021-03-05 Thread Ryan Long
CID 1255318: Unchecked return value in display_line(). Updates #4257 --- cpukit/libmisc/shell/main_edit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/libmisc/shell/main_edit.c b/cpukit/libmisc/shell/main_edit.c index a011049..8ac7eee 100644 --- a/cpukit/libmisc/shel

[PATCH] Fix Unchecked return value issue

2021-03-05 Thread Ryan Long
Hi, Here's the fix for main_edit.c. I just just needed to add a space between (void) and the function call. Thanks, Ryan Ryan Long (1): main_edit.c: Fix Unchecked return value (CID #1255318) cpukit/libmisc/shell/main_edit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.

[PATCH] main_help.c: Fix Unchecked return value from library (CID #1437650)

2021-03-10 Thread Ryan Long
CID 1437650: Unchecked return value from library in rtems_shell_help(). Closes #4291 --- cpukit/libmisc/shell/main_help.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/libmisc/shell/main_help.c b/cpukit/libmisc/shell/main_help.c index 9f59e9d..564bc30 100644 --- a/cpu

[PATCH] shell.c: Dereference after null check (CID #26083)

2021-03-10 Thread Ryan Long
CID 26083: Dereference after null check in rtems_shell_login(). Closes #4327 --- cpukit/libmisc/shell/shell.c | 196 ++- 1 file changed, 99 insertions(+), 97 deletions(-) diff --git a/cpukit/libmisc/shell/shell.c b/cpukit/libmisc/shell/shell.c index 1e5962

RE: [PATCH] shell.c: Dereference after null check (CID #26083)

2021-03-11 Thread Ryan Long
March 10, 2021 4:50 PM To: Ryan Long Cc: devel@rtems.org Subject: Re: [PATCH] shell.c: Dereference after null check (CID #26083) I need an explanation, I don't know if it is correct, or if someone can open a shell without an 'out' FILE? On Wed, Mar 10, 2021 at 12:10 PM Ryan Long

[PATCH v2] shell.c: Fix Dereference after null check (CID #26083)

2021-03-11 Thread Ryan Long
CID 26083: Dereference after null check in rtems_shell_login(). Closes #4327 --- cpukit/libmisc/shell/shell.c | 5 + 1 file changed, 5 insertions(+) diff --git a/cpukit/libmisc/shell/shell.c b/cpukit/libmisc/shell/shell.c index 1e5962b..ad47460 100644 --- a/cpukit/libmisc/shell/shell.c +++ b

[PATCH 0/2] Fix Dereference after null check Coverity issues

2021-03-12 Thread Ryan Long
Hi, For these issues, I needed to make sure that a value that could be NULL would not be dereferenced. For objectextendinformation.c, an assert was added, and in main_rtrace.c a return was added to the check. Thanks, Ryan Ryan Long (2): objectextendinformation.c: Fix Dereference after null

[PATCH 1/2] objectextendinformation.c: Fix Dereference after null check (CID #26033)

2021-03-12 Thread Ryan Long
CID 26033: Dereference after null check in _Objects_Extend_information(). Closes #4326 --- cpukit/score/src/objectextendinformation.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/cpukit/score/src/objectextendinformation.c b/cpukit/score/src/objectextendinformation.c index 979

[PATCH 2/2] main_rtrace.c: Fix Dereference after null check (CID #1399709)

2021-03-12 Thread Ryan Long
CID 1399709: Dereference after null check in rtems_trace_buffering_shell_save(). Closes #4329 --- cpukit/libmisc/shell/main_rtrace.c | 1 + 1 file changed, 1 insertion(+) diff --git a/cpukit/libmisc/shell/main_rtrace.c b/cpukit/libmisc/shell/main_rtrace.c index 753ab9d..e4f59c4 100644 --- a/cpu

[PATCH 0/5] Fix Resource leak Coverity issues

2021-03-12 Thread Ryan Long
. Thanks, Ryan Ryan Long (5): hexdump-parse.c: Fix Resource leak (CID #26032) rtems-fdt.c: Fix Resource leak (CID #1437645) nvdisk.c: Fix Resource leak (CID #1439297) flashdisk.c: Fix Resource leak (CID #1439298) rtl-shell.c: Resource leak (CID #1444140) cpukit/libblock/src

[PATCH 2/5] rtems-fdt.c: Fix Resource leak (CID #1437645)

2021-03-12 Thread Ryan Long
CID 1437645: Resource leak in rtems_fdt_load(). Closes #4297 --- cpukit/libmisc/rtems-fdt/rtems-fdt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/cpukit/libmisc/rtems-fdt/rtems-fdt.c b/cpukit/libmisc/rtems-fdt/rtems-fdt.c index 0ea3653..5bb7ce0 100644 --- a/cpukit/libmisc/rtems-fdt/rtems

[PATCH 3/5] nvdisk.c: Fix Resource leak (CID #1439297)

2021-03-12 Thread Ryan Long
CID 1439297: Resource leak in rtems_nvdisk_initialize(). Closes #4298 --- cpukit/libblock/src/nvdisk.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/cpukit/libblock/src/nvdisk.c b/cpukit/libblock/src/nvdisk.c index a7f4167..d742baf 100644 --- a/cpukit/libblock/src/nvd

[PATCH 1/5] hexdump-parse.c: Fix Resource leak (CID #26032)

2021-03-12 Thread Ryan Long
CID 26032: Resource leak in rtems_shell_hexdump_rewrite(). Closes #4296 --- cpukit/libmisc/shell/hexdump-parse.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cpukit/libmisc/shell/hexdump-parse.c b/cpukit/libmisc/shell/hexdump-parse.c index 88b9d56..5b56bbf 100644 --- a/cpukit/libmisc/s

[PATCH 5/5] rtl-shell.c: Resource leak (CID #1444140)

2021-03-12 Thread Ryan Long
CID 1444140: Resource leak in rtems_rtl_shell_object(). Closes #4300 --- cpukit/libdl/rtl-shell.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cpukit/libdl/rtl-shell.c b/cpukit/libdl/rtl-shell.c index 9f8a136..bcecdd4 100644 --- a/cpukit/libdl/rtl-shell.c +++ b/cpukit/libdl/rtl-shell.c

[PATCH 4/5] flashdisk.c: Fix Resource leak (CID #1439298)

2021-03-12 Thread Ryan Long
CID 1439298: Resource leak in rtems_fdisk_initialize(). Closes #4299 --- cpukit/libblock/src/flashdisk.c | 42 ++--- 1 file changed, 31 insertions(+), 11 deletions(-) diff --git a/cpukit/libblock/src/flashdisk.c b/cpukit/libblock/src/flashdisk.c index 91f99e0.

RE: [rtems commit] pwdgrp.c: Fix Unchecked return value from library ( CID #1255518)

2021-03-16 Thread Ryan Long
to fix that by the end of the day. -Original Message- From: Sebastian Huber Sent: Tuesday, March 16, 2021 6:33 AM To: RTEMS ; Ryan Long Subject: Re: [rtems commit] pwdgrp.c: Fix Unchecked return value from library ( CID #1255518) On 16/03/2021 12:30, Sebastian Huber wrote: > O

[PATCH] pwdgrp.c: Changed assert to void to fix runtime issues (CID #1399781)

2021-03-18 Thread Ryan Long
Changed the _Assert_unused_value_equals macro to just a void due to /etc having already been created by the network stack initialization or an initial filesystem image. --- cpukit/libcsupport/src/pwdgrp.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/cpukit/libcsuppo

RE: [PATCH] pwdgrp.c: Changed assert to void to fix runtime issues (CID #1399781)

2021-03-18 Thread Ryan Long
Coverity issue fix is helpful though. -Original Message- From: Gedare Bloom Sent: Thursday, March 18, 2021 10:37 AM To: Ryan Long Cc: devel@rtems.org Subject: Re: [PATCH] pwdgrp.c: Changed assert to void to fix runtime issues (CID #1399781) Ignoring the first line of commit issue...

  1   2   3   4   5   6   7   >