Alexander Pohoyda wrote (in a message from 13)
> Warren Turkal <[EMAIL PROTECTED]> writes:
>
> > -char *nscale(n, np, nmm, nbuf)
> > - int n, np, nmm;
> > - char *nbuf;
> > +char
> > +*nscale(int n, int np, int nmm, char *nbuf)
>
> Whouldn't that be better to have:
> char*
> n
Warren Turkal <[EMAIL PROTECTED]> writes:
> -char *nscale(n, np, nmm, nbuf)
> - int n, np, nmm;
> - char *nbuf;
> +char
> +*nscale(int n, int np, int nmm, char *nbuf)
Whouldn't that be better to have:
char*
nscale(int n, int np, int nmm, char *nbuf)
This way you can do grep -e "^nscale"
> So who applies these patches then?
people that do read "[EMAIL PROTECTED]", if you submitted it there,
or people who do read this list with some care.
> I don't have CVS write, nor do I want it at this point.
unlikely to get such an account that fast. (i dont have one.)
anyways patching works
Alexander Stohr wrote:
> i have no reason to object to such patches.
> it was done in 100 kB sized tarballs
> for the XFree86 tree in the past
> and worked well that way.
So who applies these patches then? I don't have CVS write, nor do I want it
at this point.
Warren Turkal
--
President, GOLUM
> This is the minimum work to get this program into ansi shape.
> This patch is
> ready for inclusion. If their are no objections to the patch,
> it would be
> very nice to get this in ASAP. It will make some other projects I am
> working on go smoother.
>
> Thanks, Warren Turkal
i have no reas
Thomas Dickey wrote:
> If a function's not used outside
> a given file, there's no reason to mark it "extern"...
This is the minimum work to get this program into ansi shape. This patch is
ready for inclusion. If their are no objections to the patch, it would be
very nice to get this in ASAP. It
On Tue, 9 Sep 2003, Tim Roberts wrote:
> If so, then the Darwin linker is defective. ISO Standard C variables do NOT
> require the "extern" modifier in order to have external linkage. A variable
> at file scope without an initializer is automatically "extern".
you completely missed the point (o
On Tue, 9 Sep 2003 21:57:23 +0200, Matthieu Herrb wrote:
>Thomas Dickey wrote (in a message from Tuesday 9)
> > On Tue, 9 Sep 2003, Warren Turkal wrote:
> > > -#if NeedFunctionPrototypes
> > > -extern void scale_init(void);
> > > -extern char *nscale(int, int, int, char *);
> >
> > while I'm perf
On Tue, 9 Sep 2003, Matthieu Herrb wrote:
> ... and a 3rd reason is that 'extern' is not optional for
> variables. Most traditional Unix linkers will allow the same variable
> to be declared without 'extern' in multiple object files and merge
> them into only one, but this behaviour is not a feat
Thomas Dickey wrote (in a message from Tuesday 9)
> On Tue, 9 Sep 2003, Warren Turkal wrote:
> > -#if NeedFunctionPrototypes
> > -extern void scale_init(void);
> > -extern char *nscale(int, int, int, char *);
>
> while I'm perfectly aware that "extern" is redundant, there are two things
> t
On Tue, 9 Sep 2003, Warren Turkal wrote:
> Thomas Dickey wrote:
>
> > while I'm perfectly aware that "extern" is redundant, there are two things
> > to be said in favor of keeping it:
> >
> > a) it's easy to grep for
>
> sure
>
> > b) some compilers silently ignore conflicts with a "static" defini
Thomas Dickey wrote:
> while I'm perfectly aware that "extern" is redundant, there are two things
> to be said in favor of keeping it:
>
> a) it's easy to grep for
sure
> b) some compilers silently ignore conflicts with a "static" definition of
>the prototype, but can be persuaded to warn i
On Tue, 9 Sep 2003, Warren Turkal wrote:
> Here is a patch ansifying xwininfo.c. I diffed the executable after the
> changes to the executable from before the changes, and they were the same.
>
> Index: xwininfo.c
> ===
> RCS file: /c
Warren Turkal wrote:
> Here is a patch ansifying xwininfo.c. I diffed the executable after the
> changes to the executable from before the changes, and they were the same.
I have opened a bug report at
http://bugzilla.xfree86.org/show_bug.cgi?id=677
Warren Turkal
--
President, GOLUM, Inc.
http
14 matches
Mail list logo
