grwilson approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/422#pullrequestreview-58790150
--
openzfs-developer
Dear reviewers: my most recent commit is just a comment change, so no retest is
necessary.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/422#issuecomment-325055352
@asomers pushed 1 commit.
3c5ae23 Fix an out-of-date comment as suggested by grwilson
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
asomers commented on this pull request.
> c = vd->vdev_children;
mm = kmem_zalloc(offsetof(mirror_map_t, mm_child[c]), KM_SLEEP);
mm->mm_children = c;
- mm->mm_replacing = (vd->vdev_ops == _replacing_ops ||
+ /*
+
@asomers pushed 1 commit.
f283834 Enable some warnings when building zdb, as suggested by ahrens
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@ahrens pushed 1 commit.
5955b31 typo
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/openzfs/openzfs/pull/409/files/5df44fb5d17d849a3104caf9fcf2bcff83c3c736..5955b3114619f6d79986993d9dedc9d213f63ed0
pcd1193182 approved this pull request.
Send receive code looks fine to me, just one small question.
> int err;
- if (dmu_object_info(rwa->os, obj, NULL) != 0)
+ err = dmu_object_info(rwa->os, obj, );
Why change this to add the argument?
--
You are
@prakashsurya the change to zpool_read_label isn't already in FreeBSD, just our
company's derivative OS. I generally try to merge to openzfs first.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@asomers thanks for the explanation, this looks reasonable to me. is this
already in FreeBSD?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/442#issuecomment-324981031
prakashsurya approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/442#pullrequestreview-58709837
--
openzfs-developer
you can use my example:
ksh93 bldenv.sh -d illumos.sh -c "cd usr/src/cmd/zdb && dmake clobber"
ksh93 bldenv.sh -d illumos.sh -c "cd usr/src/cmd/zdb && dmake -m serial install"
1 - will cleanup zdb
2 - will build it in one thread and failed with first error
if you don’t wont to bulid in one
If the OS was previously built, you can use the bldenv utility and then cd into
the zdb directory and run `dmake install`. More information on using the bldenv
utility is at
https://www.illumos.org/books/dev/workflow.html#your-best-friend-while-building-bldenv.
--
You are receiving this
How can I build just zdb instead of rebuilding the entire OS?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/354#issuecomment-324949719
--
@prakashsurya it's really just cleanup. My motivation was a bug in a
FreeBSD-specific fault manager that could online an entire disk instead of a
partition. Fixing that bug required changing libzfs. And while I was in there
I noticed this inconsistency.
@asomers I'll look at this later today. Can you comment on the motivation for
this change? is it simply a "code cleanup" change, or does this actually "fix"
something?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
grwilson approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/409#pullrequestreview-58659280
--
openzfs-developer
16 matches
Mail list logo
